[{"id":3674964,"web_url":"http://patchwork.ozlabs.org/comment/3674964/","msgid":"<326b2fe9-233b-4e79-89af-834c43ca79af@linaro.org>","list_archive_url":null,"date":"2026-04-07T21:14:03","subject":"Re: [PATCH v10 18/21] target/arm/tcg/translate.c: replace\n translator_ldl_swap with translator_ldl_end","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 21:59, Pierrick Bouvier wrote:\n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/translate.c | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n> index 20f5bdcbe2c..c432de2a268 100644\n> --- a/target/arm/tcg/translate.c\n> +++ b/target/arm/tcg/translate.c\n> @@ -6284,14 +6284,13 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn)\n> static uint16_t arm_lduw_code(CPUARMState *env, DisasContextBase* s,\n> target_ulong addr, bool sctlr_b)\n> {\n> -#ifndef CONFIG_USER_ONLY\n> - /* In big-endian (BE32) mode, adjacent Thumb instructions have been swapped\n> - within each word. Undo that now. */\n> + MemOp end = MO_LE;\n> if (sctlr_b) {\n> + /* In BE32 mode, adjacent Thumb instructions are swapped. */\n> addr ^= 2;\n> + end = MO_BE;\n> }\n> -#endif\n> - return translator_lduw_swap(env, s, addr, bswap_code(sctlr_b));\n> + return translator_lduw_end(env, s, addr, end);\n\nGreat, this removes the last translator_lduw_swap() use \\o/\n\nAnd a lot of complexity is removed :~)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CR5oZOtV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYcS2PFRz1yD6\n\tfor ; Thu, 09 Apr 2026 05:52:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYaD-0006WV-4G; Wed, 08 Apr 2026 15:29:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAY8C-00082V-WF\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:00:05 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wADkN-0004de-Dc\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:14:09 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso3411015e9.0\n for ; Tue, 07 Apr 2026 14:14:06 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488c1c5291esm86444435e9.15.2026.04.07.14.14.04\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 14:14:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775596445; x=1776201245; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=fPd06pqiI/5bpgSPvfgbRni8GbgGSETxxP3KZguGeZQ=;\n b=CR5oZOtViWwp/0q9bQdx3nEa3ia4SZNJ2GcEWc+g31CiuTbtMf0/YXSZuy95p3dznp\n B6pAv+J5nHFaWrYXbtOr1GJGKZaGKOyIQddLH6ZjR0QM1hmvq8vKBJbrfb5/X6M+txbY\n XocpFVI6pdSz+FfRFwK1dbFDts/kgYDvAtxTWsIj1SKVKPATKULi41D+o/Dtz309JfqJ\n 2sGDcwQADNk1fmLzIGVqPh/Gqq6w4KObUJwaZAnrLyKsXNZSorPPgg9VnBSDQo1eDsq2\n uZZ49Zq2+j8VZIk7RnJVy4WgvIMxC/20nXUJUMrAdK3HT8mMmF5Y03zGXcSnvVa9N34d\n mL9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775596445; x=1776201245;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=fPd06pqiI/5bpgSPvfgbRni8GbgGSETxxP3KZguGeZQ=;\n b=EFifkaxB9RRzHnJosQaCF+1LXWoTPiz77LwxWjRjefa6Jg0R3abhls951+L5MNixPf\n 6ULBncDcc3Bmw5pu5SKQuMwMV0EJNx3OhAZqmRjkRWDavvN7N49MOlBxBbtx5KUjxPxu\n 8wYT+Kqwmi37Ln0xNkxVg5U4r7Q/E6x8y26K8oWkFAVz0iEC6dC4v3aQ1hmf4cZfMmoI\n nxjoHq5FUZAXMXeoP4qK9RPS++Y0xmizcBieYAYhNDTKfT1nfU00FWp+XtUth8hAt5Os\n Q6i0ogXhVOIa2G5P9mquvLagw/Alf6KNPQozZ0r0mo2JY5cpre9hFRjlYfEcXqvmD7c7\n WoGQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUYPzaeRPL0y8UkUe393GB2yVTqWc01z5R6Ayo8CDIQIzOyyxwaViLBfNYw4tb2rkNeWjM/3/fgot7b@nongnu.org","X-Gm-Message-State":"AOJu0YzeuiWFHZpq912RqRJrjFICt42H8QRsUVAz62zlr11+fZMgklbj\n trg3kLRDLBAna/eecw3lW0LpTJwkplb3DXf6NgMXecdaIsvVLIn1pwyafOY7JHfLqN4=","X-Gm-Gg":"AeBDievo3IOY8ToaC6J/UUZUzA5gg33U9Xi6mYamLOn8EOR78MX2RO5oXN1QhdHwTLy\n wJDpbr3fnUPGwz0wwcOEPpjyISV42RyiI7LtmxgLSd2JB6AaEMv7PQ0OFQVFOgk7YuWQeAEMEir\n p/Ecb6LSCS2Wy9g5dm0Jn7j/hwvJJ198qRJXzDPj4JX9++NEtWBjyY/5hZL2rQl36+y/X6XQ3F4\n kFLe1djeHL8Nan/zmbm8xI2m5vokgKExi5LyveYBIHtw/pngiAcOxdF1vUWiJWsiPMFrr9VuAhY\n eGPEf1yeEvmnPjjxEZXUW5Tv2YQ2/ifOWkHbdGkFuULgHCeJWUWceoVA+ZrJARv4gBVxP9/9zkD\n LB6t6OyeBlrRJbxQ5LP/5IKl9J2ewLwSWq4AglPi+PnsTLxi5HbzSDC9Is8TU9BIXvcGPPFiZB8\n qiiNWfHu3j9wC/sg5oosbVLE0qz0a+q5oc0m8e53iqc8Tk5fU+HH9tOGu0Ysm0fAQDVA==","X-Received":"by 2002:a05:600c:4e42:b0:486:f893:56c6 with SMTP id\n 5b1f17b1804b1-4889949c0f2mr57561745e9.10.1775596445108;\n Tue, 07 Apr 2026 14:14:05 -0700 (PDT)","Message-ID":"<326b2fe9-233b-4e79-89af-834c43ca79af@linaro.org>","Date":"Tue, 7 Apr 2026 23:14:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 18/21] target/arm/tcg/translate.c: replace\n translator_ldl_swap with translator_ldl_end","Content-Language":"en-US","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Richard Henderson , qemu-arm@nongnu.org,\n Paolo Bonzini ","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-19-pierrick.bouvier@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260407195922.196410-19-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]