[{"id":3674894,"web_url":"http://patchwork.ozlabs.org/comment/3674894/","msgid":"<0c72fdf4-bdb4-472f-aa79-3142c89b1e8e@linaro.org>","list_archive_url":null,"date":"2026-04-07T21:07:07","subject":"Re: [PATCH v10 17/21] target/arm/tcg/arm_ldst.h: merge in translate.c","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 21:59, Pierrick Bouvier wrote:\n> Only translate.c uses those functions, thus move them back to this file.\n> \n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/arm_ldst.h | 47 --------------------------------------\n> target/arm/tcg/translate.c | 22 +++++++++++++++++-\n> 2 files changed, 21 insertions(+), 48 deletions(-)\n\n\n> +/* Ditto, for a halfword (Thumb) instruction */\n> +static uint16_t arm_lduw_code(CPUARMState *env, DisasContextBase* s,\n> + target_ulong addr, bool sctlr_b)\n> +{\n> +#ifndef CONFIG_USER_ONLY\n> + /* In big-endian (BE32) mode, adjacent Thumb instructions have been swapped\n> + within each word. Undo that now. */\n\nPre-existing and removed in the next patch, but in case you have to respin:\n\nWARNING: Block comments use * on subsequent lines\n#91: FILE: target/arm/tcg/translate.c:6289:\n+ /* In big-endian (BE32) mode, adjacent Thumb instructions have been \nswapped\n+ within each word. Undo that now. */\n\n> + if (sctlr_b) {\n> + addr ^= 2;\n> + }\n> +#endif\n> + return translator_lduw_swap(env, s, addr, bswap_code(sctlr_b));\n> +}","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QDI+lu+c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frX174RP0z1xv0\n\tfor ; Thu, 09 Apr 2026 04:39:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAXoY-0006o6-2X; Wed, 08 Apr 2026 14:39:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAXoV-0006J4-Cq\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:39:43 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wADde-0002rn-S9\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:07:12 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-488ba6366a7so19404605e9.0\n for ; Tue, 07 Apr 2026 14:07:10 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488be75215dsm80800575e9.6.2026.04.07.14.07.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 14:07:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775596029; x=1776200829; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=To1wsQYa7oLh+wmEwOgnUuZiDPGmaSipqak66Gx34i0=;\n b=QDI+lu+c4ctQBk2PrY6a5tlHFEQVOZCs1VKrEgKW4E6r0etNyGoWykOLD6oWo2JnaP\n ro3hd+MVAVKStcZJqOd56j3n978avSKqiEjxQqjyKsosjirCOn51jz9nSr74Ton+6W0d\n x6zSfKYGWpG+CX7mrZlaP58BfaOPSYznZoialD67Pf6r188+f0HMXuVhsfQfq5EVphDu\n /++BJcpedneHmDpvR9Yt0+9TeoNPaxhNznrHgPJB8VoeffdjYHwSQSS2pRir5H7tR9Q/\n qjJUi3mh6vi8Xt6PSo2UPdkxMbV4fYle/nSZNe4gOChyMFfjKIeTxBKvDvZY2nS4/sF9\n pf9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775596029; x=1776200829;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=To1wsQYa7oLh+wmEwOgnUuZiDPGmaSipqak66Gx34i0=;\n b=QZT2LCpFIIkElJqEZK3LXnYJG0YxyMrqd84Q/mSeMoIhS8GH5jCba7oGwIXqUt6qGl\n dfloHpWCRMQVC1aKA7bMNrXqxmOtstpBlaCybVo1LQugWPVfZWKb8ZiX3J0kMpyaCufr\n gL1gNUDs3YUfJtyht2oN0RxT203b4N+C851uMT4qDbAULbuMs8b3LL5yXJHrbvyeZRme\n J512AtsLL6ZPyAyPUtwE3NsBPJ+xtCMxAMBbHximTu63fhgz6Jq7kgRj6lzv0LjYbUiI\n mPGvCSf8zCvm6AL/NKLnlk1Te9h2w/BfLlJSZQ7BFmI2IBKBjQewF3kg9B4rgJ9+vdiM\n CeKg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXodPPlOPbd3X6y0LP2C1z2MsxUIZCGSTaQicNA8FzOM9+vxh5LW6tjO3r+JMEF7kqzXKnYQs6acs1w@nongnu.org","X-Gm-Message-State":"AOJu0YyE2gE3CMYxB6oDmLEnZ3fG5IeAxYoYXO6Ho/KC/tkPWwsxqUBu\n cgoLzqI9COogoBy2QEW0/W3J8vbULeUvbhaZingoR684zVr2F0BxLb2CiOftk2Ra1Ig=","X-Gm-Gg":"AeBDieuX6HqD0dovA5EXITaVq1Xtj6xBei1j5CnrYzO5TGIySfKgZir/aZzQXhOpZCM\n SDBSKOg8Z+9qIHMNTl/A7C5ddPt/eVu43zVooj51JA719OiCMaUi8fWkivjNngLGuBVc3mX9Gdu\n oXd2Csc6mAYO1f99mQyx8YN+YSb4HQDJHLdrekfJhVs2UrYABLM7B+nQyER0S3Q+Zj2vjgLPfTf\n 5zFh4iJ9iHuS81Bt8ErREbgsOw0wYQUkwqL1FfBipEnhWSYBUHfEqhjtWlpgGhY3vgPqS535gn+\n 5xXRwOLsOvT+tqNP4qT0F4BgimlJMWv84y9TzdZwKuSaBkRSnNuUj6nOR3KSkIegOq0hR64Gx6P\n rWskIwVhEbH+d+ofpDrV5RtQLX4d/LBtAN21VuHO7bCr3cfZS4tPvJnuhowE5wnpT+KIh6GX2o1\n LvnAl7Mw5DWVd957HCffu4jS5Y6jCE68749hitZP9plmbyGeFeeQSBLPIAxrVEODPOJA==","X-Received":"by 2002:a05:600c:621a:b0:488:b675:360f with SMTP id\n 5b1f17b1804b1-488b6753785mr94597975e9.27.1775596029282;\n Tue, 07 Apr 2026 14:07:09 -0700 (PDT)","Message-ID":"<0c72fdf4-bdb4-472f-aa79-3142c89b1e8e@linaro.org>","Date":"Tue, 7 Apr 2026 23:07:07 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 17/21] target/arm/tcg/arm_ldst.h: merge in translate.c","Content-Language":"en-US","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Richard Henderson , qemu-arm@nongnu.org,\n Paolo Bonzini ","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-18-pierrick.bouvier@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260407195922.196410-18-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674921,"web_url":"http://patchwork.ozlabs.org/comment/3674921/","msgid":"<0188d667-151f-4d82-b848-18646e1b340e@linaro.org>","list_archive_url":null,"date":"2026-04-07T21:04:53","subject":"Re: [PATCH v10 17/21] target/arm/tcg/arm_ldst.h: merge in translate.c","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 21:59, Pierrick Bouvier wrote:\n> Only translate.c uses those functions, thus move them back to this file.\n> \n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/arm_ldst.h | 47 --------------------------------------\n> target/arm/tcg/translate.c | 22 +++++++++++++++++-\n> 2 files changed, 21 insertions(+), 48 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eQUxkUIA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXrw1rMNz1xy1\n\tfor ; Thu, 09 Apr 2026 05:17:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYJb-0000lh-Q9; Wed, 08 Apr 2026 15:11:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAYHO-0005qS-LZ\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:09:34 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wADbU-0002PH-VX\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:04:58 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-488a8ca4aadso34628315e9.3\n for ; Tue, 07 Apr 2026 14:04:56 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488a952a03asm258729465e9.0.2026.04.07.14.04.53\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 14:04:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775595895; x=1776200695; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=9HpQFuT0DKPaDPfbPNtPLVWuxJBPTKUXJcpXFbKe3q0=;\n b=eQUxkUIA7TLcnPPXYL3MflfClUJ0edtHH8p0zbrXGRojFM9FIlQ5fKj4/2qOj1T4TD\n 1vjAPKxJJptBdL+YrLxWtp6zFW1yt1IuetaIjY6qw5ZhK5g3tQyvjBqqZDoC8XgQjaBF\n AGaPcYspj6kT590EQUMXGwykZuWsww2ZOBStGcriVssvgEQCpHBIMcI/200IAgU99wML\n lFNY4ltqy8sGxVqfNQHSFV1lwbUM+2uNfI0xsvSH08NAuoQ1sgUSTgsdYgA0vvRgrR86\n 8vrjMMiWVE8jGFXIfT8o4+SoM7dXfSCGoNouAjdnZ0iWneOguJC3LuBk3fqX/Jn0/cee\n 4MOg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775595895; x=1776200695;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=9HpQFuT0DKPaDPfbPNtPLVWuxJBPTKUXJcpXFbKe3q0=;\n b=OLnxIeJGmUSBaWMX6nzVy2cjOKqFbcyz65cVG14l6MjpnixHI/+9ngV5oETg4dxxgr\n 66dge0IMZqzFH9BmzZYTETgehLiztRDDDK4ljPgztvROpuZC5DI4eyPKY2JCv91ez9dE\n r6iQQlPdxW0cT3cUbIMSpk7Qri8sJwx/mWW88WlzFd4My7ZTvCNenFUPgwMlxl9HrNR/\n 8m9ssGsE3wNuTd9VZQtqBU5U4XIjYOhCs8gg+dRdYuoHeXzruLDOuKy9UPvjOFXMsEKs\n hLH4U9zFh5AxHR6xocGVHND+MTLV8bHI4tk5DlxyzivjScp0M3JXjhs2E+V6j9O0prGo\n lZ5A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUOWaCl1kUsl7cogPx6YY9FC41dNksgkT9WtfeobDqmCDVI+LdGVLI+XN7fzn3YYUs3eGYDTw6RXnPW@nongnu.org","X-Gm-Message-State":"AOJu0YxEOdhYEuYd2Ck8iKWIXyVgKtll14ZVDav3O0GwPMC32rxgdrSw\n szEFfBXBjqsqSrMDwzUDTlcl4equx0A+e+37rKaMt1YaMP6rGASiaq+mwfHvhYQzo1o=","X-Gm-Gg":"AeBDieud687AtpycakI1IR1eqwS1nJMVJ1tp24ohnj6SnDaMc53tRwiIMiw2QYKhkfO\n qUecob5DFYZ37wGWLc80DmBudjEt+bYqsPaqb8Dqf5+kwYF+rYrHPzk4NOubeU7UM5IoORxVeSv\n pNCOpNfFGS5fNIJk/nGg11pCOYX7dYSxZkA6zmYtopu/U96JzM4JJzd3e1yLNX7kU+AtQbMnnEo\n mcNedT2PCe/Mob1b8k7YcpDdNvhLsbcPLhM+Q2WyLKSC1NPPpAl8PbiSiOcAKt8N/F1n9mJCm9n\n H85TZxwb+pvEQdThZ1uRIvDXklTXflU1ea76ypt7KpQEEFZIR2ZCOKfeo5CWdW26Q+sTA1rzCWr\n IxHtxpSpCF9t3fD3vfDM0gRCy8zNp0xj6tFlSxBfsJnPf+QuzZF8oTRMqjbX7tVW46b4fvuOWyn\n oil6LyLiHFTbsDOG+6EzRVj+WR0VWlhVqS4ZAuGlxneKwAl4FbQwQX5ZiAyI5SqBzHQhMDCY1SL\n wHA","X-Received":"by 2002:a05:600c:a47:b0:485:4eaf:eb53 with SMTP id\n 5b1f17b1804b1-48899781357mr280250015e9.19.1775595895154;\n Tue, 07 Apr 2026 14:04:55 -0700 (PDT)","Message-ID":"<0188d667-151f-4d82-b848-18646e1b340e@linaro.org>","Date":"Tue, 7 Apr 2026 23:04:53 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 17/21] target/arm/tcg/arm_ldst.h: merge in translate.c","Content-Language":"en-US","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Richard Henderson , qemu-arm@nongnu.org,\n Paolo Bonzini ","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-18-pierrick.bouvier@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260407195922.196410-18-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]