[{"id":3674885,"web_url":"http://patchwork.ozlabs.org/comment/3674885/","msgid":"<7ccbc31f-b3ce-49a4-80e7-e052f517f0e1@linaro.org>","list_archive_url":null,"date":"2026-04-07T22:27:14","subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/8/26 08:20, Pierrick Bouvier wrote:\n> On 4/7/26 2:02 PM, Philippe Mathieu-Daudé wrote:\n>> On 7/4/26 21:59, Pierrick Bouvier wrote:\n>>> We know this file is for 32-bit runtime target, so we can set\n>>> TCG_ADDRESS_BITS. TCG_TYPE_VA is derived accordingly and is already\n>>> passed to translator_loop.\n>>>\n>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>\n>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n>>> ---\n>>>    target/arm/tcg/translate.c | 29 +++++++++++++++--------------\n>>>    1 file changed, 15 insertions(+), 14 deletions(-)\n>>>\n>>> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n>>> index fa4c7907dcd..0b3b4ab86be 100644\n>>> --- a/target/arm/tcg/translate.c\n>>> +++ b/target/arm/tcg/translate.c\n>>> @@ -22,7 +22,8 @@\n>>>    #include \"translate.h\"\n>>>    #include \"translate-a32.h\"\n>>> -#include \"tcg/tcg-op.h\"\n>>> +#define TCG_ADDRESS_BITS 32\n>>> +#include \"tcg/tcg-op-mem.h\"\n>>>    #include \"qemu/log.h\"\n>>>    #include \"arm_ldst.h\"\n>>>    #include \"semihosting/semihost.h\"\n>>> @@ -910,14 +911,14 @@ MemOp pow2_align(unsigned i)\n>>>     * that the address argument is TCGv_i32 rather than TCGv.\n>>>     */\n>>> -static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>> +static TCGv_va gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>>    {\n>>> -    TCGv addr = tcg_temp_new();\n>>> -    tcg_gen_extu_i32_tl(addr, a32);\n>>> +    TCGv_va addr = tcgv_va_temp_new();\n>>> +    tcg_gen_mov_i32(addr, a32);\n>>\n>> The implicit TCGv_va -> TCGv_i32 bugs me here, but the overall change\n>> will make my sleep better :) So:\n>>\n> \n> We could use TCGv_i32 directly, TCGv_va is just useful here to document the intention. I \n> can update this if Richard and you prefer this.\n\nI think this is fine, as I'm not keen on introducing a complete set of tcg_gen_foo_va \nmacros.  As is, any mismatch will be caught at compile-time.\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=aETcWrLl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frWss6P0Gz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 04:33:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAXhf-0001PI-Eu; Wed, 08 Apr 2026 14:32:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wAXhc-0000z9-B0\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:32:36 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wAEtI-0002EC-Cx\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 18:27:26 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-35d94f4ee36so3196787a91.3\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 15:27:22 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c6491157sm15051133a12.9.2026.04.07.15.27.18\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 15:27:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775600841; x=1776205641; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=2iCglNR1awWvoA7pNjFj2RSl4AI1G2ETGo7euEiz6GY=;\n b=aETcWrLltPxgKHjzQURz+J88cTLiIPmPMWMoJwDzDR/ICLroUaA833D/YUcG6a6MU+\n KAe79D5G0bO1ivyHra+p4MTJ/Se2f0d/HMQb4oKGEaHNU33pCwar99h8gx0yB+Y7c/pw\n pIDiXvwCvskvEO1goxYLISHfTmvua9TkOIq+B4mVP7ePAUo205qBvbV2papVbXCugeMk\n taWHVe3xPJ8cu91DhkHiLxVRYneBZcQcBSS3Hh+gR0mcaV9AexBfMNH0p2599MIjhL1H\n OTg4N/hppB2Gj5cnWR6htWzgz9e7bIGk5JGGIv+P1Bi6LQTrOUdmOvHXaC+00yfZBRV7\n VA0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775600841; x=1776205641;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2iCglNR1awWvoA7pNjFj2RSl4AI1G2ETGo7euEiz6GY=;\n b=bAsCTDUIVjMIdW/GarGLlaGXotESTnEBAzBSw/+QCSvUl809kXN3I7lK7jhP/1Kn3J\n FOX9JQfM+7Tbsr9jJCezgyexmCkhTGFmw6xpXyKuZwef2yYFiryr/oWMTpkzwn3MAHxi\n RMuyklYFHMSb+m2U3zUelzKPV1Y69PrQG5/SINzBCIhuctLXl3j8/dACGMBghprn8Abx\n +35arubtuiqtsfSSTjBPY4ROfyp+cdNpLzp/+DxImrFjJsZ1Q2J9Cp0IDsnRJJcQbxxo\n 4XbYi3TgwIpZzddZkBwWYsiXxfi5Ua5sjCJO/tjgy5AjMKAaiwqFzjLtQHWoKZ9J1miW\n nw5Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXMlN/7u/jn+vV2ouK6y7LbRXRaX18EOtRBtYfKvSescQ8pmAa5NvV0H1TiXAG4arNgCdD+O1WFVz9+@nongnu.org","X-Gm-Message-State":"AOJu0YzEvBbbLWlPdtouLaVKW51tydKCRJImyuW4TB2H8BTYTP6pv0M2\n hTqlIYn9YWxwBrz5U1n7lNVnataVU/XSLbntyxCzeGqIqunkivzpTPpHMMWFH2iqLbg=","X-Gm-Gg":"AeBDiesHpgWMjw76d9iqRHWPzxMfuyXl6EO5bJ4XMpjWvrUbnRgFXquH6UM1jDXCkDq\n qeUXrVvoBcS+11hn/FGRZoYT2VIciChABGrXsGxJfNajHKqEQ6VGxaqb7vvugmECv2RIdJzPNK1\n Zklov0l2quC6UvIFq54l7JtkL3/oCeIq8mZC07UgjLs7nUQPJJJ4E5jeWT360RtorNTMIDNcVY4\n DRYDgkBJEHnH+p7TjVyu6ZM2mz3urV7OdwlXTEArSor4Z0kt213/1bO/bCMTnOlPsCoEneZRmf8\n nfX520wE0f79QxRPdT1n1A1q7HWe4V4rlP8UIjRsg7rC9jpN9/7eq8a4IwCZRs49ZNYpz9bMSox\n mXexXPhiJFEq4MmKo9dcQXw02N97n2hIoF3tmeC+9Q6y5Tl7+h/s4u5Qg2mrjC2HQHephlujMYB\n kNW6TQwp09uPUCSvQYv3s73YTzORGpvI4kvbuFk43lpmbb2cLf/LHt1zbenHQtqN9d2+M=","X-Received":"by 2002:a17:90b:4d84:b0:35d:a87b:ef69 with SMTP id\n 98e67ed59e1d1-35de695c375mr17112914a91.28.1775600841347;\n Tue, 07 Apr 2026 15:27:21 -0700 (PDT)","Message-ID":"<7ccbc31f-b3ce-49a4-80e7-e052f517f0e1@linaro.org>","Date":"Wed, 8 Apr 2026 08:27:14 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","To":"Pierrick Bouvier <pierrick.bouvier@linaro.org>, =?utf-8?q?Philippe_Mathi?=\n\t=?utf-8?q?eu-Daud=C3=A9?= <philmd@linaro.org>, qemu-devel@nongnu.org","Cc":"Peter Maydell <peter.maydell@linaro.org>, jim.macarthur@linaro.org,\n qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-16-pierrick.bouvier@linaro.org>\n <c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>\n <7dfc0566-1266-4466-b2aa-707848957153@linaro.org>","From":"Richard Henderson <richard.henderson@linaro.org>","Content-Language":"en-US","In-Reply-To":"<7dfc0566-1266-4466-b2aa-707848957153@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674888,"web_url":"http://patchwork.ozlabs.org/comment/3674888/","msgid":"<7dfc0566-1266-4466-b2aa-707848957153@linaro.org>","list_archive_url":null,"date":"2026-04-07T22:20:43","subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/people/85798/","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"content":"On 4/7/26 2:02 PM, Philippe Mathieu-Daudé wrote:\n> On 7/4/26 21:59, Pierrick Bouvier wrote:\n>> We know this file is for 32-bit runtime target, so we can set\n>> TCG_ADDRESS_BITS. TCG_TYPE_VA is derived accordingly and is already\n>> passed to translator_loop.\n>>\n>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>\n>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n>> ---\n>>    target/arm/tcg/translate.c | 29 +++++++++++++++--------------\n>>    1 file changed, 15 insertions(+), 14 deletions(-)\n>>\n>> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n>> index fa4c7907dcd..0b3b4ab86be 100644\n>> --- a/target/arm/tcg/translate.c\n>> +++ b/target/arm/tcg/translate.c\n>> @@ -22,7 +22,8 @@\n>>    \n>>    #include \"translate.h\"\n>>    #include \"translate-a32.h\"\n>> -#include \"tcg/tcg-op.h\"\n>> +#define TCG_ADDRESS_BITS 32\n>> +#include \"tcg/tcg-op-mem.h\"\n>>    #include \"qemu/log.h\"\n>>    #include \"arm_ldst.h\"\n>>    #include \"semihosting/semihost.h\"\n>> @@ -910,14 +911,14 @@ MemOp pow2_align(unsigned i)\n>>     * that the address argument is TCGv_i32 rather than TCGv.\n>>     */\n>>    \n>> -static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>> +static TCGv_va gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>    {\n>> -    TCGv addr = tcg_temp_new();\n>> -    tcg_gen_extu_i32_tl(addr, a32);\n>> +    TCGv_va addr = tcgv_va_temp_new();\n>> +    tcg_gen_mov_i32(addr, a32);\n> \n> The implicit TCGv_va -> TCGv_i32 bugs me here, but the overall change\n> will make my sleep better :) So:\n>\n\nWe could use TCGv_i32 directly, TCGv_va is just useful here to document \nthe intention. I can update this if Richard and you prefer this.\n\n> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> \n>>    \n>>        /* Not needed for user-mode BE32, where we use MO_BE instead.  */\n>>        if (!IS_USER_ONLY && s->sctlr_b && (op & MO_SIZE) < MO_32) {\n>> -        tcg_gen_xori_tl(addr, addr, 4 - (1 << (op & MO_SIZE)));\n>> +        tcg_gen_xori_i32(addr, addr, 4 - (1 << (op & MO_SIZE)));\n>>        }\n>>        return addr;\n>>    }\n>> @@ -929,21 +930,21 @@ static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>    void gen_aa32_ld_internal_i32(DisasContext *s, TCGv_i32 val,\n>>                                  TCGv_i32 a32, int index, MemOp opc)\n>>    {\n>> -    TCGv addr = gen_aa32_addr(s, a32, opc);\n>> +    TCGv_va addr = gen_aa32_addr(s, a32, opc);\n>>        tcg_gen_qemu_ld_i32(val, addr, index, opc);\n>>    }\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hWkXDlEG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frWxD44Lhz1xv0\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 04:36:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAXkz-00005N-Bg; Wed, 08 Apr 2026 14:36:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAXkx-0008UF-BK\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:36:03 -0400","from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAEms-0000Xj-PD\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 18:20:49 -0400","by mail-pj1-x1029.google.com with SMTP id\n 98e67ed59e1d1-356337f058aso3139872a91.2\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 15:20:46 -0700 (PDT)","from [192.168.1.169] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2749cada2sm177884795ad.71.2026.04.07.15.20.44\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 15:20:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775600445; x=1776205245; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc\n :to:content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Tn7TFn5WY9BfwPmjK8Pf5nI6A/CjXIUDqR9R3qGPUA4=;\n b=hWkXDlEGE8XkjsH9g+uXErwqhgX1gQZi6u2SVIgSppWX9LdUHnJW1feTuD2F3WtvW3\n Dq9VvXInl16vE/8RNoZp/mrNsSyfTIuQayvqjB2CUwMiTEo353TJzlyO57SDyhBWahNt\n 7I28+ziCmPL2B4s6WB0cyzQU1TEbAZJ797Ov5tgM+ZnsaaSuQic/v791ohyN8ePKvA5p\n wppavnGXV4nIL0ooICYMrtg/ynrZPb0l+041l1lw5SyVos2bjk9/1USPp4JibRKo2Fms\n e9sGLb1O+zFdred5bRRi3ZLJ3zYwR7ClFydPA8HkuVCu4cIxtaXbOYhugQ+YrVBGc1fR\n 6Icg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775600445; x=1776205245;\n h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc\n :to:content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Tn7TFn5WY9BfwPmjK8Pf5nI6A/CjXIUDqR9R3qGPUA4=;\n b=Is9xKhcqpUpM819tnB7PsWzVaNDf5v7RpmXDvDKJKfv+vO+YW7GV+C36V+8/BaqoGl\n uISDkWbc+qVIhvMqwIxV5rraH1vT9dsGu5cSHa7gRQ4hkte/JwCSp3YrH1RTIB1jTtrD\n zxKR46K0eLmPZGvDds6UeoZAn1hjwfDuULOgrZ0aLH4aad2ipQhF74UQgZ2cYpduYhDf\n nZcqn31T8ojGmlRXIWIrryTX5C2/sdZUKdCtgPwInB4YB1XhsDqz9Hd3Geg2LGZOOXKY\n nuoeKK3CniBzi1mltMvRXnVzgiDuXVuCFh8uTT/YXTdd3aCulRRSdwuepd04VTEWtdsT\n 4wiA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVqfeAP987ekjs/CLRzYzM54Wc8NRFiyOadxln5MIeBXycFy7QR71WPzgJ++mi2+mUwnT5SHwvJTRNX@nongnu.org","X-Gm-Message-State":"AOJu0YzYiapLjtgvEDz382sOVbM5I1wbIWlDU2itatiWcfk3aAF6n3/L\n ZGltSDmplpxl9EZdlt9EAjWqk61ekkJwQ9D9vF2DIczU+ynPmrwTEk6dFdxOehILiUQ=","X-Gm-Gg":"AeBDiet7DZON8vYllsXgmfxm6aO5ACbCUKo/RTkCe84TmE+FsXjLlVmbdFZAbpBUwPF\n VnpwywcuQW872Af49C2T7G8Vp8m9j1QqRayFSAgzcWG7DCfMCnSvIEOzNufCwlqoh8/LSHIlP/B\n 0lQ0nZwdvyJZnaVqO7nYfwc4QC18XuVAE4D3N3l4tFbJZFVeAMSw3J9Mb5kpjJmGwppGILRluaI\n KoLBYbQGOvtGheCn3nrssE06LiV9YoVKn6ZHgwPUdmYB6eEiEWZEA6s44NArZ+0ls6qBvAL9Y+B\n wmNMogDiwDeJ22gZsSkFCtYgbvChwK+JbmmGftAyoBXLoAW4PHd1pm052dxxL9aV1t5HWcHUV6T\n cVsXeq9lfwBcqzVbr9Fg+lfEvfo5ycD8QaySZGXbckI6VM1t3PF/43t/sRn8O2lebBio4Jd2GRk\n HjHyVYAzkjcs9i4Kb9MXFqRo2NzCdadNqdzaxDhqT1C01asLo+oVLPzx/s6MoiLZtx67ok4OatB\n pqvXBNw","X-Received":"by 2002:a17:902:ccc9:b0:2ab:230d:2d96 with SMTP id\n d9443c01a7336-2b28173ee68mr186824715ad.11.1775600445004;\n Tue, 07 Apr 2026 15:20:45 -0700 (PDT)","Message-ID":"<7dfc0566-1266-4466-b2aa-707848957153@linaro.org>","Date":"Tue, 7 Apr 2026 15:20:43 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","Content-Language":"en-US","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-devel@nongnu.org","Cc":"Peter Maydell <peter.maydell@linaro.org>, jim.macarthur@linaro.org,\n Richard Henderson <richard.henderson@linaro.org>, qemu-arm@nongnu.org,\n Paolo Bonzini <pbonzini@redhat.com>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-16-pierrick.bouvier@linaro.org>\n <c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>","From":"Pierrick Bouvier <pierrick.bouvier@linaro.org>","Autocrypt":"addr=pierrick.bouvier@linaro.org; keydata=\n xsDNBGK9dgwBDACYuRpR31LD+BnJ0M4b5YnPZKbj+gyu82IDN0MeMf2PGf1sux+1O2ryzmnA\n eOiRCUY9l7IbtPYPHN5YVx+7W3vo6v89I7mL940oYAW8loPZRSMbyCiUeSoiN4gWPXetoNBg\n CJmXbVYQgL5e6rsXoMlwFWuGrBY3Ig8YhEqpuYDkRXj2idO11CiDBT/b8A2aGixnpWV/s+AD\n gUyEVjHU6Z8UervvuNKlRUNE0rUfc502Sa8Azdyda8a7MAyrbA/OI0UnSL1m+pXXCxOxCvtU\n qOlipoCOycBjpLlzjj1xxRci+ssiZeOhxdejILf5LO1gXf6pP+ROdW4ySp9L3dAWnNDcnj6U\n 2voYk7/RpRUTpecvkxnwiOoiIQ7BatjkssFy+0sZOYNbOmoqU/Gq+LeFqFYKDV8gNmAoxBvk\n L6EtXUNfTBjiMHyjA/HMMq27Ja3/Y73xlFpTVp7byQoTwF4p1uZOOXjFzqIyW25GvEekDRF8\n IpYd6/BomxHzvMZ2sQ/VXaMAEQEAAc0uUGllcnJpY2sgQm91dmllciA8cGllcnJpY2suYm91\n dmllckBsaW5hcm8ub3JnPsLBDgQTAQoAOBYhBGa5lOyhT38uWroIH3+QVA0KHNAPBQJivXYM\n AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH+QVA0KHNAPX58L/1DYzrEO4TU9ZhJE\n tKcw/+mCZrzHxPNlQtENJ5NULAJWVaJ/8kRQ3Et5hQYhYDKK+3I+0Tl/tYuUeKNV74dFE7mv\n PmikCXBGN5hv5povhinZ9T14S2xkMgym2T3DbkeaYFSmu8Z89jm/AQVt3ZDRjV6vrVfvVW0L\n F6wPJSOLIvKjOc8/+NXrKLrV/YTEi2R1ovIPXcK7NP6tvzAEgh76kW34AHtroC7GFQKu/aAn\n HnL7XrvNvByjpa636jIM9ij43LpLXjIQk3bwHeoHebkmgzFef+lZafzD+oSNNLoYkuWfoL2l\n CR1mifjh7eybmVx7hfhj3GCmRu9o1x59nct06E3ri8/eY52l/XaWGGuKz1bbCd3xa6NxuzDM\n UZU+b0PxHyg9tvASaVWKZ5SsQ5Lf9Gw6WKEhnyTR8Msnh8kMkE7+QWNDmjr0xqB+k/xMlVLE\n uI9Pmq/RApQkW0Q96lTa1Z/UKPm69BMVnUvHv6u3n0tRCDOHTUKHXp/9h5CH3xawms7AzQRi\n vXYMAQwAwXUyTS/Vgq3M9F+9r6XGwbak6D7sJB3ZSG/ZQe5ByCnH9ZSIFqjMnxr4GZUzgBAj\n FWMSVlseSninYe7MoH15T4QXi0gMmKsU40ckXLG/EW/mXRlLd8NOTZj8lULPwg/lQNAnc7GN\n I4uZoaXmYSc4eI7+gUWTqAHmESHYFjilweyuxcvXhIKez7EXnwaakHMAOzNHIdcGGs8NFh44\n oPh93uIr65EUDNxf0fDjnvu92ujf0rUKGxXJx9BrcYJzr7FliQvprlHaRKjahuwLYfZK6Ma6\n TCU40GsDxbGjR5w/UeOgjpb4SVU99Nol/W9C2aZ7e//2f9APVuzY8USAGWnu3eBJcJB+o9ck\n y2bSJ5gmGT96r88RtH/E1460QxF0GGWZcDzZ6SEKkvGSCYueUMzAAqJz9JSirc76E/JoHXYI\n /FWKgFcC4HRQpZ5ThvyAoj9nTIPI4DwqoaFOdulyYAxcbNmcGAFAsl0jJYJ5Mcm2qfQwNiiW\n YnqdwQzVfhwaAcPVABEBAAHCwPYEGAEKACAWIQRmuZTsoU9/Llq6CB9/kFQNChzQDwUCYr12\n DAIbDAAKCRB/kFQNChzQD/XaC/9MnvmPi8keFJggOg28v+r42P7UQtQ9D3LJMgj3OTzBN2as\n v20Ju09/rj+gx3u7XofHBUj6BsOLVCWjIX52hcEEg+Bzo3uPZ3apYtIgqfjrn/fPB0bCVIbi\n 0hAw6W7Ygt+T1Wuak/EV0KS/If309W4b/DiI+fkQpZhCiLUK7DrA97xA1OT1bJJYkC3y4seo\n 0VHOnZTpnOyZ+8Ejs6gcMiEboFHEEt9P+3mrlVJL/cHpGRtg0ZKJ4QC8UmCE3arzv7KCAc+2\n dRDWiCoRovqXGE2PdAW8788qH5DEXnwfzDhnCQ9Eot0Eyi41d4PWI8TWZFi9KzGXJO82O9gW\n 5SYuJaKzCAgNeAy3gUVUUPrUsul1oe2PeWMFUhWKrqko0/Qo4HkwTZY6S16drTMncoUahSAl\n X4Z3BbSPXPq0v1JJBYNBL9qmjULEX+NbtRd3v0OfB5L49sSAC2zIO8S9Cufiibqx3mxZTaJ1\n ZtfdHNZotF092MIH0IQC3poExQpV/WBYFAI=","In-Reply-To":"<c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1029;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1029.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674897,"web_url":"http://patchwork.ozlabs.org/comment/3674897/","msgid":"<c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>","list_archive_url":null,"date":"2026-04-07T21:02:17","subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 21:59, Pierrick Bouvier wrote:\n> We know this file is for 32-bit runtime target, so we can set\n> TCG_ADDRESS_BITS. TCG_TYPE_VA is derived accordingly and is already\n> passed to translator_loop.\n> \n> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>\n> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n> ---\n>   target/arm/tcg/translate.c | 29 +++++++++++++++--------------\n>   1 file changed, 15 insertions(+), 14 deletions(-)\n> \n> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n> index fa4c7907dcd..0b3b4ab86be 100644\n> --- a/target/arm/tcg/translate.c\n> +++ b/target/arm/tcg/translate.c\n> @@ -22,7 +22,8 @@\n>   \n>   #include \"translate.h\"\n>   #include \"translate-a32.h\"\n> -#include \"tcg/tcg-op.h\"\n> +#define TCG_ADDRESS_BITS 32\n> +#include \"tcg/tcg-op-mem.h\"\n>   #include \"qemu/log.h\"\n>   #include \"arm_ldst.h\"\n>   #include \"semihosting/semihost.h\"\n> @@ -910,14 +911,14 @@ MemOp pow2_align(unsigned i)\n>    * that the address argument is TCGv_i32 rather than TCGv.\n>    */\n>   \n> -static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n> +static TCGv_va gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>   {\n> -    TCGv addr = tcg_temp_new();\n> -    tcg_gen_extu_i32_tl(addr, a32);\n> +    TCGv_va addr = tcgv_va_temp_new();\n> +    tcg_gen_mov_i32(addr, a32);\n\nThe implicit TCGv_va -> TCGv_i32 bugs me here, but the overall change\nwill make my sleep better :) So:\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n\n>   \n>       /* Not needed for user-mode BE32, where we use MO_BE instead.  */\n>       if (!IS_USER_ONLY && s->sctlr_b && (op & MO_SIZE) < MO_32) {\n> -        tcg_gen_xori_tl(addr, addr, 4 - (1 << (op & MO_SIZE)));\n> +        tcg_gen_xori_i32(addr, addr, 4 - (1 << (op & MO_SIZE)));\n>       }\n>       return addr;\n>   }\n> @@ -929,21 +930,21 @@ static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>   void gen_aa32_ld_internal_i32(DisasContext *s, TCGv_i32 val,\n>                                 TCGv_i32 a32, int index, MemOp opc)\n>   {\n> -    TCGv addr = gen_aa32_addr(s, a32, opc);\n> +    TCGv_va addr = gen_aa32_addr(s, a32, opc);\n>       tcg_gen_qemu_ld_i32(val, addr, index, opc);\n>   }","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KAL9F4C1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frX344tGDz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 04:41:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAXpN-0001Nc-3G; Wed, 08 Apr 2026 14:40:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wAXpL-0001MK-FY\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:40:35 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wADYy-00026W-EA\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:02:21 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so74154375e9.3\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 14:02:19 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488940e075esm470003405e9.9.2026.04.07.14.02.17\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 14:02:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775595739; x=1776200539; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=pEHtRozxbaRsO1Z0uPRcQlJNySfPOxEqqvINVBJS1qs=;\n b=KAL9F4C1hSSWVbV4dW0quA1eELm1ptEBzgrurGAGUUSq/yGS/j9Ertc4aqRCJSJV8B\n 25nUtG9R4STzYL1kRMf6MWfhucgwtovdlpPVbAcsRAmO1XzY3xjIaOMFJbvHozUsT0U2\n m1QGBIXxOcDMMLev9a2Aw/FKQjxCRQErCG0Ul/vg/JN0s3ENPMwx8E41znG+hEnGsN5v\n F4PSR0ykVw+jqnBqYkEpTZYoAc3aJqlyQ+wYH5xarXjbqteZJuJlnHnMRi9tvWT2lFl+\n T4lvdYyP07XymgJUGv+SC6XPbo+vRlKEV7jrlNbQTU3UdcMmiqIreTO8au8GLiQ4kaOt\n kTgg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775595739; x=1776200539;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=pEHtRozxbaRsO1Z0uPRcQlJNySfPOxEqqvINVBJS1qs=;\n b=LNZncQuOUTc7IlFY4rUWsHFzUYhxMIDry8EH5QYsU10A1Id+zh898GJrE7KiKbEGc8\n 9vbJ5MOhbMdRm25+bdlnzDgn4Zje339AkgWXffBCKIPPxxPihzL+hp2MBpRW05PRZoeI\n a7NmTbCRNSmHt1NyCr4nsarQgyVIGq5UWH8O8EUwBsOpBjHzJA+YQjr327ra8y5ANBhi\n hP19JYE+RPHKpRxBVjx9/rqHSIrGc57MgnMiKz7HqjJP2XfcO9JTdOB9AvsZPmMzf2Ic\n u+DZOobtpHbf4Y16fRBAwxCLI+Hc1+MIIj6PuWn0bfWOh0QWgjLwJ2ZVzUnk7LNRfLzu\n 8E/w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUb1ADqWYv6TCiu7UG5BWIEru6keTa3MN9Q0pnGDbu82jtHkOf4KBcJlL1gXq3aP6wc3JWkWPxRsjLB@nongnu.org","X-Gm-Message-State":"AOJu0Ywi9hpNedvPNPIcGgKQvAeDF0P60kGdjFfiN4LO16NogAN6XCB6\n r1fnsoaBhA0+yy4aWZEATCKDFVsPBnY4nNVALwlE5vx6hcp86nnb1sNuXOotZdCwrRM=","X-Gm-Gg":"AeBDietpH39sHYpTXV6kpe5VYaPm/G5mV4bBqv/f9tR7IzyMRrsTbEp04L6ArSpy+xk\n DF7Lf1dhdjwwdEilLwyOEwWmMKbP9OFkb5aZZixX1oI/xuh0lfhqGen7G5y5MJAInb4kpxrjnDJ\n gXYoljvXv3mCNeg4DQctddkF5FbNZzVsC+c8W2qTP5Cr7dHpKF+hPGCHGyjliSrxb24yQ56RWHn\n 2KBp9XAPBYs0sUdN+t8k7hL2kVvpLX0cy/Y1HygmPkxNDonJc2FbB6r4k3o7G3rzKxGhhJZHPC1\n k9UqA8JlYZ69mfhpUMH8eyEpy1kzQYXVqnsGa5BIzki0+aM9jZNti+AhX3CxH9n3ghDQXhNbNTo\n /cO9vf7y90HIhkic1js7iGEwiq8o8gquZuq5P/5VvnNTREH7XK2dWxzYuGgwc/NNTwKwWcFunIi\n Don3xbLRuvn4Ox/FbuN6KPPwvIiTelTZoVNI2PXWQUNKJITLJlORoEuF2r3T03hTUGRw==","X-Received":"by 2002:a05:600c:c8f:b0:485:3cf3:1010 with SMTP id\n 5b1f17b1804b1-488996d23femr236502025e9.2.1775595738616;\n Tue, 07 Apr 2026 14:02:18 -0700 (PDT)","Message-ID":"<c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>","Date":"Tue, 7 Apr 2026 23:02:17 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","Content-Language":"en-US","To":"Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org","Cc":"Peter Maydell <peter.maydell@linaro.org>, jim.macarthur@linaro.org,\n Richard Henderson <richard.henderson@linaro.org>, qemu-arm@nongnu.org,\n Paolo Bonzini <pbonzini@redhat.com>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-16-pierrick.bouvier@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<20260407195922.196410-16-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674966,"web_url":"http://patchwork.ozlabs.org/comment/3674966/","msgid":"<6ff0ba9a-fa63-45e1-bd98-61f53125037d@linaro.org>","list_archive_url":null,"date":"2026-04-07T22:34:23","subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/people/85798/","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"content":"On 4/7/26 3:27 PM, Richard Henderson wrote:\n> On 4/8/26 08:20, Pierrick Bouvier wrote:\n>> On 4/7/26 2:02 PM, Philippe Mathieu-Daudé wrote:\n>>> On 7/4/26 21:59, Pierrick Bouvier wrote:\n>>>> We know this file is for 32-bit runtime target, so we can set\n>>>> TCG_ADDRESS_BITS. TCG_TYPE_VA is derived accordingly and is already\n>>>> passed to translator_loop.\n>>>>\n>>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>\n>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n>>>> ---\n>>>>     target/arm/tcg/translate.c | 29 +++++++++++++++--------------\n>>>>     1 file changed, 15 insertions(+), 14 deletions(-)\n>>>>\n>>>> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n>>>> index fa4c7907dcd..0b3b4ab86be 100644\n>>>> --- a/target/arm/tcg/translate.c\n>>>> +++ b/target/arm/tcg/translate.c\n>>>> @@ -22,7 +22,8 @@\n>>>>     #include \"translate.h\"\n>>>>     #include \"translate-a32.h\"\n>>>> -#include \"tcg/tcg-op.h\"\n>>>> +#define TCG_ADDRESS_BITS 32\n>>>> +#include \"tcg/tcg-op-mem.h\"\n>>>>     #include \"qemu/log.h\"\n>>>>     #include \"arm_ldst.h\"\n>>>>     #include \"semihosting/semihost.h\"\n>>>> @@ -910,14 +911,14 @@ MemOp pow2_align(unsigned i)\n>>>>      * that the address argument is TCGv_i32 rather than TCGv.\n>>>>      */\n>>>> -static TCGv gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>>> +static TCGv_va gen_aa32_addr(DisasContext *s, TCGv_i32 a32, MemOp op)\n>>>>     {\n>>>> -    TCGv addr = tcg_temp_new();\n>>>> -    tcg_gen_extu_i32_tl(addr, a32);\n>>>> +    TCGv_va addr = tcgv_va_temp_new();\n>>>> +    tcg_gen_mov_i32(addr, a32);\n>>>\n>>> The implicit TCGv_va -> TCGv_i32 bugs me here, but the overall change\n>>> will make my sleep better :) So:\n>>>\n>>\n>> We could use TCGv_i32 directly, TCGv_va is just useful here to document the intention. I\n>> can update this if Richard and you prefer this.\n> \n> I think this is fine, as I'm not keen on introducing a complete set of tcg_gen_foo_va\n> macros.  As is, any mismatch will be caught at compile-time.\n>\n\nAgreed. Usage should be reduced to address related functions.\n\n> \n> r~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JOg+/e3B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYd932Fwz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:52:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYcI-0005uz-Gc; Wed, 08 Apr 2026 15:31:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAYAF-00013F-U4\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:02:11 -0400","from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAF06-0003Ez-Ru\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 18:34:28 -0400","by mail-pf1-x42c.google.com with SMTP id\n d2e1a72fcca58-82cd9d0eceaso4169404b3a.3\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 15:34:26 -0700 (PDT)","from [192.168.1.169] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82d11cd2ce2sm17888135b3a.6.2026.04.07.15.34.24\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 15:34:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775601265; x=1776206065; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=LYc49bLXJNcDA8VBrfK90CEwYrXh/e078SceomJiDEg=;\n b=JOg+/e3BvCyvnGBZ1rHITwd6nbT1SuplAUF9kpzOtPfw9L91HB4SZruPAYG4AhSDWo\n CnG/6OkyPItj3dxa4vhTpsQl3sRZD4dMcCtBDCASRIaMoGj3KHT0fcNKFfBqxBz4xa1K\n w5oVNu6zHMVIIn/kWdxQeDWbb2fYDpxAE8kyRr2xfjFNyqyN4QZOZ5DO46SZH3hl49Mc\n 5tnJjb8IdF5Esh2vH/JJlBghiBCeH/URGYsDuIWvulMBSQe8+hgZZH+lgMJrBeVJaFHu\n sp/lJqd554B7RgKlhmwjTcwo0CzR6dGS75b1ssIBjWIUKrGZSA10b+622Hvj+5dB4qJY\n nM7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775601265; x=1776206065;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LYc49bLXJNcDA8VBrfK90CEwYrXh/e078SceomJiDEg=;\n b=JQxEIG8MaqVZNEc12TYk3LF3ZRA299rcLH10e12bEMGROmH0o7VRaCnYxbSgudNR5o\n KDeyzkfmpHw7TTiZaNAAcuRZ+Xu2zEfWCZ/zTQxa35UUzuszdGOVIQFjHXx3O3Yri/mY\n 2DWGo84Yi21EqRs6pq4oMJiSS3vCe9/7D5ZrV00Q27t71siVY/c8H9bLql53N9ZeOexj\n TmjPwAIEujWam0+FGqZWVK3275uv5ez6vj7LDSp9qtnc4U5u6tZDvr5YjFPsRa/l0fwJ\n 4PT1CMYEuJErVB0zRUpMC0fOjscpOkBVEvpf6u3XDDnYvLFiD5wPMkfHL22OMUkEbujK\n z7IA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUepqVGip0Srm6U644L4aOmKIN56ZTWaKGAkLRxWALhzqfDq5/XoXBWrNY3AbPfRANouYuP4D8ruJRA@nongnu.org","X-Gm-Message-State":"AOJu0YyHiHYIERTcNxMBo1UeidsApqsgqokl+HqvjNEmI9LRCRfNiV4c\n /cZ29fLGGsaDmyA0A/qBN5E+LwRCdJmckq/5fUUx+2O4RM7hTAWczy7vOdYs20kqMUI=","X-Gm-Gg":"AeBDietaXwchxgohKbuLT3MpwcySq4Pu//URmT0iiQCeZnztZiyv0WT9rBgyIhUPBDl\n 03TbFgbUbJ7D1eAvUM70efgGnNGddAMRTs1GPnnaCxte0rF8lXOd1wDRGNxmrXwRIS4P7i89hPr\n is9p1LxMkpVEKuPcYcC7bVjBWfzGjSypXgOuuh33CX+8MLCS3msAN97CGXt0fEqde+k+u4HfqjL\n nWsQu46mFdb+aLCNGyYYiN3gdxvIvEllgNSMb9Z2mhXzhX2GaaiXPgEB3/wsgDqtlGrh5Ix5fl/\n qxNove6F+O5pXIWeQdKV9fs8otKjd96zT6BvIo1gHO9sD6RYjLhHNS0OseTPOAgQuzqn3WF6DTe\n z74y+UgJNwfsLsQfg0MHzN189pkW3cjnXFNtmtuOBRWgXkb0ASlJTOWZFcg/DVod3sG7WqTWLIU\n qPK0hpSsRjyRJLk0X94Y6iYZCk38f5nl6cpKOH4EiWWGZEucwK8wIh/HBIPZzoPkGxGxF0Kg==","X-Received":"by 2002:a05:6a00:10d5:b0:82c:e4b9:531c with SMTP id\n d2e1a72fcca58-82d0da41aa6mr17229515b3a.7.1775601264864;\n Tue, 07 Apr 2026 15:34:24 -0700 (PDT)","Message-ID":"<6ff0ba9a-fa63-45e1-bd98-61f53125037d@linaro.org>","Date":"Tue, 7 Apr 2026 15:34:23 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 15/21] target/arm/tcg/translate.c: replace TCGv with\n TCGv_va","To":"Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Philippe_Mat?=\n\t=?utf-8?q?hieu-Daud=C3=A9?= <philmd@linaro.org>, qemu-devel@nongnu.org","Cc":"Peter Maydell <peter.maydell@linaro.org>, jim.macarthur@linaro.org,\n qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-16-pierrick.bouvier@linaro.org>\n <c18cb395-afa8-42c8-aedd-87863d49befc@linaro.org>\n <7dfc0566-1266-4466-b2aa-707848957153@linaro.org>\n <7ccbc31f-b3ce-49a4-80e7-e052f517f0e1@linaro.org>","From":"Pierrick Bouvier <pierrick.bouvier@linaro.org>","Content-Language":"en-US","Autocrypt":"addr=pierrick.bouvier@linaro.org; keydata=\n xsDNBGK9dgwBDACYuRpR31LD+BnJ0M4b5YnPZKbj+gyu82IDN0MeMf2PGf1sux+1O2ryzmnA\n eOiRCUY9l7IbtPYPHN5YVx+7W3vo6v89I7mL940oYAW8loPZRSMbyCiUeSoiN4gWPXetoNBg\n CJmXbVYQgL5e6rsXoMlwFWuGrBY3Ig8YhEqpuYDkRXj2idO11CiDBT/b8A2aGixnpWV/s+AD\n gUyEVjHU6Z8UervvuNKlRUNE0rUfc502Sa8Azdyda8a7MAyrbA/OI0UnSL1m+pXXCxOxCvtU\n qOlipoCOycBjpLlzjj1xxRci+ssiZeOhxdejILf5LO1gXf6pP+ROdW4ySp9L3dAWnNDcnj6U\n 2voYk7/RpRUTpecvkxnwiOoiIQ7BatjkssFy+0sZOYNbOmoqU/Gq+LeFqFYKDV8gNmAoxBvk\n L6EtXUNfTBjiMHyjA/HMMq27Ja3/Y73xlFpTVp7byQoTwF4p1uZOOXjFzqIyW25GvEekDRF8\n IpYd6/BomxHzvMZ2sQ/VXaMAEQEAAc0uUGllcnJpY2sgQm91dmllciA8cGllcnJpY2suYm91\n dmllckBsaW5hcm8ub3JnPsLBDgQTAQoAOBYhBGa5lOyhT38uWroIH3+QVA0KHNAPBQJivXYM\n AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH+QVA0KHNAPX58L/1DYzrEO4TU9ZhJE\n tKcw/+mCZrzHxPNlQtENJ5NULAJWVaJ/8kRQ3Et5hQYhYDKK+3I+0Tl/tYuUeKNV74dFE7mv\n PmikCXBGN5hv5povhinZ9T14S2xkMgym2T3DbkeaYFSmu8Z89jm/AQVt3ZDRjV6vrVfvVW0L\n F6wPJSOLIvKjOc8/+NXrKLrV/YTEi2R1ovIPXcK7NP6tvzAEgh76kW34AHtroC7GFQKu/aAn\n HnL7XrvNvByjpa636jIM9ij43LpLXjIQk3bwHeoHebkmgzFef+lZafzD+oSNNLoYkuWfoL2l\n CR1mifjh7eybmVx7hfhj3GCmRu9o1x59nct06E3ri8/eY52l/XaWGGuKz1bbCd3xa6NxuzDM\n UZU+b0PxHyg9tvASaVWKZ5SsQ5Lf9Gw6WKEhnyTR8Msnh8kMkE7+QWNDmjr0xqB+k/xMlVLE\n uI9Pmq/RApQkW0Q96lTa1Z/UKPm69BMVnUvHv6u3n0tRCDOHTUKHXp/9h5CH3xawms7AzQRi\n vXYMAQwAwXUyTS/Vgq3M9F+9r6XGwbak6D7sJB3ZSG/ZQe5ByCnH9ZSIFqjMnxr4GZUzgBAj\n FWMSVlseSninYe7MoH15T4QXi0gMmKsU40ckXLG/EW/mXRlLd8NOTZj8lULPwg/lQNAnc7GN\n I4uZoaXmYSc4eI7+gUWTqAHmESHYFjilweyuxcvXhIKez7EXnwaakHMAOzNHIdcGGs8NFh44\n oPh93uIr65EUDNxf0fDjnvu92ujf0rUKGxXJx9BrcYJzr7FliQvprlHaRKjahuwLYfZK6Ma6\n TCU40GsDxbGjR5w/UeOgjpb4SVU99Nol/W9C2aZ7e//2f9APVuzY8USAGWnu3eBJcJB+o9ck\n y2bSJ5gmGT96r88RtH/E1460QxF0GGWZcDzZ6SEKkvGSCYueUMzAAqJz9JSirc76E/JoHXYI\n /FWKgFcC4HRQpZ5ThvyAoj9nTIPI4DwqoaFOdulyYAxcbNmcGAFAsl0jJYJ5Mcm2qfQwNiiW\n YnqdwQzVfhwaAcPVABEBAAHCwPYEGAEKACAWIQRmuZTsoU9/Llq6CB9/kFQNChzQDwUCYr12\n DAIbDAAKCRB/kFQNChzQD/XaC/9MnvmPi8keFJggOg28v+r42P7UQtQ9D3LJMgj3OTzBN2as\n v20Ju09/rj+gx3u7XofHBUj6BsOLVCWjIX52hcEEg+Bzo3uPZ3apYtIgqfjrn/fPB0bCVIbi\n 0hAw6W7Ygt+T1Wuak/EV0KS/If309W4b/DiI+fkQpZhCiLUK7DrA97xA1OT1bJJYkC3y4seo\n 0VHOnZTpnOyZ+8Ejs6gcMiEboFHEEt9P+3mrlVJL/cHpGRtg0ZKJ4QC8UmCE3arzv7KCAc+2\n dRDWiCoRovqXGE2PdAW8788qH5DEXnwfzDhnCQ9Eot0Eyi41d4PWI8TWZFi9KzGXJO82O9gW\n 5SYuJaKzCAgNeAy3gUVUUPrUsul1oe2PeWMFUhWKrqko0/Qo4HkwTZY6S16drTMncoUahSAl\n X4Z3BbSPXPq0v1JJBYNBL9qmjULEX+NbtRd3v0OfB5L49sSAC2zIO8S9Cufiibqx3mxZTaJ1\n ZtfdHNZotF092MIH0IQC3poExQpV/WBYFAI=","In-Reply-To":"<7ccbc31f-b3ce-49a4-80e7-e052f517f0e1@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42c;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x42c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]