[{"id":3674480,"web_url":"http://patchwork.ozlabs.org/comment/3674480/","msgid":"<10bf66bd-56d0-4030-bcc4-d61a3a756548@linaro.org>","list_archive_url":null,"date":"2026-04-07T20:53:26","subject":"Re: [PATCH v10 13/21] target/arm/tcg/translate.c: extract\n aarch64_translate_code()","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 21:59, Pierrick Bouvier wrote:\n> This allows to get rid of TARGET_AARCH64, and helps with next patch\n> which will define at runtime tcg address type, by adding a second entry\n> point in a different source file.\n> \n> Suggested-by: Richard Henderson \n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/internals.h | 2 ++\n> target/arm/tcg/stubs32.c | 7 +++++++\n> target/arm/tcg/translate-a64.c | 9 +++++++++\n> target/arm/tcg/translate.c | 19 +++++++++----------\n> 4 files changed, 27 insertions(+), 10 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=OLBj5HQy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqz2y6gbhz1xtJ\n\tfor ; Wed, 08 Apr 2026 06:54:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wADQW-0000Yr-Ce; Tue, 07 Apr 2026 16:53:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wADQS-0000Wy-8B\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 16:53:32 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wADQQ-0000Ba-7G\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 16:53:31 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so56787305e9.2\n for ; Tue, 07 Apr 2026 13:53:29 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e80a616sm1074897175e9.2.2026.04.07.13.53.27\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 13:53:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775595208; x=1776200008; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+umKk6wWHPqSsy4J47zW2yNFfVhQ64yHh0oe/yOICg8=;\n b=OLBj5HQyyHkHDZOEIf/hDJhAxvfOHjF1X27yjz4s4XQ4X83ssqJiCzE02srNxCMjhL\n QFYaL9yr/l2EUMTA89DPyOH/gds7UloHIvxEQxAyzH1UKxQlVvJCC0WYZO9wv1DtO0oG\n OD91F338pbW1YnpO7V583Bn6H3mfNFrQhbSQ0hBonWPb6UmevnQ8ZnZ3qrjmk1oY47nH\n OqheEBPSccghPQwn03Nqp3pmQNE4/4HODzIKGb3XJzxic+dA8DN9TYGxJFD/6f0RofLA\n ZBSVkEVt+hWwy0HVKtkBWIMbY+UwUWjV8cIyv0eCVdkRgRTCKVROPu08cJWlRaL7R3wF\n xa3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775595208; x=1776200008;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=+umKk6wWHPqSsy4J47zW2yNFfVhQ64yHh0oe/yOICg8=;\n b=hvY9gig6r36dQIfJ3zBmXHtrCNvoI2j0Umbe9BRXVHxAJN99aV0kUfKscWr+IWyvtn\n Bxy86oQNVBDkwO/COwArYMvE1H4HCfKiu9uG64nVYYaA8AqZb6JgHQkThENqYy70VYSk\n QHGSMxMFXP7tReVMqlTXffFAyN0flo0YRx/Z8mFtrdMqSNsXFwiClG68ACQQnIGMm3i7\n mJjmol4nyxM4PkAVwWiiYeMxgyZQOi7uaZnGegfyc24cPCko1rnTQXRkEnrtwpL8sNVt\n BzNCUZdMIQO1+C+6WQrwiKe5ba/RpUw4e1YPpsKpMglT9JOvMFDWN+f7MMmiBjJjh9Nl\n XAVQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXOgGR8Ka9nqIV/6WdhNe6v/XAMslP8+CwoE26PCnNQPzVfI46s0TLGSUk/s8Lpdn/HW88+XuNwKAFU@nongnu.org","X-Gm-Message-State":"AOJu0YxyT/VVjdfQmERMcKGbq1BE6rcAMOAK4OwiMYpKLq5MKVZE/GjW\n 25/nkXe31AIMWolTNgwK0ZO5qngGk5Xri/mifZ8m71UPD1JJwXJ7KFYJR4rr0p6DNx0=","X-Gm-Gg":"AeBDietT8X9nnqYoenS4cCBZaNmp6BM/k3ko2SO0BN/1sosPh38KRwsLV6XW0xmuxfA\n jT4sWyQQTV91NMujgfhWVUNy5fF0VmS9X0cU15+u9WIbadUeGwNazRdi2ClxzmLMKztamWD8U98\n Lsf8qI9p6wW7oeCgx0K8G+gwlds+Lct1iGHdeGN3Qxi02BsPMK14AB+xH06Dw/5c5Doqr5JV+Ep\n vEZ7HwhOl9w+M2tbo6TFdecmHPrNTA3lLyLLljYv7jivsJzfa7i5HU2gxKpP9XLoA3dOuPQZQeO\n Qzv+gavduTAtZ/V3xmexXVXCIVYtVTPIzfRqMV9E1a574ZLaFjj2x/p8trG907yvkUAnD4T18Qn\n XStmqmB/8N8RgdlwAfV/+kLiv7c23vom7jh/oAxCvjbS/FdHnYHddavhej9M2kp+ts1K22nFxTW\n iktvTxfo0tp9IiowQ/LszG4kE11kYEPqK81B2QTOcvMtRNFi+NhzSAcq75+2h5xJqPYg==","X-Received":"by 2002:a05:600c:8012:b0:485:3f72:323f with SMTP id\n 5b1f17b1804b1-4889974a416mr269254155e9.11.1775595208346;\n Tue, 07 Apr 2026 13:53:28 -0700 (PDT)","Message-ID":"<10bf66bd-56d0-4030-bcc4-d61a3a756548@linaro.org>","Date":"Tue, 7 Apr 2026 22:53:26 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v10 13/21] target/arm/tcg/translate.c: extract\n aarch64_translate_code()","Content-Language":"en-US","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Richard Henderson , qemu-arm@nongnu.org,\n Paolo Bonzini ","References":"<20260407195922.196410-1-pierrick.bouvier@linaro.org>\n <20260407195922.196410-14-pierrick.bouvier@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260407195922.196410-14-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]