[{"id":3674431,"web_url":"http://patchwork.ozlabs.org/comment/3674431/","msgid":"","list_archive_url":null,"date":"2026-04-07T10:39:31","subject":"Re: [PATCH v3 1/5] monitor: store monitor id and dynamic flag in\n Monitor struct","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Apr 07, 2026 at 09:32:45AM +0200, Christian Brauner wrote:\n> Add 'id', 'dynamic', and 'dead' fields to struct Monitor. The id field\n> stores the monitor identifier from MonitorOptions which was previously\n> parsed but discarded. The dynamic flag marks monitors created at runtime\n> via the upcoming monitor-add command, and the dead flag will be used for\n> deferred destruction during monitor-remove.\n> \n> Extend monitor_init_qmp() to accept id and dynamic parameters so these\n> are set before the monitor is added to mon_list.\n> \n> For iothread monitors, move monitor_list_append() from the setup BH to\n> the caller so monitor_find_by_id() can detect duplicates immediately.\n> Without this, two concurrent monitor-add calls could both pass the\n> duplicate check before either BH runs. This means the monitor is now\n> visible in mon_list before its chardev handlers are set up, which was\n> not the case before. This is safe because the request queue is still\n> empty (no chardev handlers means no monitor_qmp_read(), so the\n> dispatcher finds nothing to dispatch) and event broadcast is handled\n> below.\n> \n> This requires initializing mon->commands = &qmp_cap_negotiation_commands\n> before monitor_list_append(). Without it, commands is NULL (from\n> g_new0) and monitor_qapi_event_emit() would not skip the monitor during\n> event broadcast -- its check is specifically for the\n> qmp_cap_negotiation_commands pointer, so a NULL falls through to\n> qmp_send_response() on an uninitialized monitor. CHR_EVENT_OPENED sets\n> commands to the same value again later.\n> \n> Add monitor_find_by_id() to look up monitors by identifier. The lookup\n> takes monitor_lock to serialize with the I/O thread BH that modifies\n> mon_list, but releases it before returning. The caller must hold the\n> BQL to ensure the returned pointer remains valid since only BQL holders\n> can destroy monitors.\n> \n> Free the id string in monitor_data_destroy().\n> \n> Signed-off-by: Christian Brauner (Amutable) \n> ---\n> include/monitor/monitor.h | 3 ++-\n> monitor/monitor-internal.h | 5 +++++\n> monitor/monitor.c | 21 ++++++++++++++++++++-\n> monitor/qmp.c | 11 ++++++++---\n> 4 files changed, 35 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h\n> index 296690e1f1..7a2bb603e4 100644\n> --- a/include/monitor/monitor.h\n> +++ b/include/monitor/monitor.h\n> @@ -19,7 +19,8 @@ bool monitor_cur_is_qmp(void);\n> \n> void monitor_init_globals(void);\n> void monitor_init_globals_core(void);\n> -void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp);\n> +void monitor_init_qmp(Chardev *chr, bool pretty, const char *id,\n> + bool dynamic, Error **errp);\n> void monitor_init_hmp(Chardev *chr, bool use_readline, Error **errp);\n> int monitor_init(MonitorOptions *opts, bool allow_hmp, Error **errp);\n> int monitor_init_opts(QemuOpts *opts, Error **errp);\n> diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\n> index feca111ae3..4896812d4e 100644\n> --- a/monitor/monitor-internal.h\n> +++ b/monitor/monitor-internal.h\n> @@ -98,7 +98,10 @@ struct Monitor {\n> bool is_qmp;\n> bool skip_flush;\n> bool use_io_thread;\n> + bool dynamic; /* true if created via monitor-add */\n> + bool dead; /* awaiting drain after monitor-remove */\n\nNeither of these fields appear to be used for anything in this\npatch. If they're used in a later patch, then add them at time\nof use.\n\n> \n> + char *id; /* NULL for unnamed CLI monitors */\n> char *mon_cpu_path;\n> QTAILQ_ENTRY(Monitor) entry;\n> \n> @@ -181,6 +184,8 @@ void monitor_data_destroy_qmp(MonitorQMP *mon);\n> void coroutine_fn monitor_qmp_dispatcher_co(void *data);\n> void qmp_dispatcher_co_wake(void);\n> \n> +Monitor *monitor_find_by_id(const char *id);\n> +\n> int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n> void handle_hmp_command(MonitorHMP *mon, const char *cmdline);\n> int hmp_compare_cmd(const char *name, const char *list);\n> diff --git a/monitor/monitor.c b/monitor/monitor.c\n> index 00b93ed612..7144255e12 100644\n> --- a/monitor/monitor.c\n> +++ b/monitor/monitor.c\n> @@ -622,6 +622,7 @@ void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,\n> \n> void monitor_data_destroy(Monitor *mon)\n> {\n> + g_free(mon->id);\n> g_free(mon->mon_cpu_path);\n> qemu_chr_fe_deinit(&mon->chr, false);\n> if (monitor_is_qmp(mon)) {\n> @@ -633,6 +634,24 @@ void monitor_data_destroy(Monitor *mon)\n> qemu_mutex_destroy(&mon->mon_lock);\n> }\n> \n> +/*\n> + * Look up a monitor by its id. The monitor_lock is released before\n> + * returning, so the caller must hold the BQL to ensure the returned\n> + * pointer remains valid (only BQL holders can destroy monitors).\n> + */\n> +Monitor *monitor_find_by_id(const char *id)\n> +{\n> + Monitor *mon;\n> +\n> + QEMU_LOCK_GUARD(&monitor_lock);\n> + QTAILQ_FOREACH(mon, &mon_list, entry) {\n> + if (mon->id && strcmp(mon->id, id) == 0) {\n> + return mon;\n> + }\n> + }\n> + return NULL;\n> +}\n> +\n> void monitor_cleanup(void)\n> {\n> /*\n> @@ -732,7 +751,7 @@ int monitor_init(MonitorOptions *opts, bool allow_hmp, Error **errp)\n> \n> switch (opts->mode) {\n> case MONITOR_MODE_CONTROL:\n> - monitor_init_qmp(chr, opts->pretty, errp);\n> + monitor_init_qmp(chr, opts->pretty, opts->id, false, errp);\n> break;\n> case MONITOR_MODE_READLINE:\n> if (!allow_hmp) {\n> diff --git a/monitor/qmp.c b/monitor/qmp.c\n> index 687019811f..afbe2283d6 100644\n> --- a/monitor/qmp.c\n> +++ b/monitor/qmp.c\n> @@ -510,10 +510,10 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)\n> qemu_chr_fe_set_handlers(&mon->common.chr, monitor_can_read,\n> monitor_qmp_read, monitor_qmp_event,\n> NULL, &mon->common, context, true);\n> - monitor_list_append(&mon->common);\n> }\n> \n> -void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)\n> +void monitor_init_qmp(Chardev *chr, bool pretty, const char *id,\n> + bool dynamic, Error **errp)\n> {\n> MonitorQMP *mon = g_new0(MonitorQMP, 1);\n> \n> @@ -527,12 +527,16 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)\n> monitor_data_init(&mon->common, true, false,\n> qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT));\n> \n> + mon->common.id = g_strdup(id);\n> + mon->common.dynamic = dynamic;\n> mon->pretty = pretty;\n> \n> qemu_mutex_init(&mon->qmp_queue_lock);\n> mon->qmp_requests = g_queue_new();\n> \n> json_message_parser_init(&mon->parser, handle_qmp_command, mon, NULL);\n> + /* Prevent event broadcast to an uninitialized monitor. */\n> + mon->commands = &qmp_cap_negotiation_commands;\n> if (mon->common.use_io_thread) {\n> /*\n> * Make sure the old iowatch is gone. It's possible when\n> @@ -551,7 +555,8 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)\n> */\n> aio_bh_schedule_oneshot(iothread_get_aio_context(mon_iothread),\n> monitor_qmp_setup_handlers_bh, mon);\n> - /* The bottom half will add @mon to @mon_list */\n> + /* Synchronous insert for immediate duplicate detection. */\n> + monitor_list_append(&mon->common);\n> } else {\n> qemu_chr_fe_set_handlers(&mon->common.chr, monitor_can_read,\n> monitor_qmp_read, monitor_qmp_event,\n> \n> -- \n> 2.47.3\n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EAw2Ut+B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxLr2BlTz1yGM\n\tfor ; Wed, 08 Apr 2026 05:38:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wABWA-0007uB-Fm; Tue, 07 Apr 2026 14:51:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wABTm-0002eY-7W\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:48:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wA3qS-0005AI-5m\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 06:39:46 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-Y_NaVTD1PRufTALoeK3vbQ-1; Tue,\n 07 Apr 2026 06:39:39 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A24E81956046; Tue, 7 Apr 2026 10:39:37 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id DBC0130001BB; Tue, 7 Apr 2026 10:39:34 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775558382;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=Hbs22JhBt6EjZOe3QujDiy+G5sHIl7it0+rcHyQDPOE=;\n b=EAw2Ut+BpRI1pPD1M8+B4ySJN8Iy8UCu3OfIktEGK2XCch2LR/H9ZKvSJqTXcXKBoGBeYA\n GZNkS8oUBTFjR53WAcjEoqvMu1uTDyz6KO22ALQIeJasa7Rc+PmFuZltBRs25LJJ/MbZHt\n tz7icQvyujStQBKU3RHkAGqkGY69pBE=","X-MC-Unique":"Y_NaVTD1PRufTALoeK3vbQ-1","X-Mimecast-MFC-AGG-ID":"Y_NaVTD1PRufTALoeK3vbQ_1775558378","Date":"Tue, 7 Apr 2026 11:39:31 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Christian Brauner ","Cc":"qemu-devel@nongnu.org, Markus Armbruster ,\n Eric Blake , Fabiano Rosas ,\n Laurent Vivier , Paolo Bonzini ,\n Thomas Huth ,\n Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Subject":"Re: [PATCH v3 1/5] monitor: store monitor id and dynamic flag in\n Monitor struct","Message-ID":"","References":"<20260407-work-qmp-monitor-hotplug-v3-0-cb259800fffb@kernel.org>\n <20260407-work-qmp-monitor-hotplug-v3-1-cb259800fffb@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260407-work-qmp-monitor-hotplug-v3-1-cb259800fffb@kernel.org>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674498,"web_url":"http://patchwork.ozlabs.org/comment/3674498/","msgid":"<20260407-beackern-bereichern-888fb1925d45@brauner>","list_archive_url":null,"date":"2026-04-07T20:59:37","subject":"Re: [PATCH v3 1/5] monitor: store monitor id and dynamic flag in\n Monitor struct","submitter":{"id":82326,"url":"http://patchwork.ozlabs.org/api/people/82326/","name":"Christian Brauner","email":"brauner@kernel.org"},"content":"On Tue, Apr 07, 2026 at 11:39:31AM +0100, Daniel P. Berrangé wrote:\n> On Tue, Apr 07, 2026 at 09:32:45AM +0200, Christian Brauner wrote:\n> > Add 'id', 'dynamic', and 'dead' fields to struct Monitor. The id field\n> > stores the monitor identifier from MonitorOptions which was previously\n> > parsed but discarded. The dynamic flag marks monitors created at runtime\n> > via the upcoming monitor-add command, and the dead flag will be used for\n> > deferred destruction during monitor-remove.\n> > \n> > Extend monitor_init_qmp() to accept id and dynamic parameters so these\n> > are set before the monitor is added to mon_list.\n> > \n> > For iothread monitors, move monitor_list_append() from the setup BH to\n> > the caller so monitor_find_by_id() can detect duplicates immediately.\n> > Without this, two concurrent monitor-add calls could both pass the\n> > duplicate check before either BH runs. This means the monitor is now\n> > visible in mon_list before its chardev handlers are set up, which was\n> > not the case before. This is safe because the request queue is still\n> > empty (no chardev handlers means no monitor_qmp_read(), so the\n> > dispatcher finds nothing to dispatch) and event broadcast is handled\n> > below.\n> > \n> > This requires initializing mon->commands = &qmp_cap_negotiation_commands\n> > before monitor_list_append(). Without it, commands is NULL (from\n> > g_new0) and monitor_qapi_event_emit() would not skip the monitor during\n> > event broadcast -- its check is specifically for the\n> > qmp_cap_negotiation_commands pointer, so a NULL falls through to\n> > qmp_send_response() on an uninitialized monitor. CHR_EVENT_OPENED sets\n> > commands to the same value again later.\n> > \n> > Add monitor_find_by_id() to look up monitors by identifier. The lookup\n> > takes monitor_lock to serialize with the I/O thread BH that modifies\n> > mon_list, but releases it before returning. The caller must hold the\n> > BQL to ensure the returned pointer remains valid since only BQL holders\n> > can destroy monitors.\n> > \n> > Free the id string in monitor_data_destroy().\n> > \n> > Signed-off-by: Christian Brauner (Amutable) \n> > ---\n> > include/monitor/monitor.h | 3 ++-\n> > monitor/monitor-internal.h | 5 +++++\n> > monitor/monitor.c | 21 ++++++++++++++++++++-\n> > monitor/qmp.c | 11 ++++++++---\n> > 4 files changed, 35 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h\n> > index 296690e1f1..7a2bb603e4 100644\n> > --- a/include/monitor/monitor.h\n> > +++ b/include/monitor/monitor.h\n> > @@ -19,7 +19,8 @@ bool monitor_cur_is_qmp(void);\n> > \n> > void monitor_init_globals(void);\n> > void monitor_init_globals_core(void);\n> > -void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp);\n> > +void monitor_init_qmp(Chardev *chr, bool pretty, const char *id,\n> > + bool dynamic, Error **errp);\n> > void monitor_init_hmp(Chardev *chr, bool use_readline, Error **errp);\n> > int monitor_init(MonitorOptions *opts, bool allow_hmp, Error **errp);\n> > int monitor_init_opts(QemuOpts *opts, Error **errp);\n> > diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\n> > index feca111ae3..4896812d4e 100644\n> > --- a/monitor/monitor-internal.h\n> > +++ b/monitor/monitor-internal.h\n> > @@ -98,7 +98,10 @@ struct Monitor {\n> > bool is_qmp;\n> > bool skip_flush;\n> > bool use_io_thread;\n> > + bool dynamic; /* true if created via monitor-add */\n> > + bool dead; /* awaiting drain after monitor-remove */\n> \n> Neither of these fields appear to be used for anything in this\n> patch. If they're used in a later patch, then add them at time\n> of use.\n\nOk.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MYYKYD+O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (unknown [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fr0F13mPwz1xv0\n\tfor ; Wed, 08 Apr 2026 07:48:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wADYZ-0005Ye-TS; Tue, 07 Apr 2026 17:01:55 -0400","from eggs.gnu.org ([209.51.188.92])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wADYY-0005YK-Mo\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 17:01:54 -0400","from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wADWQ-0001Ph-IU\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 16:59:43 -0400","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 00759600AC;\n Tue, 7 Apr 2026 20:59:42 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7332DC116C6;\n Tue, 7 Apr 2026 20:59:39 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1775595581;\n bh=i38PdCOospeuZ97BtU06FHd3FUy6qM5rW3XcNazdeJ8=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=MYYKYD+OBRWFWRpnqS3BCf90+Rud0g27Ap/F1mlIDtu4AD94v8FOklJNl+f5PjkWh\n 5vHy9Jn/QhyfqWpIGl3ETtLOJTEUYgpCIKzHocMmW3LD3LztTOYYS9mho5PliK/l/u\n bNN77xD3Uo0R6uKIquhu1+HXG4IN33dv/6kXLoslsMsnyb/6ru5VDr39/v+WITV+ov\n DrSDxAQ5+b40H+k/bdNdaPVhsA6av0fZS9p0C8HP1OkMxJ1adpLsD5GAkV2VNfSVG/\n E/4Ur7Kr0HvLVyD9ES28bsD7tJPUJIxBeMZ0AUmh7mm/yuTTuJnEAllLhPh/gnFadR\n xMALj6RzlBK3A==","Date":"Tue, 7 Apr 2026 22:59:37 +0200","From":"Christian Brauner ","To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Cc":"qemu-devel@nongnu.org, Markus Armbruster ,\n Eric Blake , Fabiano Rosas ,\n Laurent Vivier , Paolo Bonzini ,\n Thomas Huth , Philippe =?utf-8?q?Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ","Subject":"Re: [PATCH v3 1/5] monitor: store monitor id and dynamic flag in\n Monitor struct","Message-ID":"<20260407-beackern-bereichern-888fb1925d45@brauner>","References":"<20260407-work-qmp-monitor-hotplug-v3-0-cb259800fffb@kernel.org>\n <20260407-work-qmp-monitor-hotplug-v3-1-cb259800fffb@kernel.org>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Received-SPF":"pass client-ip=2600:3c04:e001:324:0:1991:8:25;\n envelope-from=brauner@kernel.org; helo=tor.source.kernel.org","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]