[{"id":3674917,"web_url":"http://patchwork.ozlabs.org/comment/3674917/","msgid":"<8a16db1b-459f-4553-a104-c6849b53c88a@gmail.com>","list_archive_url":null,"date":"2026-04-08T03:13:54","subject":"Re: [PATCH v2 3/5] hw/ufs: Add idle operation","submitter":{"id":86755,"url":"http://patchwork.ozlabs.org/api/people/86755/","name":"Jeuk Kim","email":"jeuk20.kim@gmail.com"},"content":"On 4/7/2026 7:23 PM, Jaemyung Lee wrote:\n> When no I/O occurs, the UFS Device performs various internal operations.\n> To emulate this, adds a timer that periodically checks the current I/O\n> status of the device and call the ufs_process_idle() function when idle.\n>\n> Signed-off-by: Jaemyung Lee \n> ---\n> hw/ufs/ufs.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> hw/ufs/ufs.h | 2 ++\n> 2 files changed, 61 insertions(+)\n>\n> diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c\n> index 69f82ab462d135fe6cda479891f9d8f26d19be9a..5102d9bbab640faded69c93be73cbe319db68646 100644\n> --- a/hw/ufs/ufs.c\n> +++ b/hw/ufs/ufs.c\n> @@ -1801,6 +1801,59 @@ static void ufs_sendback_req(void *opaque)\n> ufs_irq_check(u);\n> }\n> \n> +static void ufs_process_idle(UfsHc *u)\n> +{\n> + /* Currently do nothing */\n> + return;\n> +}\n> +\n> +static inline bool ufs_check_idle(UfsHc *u)\n> +{\n> + return !u->reg.utrldbr;\n> +}\n> +\n> +static inline bool ufs_mcq_check_idle(UfsHc *u)\n> +{\n> + if (!u->params.mcq) {\n> + return true;\n> + }\n> +\n> + for (int qid = 0; qid < ARRAY_SIZE(u->sq); qid++) {\n> + if (!ufs_mcq_sq_empty(u, qid)) {\n> + return false;\n> + }\n> +\n> + /* internal ongoing MCQ request check */\n> + UfsSq *sq = u->sq[qid];\n\nMCQ queues are non-NULL only for the qids that are actually created.\nYou must add a NULL check here.\n\n\n> + for (int i = 0; i < sq->size; i++) {\n> + if (sq->req[i].state != UFS_REQUEST_IDLE) {\n> + return false;\n> + }\n> + }\n> + }\n> +\n> + for (int qid = 0; qid < ARRAY_SIZE(u->cq); qid++) {\n> + if (!ufs_mcq_cq_empty(u, qid)) {\n> + return false;\n> + }\n> + }\n\nChecking only ufs_mcq_cq_empty() is not sufficient.\nYou should also check:\nu->cq[qid] && !QTAILQ_EMPTY(&u->cq[qid]->req_list)\n\n> +\n> + return true;\n> +}\n> +\n> +#define UFS_IDLE_TIMER_TICK 100 /* 0.1s */\n> +static void ufs_idle_timer_cb(void *opaque)\n> +{\n> + UfsHc *u = opaque;\n> + int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n> +\n> + if (ufs_check_idle(u) && ufs_mcq_check_idle(u)) {\n> + ufs_process_idle(u);\n> + }\n> +\n> + timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n> +}\n> +\n> static bool ufs_check_constraints(UfsHc *u, Error **errp)\n> {\n> if (u->params.nutrs > UFS_MAX_NUTRS) {\n> @@ -1863,6 +1916,7 @@ static void ufs_init_hc(UfsHc *u)\n> uint32_t cap = 0;\n> uint32_t mcqconfig = 0;\n> uint32_t mcqcap = 0;\n> + int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n> \n> u->reg_size = pow2ceil(ufs_reg_size(u));\n> \n> @@ -1959,6 +2013,9 @@ static void ufs_init_hc(UfsHc *u)\n> * dynamically\n> */\n> u->temperature = UFS_TEMPERATURE;\n> +\n> + timer_init_ms(&u->idle_timer, QEMU_CLOCK_VIRTUAL_RT, ufs_idle_timer_cb, u);\n> + timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n> }\n> \n> static void ufs_realize(PCIDevice *pci_dev, Error **errp)\n> @@ -1986,6 +2043,8 @@ static void ufs_exit(PCIDevice *pci_dev)\n> {\n> UfsHc *u = UFS(pci_dev);\n> \n> + timer_del(&u->idle_timer);\n> +\n> qemu_free_irq(u->irq);\n> \n> qemu_bh_delete(u->doorbell_bh);\n> diff --git a/hw/ufs/ufs.h b/hw/ufs/ufs.h\n> index 13d964c5ae5ec430a98b2ef71987cb9279e9a317..b5f040302129f4d02732ddd20ef82eb33c41922a 100644\n> --- a/hw/ufs/ufs.h\n> +++ b/hw/ufs/ufs.h\n> @@ -148,6 +148,8 @@ typedef struct UfsHc {\n> UfsCq *cq[UFS_MAX_MCQ_QNUM];\n> \n> uint8_t temperature;\n> +\n> + QEMUTimer idle_timer;\n> } UfsHc;\n> \n> static inline uint32_t ufs_mcq_sq_tail(UfsHc *u, uint32_t qid)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=jL19Mk+y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXkX3jPgz1yD3\n\tfor ; Thu, 09 Apr 2026 05:12:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYGs-0004qj-RM; Wed, 08 Apr 2026 15:09:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAYFY-0003Jc-Ux\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:07:44 -0400","from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAJMc-00008c-TN\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 23:14:00 -0400","by mail-pf1-x436.google.com with SMTP id\n d2e1a72fcca58-82cf83bf375so2364941b3a.0\n for ; Tue, 07 Apr 2026 20:13:58 -0700 (PDT)","from [192.168.0.22] ([211.226.54.223])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82d59834b63sm3056853b3a.21.2026.04.07.20.13.54\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 20:13:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775618037; x=1776222837; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=eN0XT8CmTyToGaSu23qPJxNwe3iqDjG9RzrkLZpHRYE=;\n b=jL19Mk+yHV9rNtOcbYSAG1vjkXPxqf+/Xr7EX/xl26p1WMm3plRhni/X1tkSx4TRYR\n 8Sbh9zM3qqRf58ZGOmMclcB748dZnBYn1mzPSceS9BSGoLvyy/DF+e72JOXHpa7tj/1M\n RdU/mkYKpsJbgZXGOVoKPazN5Bq07vGKhnNdROH82Bx+HsilVEkrPnv/lLM+ARLd6BOu\n lyeFfHNK55xZIgMGBFz+gMqwl2twdp14+YRoQVOssGLIg71+DkxlRjLWcixU7OirQdaW\n RozlWiMzSmHmATcjKstqqssFHjD8bGlsaNqUeLVrDyR/TI9TJVr8kT/dHZuvoGLz4+J1\n ULfQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775618037; x=1776222837;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=eN0XT8CmTyToGaSu23qPJxNwe3iqDjG9RzrkLZpHRYE=;\n b=qOh43OHKlCi91UFVLsmrH6Zd8xQdThkQbPL9JUvpPzoMqxGFbUYs6VtmN/4Em9UWQj\n UaPCqNoMLgT2LQk8v/UesI3z4Eu/Qfp5E3Et3seWa9Gi+GRjjNOkw5rhJce2bGTV3p/l\n SVoWhQQzcMlXQ/xcCd3bCjTB1poevx1j9kdmSQO4mfuqP+g5kFljUXZ2KegG95AadvOW\n LGo4D2iEH431PvaZAfkRtsYqoPhru9UU8Tw0HszPkGoiZOxeW+GeA6oR4zApial6ufPx\n 9Da+0A2DJBqL4xA8wsiXduNDO+dnp3ag6388nclMA3w2YjjQhXIZn0KwYFpvqvmVPMR9\n x+Rg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWPxgRPzrfBnkWdiggIiHHG0PoSgLsG2+qcjF6jsvJHLNRIB8a9y3oVPV4PF17EqTwO72LHiltjN5hP@nongnu.org","X-Gm-Message-State":"AOJu0YzORaPeN05A8ImfGoy7esKSpSJekBJOCOWdKx5SoAALThoEl1EQ\n 7GtMlhkhnlSsvIoziPXpA5luvBkEP9ZGlaLqhkfRDwHZn32h1XYaI+QB","X-Gm-Gg":"AeBDiett0xEPasrHcAoDLYjCH0fq9z5TlGR7jtJwnR7aXZWK/ZcuWEir0rzmMwKOccp\n tn1HMueIBbagWaRJr+uAJcN0wnSbBoyis1HAgmeT+kqk8YME98gykUx87N3oPtjVQ3sZLDfsMT2\n EI9Gk8vyu93UCDFYdZtzGycUHgHMW7Ar6afTNJD93Nh7O7E6BgfHJfkguIz4IvIRlQWmFIEswAx\n HwvqASNfLbFF7IAu/G9Qy8LDNkfQvmjKeZv7tzoaoMjyB0IGQMFWiT/twSiP1ogX04DH+gjKgoP\n fuXGcz0rtWjNBtE1xIoFMNwfasK/hFDnKDRYhxVFKa9TnEoL2SSP9QQ7zkfj+nQ6fzlohYw1OuL\n W7ZzBmQwNq86m8Ddhr/kjJo47UjJGQkNO46DtcQJDIsj/+AbsK4c0ub8YMTOVOJbTRCMGzgMa06\n 529CtKkvpNkIey4XnPL7FKw0qznBTa7+bPJ10wUWalvA==","X-Received":"by 2002:a05:6a00:1794:b0:82a:14aa:795f with SMTP id\n d2e1a72fcca58-82d0db6279fmr20047562b3a.35.1775618036819;\n Tue, 07 Apr 2026 20:13:56 -0700 (PDT)","Message-ID":"<8a16db1b-459f-4553-a104-c6849b53c88a@gmail.com>","Date":"Wed, 8 Apr 2026 12:13:54 +0900","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/5] hw/ufs: Add idle operation","To":"Jaemyung Lee , qemu-devel@nongnu.org","Cc":"Jeuk Kim , Kevin Wolf ,\n Hanna Reitz , qemu-block@nongnu.org,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini , Jaemyung Lee ","References":"<20260407-write_booster-v2-0-dd772bb30194@samsung.com>\n <20260407-write_booster-v2-3-dd772bb30194@samsung.com>","Content-Language":"ko","From":"Jeuk Kim ","In-Reply-To":"<20260407-write_booster-v2-3-dd772bb30194@samsung.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::436;\n envelope-from=jeuk20.kim@gmail.com; helo=mail-pf1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]