[{"id":3674386,"web_url":"http://patchwork.ozlabs.org/comment/3674386/","msgid":"<9ae5a77f-38a4-4067-9a16-9493774158fb@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-07T09:38:50","subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","submitter":{"id":92288,"url":"http://patchwork.ozlabs.org/api/people/92288/","name":"Daniel Henrique Barboza","email":"daniel.barboza@oss.qualcomm.com"},"content":"On 4/7/2026 1:36 AM, alistair23@gmail.com wrote:\n> From: Alistair Francis <alistair.francis@wdc.com>\n> \n> The stack pointer is being truncated as 32-bits for qemu-riscv64, so\n> let's add a print_read_write helper that ensures all of the bits are\n> printed.\n> \n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3238\n> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>\n> ---\n\n\nReviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>\n\n\n>   linux-user/strace.c    | 14 ++++++++++++++\n>   linux-user/strace.list |  4 ++--\n>   2 files changed, 16 insertions(+), 2 deletions(-)\n> \n> diff --git a/linux-user/strace.c b/linux-user/strace.c\n> index 2cbaf94c89..023173857b 100644\n> --- a/linux-user/strace.c\n> +++ b/linux-user/strace.c\n> @@ -4309,6 +4309,20 @@ print_tgkill(CPUArchState *cpu_env, const struct syscallname *name,\n>   }\n>   #endif\n>   \n> +#if defined(TARGET_NR_read) || defined(TARGET_NR_write)\n> +static void\n> +print_read_write(CPUArchState *cpu_env, const struct syscallname *name,\n> +        abi_long arg0, abi_long arg1, abi_long arg2,\n> +        abi_long arg3, abi_long arg4, abi_long arg5)\n> +{\n> +    print_syscall_prologue(name);\n> +    print_raw_param(\"%d\", arg0, 0);\n> +    print_pointer(arg1, 0);\n> +    print_raw_param(\"%d\", arg2, 1);\n> +    print_syscall_epilogue(name);\n> +}\n> +#endif\n> +\n>   #if defined(TARGET_NR_pread64) || defined(TARGET_NR_pwrite64)\n>   static void\n>   print_pread64(CPUArchState *cpu_env, const struct syscallname *name,\n> diff --git a/linux-user/strace.list b/linux-user/strace.list\n> index 35f001fecd..239b9e18b4 100644\n> --- a/linux-user/strace.list\n> +++ b/linux-user/strace.list\n> @@ -1114,7 +1114,7 @@\n>   { TARGET_NR_quotactl, \"quotactl\" , NULL, NULL, NULL },\n>   #endif\n>   #ifdef TARGET_NR_read\n> -{ TARGET_NR_read, \"read\" , \"%s(%d,%#x,%d)\", NULL, NULL },\n> +{ TARGET_NR_read, \"read\" , NULL, print_read_write, NULL },\n>   #endif\n>   #ifdef TARGET_NR_readahead\n>   { TARGET_NR_readahead, \"readahead\" , NULL, NULL, NULL },\n> @@ -1674,7 +1674,7 @@\n>                        print_syscall_ret_waitpid },\n>   #endif\n>   #ifdef TARGET_NR_write\n> -{ TARGET_NR_write, \"write\" , \"%s(%d,%#x,%d)\", NULL, NULL },\n> +{ TARGET_NR_write, \"write\" , NULL, print_read_write, NULL },\n>   #endif\n>   #ifdef TARGET_NR_writev\n>   { TARGET_NR_writev, \"writev\" , \"%s(%d,%p,%#x)\", NULL, NULL },","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=QjgoTHXN;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=QDN3aaEN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqx6b4Csfz1yGM\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 05:27:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wABWz-0008Kj-Fj; Tue, 07 Apr 2026 14:52:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <daniel.barboza@oss.qualcomm.com>)\n id 1wABTp-0002eY-LJ\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:48:53 -0400","from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <daniel.barboza@oss.qualcomm.com>)\n id 1wA2te-0003Md-72\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 05:38:59 -0400","from pps.filterd (m0279863.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6376r4lX1584991\n for <qemu-devel@nongnu.org>; Tue, 7 Apr 2026 09:38:56 GMT","from mail-dl1-f72.google.com (mail-dl1-f72.google.com\n [74.125.82.72])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr9t3kh-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 09:38:56 +0000 (GMT)","by mail-dl1-f72.google.com with SMTP id\n a92af1059eb24-12737f276a2so7666340c88.1\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 02:38:56 -0700 (PDT)","from [192.168.68.100] ([177.18.66.130])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12bed93f861sm19353556c88.0.2026.04.07.02.38.52\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 02:38:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n WxskF6LO3XCdZZOnO3IbldOfc27E8D+GDM32DgLltss=; b=QjgoTHXNks5YzPCo\n TwDKq2GhGe4hP9lwhHAqKnYxHMmef6DKqj8jx4aZGONabrq2+Dt2/XcgOyPEfe7w\n rH2VAyQg3wVt4M6xjLObgEaJzigS3SUkan6PL5S/XsMrpMg0tjFJ4iL/fm1CjAZm\n ZCqaZg5Q8h0luclDz/h1dj61wvDGsyVwitL0Jz4Plt7HsffxoMvzuzpdiFkyTaJS\n 6+Q5kNDgrbc2GhgtOZFYGYIL2oMxB+YeO6qT4ikHWl/5zTjmt8UkWAxbcFfAr/E8\n FDcltS9j52o6hSFME2hwt3DZCtibNxMBD+c/S7toYMf2DKmRKQqf6/ji/ce4B9U4\n 94119g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775554736; x=1776159536; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=WxskF6LO3XCdZZOnO3IbldOfc27E8D+GDM32DgLltss=;\n b=QDN3aaENor3hiz4VRWI2pjBdV0p5rGG4tY+wmb+SbqnF7gzpW1juStEL0u5EG1+cYe\n TuBH8YzWF7pYOKAuYVG1tfge5X8R3BKNfMzRhzW6/d5vn0FmRUIj78DmpuSI/8L6CGRp\n vDA7v2cIL84d5Rj9Enkjupu3brIFdUFnfUlUkTW+Ez36unnF25QVwIZlPJJaOqI1iSvI\n AivWmMkE+REZ+bk3b8Ch0CaKkXa1llPRU/AQt7DxE8n5xIZNBwrNpuzTP2AnWmrgOhGy\n JSG3pXfv5dqdB8ZyTutDe4pfrffI8sK1Ujlxhmv+frYK3yapB0pQQxaClui6Z+2jk0Cw\n fOEA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775554736; x=1776159536;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=WxskF6LO3XCdZZOnO3IbldOfc27E8D+GDM32DgLltss=;\n b=PqN58Pzqqo9mR92b/sdE+MXeiQykY/04tOtisKqHqePSIm7tt5jBi4KYnyCYyE/M5P\n n/SW/zQaA/GoNCr7Nz7NujqSUUaGAdyqfe9Bd7tuOz/wRUs8PdJZMdKOi2nWWnJFAp5D\n +JqSdKhjWPKk7YLUek0oT3IAEHhjkxm9KWMcUxmvADJEPO7MHpbW50hAgiU1XuUhzgUD\n nHZfk761SDAG4O+Mom+dTiFGIPBiOOWLRxTV8kvQIYavc2LpMQsfCRJTPUaXpnyZ5Ucu\n 8qrOppAloGzVtmyDcf3qVcJCzqLqeo5vu/Vxpu3Pt4UJDIZEoUf3D3+XYWIQQ55U+iCo\n DU4Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV/Zv74yma1281ExOfL2L4SLTXP/bFANHV6BxdtzaCI8nFvqIptzgDl0W+y4+/vdrn57y5toZAmfTHq@nongnu.org","X-Gm-Message-State":"AOJu0YwaNPZbr39eZzeNJu/Nsi08vHZYMhfAQhElDdLJFDG/oQLvnJB9\n bK6IgL8HXHK+vIfNnc1y6Fdc0mhMUyswnMN5SVnARIbtlE5XpiwKGe92TpgGvk6Bk7SYzWwTP8h\n S+TFJfqmlTjGae5RL/jCUXp3BLYbJiJcoojybkvCypgwWx62fqZvBUyy1kA==","X-Gm-Gg":"AeBDietjzu57CoWHgW+Lzc/sW4kU66ZonZhgcbP+GkQhHEnnKlR55NZl2STI3uzNnHT\n IMzdGvMGHxIJurcXbrnfnDnk4eixs9pCercArkZuK7HDkTDjYHetJoQAErXHdtqgDakekYikSTs\n RvWncdPiQ2g/+bi0mpmaWsQK5pMUJszLgALrSfCA79Ry8GrnbVqnZPZn5DQJX0gart3rP++siJ5\n jZjGU6Hi88OiJKKR4Exc36P80wYL3UNz0HMD2ctdLbrUzLbs1CM88wWhwb35tceUvQxYCuztYdO\n j60/j58Jp2BUgVQULlNEB7Rpe8KXPC5O3WuD+5pezxCXrPnICVaSMQNFEUtjoBgcrNu9fDaHvMN\n GJpl2WDM1iUIEP5WrALX5KypFjD2opZMtl5lnFxlI9YXZqRzHVUXdAyNY","X-Received":["by 2002:a05:7022:6199:b0:11d:c22e:a131 with SMTP id\n a92af1059eb24-12bfb6edfbbmr7446330c88.3.1775554735949;\n Tue, 07 Apr 2026 02:38:55 -0700 (PDT)","by 2002:a05:7022:6199:b0:11d:c22e:a131 with SMTP id\n a92af1059eb24-12bfb6edfbbmr7446300c88.3.1775554735278;\n Tue, 07 Apr 2026 02:38:55 -0700 (PDT)"],"Message-ID":"<9ae5a77f-38a4-4067-9a16-9493774158fb@oss.qualcomm.com>","Date":"Tue, 7 Apr 2026 06:38:50 -0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","To":"alistair23@gmail.com, palmer@dabbelt.com, liwei1518@gmail.com,\n zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com,\n qemu-riscv@nongnu.org, qemu-devel@nongnu.org","Cc":"Alistair Francis <alistair.francis@wdc.com>","References":"<20260407043614.372871-1-alistair.francis@wdc.com>\n <20260407043614.372871-3-alistair.francis@wdc.com>","From":"Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>","Content-Language":"en-US","In-Reply-To":"<20260407043614.372871-3-alistair.francis@wdc.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authority-Analysis":"v=2.4 cv=SMdykuvH c=1 sm=1 tr=0 ts=69d4d0b0 cx=c_pps\n a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=Wg2i10Q8swPuJs8jTFC2sw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22\n a=p0WdMEafAAAA:8 a=pGLkceISAAAA:8 a=JF9118EUAAAA:8 a=EUspDBNiAAAA:8\n a=H3as2Lr20vdLQCbXi_cA:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22\n a=xVlTc564ipvMDusKsbsT:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDA4OCBTYWx0ZWRfX3i35v9merA7N\n HYSISPIqPqkZ8kdq+LE72HQi7znbWQzqDtvQSjwwIbW5uTPZfdB54oLN7apDX9iVtEeg9Nwv4NZ\n ZjHm+asETT8Mign+sn8u6sUHnXCdoAYLz09JWSKrpPUCKzDKSBjKgh14o0hOatLxCmQl4Q50sQq\n dqa4wHTIxcJNkBWtaLgwzWDT/4e/TADoWRY0s4carCEusdHXJhXiFvn4RuxD4dSOUhcE7hn1iyf\n bgqxO8LCFlY/8uFRGpojptah3E9gCM7pTwmf1Y9vb+tLNMo7EDeX41h/TjuDOYBuYW5teOWBftg\n gHUEOAzeMjto5mtIF10MwZ0a3JbuOOeGrHm7rGJEO3WDFVcWjSQBZEo0AWD5URpAk9oiO28rTly\n UaRW8k5b4nT0yzaXJ0zHschGsfBwQDqfTvwEH+qBGSjN4Aqo9KppPDmhShOUprc+o8SgLsg3XI3\n 5nwqol4btAj6vckGbYw==","X-Proofpoint-GUID":"WmrJX87ZCDa_y87QhrhcLI4SHzWvM519","X-Proofpoint-ORIG-GUID":"WmrJX87ZCDa_y87QhrhcLI4SHzWvM519","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_02,2026-04-07_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0\n impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070088","Received-SPF":"pass client-ip=205.220.168.131;\n envelope-from=daniel.barboza@oss.qualcomm.com;\n helo=mx0a-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674427,"web_url":"http://patchwork.ozlabs.org/comment/3674427/","msgid":"<adUycpyM7bUjmC_7@ZEVORN-PC.localdomain>","list_archive_url":null,"date":"2026-04-07T16:55:51","subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","submitter":{"id":92265,"url":"http://patchwork.ozlabs.org/api/people/92265/","name":"Chao Liu","email":"chao.liu.zevorn@gmail.com"},"content":"On Tue, Apr 07, 2026 at 02:36:11PM +1000, alistair23@gmail.com wrote:\n> From: Alistair Francis <alistair.francis@wdc.com>\n> \n> The stack pointer is being truncated as 32-bits for qemu-riscv64, so\n> let's add a print_read_write helper that ensures all of the bits are\n> printed.\n> \n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3238\n> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>\n> ---\n>  linux-user/strace.c    | 14 ++++++++++++++\n>  linux-user/strace.list |  4 ++--\n>  2 files changed, 16 insertions(+), 2 deletions(-)\n> \n> diff --git a/linux-user/strace.c b/linux-user/strace.c\n> index 2cbaf94c89..023173857b 100644\n> --- a/linux-user/strace.c\n> +++ b/linux-user/strace.c\n> @@ -4309,6 +4309,20 @@ print_tgkill(CPUArchState *cpu_env, const struct syscallname *name,\n>  }\n>  #endif\n>  \n> +#if defined(TARGET_NR_read) || defined(TARGET_NR_write)\n> +static void\n> +print_read_write(CPUArchState *cpu_env, const struct syscallname *name,\n> +        abi_long arg0, abi_long arg1, abi_long arg2,\n> +        abi_long arg3, abi_long arg4, abi_long arg5)\n> +{\n> +    print_syscall_prologue(name);\n> +    print_raw_param(\"%d\", arg0, 0);\n> +    print_pointer(arg1, 0);\n> +    print_raw_param(\"%d\", arg2, 1);\nIf TARGET_NR_read and TARGET_NR_write support 64-bit targets,\nabi_long is int64_t, so %d will be truncated. We can use\nTARGET_ABI_FMT_ld to replace it.\n\nOtherwise LGTM.\n\nReviewed-by: Chao Liu <chao.liu.zevorn@gmail.com>\n\nThanks,\nChao\n> +    print_syscall_epilogue(name);\n> +}\n> +#endif\n> +\n>  #if defined(TARGET_NR_pread64) || defined(TARGET_NR_pwrite64)\n>  static void\n>  print_pread64(CPUArchState *cpu_env, const struct syscallname *name,\n> diff --git a/linux-user/strace.list b/linux-user/strace.list\n> index 35f001fecd..239b9e18b4 100644\n> --- a/linux-user/strace.list\n> +++ b/linux-user/strace.list\n> @@ -1114,7 +1114,7 @@\n>  { TARGET_NR_quotactl, \"quotactl\" , NULL, NULL, NULL },\n>  #endif\n>  #ifdef TARGET_NR_read\n> -{ TARGET_NR_read, \"read\" , \"%s(%d,%#x,%d)\", NULL, NULL },\n> +{ TARGET_NR_read, \"read\" , NULL, print_read_write, NULL },\n>  #endif\n>  #ifdef TARGET_NR_readahead\n>  { TARGET_NR_readahead, \"readahead\" , NULL, NULL, NULL },\n> @@ -1674,7 +1674,7 @@\n>                       print_syscall_ret_waitpid },\n>  #endif\n>  #ifdef TARGET_NR_write\n> -{ TARGET_NR_write, \"write\" , \"%s(%d,%#x,%d)\", NULL, NULL },\n> +{ TARGET_NR_write, \"write\" , NULL, print_read_write, NULL },\n>  #endif\n>  #ifdef TARGET_NR_writev\n>  { TARGET_NR_writev, \"writev\" , \"%s(%d,%p,%#x)\", NULL, NULL },\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=p1bdEmJE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxKd1Y5vz1yGM\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 05:37:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wABRd-00037J-Uz; Tue, 07 Apr 2026 14:46:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chao.liu.zevorn@gmail.com>)\n id 1wABRZ-0002em-0Z\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:46:33 -0400","from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <chao.liu.zevorn@gmail.com>)\n id 1wA9iq-000196-BW\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 12:56:17 -0400","by mail-qt1-x844.google.com with SMTP id\n d75a77b69052e-50d880e6fbbso1018121cf.0\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 09:56:13 -0700 (PDT)","from ZEVORN-PC.localdomain ([162.244.208.119])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50d521952c4sm133732451cf.4.2026.04.07.09.56.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 09:56:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775580972; x=1776185772; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=xAu+uDvQJ2Ng9RFWEjPwEjctixPjdJqujlb83VbpOnI=;\n b=p1bdEmJE2+1hQm5nH/HkpI39/jMa+6K4RQbuGhAd/vIjR1CYCro2ANQXMg489ZsK5a\n H2GMR5lWFycC6/5RxMSTXHTY42yv2AstgTDXLwgB21QhhvS6UdF1Sup+ApXgAvTmowq/\n cAEBg7ybl2d5YTbGCW1OBtCDcCB/IrDOnWXgd+LHP2u1m/CgmonMPtkLqrnx1LAoeVD/\n ZkmOvLMCLtU/3xCbodalWv49S6uOxOQ6mbA40eOy588nU19smhcVCfBmPnxBYt5Jrq6l\n L+emUrhJoeDo0HgAfamGpfxGPtK8cZvmhEMWlWVT1w5q75D/L2RQRLGRACm61i3vkl8J\n jGdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775580972; x=1776185772;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=xAu+uDvQJ2Ng9RFWEjPwEjctixPjdJqujlb83VbpOnI=;\n b=D3Djq/0+6LCTYVhdMHNXBJMfqZyUmEilNIvMtp9fcM8MgaDkNhXacVhgeV9QqhK67f\n ZOc8NfAfBo428GTlysEabECJgurzUVHZwM2rVfD+r2TcNg7fzIJxhEFBlZLGgwMZdIAc\n vslZUJsky4JRW1BEwva40USor8gbnvCcHaiwmUH2Gyjr9+SDzAnK/mYG9UchV/CWL287\n Ilg5VA6NImgxePQViPIf7/leif6PjOaW31R8BJXW+5HSnu3JbMRld0ucuCxMaAEp1vXC\n qlEr9o+KNWTDhD0xMXpB17oqEX5JoGN0lkmD7C2W5LwmyKjVhs4P4HsaHPRQDecqFPn/\n 3Onw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXO8CserZctyR2brO0TSpVDrzSdauDRN71Tk8xVVMEY88hSQF3/B+7yb2J4sIkPIvZYLeZcetZtmAZD@nongnu.org","X-Gm-Message-State":"AOJu0YxrV4Pl76US9OWXisXgolcfBimfxTZuF67XBvaGlKm6h0grOfuI\n KbEHxGdk3uWwclZIfMn4lOBsR9wzLFiEqCb50644Oo/6ZSsMCmVVRhPT","X-Gm-Gg":"AeBDiet7d9J9lASIRV56h6m0fXX9ThPOdpxoY2xfn8nEXhYFn39R8ZZjDwbnkiEtunn\n aQSsvpeb2j/E6Ki6oUwsRWuyyNqrqCZeOP6m8OoZ5UsAXVdxz76Dq1E3KPs2TcUvijzUtpyWtmA\n JeaWF5KVSQwvhjzuQhMfINuMm0FkqrTRyQo8dxwBtHQhnrAVT199fKKlLk1SEliQJ1yCxwTBJxw\n Ddc301yUqPPUypUDlH+VI0uNhMQkSDwFv/99WHc6X8ZGSRUpyTPZXV1817oCWTrTeETyIfRkNiM\n d/wmPWYhqdHfCQJilqGixs7ghGZ3YhRXsjBDLdKWsmPUHpf46tldwIfzovONSbmcgpfoNkFCiGt\n AQlbSc2J47sMoXhyMVpcqUQnN5iFMKxcxsrtCtMx3hfeEkNglDUA/GAOTNOg6wXGAcu0xG12kAH\n SSpim+uXqu2a6qVISnRF9a7qkp0QrKLiPXW2dR1sb2HXZ/a35L8Hqa64TdIuFp2yaIUyY+5N/i","X-Received":"by 2002:a05:622a:1902:b0:50d:6fd3:421 with SMTP id\n d75a77b69052e-50d6fd307damr224051291cf.6.1775580972019;\n Tue, 07 Apr 2026 09:56:12 -0700 (PDT)","Date":"Wed, 8 Apr 2026 00:55:51 +0800","From":"Chao Liu <chao.liu.zevorn@gmail.com>","To":"alistair23@gmail.com","Cc":"palmer@dabbelt.com, liwei1518@gmail.com,\n daniel.barboza@oss.qualcomm.com, zhiwei_liu@linux.alibaba.com,\n qemu-riscv@nongnu.org,\n qemu-devel@nongnu.org, Alistair Francis <alistair.francis@wdc.com>","Subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","Message-ID":"<adUycpyM7bUjmC_7@ZEVORN-PC.localdomain>","References":"<20260407043614.372871-1-alistair.francis@wdc.com>\n <20260407043614.372871-3-alistair.francis@wdc.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260407043614.372871-3-alistair.francis@wdc.com>","Received-SPF":"pass client-ip=2607:f8b0:4864:20::844;\n envelope-from=chao.liu.zevorn@gmail.com; helo=mail-qt1-x844.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674932,"web_url":"http://patchwork.ozlabs.org/comment/3674932/","msgid":"<9846560e-9074-419d-9d06-9b949f6372ce@linaro.org>","list_archive_url":null,"date":"2026-04-08T08:37:49","subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/4/26 18:55, Chao Liu wrote:\n> On Tue, Apr 07, 2026 at 02:36:11PM +1000, alistair23@gmail.com wrote:\n>> From: Alistair Francis <alistair.francis@wdc.com>\n>>\n>> The stack pointer is being truncated as 32-bits for qemu-riscv64, so\n>> let's add a print_read_write helper that ensures all of the bits are\n>> printed.\n>>\n>> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3238\n>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>\n>> ---\n>>   linux-user/strace.c    | 14 ++++++++++++++\n>>   linux-user/strace.list |  4 ++--\n>>   2 files changed, 16 insertions(+), 2 deletions(-)\n\n\n>> +#if defined(TARGET_NR_read) || defined(TARGET_NR_write)\n>> +static void\n>> +print_read_write(CPUArchState *cpu_env, const struct syscallname *name,\n>> +        abi_long arg0, abi_long arg1, abi_long arg2,\n>> +        abi_long arg3, abi_long arg4, abi_long arg5)\n>> +{\n>> +    print_syscall_prologue(name);\n>> +    print_raw_param(\"%d\", arg0, 0);\n>> +    print_pointer(arg1, 0);\n>> +    print_raw_param(\"%d\", arg2, 1);\n> If TARGET_NR_read and TARGET_NR_write support 64-bit targets,\n> abi_long is int64_t, so %d will be truncated. We can use\n> TARGET_ABI_FMT_ld to replace it.\n\nWith the 2 \"%d\" replacements to TARGET_ABI_FMT_ld:\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n\n> \n> Otherwise LGTM.\n> \n> Reviewed-by: Chao Liu <chao.liu.zevorn@gmail.com>\n> \n> Thanks,\n> Chao\n>> +    print_syscall_epilogue(name);\n>> +}\n>> +#endif","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IwVLNYb8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXxQ4y15z1xv0\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:21:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYHN-0005my-BC; Wed, 08 Apr 2026 15:09:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wAYGA-0003n2-FB\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:08:19 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wAOQ5-0001ef-OA\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 04:37:55 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso7357935e9.0\n for <qemu-devel@nongnu.org>; Wed, 08 Apr 2026 01:37:53 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4e5890sm55800959f8f.31.2026.04.08.01.37.50\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 08 Apr 2026 01:37:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775637472; x=1776242272; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=rYvIoV64UzXrtoITOOTHknJ6ZResgG8x/xuVEBwW9Yw=;\n b=IwVLNYb8oveekigxcPRwBLBRWrpKVRGYwEyUbmaXa7Ohfu2I/d7t8DkDlLq92lVs3B\n EF3eVcc05XaQZB4eXI3KnunIjVmArVk4Js9vLPxzFEput5T5QVdY+IGIO1fO5OjGPi/i\n zELvZh+TLnh/5TTwRF4+au4pe8pK0MKqOuE2EOVWn2odlZfIhEHMzFnhXS1jp2ekiwTX\n xvzHgAqH5bOFHf4Hivwu0LkdvtDUgfGaT9rF0j1Nf4gBEa0XfXzgsIcMSP/R5SkZ1ZP/\n N2sQHJWIc54XzeEj9hacbrbR11DTeMpIIhNK6WZ09e44Ku9xkN0f2kPP+5rBIqDKa87x\n CMhA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775637472; x=1776242272;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=rYvIoV64UzXrtoITOOTHknJ6ZResgG8x/xuVEBwW9Yw=;\n b=Chzd3SQ0BdT4FIej+05f8UzfXW0yyrNJlhEr0999g4I5M6+BMwfOuzMNoJ5+AI4BZ7\n 8fKiGU3JPidT7MU/nwyNkRDM/aUNQCWAYCvvLAWngR4Ye45QV46uBjWhDpen3umSRakB\n 1xK4JGEIIYUrktlJQFX65iYevl3lfcu7dxleoeaA0oFvSCqEb19dVUqznA/wE69gSXPs\n XRY5wVfVqLl4xrlF8TI5NP6VatMLRCsgkn8kuCYZTNtFJ5QQnNeYIW3RG0FAlc8OH94w\n yI7hBl6q40WNwc47VfRAFNk8NELDvIoNO7OG57KjwjsA5FAVDoP0kn/h0AcwARGahE6j\n SLbw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU99eX3e7crxtGRVQc/nPWDEFwbHiHdk59exz4YuTIHiRZC9GHeM3NGjKitnodin7Ox6A/TKEZTtX+m@nongnu.org","X-Gm-Message-State":"AOJu0YziXQeGAJpdWXGbhMtDddJpzu3X6OaLo2ewq3kq+ifvbqNCPVQI\n e84wAoimykZk8nYIi8P6ZsoCB2P35ATtxXHdEF82BteiH27JHvHmQf1If7bRDQhfiqs=","X-Gm-Gg":"AeBDieuzJliLr1BWRdNAeULO0NRUSbE1s1HvkReXRUmVHOi39nKY//3G7lupnKNu/LT\n dV6P8Amnm+Ff9AVsdTh9Ei6Sr1LVSE82kXJdXIw0v9yxOR/VDT07r08Kkz/B17V7Ib14U5Pou7U\n s53GpDRDtI4hfyt+MGhlBIIk6nOJiP2tZh/C98Mpa6C2HjcWeJrOtv84XwV5EswOA7s1IuaNTcE\n rz3NSdLpJfOoU9sVvBZ4Wnb/rgn8s2bBKo0zeFMjbJGrvPgNTnwLVksUCvwCAKVxac33VqSuxhe\n NCOPs2BtjKanjEVnDxyIF33np/6UodW6wCSuU6nz4q4Jp+66EC0OYYtY6HKd6lsARQ54cViX4Ms\n wEGfeEKTm+o+SV9MBUGzKJWwCY+9kz2ha+vjakmn5aY6Jiz+c27z95Zr2QqdrWl1UdUQ3a4cK4A\n 6Gwiv/mLrnEu3P3ShVouxNl5Ka+UuhDKRQv5KgwpQqAvM5fXoxpZPXrg9xDklqTCRa0w==","X-Received":"by 2002:a05:600c:8288:b0:488:b47a:908b with SMTP id\n 5b1f17b1804b1-488b47a92e3mr142534175e9.11.1775637471887;\n Wed, 08 Apr 2026 01:37:51 -0700 (PDT)","Message-ID":"<9846560e-9074-419d-9d06-9b949f6372ce@linaro.org>","Date":"Wed, 8 Apr 2026 10:37:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","Content-Language":"en-US","To":"Chao Liu <chao.liu.zevorn@gmail.com>, alistair23@gmail.com","Cc":"palmer@dabbelt.com, liwei1518@gmail.com, daniel.barboza@oss.qualcomm.com,\n zhiwei_liu@linux.alibaba.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org,\n Alistair Francis <alistair.francis@wdc.com>","References":"<20260407043614.372871-1-alistair.francis@wdc.com>\n <20260407043614.372871-3-alistair.francis@wdc.com>\n <adUycpyM7bUjmC_7@ZEVORN-PC.localdomain>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<adUycpyM7bUjmC_7@ZEVORN-PC.localdomain>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3674971,"web_url":"http://patchwork.ozlabs.org/comment/3674971/","msgid":"<91744ff3-df7c-46e5-b2a1-cd7f49051723@linaro.org>","list_archive_url":null,"date":"2026-04-08T01:40:20","subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/7/26 14:36, alistair23@gmail.com wrote:\n> From: Alistair Francis <alistair.francis@wdc.com>\n> \n> The stack pointer is being truncated as 32-bits for qemu-riscv64, so\n> let's add a print_read_write helper that ensures all of the bits are\n> printed.\n> \n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3238\n> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>\n> ---\n>   linux-user/strace.c    | 14 ++++++++++++++\n>   linux-user/strace.list |  4 ++--\n>   2 files changed, 16 insertions(+), 2 deletions(-)\n\nThis is indicative of incorrect fowarding of values to system fprintf.\nWe really should be handling the format ourselves so abi_long etc are handled properly.\n\nIn particular,\n\n> +print_read_write(CPUArchState *cpu_env, const struct syscallname *name,\n> +        abi_long arg0, abi_long arg1, abi_long arg2,\n> +        abi_long arg3, abi_long arg4, abi_long arg5)\n> +{\n> +    print_syscall_prologue(name);\n> +    print_raw_param(\"%d\", arg0, 0);\n> +    print_pointer(arg1, 0);\n> +    print_raw_param(\"%d\", arg2, 1);\n> +    print_syscall_epilogue(name);\n> +}\n> +#endif\n\nThis is more work than we should require for such simple syscalls.\n\n>   #ifdef TARGET_NR_read\n> -{ TARGET_NR_read, \"read\" , \"%s(%d,%#x,%d)\", NULL, NULL },\n> +{ TARGET_NR_read, \"read\" , NULL, print_read_write, NULL },\n\nIdeally, I think %p is the correct format to use for a syscall pointer argument. \nInterpreted, of course, in the context of abi_ptr.\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HfEKLx8u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYkJ2LxHz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:57:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYVx-0005W9-9t; Wed, 08 Apr 2026 15:24:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wAY6F-00071A-9q\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:58:05 -0400","from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wAHu8-0007fp-Bf\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 21:40:30 -0400","by mail-pj1-x102e.google.com with SMTP id\n 98e67ed59e1d1-35d9827661bso2861473a91.3\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 18:40:27 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dd35e3621sm18986783a91.4.2026.04.07.18.40.24\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 18:40:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775612426; x=1776217226; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LSiexCJ9o4smBQFEEGiaDlD9TcxAYTKBOunRKVeNnFw=;\n b=HfEKLx8u014/Ud12CF563CjKFy4xgZ6rXV8tshPfOiSE04uSP+Mjwmu1/mVFvBD7a3\n p1swi5xpnUNZZ0xbSk+iHI/tpYLfvGlZK8J0R/YxzDoPrC46HViHmH9cC8i9bdLbqk3c\n YKcKlsWYWLlFjYn4TmW2oR8aNHbp4GqLO8cyTQWINVSZyTfV5iqKCAt8JnpGyQVZKmOW\n xTAu01rD7kO5NQS4Upm17ZPGjtaI1bKWYZUQRxnFVVBsTL9MIKd58C3rVW3B0OO0BbNO\n tm6dzvkaMEYqOl2kjD8i05aqTIDCR7YXU3Axjlo+fj8SLE4oeM5dcDlGSbjYESn/h409\n Sgug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775612426; x=1776217226;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=LSiexCJ9o4smBQFEEGiaDlD9TcxAYTKBOunRKVeNnFw=;\n b=LnIvqxaJFlv89BQZR/Zap1+SJYCsCv9+vco002jhySWc3OUB3fIN7l8Iwe507R1M8d\n 0Z0B/jMVvDzA+Y+TEevPV19we+v9dHacX+R9CfcbfEZb7Oy+32gJ35mGJ4RVIbpgHfZs\n icQLoe0+K/o16ydEMBymN8/fuC2ZJBX5yibHZkHNbFAPZO+SEaxyInOg4/aWzaJVQWb1\n NC1RmR/4RtfOngN02A2qVsXr0MEn2wy0LdMRtcNwIDA2O69NM6mcRLKlnCJEwLXUrKro\n yJj7UaIa20/kSVQ6KXPugQacX8TgjEU5oC0AaYRfuNjOfhZnoAXNKtUyc3dUYQOKUHNO\n otoA==","X-Gm-Message-State":"AOJu0YxKbp/PHtrJwnOZj3B53KGbGD59Xuvsp3/aYVzDlT2UeWLNlHtA\n 0/nt+lXX8JJ4vMQJIvPzq8/OMcx3bAb4rt/Ix1E6pZUeNW4QGqffArdp0vcKzde6NzgXT8aF/Pu\n Am6l09ug=","X-Gm-Gg":"AeBDietUtDvFMoUBBQg66sjl19FInBXE4rI6ayUw4FtP+ak8CoQIUYKRK+c89XAA2in\n BWQ++4B1hEvEgediUzADKSvF+rVphi3PZmXhkfYU6sNcaBkmLHQ9OSFqPvQRDLkquJdbB4RJ2iB\n XL3zHRCqNl+0fM6SrnCdO3EhgN+eWjeIg5lA/ipgE5r5BqcmXfkz2VnwhSWrsJVxuDJTlI5h5yL\n TzNWKf4r1PFGyk80pz1vhOc90K90mhRf65d6663751rAide2KRnbjnfbw4AS6LswYFviXjYM0E1\n QMVuv/6nHl5ypX/reWDHUL9F8hffQcjUiXlq5LMfMQO3UqR3ltDy3Th+W/5uCVwptt42nTybyte\n 92W1QA0bdSOdF/JrA1XSSeI+hryGOi6/MTsB6Yaf9weNcPD+P1kQmORywfhLVQG2UWT93v5iAbE\n vq0QRoKQ7XYBbFvdOrTcJhC0yQyQXJYRPAAuc43Ijd6Lr+ZCItBbxDxahgopZXW6G3SYFKtWtq9\n 5OaJg==","X-Received":"by 2002:a17:90b:5585:b0:355:35b0:8b78 with SMTP id\n 98e67ed59e1d1-35de69a6545mr18004619a91.27.1775612425687;\n Tue, 07 Apr 2026 18:40:25 -0700 (PDT)","Message-ID":"<91744ff3-df7c-46e5-b2a1-cd7f49051723@linaro.org>","Date":"Wed, 8 Apr 2026 11:40:20 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] linux-user/strace: Add a wrapper for read and write","To":"qemu-devel@nongnu.org","References":"<20260407043614.372871-1-alistair.francis@wdc.com>\n <20260407043614.372871-3-alistair.francis@wdc.com>","From":"Richard Henderson <richard.henderson@linaro.org>","Content-Language":"en-US","In-Reply-To":"<20260407043614.372871-3-alistair.francis@wdc.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]