[{"id":3674944,"web_url":"http://patchwork.ozlabs.org/comment/3674944/","msgid":"","list_archive_url":null,"date":"2026-04-08T12:00:21","subject":"Re: [RFC v4 3/5] io/channel-socket: tolerate AF_PACKET getpeername","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Apr 07, 2026 at 01:05:50PM +0800, Cindy Lu wrote:\n> When -chardev socket,fd=... is handed an AF_PACKET socket,\n> getpeername() can fail with EOPNOTSUPP instead of ENOTCONN because\n> packet sockets are not connection-oriented. qio_channel_socket_set_fd()\n> currently treats that as fatal and refuses to wrap the fd, even though\n> getsockname() and the local address are still valid.\n> \n> Treat EOPNOTSUPP the same way as ENOTCONN and leave remoteAddr empty.\n> That keeps existing stream-socket behavior unchanged while allowing\n> AF_PACKET fds to be adopted by QIOChannelSocket.\n> \n> Signed-off-by: Cindy Lu \n> ---\n> io/channel-socket.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/io/channel-socket.c b/io/channel-socket.c\n> index 3053b35ad8..2ed26aefa3 100644\n> --- a/io/channel-socket.c\n> +++ b/io/channel-socket.c\n> @@ -115,7 +115,11 @@ qio_channel_socket_set_fd(QIOChannelSocket *sioc,\n> \n> if (getpeername(fd, (struct sockaddr *)&sioc->remoteAddr,\n> &sioc->remoteAddrLen) < 0) {\n> - if (errno == ENOTCONN) {\n> + if (errno == ENOTCONN\n> +#ifdef EOPNOTSUPP\n> + || errno == EOPNOTSUPP\n> +#endif\n\nWhy conditionalize it ? We use this unconditionally throughout\nQEMU code AFAICS, even on Windows.\n\n> + ) {\n> memset(&sioc->remoteAddr, 0, sizeof(sioc->remoteAddr));\n> sioc->remoteAddrLen = sizeof(sioc->remoteAddr);\n> } else {\n> -- \n> 2.52.0\n> \n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=efmWXeBg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frY7g35n7z1yD6\n\tfor ; Thu, 09 Apr 2026 05:30:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYVl-0004Sb-88; Wed, 08 Apr 2026 15:24:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAY52-0006g7-04\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:56:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wARaA-0008D7-36\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 08:00:31 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-mEDxfqJlP_azAihopj8kOQ-1; Wed,\n 08 Apr 2026 08:00:27 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4784C180056E; Wed, 8 Apr 2026 12:00:26 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 573B019560A6; Wed, 8 Apr 2026 12:00:24 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775649629;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=QzRZy/UiZMCPm6IVlmWgawDD3tp2+VYGrqFAiLFQBHo=;\n b=efmWXeBgk7A4h0/RGQFssd+1j45xF08q1OqKgs+viaf990sKdPfkEzSpeKzxGjig8bODsf\n quw229kRkC/yVM85+kYDUhn8pIm2kjOBiuTbiuiphJeve4kRq4r6y+GiceXuIZuijA6mCR\n tehOTk43gebiU5x7B7WrOPJv+ybkRA4=","X-MC-Unique":"mEDxfqJlP_azAihopj8kOQ-1","X-Mimecast-MFC-AGG-ID":"mEDxfqJlP_azAihopj8kOQ_1775649626","Date":"Wed, 8 Apr 2026 13:00:21 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Cindy Lu ","Cc":"mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, jmarcin@redhat.com, qemu-devel@nongnu.org","Subject":"Re: [RFC v4 3/5] io/channel-socket: tolerate AF_PACKET getpeername","Message-ID":"","References":"<20260407050818.2249570-1-lulu@redhat.com>\n <20260407050818.2249570-4-lulu@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260407050818.2249570-4-lulu@redhat.com>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]