[{"id":3675150,"web_url":"http://patchwork.ozlabs.org/comment/3675150/","msgid":"","list_archive_url":null,"date":"2026-04-09T08:08:37","subject":"Re: [RFC PATCH 5/5] gpio: mmio: add port-mapped read/write callbacks","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"Hi Jose,\n\nthanks for your patch!\n\nOn Tue, Apr 7, 2026 at 8:49 PM Jose Javier Rodriguez Barbarin\n wrote:\n\n> Implement PMIO read and write callbacks for 8-, 16- and 32-bit\n> register accesses using the corresponding port I/O helpers.\n>\n> Signed-off-by: Jose Javier Rodriguez Barbarin \n\nOverall this looks fine to me, but with the change that it is moved\nover to using the union.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=FQS3kITE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34922-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"FQS3kITE\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frsyZ5wWrz1yCv\n\tfor ; Thu, 09 Apr 2026 18:08:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 5BB0030087F1\n\tfor ; Thu, 9 Apr 2026 08:08:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 30B6238F941;\n\tThu, 9 Apr 2026 08:08:49 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E77EE38F632\n\tfor ; Thu, 9 Apr 2026 08:08:48 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 95B58C2BC9E\n\tfor ; Thu, 9 Apr 2026 08:08:48 +0000 (UTC)","by mail-yw1-f177.google.com with SMTP id\n 00721157ae682-79c20063a32so6515297b3.1\n for ;\n Thu, 09 Apr 2026 01:08:48 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775722129; cv=none;\n b=p2OyveurLBqZQPYedGOT7XQmttAV/bHAI5dqmx21zsOQ9Bgu4iubbrOKXhFNyQgR8CUdVJ+EHMSjwrpQskJoLz7higMfxohVo8ToJGpvbguHhbDv30S0IzD3g0qp4kQdxHDAt7WUCWWzoakfkfFIAFlAVwajZihdJWc8HIZEjAk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775722129; c=relaxed/simple;\n\tbh=E6cVnBM4Wihu3vyKUFn8rmJXguE0y6A9+FlmYJgfIKI=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=qtYmbu7sk0zWP38tAuE7vLEN48YHO2+enW9EIeLuQAA3vckzvTvnBAHCWrmkPvdhIPdNoNma0Br30n6xP8MDwNQ17bvMmZxQP+ePij/2HKQ1XLIDFIKxkQjDym1NFBtrIAvIhnHGqakAbkuCfz21bdBD05xa1XPad4ueaj86L4M=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=FQS3kITE; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775722128;\n\tbh=E6cVnBM4Wihu3vyKUFn8rmJXguE0y6A9+FlmYJgfIKI=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=FQS3kITEkgcrUdmaeO2L6S9zDWyAf/c9Fjf6Hy5L6rYpcZCD86htMW4YKe8DdHQMa\n\t 2f2PpzJufpVcwbnhaeiAKhJKt6yGuHjvM8LaPrp1BY46dCZqlVxifAvbpQ/N/mx6Ja\n\t orH1V14vxP0dJ3dBgjRkKi5Ak1t+SIcVuBcKGOJC8Lb+5HU2ApttKFlsgcULe08D8z\n\t 8HTEdf8UswtbWLDYVWcl8m/XvSAMV1L4c68C56Ye8tS4UASIQ96kuiB4NoL1ChUG0F\n\t LviLx66Ivzs1s62wfUVQS+CEtaaf3jiyojKyd9lvG0fOBFXSHzX6xRDr0oS9BLvPjA\n\t zIDfH+BY8cWBQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUSiel6PHJEaZoTJkKiu8/ZTaxyLCGyHJMBF/FkFK9dv0wPv4LMYnkohUpX4g/PjCCVuL3a5p4+oEp/@vger.kernel.org","X-Gm-Message-State":"AOJu0YxEhs2xSirW/guLo2HeUDihtg9Z/US5KbHXf8BhCbQ8e7hUEfcW\n\t5K0dv6qLK2H7LKQNqjLZCVjP5M/z+Rt54K27L2BSjgh1HoJq2jC9o9GE21pVDhwwlLCI+WBNTjf\n\tWIM47Ae2wlurkPrpPDjsC/RKApll2od8=","X-Received":"by 2002:a05:690c:e3e4:b0:796:335a:895 with SMTP id\n 00721157ae682-7adec6e60c0mr25137627b3.6.1775722128030; Thu, 09 Apr 2026\n 01:08:48 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260407184805.807328-1-dev-josejavier.rodriguez@duagon.com>\n <20260407184805.807328-6-dev-josejavier.rodriguez@duagon.com>","In-Reply-To":"<20260407184805.807328-6-dev-josejavier.rodriguez@duagon.com>","From":"Linus Walleij ","Date":"Thu, 9 Apr 2026 10:08:37 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzB9Ba7WRFIdllo03EWBOZPdQQniIwixxePWLmVAE4AzRNEqmOWL19CY2I8","Message-ID":"\n ","Subject":"Re: [RFC PATCH 5/5] gpio: mmio: add port-mapped read/write callbacks","To":"Jose Javier Rodriguez Barbarin ","Cc":"brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]