[{"id":3675143,"web_url":"http://patchwork.ozlabs.org/comment/3675143/","msgid":"","list_archive_url":null,"date":"2026-04-09T07:59:49","subject":"Re: [RFC PATCH 2/5] gpio: generic: extend gpio_generic_chip_config\n with PMIO register fields","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"Hi Jose,\n\nthanks for your patch!\n\nOn Tue, Apr 7, 2026 at 8:49 PM Jose Javier Rodriguez Barbarin\n wrote:\n\n> Instead of replacing the register type with gpio_chip_reg, it is better\n> to extend the structure by adding dedicated fields for I/O port\n> registers.\n>\n> This ensures compatibility with memory-mapped devices.\n>\n> Signed-off-by: Jose Javier Rodriguez Barbarin \n(...)\n> @@ -54,6 +59,11 @@ struct gpio_generic_chip_config {\n> void __iomem *clr;\n> void __iomem *dirout;\n> void __iomem *dirin;\n> + unsigned long dat_port;\n> + unsigned long set_port;\n> + unsigned long clr_port;\n> + unsigned long dirout_port;\n> + unsigned long dirin_port;\n\nIsn't it easier to just create a new config type?\n\nstruct gpio_generic_port_chip_config { ... }?\n\nIt's only three more entries apart from this that will be duplicate.\n\nThis is only used during config anyway so it should be fine I think.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PoMRe5Jy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34919-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"PoMRe5Jy\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frssF4fcXz1xtJ\n\tfor ; Thu, 09 Apr 2026 18:04:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 867003085D80\n\tfor ; Thu, 9 Apr 2026 08:00:03 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E3A013876DB;\n\tThu, 9 Apr 2026 08:00:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A4ABD3876A9\n\tfor ; Thu, 9 Apr 2026 08:00:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 82FD1C2BCAF\n\tfor ; Thu, 9 Apr 2026 08:00:01 +0000 (UTC)","by mail-yx1-f50.google.com with SMTP id\n 956f58d0204a3-65075c2ba66so653755d50.1\n for ;\n Thu, 09 Apr 2026 01:00:01 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775721601; cv=none;\n b=QfhrnoXSVUNnDdTQAtxQflPKOspOxBYgXfePKl6ZEF2MRP3j3kjZcVLzuFPAu0t+aGTBWmG5mGeCTROVqguMauuL+AWJI3+MCH4jh8+70lBrIleW727+GzSS7V54OPZIIIg5WzWV8CSz97lK5rgHT0phzc9VSqDN/89AFXvK05s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775721601; c=relaxed/simple;\n\tbh=josDUjqMelZ/2LBMGfvaFfN3TmKDlC13I5MLpF4fjmA=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=dVi6//MI+o/wxbb91tsgardX7WvFKr360G9DZHBNMfEVVlMWWOu4oAg8ZtkRxq/XXFOdeB9lSum+pbQ3WcHaMuBhSFRZdxw29EQwcbaFA+YPXpaxXfwidwBmCCQgoNy7wiMVAV13DckNRo4otTu+0EWZ9Gt0tLpMVpdGeNHnBiE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=PoMRe5Jy; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775721601;\n\tbh=josDUjqMelZ/2LBMGfvaFfN3TmKDlC13I5MLpF4fjmA=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=PoMRe5JyveST97xbiN4xnCUxD3Dw49aIfON6x9Bnuj6iWCKVP1w0Dkt+sAPcwS2g+\n\t 3NvdM8JXxJ72/o1CBWdBiJG7F/zfOd0TP1V+4b4ZC9ZMDC9I+X5ufkZFt6nrwEiY5O\n\t cUSPmVShUPaqvZEZFVxEWVS/tiudqs5hQJrkk7CDxiUNIvI7pnK6O0oc4WhVQqHyp9\n\t GYY7kSMjJliyo+W166uJ3GFhIxpyEmkgqwu3GmdqeyZCPVOzMVFKF3qQ5bI+iKQ5fV\n\t BU/SZZ4baysZpo8SN//YgJJy4MbTtVc8vwpd8WE/dxcx2O7dI/mQIyeX84lZcJw/an\n\t TDVfgh7lvlnQQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU7mXv3tdkh3bbFt4Ii0lqisLjKbvGudvrqk2ayByZ/AgWUzjnv7pmeODOauzOqZxbWwpR27MnA84zD@vger.kernel.org","X-Gm-Message-State":"AOJu0YzkpAGavnSHUxXeitvM9qAuPEPF5bqNIu9MxkfETjsRpQub2Eq2\n\totFpamVsm9lvLDaT3DKRPYg7SecuGkdMZZE+cffs5MjY/e2zyoOA+vvtLClCmwDdqKhquC3Xgrg\n\tLIVIbwzkgT9w9SybAPBTdupO6zHwZkw4=","X-Received":"by 2002:a05:690e:429a:20b0:650:21bd:e0e7 with SMTP id\n 956f58d0204a3-6518773ab08mr1807512d50.44.1775721600278; Thu, 09 Apr 2026\n 01:00:00 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260407184805.807328-1-dev-josejavier.rodriguez@duagon.com>\n <20260407184805.807328-3-dev-josejavier.rodriguez@duagon.com>","In-Reply-To":"<20260407184805.807328-3-dev-josejavier.rodriguez@duagon.com>","From":"Linus Walleij ","Date":"Thu, 9 Apr 2026 09:59:49 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzAYrd0AsQ4w1IJSpteGXAdsiD8DmyUvywI8ZlGoJHL86v-ez21sj-ulA2M","Message-ID":"\n ","Subject":"Re: [RFC PATCH 2/5] gpio: generic: extend gpio_generic_chip_config\n with PMIO register fields","To":"Jose Javier Rodriguez Barbarin ","Cc":"brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]