[{"id":3675296,"web_url":"http://patchwork.ozlabs.org/comment/3675296/","msgid":"<89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","list_archive_url":null,"date":"2026-04-09T12:47:57","subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/people/85252/","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"content":"On 4/7/26 18:52, Jose Ignacio Tornos Martinez wrote:\n> After commit ad7c7b2172c3 (\"net: hold netdev instance lock during sysfs\n> operations\"), iavf_set_mac() is called with the netdev instance lock\n> already held.\n> \n> The function queues a MAC address change request via\n> iavf_replace_primary_mac() and then waits for completion. However, in\n> the current flow, the actual virtchnl message is sent by the watchdog\n> task, which also needs to acquire the netdev lock to run. Additionally,\n> the adminq_task which processes virtchnl responses also needs the netdev\n> lock.\n> \n> This creates a deadlock scenario:\n> 1. iavf_set_mac() holds netdev lock and waits for MAC change\n> 2. Watchdog needs netdev lock to send the request -> blocked\n> 3. Even if request is sent, adminq_task needs netdev lock to process\n> PF response -> blocked\n> 4. MAC change times out after 2.5 seconds\n> 5. iavf_set_mac() returns -EAGAIN\n> \n> This particularly affects VFs during bonding setup when multiple VFs are\n> enslaved in quick succession.\n> \n> Fix by implementing a synchronous MAC change operation similar to the\n> approach used in commit fdadbf6e84c4 (\"iavf: fix incorrect reset handling\n> in callbacks\").\n> \n> The solution:\n> 1. Send the virtchnl ADD_ETH_ADDR message directly (not via watchdog)\n> 2. Poll the admin queue hardware directly for responses\n> 3. Process all received messages (including non-MAC messages)\n> 4. Return when MAC change completes or times out\n> \n> A new generic function iavf_poll_virtchnl_response() is introduced that\n> can be reused for any future synchronous virtchnl operations. It takes a\n> callback to check completion, allowing flexible condition checking.\n> \n> This allows the operation to complete synchronously while holding\n> netdev_lock, without relying on watchdog or adminq_task. The function\n> can sleep for up to 2.5 seconds polling hardware, but this is acceptable\n> since netdev_lock is per-device and only serializes operations on the\n> same interface.\n> \n> To support this, change iavf_add_ether_addrs() to return an error code\n> instead of void, allowing callers to detect failures.\n> \n> Fixes: ad7c7b2172c3 (\"net: hold netdev instance lock during sysfs operations\")\n> cc: stable@vger.kernel.org\n> Signed-off-by: Jose Ignacio Tornos Martinez \n> ---\n> v2: Complete rewrite using synchronous polling approach instead of dropping\n> the netdev lock. New approach:\n> - Polls admin queue hardware directly (similar to iavf_reset_step)\n> - Processes all virtchnl messages inline while holding netdev_lock\n> - Introduced generic iavf_poll_virtchnl_response() for code reuse\n> - No lock dropping, following accepted pattern from ndo_change_mtu fix\n> v1: https://lore.kernel.org/netdev/20260406112057.906685-4-jtornosm@redhat.com/\n> \n> drivers/net/ethernet/intel/iavf/iavf.h | 2 +-\n> drivers/net/ethernet/intel/iavf/iavf_main.c | 118 +++++++++++++++---\n> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 11 +-\n> 3 files changed, 110 insertions(+), 21 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h\n> index e9fb0a0919e3..5bc23519fe9c 100644\n> --- a/drivers/net/ethernet/intel/iavf/iavf.h\n> +++ b/drivers/net/ethernet/intel/iavf/iavf.h\n> @@ -589,7 +589,7 @@ void iavf_configure_queues(struct iavf_adapter *adapter);\n> void iavf_enable_queues(struct iavf_adapter *adapter);\n> void iavf_disable_queues(struct iavf_adapter *adapter);\n> void iavf_map_queues(struct iavf_adapter *adapter);\n> -void iavf_add_ether_addrs(struct iavf_adapter *adapter);\n> +int iavf_add_ether_addrs(struct iavf_adapter *adapter);\n> void iavf_del_ether_addrs(struct iavf_adapter *adapter);\n> void iavf_add_vlans(struct iavf_adapter *adapter);\n> void iavf_del_vlans(struct iavf_adapter *adapter);\n> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\n> index 67aa14350b1b..2ef30b1ef35c 100644\n> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n> @@ -1047,6 +1047,105 @@ static bool iavf_is_mac_set_handled(struct net_device *netdev,\n> \treturn ret;\n> }\n> \n> +/**\n> + * iavf_poll_virtchnl_response - Poll admin queue for virtchnl response\n> + * @adapter: board private structure\n> + * @condition: callback to check if desired response received\n> + * @cond_data: context data passed to condition callback\n> + * @timeout_ms: maximum time to wait in milliseconds\n> + *\n> + * Polls admin queue and processes all messages until condition returns true\n> + * or timeout expires. Caller must hold netdev_lock. This can sleep for up to\n> + * timeout_ms while polling hardware.\n> + *\n> + * Returns 0 on success (condition met), -EAGAIN on timeout or error\n> + */\n> +static int iavf_poll_virtchnl_response(struct iavf_adapter *adapter,\n> +\t\t\t\t bool (*condition)(struct iavf_adapter *, void *),\n> +\t\t\t\t void *cond_data,\n\nthis could be const, then no cast on the callsite\n\n> +\t\t\t\t unsigned int timeout_ms)\n> +{\n> +\tstruct iavf_hw *hw = &adapter->hw;\n> +\tstruct iavf_arq_event_info event;\n> +\tenum virtchnl_ops v_op;\n> +\tenum iavf_status v_ret;\n> +\tunsigned long timeout;\n> +\tint ret;\n> +\n> +\tnetdev_assert_locked(adapter->netdev);\n> +\n> +\tevent.buf_len = IAVF_MAX_AQ_BUF_SIZE;\n> +\tevent.msg_buf = kzalloc(event.buf_len, GFP_KERNEL);\n> +\tif (!event.msg_buf)\n> +\t\treturn -ENOMEM;\n> +\n> +\ttimeout = jiffies + msecs_to_jiffies(timeout_ms);\n> +\twhile (time_before(jiffies, timeout)) {\n> +\t\tif (condition(adapter, cond_data)) {\n\nif condition is met, but timed out, there should be no error\n\n> +\t\t\tret = 0;\n> +\t\t\tgoto out;\n> +\t\t}\n> +\n> +\t\tret = iavf_clean_arq_element(hw, &event, NULL);\n> +\t\tif (!ret) {\n> +\t\t\tv_op = (enum virtchnl_ops)le32_to_cpu(event.desc.cookie_high);\n> +\t\t\tv_ret = (enum iavf_status)le32_to_cpu(event.desc.cookie_low);\n> +\n> +\t\t\tiavf_virtchnl_completion(adapter, v_op, v_ret,\n> +\t\t\t\t\t\t event.msg_buf, event.msg_len);\n> +\n> +\t\t\tmemset(event.msg_buf, 0, IAVF_MAX_AQ_BUF_SIZE);\n> +\t\t}\n> +\n> +\t\tusleep_range(1000, 2000);\n\nno sleep after message received (ok to do on empty queue)\n\n> +\t}\n> +\n> +\tret = -EAGAIN;\n> +out:\n> +\tkfree(event.msg_buf);\n> +\treturn ret;\n> +}\n> +\n> +/**\n> + * iavf_mac_change_done - Check if MAC change completed\n> + * @adapter: board private structure\n> + * @data: MAC address being checked (as void *)\n> + *\n> + * Callback for iavf_poll_virtchnl_response() to check if MAC change completed.\n> + *\n> + * Returns true if MAC change completed, false otherwise\n> + */\n> +static bool iavf_mac_change_done(struct iavf_adapter *adapter, void *data)\n> +{\n> +\tconst u8 *addr = data;\n> +\n> +\treturn iavf_is_mac_set_handled(adapter->netdev, addr);\n> +}\n> +\n> +/**\n> + * iavf_set_mac_sync - Synchronously change MAC address\n> + * @adapter: board private structure\n> + * @addr: MAC address to set\n> + *\n> + * Sends MAC change request to PF and polls admin queue for response.\n> + * Caller must hold netdev_lock. This can sleep for up to 2.5 seconds.\n> + *\n> + * Returns 0 on success or error\n> + */\n> +static int iavf_set_mac_sync(struct iavf_adapter *adapter, const u8 *addr)\n> +{\n> +\tint ret;\n> +\n> +\tnetdev_assert_locked(adapter->netdev);\n> +\n> +\tret = iavf_add_ether_addrs(adapter);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> +\treturn iavf_poll_virtchnl_response(adapter, iavf_mac_change_done,\n> +\t\t\t\t\t (void *)addr, 2500);\n\nthis function looks elegant, thank you\n\nI'm a little affraid that this model (if applied to other things than\nsetting MAC) will skip some of our \"much needed\" logic in the watchdog.\n\nI have not thinked about much yet.\n\nunrelated: callback looks elegant, but for virtchnl, it is almost always\nthe case that we wait for some VC OPCODE to come back, and this is just\na number. It could be easily coded as a callback too, passing wanted\nvalue masked in pointer, but I would say that just passing a normal u32\nparam will be most clean","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=hFrXKaCv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0386K5Rz1yD3\n\tfor ; Thu, 09 Apr 2026 22:43:16 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C6C7D4106A;\n\tThu, 9 Apr 2026 12:43:14 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vU7d5xwvo72n; Thu, 9 Apr 2026 12:43:13 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id CCC8840B89;\n\tThu, 9 Apr 2026 12:43:13 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 6F63C1F6\n for ; Thu, 9 Apr 2026 12:43:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 4C1586087E\n for ; Thu, 9 Apr 2026 12:43:12 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WPJQ5RUTpq97 for ;\n Thu, 9 Apr 2026 12:43:11 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 2EE686077D\n for ; Thu, 9 Apr 2026 12:43:10 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 05:43:10 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 05:43:10 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 9 Apr 2026 05:43:09 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 9 Apr 2026 05:43:09 -0700","from BL0PR03CU003.outbound.protection.outlook.com (52.101.53.6) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 9 Apr 2026 05:43:08 -0700","from CH0PR11MB8086.namprd11.prod.outlook.com (2603:10b6:610:190::8)\n by PH3PPF310D5CFFC.namprd11.prod.outlook.com (2603:10b6:518:1::d14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.15; Thu, 9 Apr\n 2026 12:43:04 +0000","from CH0PR11MB8086.namprd11.prod.outlook.com\n ([fe80::2769:b184:69c6:6eb0]) by CH0PR11MB8086.namprd11.prod.outlook.com\n ([fe80::2769:b184:69c6:6eb0%6]) with mapi id 15.20.9769.018; Thu, 9 Apr 2026\n 12:42:58 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org CCC8840B89","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2EE686077D"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775738593;\n\tbh=lL+Wx4pBq0LjAtsJxOGBqKis4fgHe12vFEml8hNZp8E=;\n\th=Date:To:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=hFrXKaCv5ptuyeRpJIPl6Ds3ty4y12yC9+ITLBBRN6f5b8N0NAnWacI9rVE5fDH/y\n\t HsJuIDM6FCJ502Fe20K5ZxRhp9KuWIuS9u5L/yZGnZJAu8cdq/rT/MqkVrntHaVrMG\n\t sbvs61a5+scvxr3Fq2dJUZaJvDqsuJKmND8GbhUe8xaOMe1U70zUex0pxTcW8D2Y5b\n\t JdIGAJb/DqFi6nyb2evmTdPuMjFjPpfNHaUz4qtAeAO6gKayCMh7lHLqRf30rfda7z\n\t W6/qfe5L1kHs21+4JRPTArtbDqQtwANmlrIERoOIiZvlv6fx3ckWBXijNMgmAhB+Z5\n\t nEuxjhJ3Vy93w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 2EE686077D","X-CSE-ConnectionGUID":["zbjKbwBLR9WLzmR/MTsMpA==","zCrGoGGxQXat/tuqPZxCqw=="],"X-CSE-MsgGUID":["ymkB6KotTuCgBKwiOjkqDg==","d0GkJdP+TUSfAEpvV10uhg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11753\"; a=\"87815762\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"87815762\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"226003967\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=XZF/IDWiPRQZ+PotR502Zoo4tiMtMl+7qOrUi5f7XzihU9G/0pkDLFkgulkAwy72b+TqoT7lxo6ggZTi2HMM4harJdejTvPq1f6dIkQs2TNgTdAlwnJXAmQWA9lezY4dTIRBQEdU2AsuyX67gwSSoMJfzM1npF0YRA0yJ5CKxmdlP7630n8ZyJUpnFaeDI20dinNTgtkZYnjXyhK0PRNERo5qD37tgtESFQpikOa4WmlY6/3JP7n3YI3ZX57Te/gwlvGq+VEUwVqin6h8inHJlTcU9eYmjrJrqby0BwKktFpIlF7rYq1uecERF2iQ7DwQyLsWo9t/7x55DBjJGHEOg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=lL+Wx4pBq0LjAtsJxOGBqKis4fgHe12vFEml8hNZp8E=;\n b=H4wEp/U78t6JFmj0vV9L8mEoK7fr4ZTB8p8bkzX4Bf/g14aHvHs2AuCzTtHSAmE/gMVFeq/9ERKy8wEwQujvpS+zaDKJ1N40GEjUFTBNOdzkZqG6ezt52FCmV3ubuXLr2Of+rLpkS0uwiaw+P8KvrxYevzCJdTG51FndqHHf2VxmjGp1UiEUHYl3YOA4Qcv1VaJEpMt+yonvPUrxnisOq8srM74W+qFEN++n69nV4Qc8KtmvqiIN1lq49rI9vJ+zK3me5tsY2ad6VQTZPZY7eNQFgyYC10YjArR6U4V4mBJqznTLjB86u4NuqLdnHiU9C2HKqTuUiIKc/XusNHFDRA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","Date":"Thu, 9 Apr 2026 14:47:57 +0200","User-Agent":"Mozilla Thunderbird","To":"Jose Ignacio Tornos Martinez ","References":"<20260407165206.1121317-1-jtornosm@redhat.com>\n <20260407165206.1121317-4-jtornosm@redhat.com>","From":"Przemek Kitszel ","Content-Language":"en-US","In-Reply-To":"<20260407165206.1121317-4-jtornosm@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"VI1PR09CA0129.eurprd09.prod.outlook.com\n (2603:10a6:803:12c::13) To CH0PR11MB8086.namprd11.prod.outlook.com\n (2603:10b6:610:190::8)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH0PR11MB8086:EE_|PH3PPF310D5CFFC:EE_","X-MS-Office365-Filtering-Correlation-Id":"87a2c18e-f082-4748-9cb4-08de96358737","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|7416014|366016|1800799024|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n hU4INtTdaJSM4Vpt0Pb2zhTu+pkYApG/1h1NFcaatHKH72DpJl8UEo6XyWWumnc4guwZIFZx6IY/0WClXYlnn5PJAPj7Ntgrabe0rxUpcGQhvITZ1/0NTdIZdyWOiCAmJaGUDcLPdsFauqaHmkQaya4wO1F099nQTHYBYlSUvalVh8V/ra30Hkl6cEP/MVYnzvUriazIVGM2Nx85pCMutwWotRt3kCOSPmCeX08y17d5XddIlSwhTBQ28GysN1EZpSJSb46RGEgKIKEnJ82ltQ3yGxLVDSOGxgiVKbgVuc1+dSkLwem0s+0pQpl/7Kv/3lCvyhFKXVk49suPoMiJ4MIIzhERlXCCHteVRjPl+kDumN0qxnFJIZMVxKO1WySkiwEsDUu+t8OlP/iips5iDIyC5TYWQHtgU3xdwhxNmaiqdILlhNeV9Kr15sJ9rwBWV5YlX0c7waxQZ1rhdtXkQI3+ROQud5cgx1AbpWGjr96Z+qEDh1QJ3Vu8tt/OvXDkyj2k9W32FcLCW7+Io+mE8jUP45TB05kHVktw43ST3JDzuOZRCZM89/A8uyZx+bhvvNoQ7aFD0l8t2hWOUMtmwud2Q7oI2F5ZV4JYJ/NFJZeotfuoDDc/6SFnDV6dtOTdzTEwN2NKsESrl89oh2f1iLNZSdqfE8ka8jMdC6o0Bl6512XBUN9Sr0o9PZc07+GVBwjvA4eNpN1ju9jDKjc89RDUTCx5h1P3daPnINvAtjk=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:CH0PR11MB8086.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(366016)(1800799024)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?epkiJ7TgiW9xt1I/fBA4lviez/Wn?=\n\t=?utf-8?q?OKl4/HE8RfkkME/M78RUDLx6fHkZj5mlxgt+3KmM7QAYPMQH2LAjZRFT1tp7OB1dR?=\n\t=?utf-8?q?peAf8MkzAs3kE+zG9DC09uxNHdpxQodPA//JDOr4Db7i5vek7k0XCfCg/8pPBYt0H?=\n\t=?utf-8?q?DX1faOrDAlwD688yC8MWTlheW00vqWRDAkGZBFjM9AChJhQYHCr/Q7ffZ4pnsHHYa?=\n\t=?utf-8?q?r+/7vY85eKUzzt6PteyFc6N13ZNCAbtBecrkhyHU1EvLns71XTC29eRcDb21Hp9ww?=\n\t=?utf-8?q?ZJSbsxVz2l+/LYuHMxaxJH2BT5OXdH2K/STQAlIfzLbZQiwhl4gokYLVXjj9/C5Ki?=\n\t=?utf-8?q?np65oPgqcimTiybu2aeSZIDxOKT+Bk2lrh1Akgx+KtGaL/6LFGbajYzMNsPcCq9Ki?=\n\t=?utf-8?q?byBP+b2cUAB7L9jdNZ+rE9nL+nMIQCE/jLnv8zrZ5gY4hk1EbWTTxL3gYXL+PAKmu?=\n\t=?utf-8?q?UP9IMSiqlu56JiaZOS7g7nGAluaX810f369LhVgM0tQMgT3X/KPkfn3DJT2ECOLTb?=\n\t=?utf-8?q?0Y7ZwF4VDQXGc0/gWfplLK4h2tc8/bu68SDr1AlZP7aphj6jPQyX6YCEPF9gXyayW?=\n\t=?utf-8?q?/yZak7Sul8F1fSy2F0s/nOVNbRccW7HIIbq/tWhdqSIy+VY4RDaI/KDUOi2iMaNvZ?=\n\t=?utf-8?q?j/meyl4zlqBkCm/QMVF32kuzHYu+twmzuWnVZ7mcVf8cTDztvQ8yMFBOh9R+52Ehg?=\n\t=?utf-8?q?TfiKr9q1oo+5VSfYXEdwsWcERMEB2Aqf4IBqM9tollTLZOnjrXxX94MlahvOL6RLA?=\n\t=?utf-8?q?ptD/ghJwsQRLDRfXeQ0OLVo8H9JoFlRXNpfYBroFSMCRyYsrHuxJ67O3hNB+AfaIG?=\n\t=?utf-8?q?e5uNh/ODbPEDGsXDsraxbJDAAuM5fzPMCt3vZsRrPDHsSudKqMp2ELXc4/n5NagzP?=\n\t=?utf-8?q?klRP7GmQEwrqrA9AncAUBhkJFE1vKRqxYc/30gBPPDXuX8tzpZZbHqrSkjULDvsSC?=\n\t=?utf-8?q?vRCACPhEy89gUtjcZM9UAMv4fmHqvnoZYyd8HMXbTFfFMzd1x79Rmnli56yPqCxaA?=\n\t=?utf-8?q?27UMK96+Y0oYICc2RBGg9skaVvkDlDIAtOSl2CufIPI0AEPc9MXXKAgmEomSk46bn?=\n\t=?utf-8?q?QneRYg1BNZPfoCSjovMTUGPyQ+bARdbYrWdof7xKhXQNdMrjEbk5aYe9PLYkrvmiy?=\n\t=?utf-8?q?4FuONlhKUs51QgUVjk9/E/dASlBLi0tKq6Uerq2XdvKErYvuqBgnJJGDOeFEGDE35?=\n\t=?utf-8?q?qKOVLQJSjJbaHBbgPucJUvU3mZBCNassHCkHz8T2f+vfVgKHlTgsSqmOIfr2UcFyo?=\n\t=?utf-8?q?vbAlpy2E3Pb5tOwz2cyZ0G3zezQBS/1OdeMrRIZd7OwXWEkvIWGSh28BOXgrWu8R2?=\n\t=?utf-8?q?MhNa0q70pnuh2itFFOPolvMn/RydSQtnLeOkkhJ9m1167aUx1IZLPe56zdDLOTXub?=\n\t=?utf-8?q?JQxqj/bU8Li+h3kKZR8z0otLnVsGZHFQQZ9iT8w0d+wuCk9fzB9XNe+rbc43SM7H8?=\n\t=?utf-8?q?s60vnXrg3PEyMg8L7Ef+soPH1jzg4bcnirwQGPnE5WCdsbU6yyALWiLS1Fq+mmfC2?=\n\t=?utf-8?q?Km8b1dKzeOAMYQy0svdg8O7fAqkqfZJWyptGmGZLt6nDcYj1vaKj/s779QEJTGROc?=\n\t=?utf-8?q?8AQVpq0DRb1OtDAoWYgKWpBDbF7xhmkpjxPzOzFSMvjriTg1NHqtbqNBGolJaCaDT?=\n\t=?utf-8?q?KmzN8o5asqzAybOrGdl7nIH0vId7LjC/S2eauI1A1Wrsg/wgnrU78=3D?=","X-Exchange-RoutingPolicyChecked":"\n b+Wisb7Wj0fKAGF7q+yR+eJBKc5Ni8eakyZ+J2670I7Lagq2l+o+qXeDXopRcNojuKITLCUd/u5xuj9Ca9HAnU2rBgsRO749gXiNfGgw8270eNBv50I1zpkP4LcR7tVQi4nAOuFWMBPDcsBTHSiMAjxi0p3QbpkoRqr80ksPnNyuoaTNgYod8uQnnVLpDlSblphqW2GyitGvybt5ngWwIVND+w1mMNh/l4FTifbYY1TM26M2Gi05V4GnAh9W5nBFXUd/HkrwvpzluzsJRLyYW9nlLBC7THLUIZKKpwxEPTKccxImcEfQuCvoxHek950o6UMf3Fp6Y+0K/LWhz4cMQw==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 87a2c18e-f082-4748-9cb4-08de96358737","X-MS-Exchange-CrossTenant-AuthSource":"CH0PR11MB8086.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"09 Apr 2026 12:42:58.0939 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n CVE5XmtkHvqC5wZ/YKznj5DCgYTe3V9ZdEihDnYO6N/Y50pJRmind73ga2gDlHn6jq2jDaa6EWeJcfeb1aymdtzWaAca73LC+tzWPxz+bCk=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH3PPF310D5CFFC","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775738591; x=1807274591;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=nGwmdtWdL3JZE4jDRpc3UGjGQBLRt7i7IwjdWUtM430=;\n b=LApb9+yiFua+gDWzJRILgrOGC6EeFN54le7Cd0aoFMUkNgYgXLiL9BI0\n ZwvUd0ybz9r2tT2ntI+XH3VwrU4nMu022aAAqZg7Oy4FnNCMMfAMChWiO\n ECaiuUXrM34heZ+U7/S7yXnTB26VpieBVTrCr4BZzh4q9stRZlY1Oqvzr\n RcFHvrl2a8lDb/GtxK9MXmCD6hf9vXNt2eV+ERoRWPq51Ja5+VqLU2oSr\n UiujtDSvqlcBhoMH6hlgbarfd8TfyfqLVqke4gbC6Szw3H35EPu/xui/6\n Sjw6AaRrHZk3CkfU6Xy4VYYg946RafhqLkv48G49+ozo+aHTYfl0LU0wW\n A==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=LApb9+yi","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"netdev@vger.kernel.org, stable@vger.kernel.org, edumazet@google.com,\n anthony.l.nguyen@intel.com, kuba@kernel.org,\n Jacob Keller , intel-wired-lan@lists.osuosl.org,\n pabeni@redhat.com, davem@davemloft.net,\n \"kohei.enju@gmail.com\" ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3675818,"web_url":"http://patchwork.ozlabs.org/comment/3675818/","msgid":"<20260410111205.84349-1-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-10T11:12:05","subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"content":"Hello Przemek,\n\nThank you for your comments.\nI will try to include them in a next version.\n\nBest regards\nJose Ignacio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=YAT1jlo+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsYzy0wfYz1yGb\n\tfor ; Fri, 10 Apr 2026 21:12:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5AF4660BF3;\n\tFri, 10 Apr 2026 11:12:22 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Wpg3i6LIphEm; Fri, 10 Apr 2026 11:12:21 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8D6BD60BE1;\n\tFri, 10 Apr 2026 11:12:21 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id CFFDA194\n for ; Fri, 10 Apr 2026 11:12:19 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id B5F6A4043C\n for ; Fri, 10 Apr 2026 11:12:19 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id D6syjVvX4jqh for ;\n Fri, 10 Apr 2026 11:12:19 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B053E40399\n for ; Fri, 10 Apr 2026 11:12:18 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-cO40RGV6P32C3UDeo9Ngow-1; Fri,\n 10 Apr 2026 07:12:13 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A8A2A19560B2; Fri, 10 Apr 2026 11:12:11 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.32.88])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id ECEF21955F2E; Fri, 10 Apr 2026 11:12:06 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8D6BD60BE1","OpenDKIM Filter v2.11.0 smtp2.osuosl.org B053E40399"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775819541;\n\tbh=6q/fYiv79cBBdIHumevrLvgbJqRc865vCfOw9Njpits=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=YAT1jlo+sO1HmSvsKmfFCoIzzbsxfsYr6EbNC0aKaECIQYjl95ocCsWQcnKwNl6qh\n\t jfBX8evitEtTIjTPwuaL2h+9FuWgDvfjjyE4G34syVoQf/Perd574cMHYb8DBLTXNL\n\t BUlk66SYc47Lf7xUlFXR4JPh1CtUvm6QeytuOnwdRnrXbs48LPbuiB12ALMRQln/lC\n\t IrQE0+dDH2G+ZYWJJSefl2Bxiaoywb4BTcCj6uYkLMaMW/u52Rv420EWOv887FpV3u\n\t V4pBxeHdIPBXkeukUAIghizJofGNw+TBP+7V25EjjSUNz4dOp1wS+d5faQ/iIGB3jV\n\t GNOWYnuYXaD0w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org B053E40399","X-MC-Unique":"cO40RGV6P32C3UDeo9Ngow-1","X-Mimecast-MFC-AGG-ID":"cO40RGV6P32C3UDeo9Ngow_1775819532","From":"Jose Ignacio Tornos Martinez ","To":"przemyslaw.kitszel@intel.com","Date":"Fri, 10 Apr 2026 13:12:05 +0200","Message-ID":"<20260410111205.84349-1-jtornosm@redhat.com>","In-Reply-To":"<89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","References":"<89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"hBjFN69n2X_4CmnPHROj6sWPBVDYUd5QwM5hpvXxW30_1775819532","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775819537;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6q/fYiv79cBBdIHumevrLvgbJqRc865vCfOw9Njpits=;\n b=BU9O0dKw3glWqHUEu+qCsAGnmAiFou+x3bSKC8ZiSwD5x8BQpTReEvSSK1R1+ByNM+T51n\n XG1BSCklNAn7WSm436m/5qVv4xlu1epq274bu97s7OmjruKXhekEi2zLeER0dH5iGj3pX+\n MojtEJizK/ntsNGpi2PRG4hImDAnNCc=","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=BU9O0dKw"],"Subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"netdev@vger.kernel.org, stable@vger.kernel.org, edumazet@google.com,\n intel-wired-lan@lists.osuosl.org, jtornosm@redhat.com, kuba@kernel.org,\n jacob.e.keller@intel.com, anthony.l.nguyen@intel.com, pabeni@redhat.com,\n davem@davemloft.net, kohei.enju@gmail.com","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3675878,"web_url":"http://patchwork.ozlabs.org/comment/3675878/","msgid":"<30d48647-8c1d-4683-ae9d-becb33cf8d4f@intel.com>","list_archive_url":null,"date":"2026-04-10T13:19:34","subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/people/85252/","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"content":"I believe this is a move in right direction,\nplease also find some more comments\n\n>> +/**\n>> + * iavf_poll_virtchnl_response - Poll admin queue for virtchnl response\n>> + * @adapter: board private structure\n>> + * @condition: callback to check if desired response received\n>> + * @cond_data: context data passed to condition callback\n>> + * @timeout_ms: maximum time to wait in milliseconds\n>> + *\n>> + * Polls admin queue and processes all messages until condition \n>> returns true\n>> + * or timeout expires. Caller must hold netdev_lock. This can sleep \n>> for up to\n>> + * timeout_ms while polling hardware.\n>> + *\n>> + * Returns 0 on success (condition met), -EAGAIN on timeout or error\n\nkdoc requires \"Return:\"\n\n>> + */\n>> +static int iavf_poll_virtchnl_response(struct iavf_adapter *adapter,\n\nplease move it to iavf_virtchnl.[ch], could be useful for other also,\nnot need to move it then and loose your authorship in default blame view\n\none more thing is that this could be perhaps integrated with existing\niavf_poll_virtchnl_msg(), which does not call\niavf_virtchnl_completion(), but likely could\n\n>> +                       bool (*condition)(struct iavf_adapter *, void *),\n>> +                       void *cond_data,\n> \n> this could be const, then no cast on the callsite\n> \n>> +                       unsigned int timeout_ms)\n>> +{\n>> +    struct iavf_hw *hw = &adapter->hw;\n>> +    struct iavf_arq_event_info event;\n>> +    enum virtchnl_ops v_op;\n>> +    enum iavf_status v_ret;\n>> +    unsigned long timeout;\n>> +    int ret;\n>> +\n>> +    netdev_assert_locked(adapter->netdev);\n>> +\n>> +    event.buf_len = IAVF_MAX_AQ_BUF_SIZE;\n>> +    event.msg_buf = kzalloc(event.buf_len, GFP_KERNEL);\n>> +    if (!event.msg_buf)\n>> +        return -ENOMEM;\n>> +\n>> +    timeout = jiffies + msecs_to_jiffies(timeout_ms);\n>> +    while (time_before(jiffies, timeout)) {\n\nplease consider do-while (after the rest of changes could be better)\n\n>> +        if (condition(adapter, cond_data)) {\n> \n> if condition is met, but timed out, there should be no error\n> \n>> +            ret = 0;\n>> +            goto out;\n>> +        }\n>> +\n>> +        ret = iavf_clean_arq_element(hw, &event, NULL);\n\ninstead of NULL pass \"pending\" param, if not zero you could omit\nnext sleep\n\n>> +        if (!ret) {\n>> +            v_op = (enum \n>> virtchnl_ops)le32_to_cpu(event.desc.cookie_high);\n>> +            v_ret = (enum \n>> iavf_status)le32_to_cpu(event.desc.cookie_low);\n>> +\n>> +            iavf_virtchnl_completion(adapter, v_op, v_ret,\n>> +                         event.msg_buf, event.msg_len);\n>> +\n>> +            memset(event.msg_buf, 0, IAVF_MAX_AQ_BUF_SIZE);\n>> +        }\n>> +\n>> +        usleep_range(1000, 2000);\n\nvery old commit 9e3f23f44f32 (\"i40e: reduce wait time for adminq command\ncompletion\") said that 50usec is right amount to sleep between checks\n\n> \n> no sleep after message received (ok to do on empty queue)\n> \n>> +    }\n>> +\n>> +    ret = -EAGAIN;\n>> +out:\n>> +    kfree(event.msg_buf);\n>> +    return ret;\n>> +}\n>> +\n>> +/**\n>> + * iavf_mac_change_done - Check if MAC change completed\n>> + * @adapter: board private structure\n>> + * @data: MAC address being checked (as void *)\n>> + *\n>> + * Callback for iavf_poll_virtchnl_response() to check if MAC change \n>> completed.\n>> + *\n>> + * Returns true if MAC change completed, false otherwise\n>> + */\n>> +static bool iavf_mac_change_done(struct iavf_adapter *adapter, void \n>> *data)\n>> +{\n>> +    const u8 *addr = data;\n>> +\n>> +    return iavf_is_mac_set_handled(adapter->netdev, addr);\n>> +}\n>> +\n>> +/**\n>> + * iavf_set_mac_sync - Synchronously change MAC address\n>> + * @adapter: board private structure\n>> + * @addr: MAC address to set\n>> + *\n>> + * Sends MAC change request to PF and polls admin queue for response.\n>> + * Caller must hold netdev_lock. This can sleep for up to 2.5 seconds.\n>> + *\n>> + * Returns 0 on success or error\n>> + */\n>> +static int iavf_set_mac_sync(struct iavf_adapter *adapter, const u8 \n>> *addr)\n>> +{\n>> +    int ret;\n>> +\n>> +    netdev_assert_locked(adapter->netdev);\n>> +\n>> +    ret = iavf_add_ether_addrs(adapter);\n>> +    if (ret)\n>> +        return ret;\n>> +\n>> +    return iavf_poll_virtchnl_response(adapter, iavf_mac_change_done,\n>> +                       (void *)addr, 2500);\n> \n> this function looks elegant, thank you\n> \n> I'm a little affraid that this model (if applied to other things than\n> setting MAC) will skip some of our \"much needed\" logic in the watchdog.\n> \n> I have not thinked about much yet.\n> \n> unrelated: callback looks elegant, but for virtchnl, it is almost always\n> the case that we wait for some VC OPCODE to come back, and this is just\n> a number. It could be easily coded as a callback too, passing wanted\n> value masked in pointer, but I would say that just passing a normal u32\n> param will be most clean\n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=3kSjmi93;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fscpx6b2Dz1y2d\n\tfor ; Fri, 10 Apr 2026 23:19:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 36B1B410DF;\n\tFri, 10 Apr 2026 13:19:49 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vhfrMS7MFuxg; Fri, 10 Apr 2026 13:19:47 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4DEA7410D8;\n\tFri, 10 Apr 2026 13:19:47 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 9CC8B194\n for ; Fri, 10 Apr 2026 13:19:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id A4D0E410D8\n for ; Fri, 10 Apr 2026 13:19:44 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id txdc562YsPKK for ;\n Fri, 10 Apr 2026 13:19:44 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.21])\n by smtp4.osuosl.org (Postfix) with ESMTPS id CBC864107C\n for ; Fri, 10 Apr 2026 13:19:43 +0000 (UTC)","from fmviesa004.fm.intel.com ([10.60.135.144])\n by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 06:19:43 -0700","from fmsmsx902.amr.corp.intel.com ([10.18.126.91])\n by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 06:19:42 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 10 Apr 2026 06:19:42 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 10 Apr 2026 06:19:42 -0700","from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.1) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 10 Apr 2026 06:19:41 -0700","from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9)\n by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.42; Fri, 10 Apr\n 2026 13:19:40 +0000","from MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311]) by MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311%5]) with mapi id 15.20.9791.032; Fri, 10 Apr 2026\n 13:19:39 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4DEA7410D8","OpenDKIM Filter v2.11.0 smtp4.osuosl.org CBC864107C"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775827187;\n\tbh=p47Gn4bIHQyfMpllVKYUXdD8PnbjMRaJ10VFmV8X+BA=;\n\th=Date:From:To:CC:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=3kSjmi93WQF3AGOl9fudXAeu2aeQSvMp24ayLwJnDCDauNeQQEZrBiBlgAsblaCWI\n\t uHxvjDSGhU1bF3aaqhcU8VJ22n+k6xks9R7c53arHA4FXbNsRIDu4P9wb/BJpgWoTZ\n\t R1Pcok1NuY1FC+y9lnA4cxcjwYcGgoI5nYaSSRWs/j+VcyHW03CzoHttgl6t/MnL8O\n\t C6NoVuwa4RQ6t/yHeIR3TGVHsc1vZbWEgmRL4H14NesHtWw7mIo9x3e2V88EhWjVXy\n\t eSzrbRmPOMDzcdPbzI9pfngsZhsWzv4JRYhYiEOvzAkO4JTJTD3Tu9qInwdnjpD9cv\n\t iRYEcI98beEyw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.21;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org CBC864107C","X-CSE-ConnectionGUID":["+TDl0qU1TQ2+nvI/2plgQw==","EnHieW76SGSoTYVourglNQ=="],"X-CSE-MsgGUID":["Fjrj2Uf/QzKm4p5fiI2OFw==","tVxLm4a9TsqlNto06SnKXQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"76723574\"","E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"76723574\"","E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"230807026\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=NwjAifvAAc7Y/TL0qi1OdgwD6A12gn/KDbwrtDiEvcik7L/3bPlbg7qTjjiM4/KS8ZQi3dsEU2EpurVpRMn5jpOI2hjCCOspJmJBL2bGGtqQ+blPFe1sC1CT2wuSf5rRzH6JpUqWGymA1HpGKuqvfDH/vvTC0qHuT/shJAoYVIvErbYN5INQhGjVMYPTrx5KYkvmKCEsKFh8HB6wegmslY/VUgUaY/IGJ8VO77sRHONIcFXnf4m5M6ql8bz7tAb2K1cONKKlyuY3qmQP1HXIOsyDRux9KFFpcjKz5akKHcucIESTMRftcnYdr7gSsdESwFqbpCK0VMEIgvEcHd5cTg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p47Gn4bIHQyfMpllVKYUXdD8PnbjMRaJ10VFmV8X+BA=;\n b=cTHpU6TvF4jD8AsRaG5dKQ3cQB4ZqK3MvxnWrXee3+St9uOyvLI/us5MCzCFyVfw+196uAyL3mbyLRiKsUJkon1RmmESX7tkgytHxiHqej4zH4BPWjn2Xuc+VJvfhfAdd5MPW5w8r07Em/3/6aoO/XWXR39l7efw9lyeCPKaOKoPZ9lGU8NvuRi664REyjnzKBuDEQQisavjStAE7D+h8Ca8d1kvyIBXxgMByF6Rowl4Xnf/GTWDawws4NDBtVfESEe6eCsiGkAxhDZKIPt5wWxycTsZfvexebu4M48FVmAXWrMoUxhXv3cRPwXfwWF12A4+l01OsIEe/BNDTBaVXw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<30d48647-8c1d-4683-ae9d-becb33cf8d4f@intel.com>","Date":"Fri, 10 Apr 2026 15:19:34 +0200","User-Agent":"Mozilla Thunderbird","From":"Przemek Kitszel ","To":"Jose Ignacio Tornos Martinez ","CC":", , ,\n , , Jacob Keller\n , ,\n , , \"kohei.enju@gmail.com\"\n ","References":"<20260407165206.1121317-1-jtornosm@redhat.com>\n <20260407165206.1121317-4-jtornosm@redhat.com>\n <89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","Content-Language":"en-US","In-Reply-To":"<89bfd605-1877-4d40-95e1-bfeae6624168@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"DU2PR04CA0053.eurprd04.prod.outlook.com\n (2603:10a6:10:234::28) To MN6PR11MB8102.namprd11.prod.outlook.com\n (2603:10b6:208:46d::9)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MN6PR11MB8102:EE_|PH0PR11MB4824:EE_","X-MS-Office365-Filtering-Correlation-Id":"fdf80093-723d-4510-c828-08de9703d1f3","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n 41pXlk0XzmoMW3fCCmEKvhBo9roBcSINnPZsaYqByGe7CoPYxjssF2VmEOiFMrktr5jMN0l4XkTUycJx0mRDKV4DSF4SiPSQHfNnZzSn9jUt1Gly8DqigUtg1P+4zLsihEmkQECODA+bB8xP+1ml422IBZtg6fL9IjdC/71NLICLh4+9XDcPnzEGsdCQOi/GJLjApEZAMc31z7FYQpw4hdl7tGmXrV9h9xF5fGKeF41bPHpyftyt5QD5+oeWarGuHf0Qd+1WS96+x6FFZ5yvPqmF1vS6IMSxYQ4HmQAuaZAUZIsr8xIW0F8i3E+CZAQEaDsC8pSwQRYhPzaZOENYWyDtTqQSZhZjNZ0LlXelbXRrQ+cFfDm7An3vK/7dukO3QiU587XFhTHSUxhfQMZXUSPBwim76Z+8YN2ArWI7ZAp2eHoKA3fqcMV8TJYxZywEQzg6P98FjDJS4197Cc3yYLq/GFeJNU6NrYshccFduXDpTd6LJL3RuYmd+jZShLDn2Dhq8pr+c9ALWcES5/epVDG9O/Ua3YJL+FEDeiM+0VaKfgB17KQZjudb/cb9LTaFJDVL7LZEq8NfOW+UOpn5GGJeHo4EU2gU6W7TO0h3/I0trRwtRo+sIdmPrzc3ugZZxQZ+SMOuzpjWeBaJ0QHECu7MuWvGyM1VSEa5K+wuN9wWIJ2cQneK3bst+GZAf1fkj9Kufr3LEJW/ssBjKaeg0uFVwziOSKDD/Ht/5oa6f7s=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?KueYFjhufx5C1VI9pkNurEPDcrcs?=\n\t=?utf-8?q?vR+o+AEDh7cJqVbaf6n5pfFeMyV9nHby/3AquTqd4eRQI3qLEVz7v/06dR8UMHjHK?=\n\t=?utf-8?q?fvXtGmIyfMVKpTt6iv4NGk75Ifz/ojEXm86XhHZWWkKze6aMNTov1HtFcr6EFif1y?=\n\t=?utf-8?q?PQhRG2Qrj73vSArGl1b46e6ViKVLzRr4EyrqNXpjJhDV/aU3X/eitFmmEvh6U1nzG?=\n\t=?utf-8?q?57Nrx+ZmAcmZhETmLLUR/4UuKfKedfo3zQnRAs3BT7WHHfk00N2sZxj1bFhsyyHHn?=\n\t=?utf-8?q?WbKjP/ACZ6ZCS17e6JUj9DVyMkG4/1aOmWnETu46nfnM1/e/px07ivTpTiBilFDcS?=\n\t=?utf-8?q?1DBjTJtu7sHeLzF4ORdSsVMoVb9zrlMboNqWuBpEbECuMdRyhG+bC8BiQjhGzO053?=\n\t=?utf-8?q?ha2EZkpwT6ty1DXfBp7iMALBrKOxS0ilspDTnj24yBsi5Unrq3oIOyFopx3tq6/38?=\n\t=?utf-8?q?/HfX2soe7QM8QFz9skXO+QdkDO5l3EFtFOX3776XZ4mJAKS5LLK0t2MeVZkC0yztZ?=\n\t=?utf-8?q?qVEBJZmrcj8GWGzBOyGSYyRmm86qx4c6YnAqrfQGTXTZavbV0mitxfdo67HEzOIhN?=\n\t=?utf-8?q?efbUvgnluFhYoCiu5XctrIAgiCTMbpIQtSGC3KtClWwSSWB7Cz4RmNe6xFC9UaPje?=\n\t=?utf-8?q?kglZGH1r44ey1P9nim/AWJBaPCF3RIq2+C/jlBpBubw4aBhGqau4H2V8YKJyJLa+t?=\n\t=?utf-8?q?2trFR/d/AKN5xh+edeJD+uGpQWk5NO2P6APq3do1p+IDXn0y0WXVIoAlCNRSgYIcR?=\n\t=?utf-8?q?erpiG3DDxX0SSwRbiEuRXraYPMsDFJNxm0VXakRrVsX/wiy76YlxTnJfthLZNW8ox?=\n\t=?utf-8?q?8DRo7gjvhQXDGjQG+atldcQN98yjxMCArD1Ot9dG8eJ/7pj9DKRe3WkrzewXhldu7?=\n\t=?utf-8?q?8LoEJU6NW4DLicFK1rV1rKO1XAmnHRUgndhqEv4PkbbLLGadn6kD/iQ2jvzR7bg8x?=\n\t=?utf-8?q?Qmv8sXFqrEuYjbN3HReKdA987x9Sqm4xGW9YE6gaAU/AjW5AnblOC516ZWJC8X0FT?=\n\t=?utf-8?q?Ybos7TdAmGD6EXUXbuM+yZ+OY5pm9ZVuCEL5U320W+8vvx/r+aVNVVNCH0/lUJduV?=\n\t=?utf-8?q?2aGZiG1ePFsRNerjm97BIoBrwH//U8zLeaORLoAAR6j7H/S/5nw3SSPK4TyREIrez?=\n\t=?utf-8?q?rsnqEfMh7sCtIn/UbyRU5mZkSDPXbICAA8wnLM521IAcGL97wE3ohuBy89mI5Z/yM?=\n\t=?utf-8?q?o2RWhn6tourpE1Pevog5I3Zeodk1F5IMWvg19F7FnhR5MmN72X2SUnOknAt/Z61CS?=\n\t=?utf-8?q?0IFABIQ4AO2I0E5ii/ytC85kPoLAxC5rHfYKcks76F0GAdLNZ51Wu8WYRiDeXMu8F?=\n\t=?utf-8?q?08TuVU2HSwKW1Iot76jYcwQhW8SWgeg8kE4mGPLtRE5wWDpo+cNgebpo98QGHmUJf?=\n\t=?utf-8?q?PBcdFKthT2Cq1xuYzB3KBpGwTZIMF4hlYyczQMA0KNSBLQYIXX1AkbBcpmMgiOXeR?=\n\t=?utf-8?q?XDR3b3/whFOV+SEvs9w+wm/ZT3xrUkVvVBk0YFtYOL0BGXcRf0Ih3MdMMxEHv+bT4?=\n\t=?utf-8?q?WJah9RGitsQyhJyD5IilmHImVeto/rAczDDxgYErq7Vq3CYrOPaP1kWMCy6YcOSpD?=\n\t=?utf-8?q?J7hKabQu3eHdxPpE747sX4+08VJMxGGtqh1Cj2QqLxIOgbZprrnWtAIx+TlVLjKWX?=\n\t=?utf-8?q?R/qbtAMpoyYK/LwRYj87BK5yKrwR5YH5U6cKB+ZA57Nt0yrzDByW4=3D?=","X-Exchange-RoutingPolicyChecked":"\n Jx5zuvthcrBHDm0piZAGnem4EhzEj87DUqkeMH3J7RU0YpjoIkQyaX+1qxJz9ro58rQzv9N6eQsAXSVsdfCc9Ai8MVVM0J9r4EB2Xsb+VJMbh7utTsEBKs8DeYxyBhXEZjwZO6StsVG8aKG8/cjh21uFumf8gLSZYSXNro4xq3KrGhWtmVhtpLJigEuOtimQRttwu98Q2tm2HpZA/A7rzAECO4SzZHayF9NEHSB5gv6M9JPI0ZjttZ1ZuxcrWEp0QbBy5Kp9FFFSm1UnuOGVO+KW70orv4HmlBO69LhdBCdS4lQ/sM2OPqLS+owkvk3SCykmWzUXAiZe70s5VUZQig==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n fdf80093-723d-4510-c828-08de9703d1f3","X-MS-Exchange-CrossTenant-AuthSource":"MN6PR11MB8102.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"10 Apr 2026 13:19:39.8433 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n EUHzaBoyf1FmldBiV4oV+jvsXV42BBGDhqEYw1gehXNUPzySx0tcSnjwFzL4Q2qZdyaEWc4tkEAXTpDgGfz7k6bej4DQa78jf2/p494n2UQ=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH0PR11MB4824","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775827184; x=1807363184;\n h=message-id:date:subject:from:to:cc:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=7pnGKDNd3j+eHJvi7lZ2sCgswYu8IAzahNatqToothw=;\n b=YC9AmIBk0L+iDTY8lCaUF7GDh/S3SA0ezSTUKu6+XymlzYsWMW6gkWMM\n qcejegbQ+jRKzL3FHUv5ODxdg85uUQ7vmVEJt0miGEZ9ycfkBbhaOwNu6\n XlXYQkeXJdRz5jsJze4lfWKXfsxHK5wvvqja1Ws2blz79EOj7d7qud7qm\n GSJhslgTEbffD2qkfz6OXQj0lhdS7h9XgDVSUEW8tAB9TIH6tFkNzxtIF\n WyNL9n5sv2OkrAC5mm9W3Ql+5AObypEO+HWwCE/B3+OvHrD0lfjETw9yW\n CfkPlq0a7cbbmCKV3NCfoxq2NSi/muCUbXy4SBiLM0mP6WEHo7+rQQza4\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=YC9AmIBk","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3675976,"web_url":"http://patchwork.ozlabs.org/comment/3675976/","msgid":"<20260410162542.209743-1-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-10T16:25:42","subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"content":"Hello Przemek,\n\nThank you again for your comments.\nI will try to include the new ones too in the next version.\nIn addition, I will analyze the suggested integration with existing\niavf_poll_virtchnl_msg() and possibly iavf_virtchnl_completion, but maybe\nbetter in a new patch of the series as a refactoring.\n\nBest regards\nJose Ignacio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ub+LSyfB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshxj356Bz1y2d\n\tfor ; Sat, 11 Apr 2026 02:26:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 041BA610A9;\n\tFri, 10 Apr 2026 16:25:59 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id svVZz7AtA1I1; Fri, 10 Apr 2026 16:25:58 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 38A5E610A6;\n\tFri, 10 Apr 2026 16:25:58 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 684A8237\n for ; Fri, 10 Apr 2026 16:25:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 558B640B63\n for ; Fri, 10 Apr 2026 16:25:57 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HJuxIgweDRMb for ;\n Fri, 10 Apr 2026 16:25:56 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 344BB40B58\n for ; Fri, 10 Apr 2026 16:25:55 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-uRPQk7QlOeyjSGPY8gCZmA-1; Fri,\n 10 Apr 2026 12:25:50 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A82C3183EED1; Fri, 10 Apr 2026 16:25:48 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.32.88])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3F5B01800B7F; Fri, 10 Apr 2026 16:25:43 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 38A5E610A6","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 344BB40B58"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775838358;\n\tbh=WIgf06YVrt3i8IDBeTEXTOVKt6Ma5XHOJR3hB7Q6upw=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ub+LSyfBatpFhqucztCGz8/C+c76UDWF7UUnwR2dyMxxUY0D81DmNkUo0E1so5ofy\n\t pIrB+D8WAc+7c4HSk1Dq61TTe965WVpUMV4F9G1d0s34cBMy8Z34Dur56hPolEZQ0n\n\t y+6nzFtMj/n5+W9PwZ3BJhJ0X2MuRjvotSEY1lfHkD/as8vQguddMh757ixqRQi4S0\n\t Cq8NINv0wXPYowExuwmkRYbU7bed2XFhyzAWUbkFwtW6yuaPj+L5abwPP3wka81j7R\n\t uDYsCZ+eiU1zVoo+mNu0mrN9HB/cvPh/W5Zy0YQ0irk9C8plaiRrQx6KrF/cwXIv1P\n\t ll9XxKR5GeaaA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 344BB40B58","X-MC-Unique":"uRPQk7QlOeyjSGPY8gCZmA-1","X-Mimecast-MFC-AGG-ID":"uRPQk7QlOeyjSGPY8gCZmA_1775838348","From":"Jose Ignacio Tornos Martinez ","To":"przemyslaw.kitszel@intel.com","Cc":"anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n intel-wired-lan@lists.osuosl.org, jacob.e.keller@intel.com,\n jtornosm@redhat.com, kohei.enju@gmail.com, kuba@kernel.org,\n netdev@vger.kernel.org, pabeni@redhat.com, stable@vger.kernel.org","Date":"Fri, 10 Apr 2026 18:25:42 +0200","Message-ID":"<20260410162542.209743-1-jtornosm@redhat.com>","In-Reply-To":"<30d48647-8c1d-4683-ae9d-becb33cf8d4f@intel.com>","References":"<30d48647-8c1d-4683-ae9d-becb33cf8d4f@intel.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-MFC-PROC-ID":"0fegZ1P81zMaraHSGwpZIIfQSXEyrL5cFR7UdHohQ54_1775838348","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775838354;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=WIgf06YVrt3i8IDBeTEXTOVKt6Ma5XHOJR3hB7Q6upw=;\n b=HQcHSvh2v+oMPkfSsvTJfZrWARm8hoSxHYnSFBB6cxlKM1nQ/R20JRmVgbLiO/KPklLZvs\n fwVxNEGgdSgFrcBQFriQ2XyEcGq0E9hp5zTBgGckQXouHiqrFu0078Qi5Vw7xizDqMCZrC\n Fm6BTB/DQVTVRrj1bpxIQz4cF/E0y88=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HQcHSvh2"],"Subject":"Re: [Intel-wired-lan] [PATCH net v2 3/4] iavf: send MAC change\n request synchronously","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]