[{"id":3676053,"web_url":"http://patchwork.ozlabs.org/comment/3676053/","msgid":"","list_archive_url":null,"date":"2026-04-10T21:02:28","subject":"Re: [PATCH 1/8] smb: smbdirect: change\n smbdirect_socket_parameters.{initiator_depth,responder_resources} to __u16","submitter":{"id":89563,"url":"http://patchwork.ozlabs.org/api/people/89563/","name":"Henrique Carvalho","email":"henrique.carvalho@suse.com"},"content":"Acked-by: Henrique Carvalho \n\nOn Tue, Apr 07, 2026 at 04:46:27PM +0200, Stefan Metzmacher wrote:\n> We still limit this to U8_MAX as the rdma api only uses __u8\n> and that's also the limit for Infiniband and RoCE*,\n> while iWarp would be able to support larger values at\n> the protocol level.\n> \n> As struct smbdirect_socket_parameters will be part\n> of the uapi for IPPROTO_SMBDIRECT in future, change it\n> now even if userspace sockets won't be supported yet.\n> \n> Cc: Steve French \n> Cc: Tom Talpey \n> Cc: Long Li \n> Cc: Namjae Jeon \n> Cc: David Howells \n> Cc: Henrique Carvalho \n> Cc: linux-cifs@vger.kernel.org\n> Cc: samba-technical@lists.samba.org\n> Signed-off-by: Stefan Metzmacher \n> ---\n> fs/smb/common/smbdirect/smbdirect.h | 4 ++--\n> fs/smb/common/smbdirect/smbdirect_socket.c | 5 +++++\n> 2 files changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/fs/smb/common/smbdirect/smbdirect.h b/fs/smb/common/smbdirect/smbdirect.h\n> index e70a21eb57f0..8fbffe3eb845 100644\n> --- a/fs/smb/common/smbdirect/smbdirect.h\n> +++ b/fs/smb/common/smbdirect/smbdirect.h\n> @@ -32,8 +32,8 @@ struct smbdirect_socket_parameters {\n> \t__u32 resolve_route_timeout_msec;\n> \t__u32 rdma_connect_timeout_msec;\n> \t__u32 negotiate_timeout_msec;\n> -\t__u8 initiator_depth;\n> -\t__u8 responder_resources;\n> +\t__u16 initiator_depth; /* limited to U8_MAX */\n> +\t__u16 responder_resources; /* limited to U8_MAX */\n> \t__u16 recv_credit_max;\n> \t__u16 send_credit_target;\n> \t__u32 max_send_size;\n> diff --git a/fs/smb/common/smbdirect/smbdirect_socket.c b/fs/smb/common/smbdirect/smbdirect_socket.c\n> index 1e3b361728cc..4003753bea26 100644\n> --- a/fs/smb/common/smbdirect/smbdirect_socket.c\n> +++ b/fs/smb/common/smbdirect/smbdirect_socket.c\n> @@ -166,6 +166,11 @@ int smbdirect_socket_set_initial_parameters(struct smbdirect_socket *sc,\n> \tif (sp->flags & ~SMBDIRECT_FLAG_PORT_RANGE_MASK)\n> \t\treturn -EINVAL;\n> \n> +\tif (sp->initiator_depth > U8_MAX)\n> +\t\treturn -EINVAL;\n> +\tif (sp->responder_resources > U8_MAX)\n> +\t\treturn -EINVAL;\n> +\n> \tif (sp->flags & SMBDIRECT_FLAG_PORT_RANGE_ONLY_IB &&\n> \t sp->flags & SMBDIRECT_FLAG_PORT_RANGE_ONLY_IW)\n> \t\treturn -EINVAL;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=Bhwvc8sK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10754-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=\"Bhwvc8sK\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.41","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsq8y0dVDz1yCv\n\tfor ; Sat, 11 Apr 2026 07:06:10 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E006D300BD94\n\tfor ; Fri, 10 Apr 2026 21:02:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 96D773A7F5E;\n\tFri, 10 Apr 2026 21:02:37 +0000 (UTC)","from mail-wm1-f41.google.com (mail-wm1-f41.google.com\n [209.85.128.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C96833D4FB\n\tfor ; Fri, 10 Apr 2026 21:02:36 +0000 (UTC)","by mail-wm1-f41.google.com with SMTP id\n 5b1f17b1804b1-488a29e6110so28318805e9.3\n for ;\n Fri, 10 Apr 2026 14:02:35 -0700 (PDT)","from precision.tail0b5424.ts.net\n ([2804:7f0:6400:d040:6795:56c9:49cb:ad88])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c34acb077sm4566350c88.6.2026.04.10.14.02.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 14:02:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775854957; cv=none;\n b=Cr4HwEqfmA9YpkCbjcUU+YjLwHkjjVJhVJzn2XCYaoKhI8snKGqtiFON6yd3NVRUJXyQPRs+YWXF/hn+3o/M29EPpV4CCSsW7xB4ORxgACHDVbk8WB7Qz4AfRWYEKVVbvTqr66Uc0ppyGttZ1Xf3AsAiab3zZYAl2NmRtLIxDdE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775854957; c=relaxed/simple;\n\tbh=9xqkXDH3o5aSwWBdUZhXrAzKi7tajxryrTjWmlprNgU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=fHnb/S3h1N00cSwkoBf0DcTFIKPheLaxxTq3GvVxyHVyXEwrtwYx/CqYuhwWX9ro414YYu4v4DP+w+7mAxzHVYTn4O8xK5T4+RDQRXpieAtKQ5lYq43ty6HXMNRUT609BUPqPBmgwLweIJS+d1vT57CzakjU/IlujdjQc6q3DAs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com;\n spf=pass smtp.mailfrom=suse.com;\n dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=Bhwvc8sK; arc=none smtp.client-ip=209.85.128.41","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1775854954; x=1776459754;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=Sun3fsG4LspnWyjkCY2kXfvLourR47k4fQ5gMPWbJRo=;\n b=Bhwvc8sKhlFQsdH8wApTQysPcS2ElTm4M+j7aOkK4XD7tlk0aNxEuH+Qb4v7QpGwd+\n zaJjJ3yTvn/OjBemSfLbsYHRI0otm8kTrGZS/VarAJmAfkee1NyMccmgW6fhTAZFodKk\n 5TreADbpFM25aARpWrXgI+Z/pnyHwdO9T+Tyvzv/z8ilcnwGoC+kCNA+cljqQGpNL+Cz\n sb5jUU08YGOgrDvg4iRG2XK86+fCAm0t3RYv29SL2JIwvcf8WQmC96ileomfaSxDDzYR\n HTrF1xwVuVvxF1kJUOWqI95t7DvFUt2Gk/HyBV6eX76flDa1ivAiKEoWb/HXd9dnGlw6\n IjTw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775854954; x=1776459754;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Sun3fsG4LspnWyjkCY2kXfvLourR47k4fQ5gMPWbJRo=;\n b=TTfqjZ+IHvluodTBBGVXymoUbkeVxlkw+gpFDe10DfWqzc4dFPDqEkiCtMWYXvWcRY\n LzNsgsPP0+StSogBq+ArH8GvQh3Ir4VXCKLqM2LD8erKDbTfJuPjEuf6Or3ld63kHjBQ\n OP2vlpPqemDb+jUolABRAhSsdlhcddncqxQ3e/EF3CB3eVmBKAvD2Xr+PjjDuwPoAfjf\n 6vPbn6Yw1/Hon4hM0Y2kVwBMyrbiCNehIynWFkoIv4jTyKh4oB8JOc95n8sFKhLHZAK2\n H7JhPhL4vmcYJ8+l4uhiqdT2LAgMGyNPeZ3fRvqMqF39HaPh91y0QTGSTyDyQLam2U8Z\n THDQ==","X-Gm-Message-State":"AOJu0YyjF0CnAbonnUa9gEWe4+bp0B40XmZrW38fHvUKQ6lYVonJn/PP\n\tlLG2kHZQGr3r85RahjHOMKyigg0zA2/MjrNzRUPz7kxJtV72GOU7zLz6PXQIelY5emI=","X-Gm-Gg":"AeBDietz1IrKyIvwTo1Kr03zlumOFHomzGgR/H4w9pdjqGwXWcY0KphYajaphgDbEbg\n\tLbLy+4g833GTubP9DejR1ts9427s1ZJf3ANL+V54Zi4YDM649xR8+YoyNcKODO2PF8hKpqfXSbj\n\thWuCDIXVvJu8nMd0Pcc+HQauHgPhNWh7DNFSAYzGjzOUM/g5sRENljx5OSAVmgG69P7OL52Sk3s\n\tbOn6U2YuimGvEItkVAXLRDrAvgqTqaukygLrI2WptilHL3O9K9CzCOE7QMXAHG/UhHLMlAseKvt\n\tQud3q9nvVZcRourQssclnmSM6D/6WNnwJvCGGOHXy3OOWxhf74egQ+YPKESEYK3Kk7KgcEhlGvJ\n\tSxn+X6uGNu/WwnuYF8uNjkA7jVteNNCimHytv3TIlo0xF4CpaxFlkQLuUoTpTlecy3d8qeAgb8b\n\tYxHx28cwUvBPWnkFXxX3cv95wX0WX/YWFGj3yNFhHfQ5tZCinCi6g/hTQ=","X-Received":"by 2002:a05:600c:4f56:b0:480:690e:f14a with SMTP id\n 5b1f17b1804b1-488d68765fcmr66959155e9.14.1775854954426;\n Fri, 10 Apr 2026 14:02:34 -0700 (PDT)","Date":"Fri, 10 Apr 2026 18:02:28 -0300","From":"Henrique Carvalho ","To":"Stefan Metzmacher ","Cc":"linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tSteve French , Tom Talpey ,\n Long Li ,\n\tNamjae Jeon , David Howells ","Subject":"Re: [PATCH 1/8] smb: smbdirect: change\n smbdirect_socket_parameters.{initiator_depth,responder_resources} to __u16","Message-ID":"","References":"\n ","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n "}}]