[{"id":3674912,"web_url":"http://patchwork.ozlabs.org/comment/3674912/","msgid":"<87173dd2-7a26-4063-b943-993a6331c1de@baylibre.com>","list_archive_url":null,"date":"2026-04-08T19:04:43","subject":"Re: [PATCH 8/8] spi: mtk_snor: Remove status register write procedure\n in probe()","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"On 4/6/26 3:13 PM, David Lechner wrote:\n> From: Meiker Gao \n> \n> Remove status register write procedure in probe(). This is handled in\n> spi-nor-core by the SPI_NOR_HAS_LOCK flag.\n> \n> Signed-off-by: Meiker Gao \n> Signed-off-by: David Lechner \n> ---\n> drivers/spi/mtk_snor.c | 13 -------------\n> 1 file changed, 13 deletions(-)\n> \n> diff --git a/drivers/spi/mtk_snor.c b/drivers/spi/mtk_snor.c\n> index 21ac115e3c3..3b9eac383ab 100644\n> --- a/drivers/spi/mtk_snor.c\n> +++ b/drivers/spi/mtk_snor.c\n> @@ -567,19 +567,6 @@ static int mtk_snor_probe(struct udevice *bus)\n> \tmtk_snor_rmw(priv, MTK_NOR_REG_CFG3,\n> \t\t MTK_NOR_DISABLE_WREN | MTK_NOR_DISABLE_SR_POLL, 0);\n> \n> -\t/*\n> -\t * Unlock all blocks using write status command.\n> -\t * SPI-MEM hasn't implemented unlock procedure on MXIC devices.\n> -\t * We may remove this later.\n> -\t */\n> -\twritel(2 * BITS_PER_BYTE, priv->base + MTK_NOR_REG_PRG_CNT);\n> -\twritel(MTK_NOR_UNLOCK_ALL, priv->base + MTK_NOR_REG_PRGDATA(5));\n> -\twritel(MTK_NOR_IRQ_WRSR, priv->base + MTK_NOR_REG_IRQ_EN);\n> -\twritel(MTK_NOR_CMD_WRSR, priv->base + MTK_NOR_REG_CMD);\n> -\tret = readl_poll_timeout(priv->base + MTK_NOR_REG_IRQ_STAT, reg,\n\nThis was the only user of reg, so we need to remove that too.\n\n../drivers/spi/mtk_snor.c: In function ‘mtk_snor_probe’:\n../drivers/spi/mtk_snor.c:530:13: warning: unused variable ‘reg’ [-Wunused-variable]\n 530 | u32 reg;\n | ^~~\n\n> -\t\t\t\t !(reg & MTK_NOR_IRQ_WRSR),\n> -\t\t\t\t ((3 * BITS_PER_BYTE) + 1) * 200);\n> -\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=MPQ93GB7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"MPQ93GB7\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXYy6Cgpz1xy1\n\tfor ; Thu, 09 Apr 2026 05:04:54 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B0063838BB;\n\tWed, 8 Apr 2026 21:04:50 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9DAD9838BB; Wed, 8 Apr 2026 21:04:49 +0200 (CEST)","from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n [IPv6:2607:f8b0:4864:20::333])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3B31483693\n for ; Wed, 8 Apr 2026 21:04:47 +0200 (CEST)","by mail-ot1-x333.google.com with SMTP id\n 46e09a7af769-7dbce74e537so80370a34.1\n for ; Wed, 08 Apr 2026 12:04:47 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:21a6:1216:500b:3ea0?\n ([2600:8803:e7e4:500:21a6:1216:500b:3ea0])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7dbed6c3512sm5316459a34.4.2026.04.08.12.04.43\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 08 Apr 2026 12:04:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775675086;\n x=1776279886;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=UskTi13hp/xyWSdcpsi4P20ku7eYkfO8ld0IxptIzfs=;\n b=MPQ93GB79A5oIqyamIPtAUNl6LFsb7J80AFiQg6Lb9n6nHUbq2i9lKXqfGvQbnamWG\n /gTYhq0FeeCowCFh0j0QCVcAHBxHaJtjreUrqDtuaxKq52+35rlvnBdic9H+9v+gGetI\n rRUHLAo9ZmJjj+oIG9eOVd17TkR4riyC3bgeA5zanRzlVJ2FoBgxu4Z+3c9OMo1Jp0c8\n qVACqSjXLsxPINLMPd+e2JBI8cxQo6dBvy8FDcJRpyzYfhSzmy+E9J9tZbdeJq+iiX8i\n zZwfPKIWJqOIU5q/DzhIkcJSIyhf3ntIm8cBkxEBEKWtlZ+rBaGu1Zo0z/ukRHB8rSQp\n RDPw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775675086; x=1776279886;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=UskTi13hp/xyWSdcpsi4P20ku7eYkfO8ld0IxptIzfs=;\n b=qqw+PBNTjEkBnFPMRT1Y8UExXzIjdlpTxu84vJnY+lFGJJjKh4ArfDav0+BqYy0bIF\n WA4PD5JSU7bLm/3kA8vPa4yIFeSR0FH+s732oQsYNWNLuA30zppNZDp4LU7P6H/iYj/S\n nOFswrAkOPkepICVBoixIDPYcMh3x1ZEWGnelE2sYiJXYoCEBdb0PThfvSoqN+4t2tB4\n O/m7x7ZANdsmf4W86AFcKx6otT/C8/A9ZSPwBATn1r43QMRIRKudeq2mS+rI839lirPF\n 7AZ53R3Pq+3J48kbvz7lVie3huvHoCSg3ZjBT9fClooJ08jXAXDvSCYyfdS5X6/U3t01\n UNow==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUtCDHOu2FmCwtggrU+HTj1QhHaV5ivwae+tUnxOCmXXrXPohJOyNo9z0dzOlvl6b71Ms3RDSA=@lists.denx.de","X-Gm-Message-State":"AOJu0Yz+ATKABdrccb88RTIU36n6y6w3ARO/t5H7bocsEZY4YUDD4Ylo\n nFcyOWBB6+t3Pd52DY5+gSAZ1tsOI97wLbwfBG8o5eqRc5NpsKotjBPTA9wMNF1G+lw=","X-Gm-Gg":"AeBDieuaiNuLg/ZLG+4mAjpPRNdo7rhOx/0ycc89R4mRHMY45664zK/CAkA9ufzmySg\n 6k8xfVuhkK5lcNZiL7ci+qpre3MAnNSAHqCwOx4GmUdmcsHkEQIwS3Tv+Axti/YmdQAGiNogV5b\n 87ctrlLAfyuoMnIGMZLaDNYvti2UnQ6NBRub89exqQXOLKuloc45N0bKbwD+woBugLC3i3yfrOB\n xb0agBqQ8WtP807RMSVxlajk9DZhsIHRTUcgb/2WGNTpHmb3908JP1th5wHQIYK4N5AIA2c+stf\n up/MjtEc6vqAiU48eRs0FiXkUdoG5HTxhRp6tN+2OAmR+eKfddTIA/DPRsBOVajepT/QtMOilMZ\n vLORvs9FiYxAU6fLnha4XKFcXQ/1K9gD2AHN9ep4318asz779V2d+7w0IzPWKI+Lpz4NlpFoExr\n DGoChpKf2o0sh7R9tXaB2Uly1hiGoeVqXd4O0wMS3Q3b8pCjjtRkEn8D7R5kKiTD+fpwIprnD7G\n NaSdOjRqOJL","X-Received":"by 2002:a05:6830:43a1:b0:7d7:ebf0:34b0 with SMTP id\n 46e09a7af769-7dbb74e949fmr12584799a34.15.1775675085904;\n Wed, 08 Apr 2026 12:04:45 -0700 (PDT)","Message-ID":"<87173dd2-7a26-4063-b943-993a6331c1de@baylibre.com>","Date":"Wed, 8 Apr 2026 14:04:43 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 8/8] spi: mtk_snor: Remove status register write procedure\n in probe()","To":"Ryder Lee , Weijie Gao ,\n Chunfeng Yun ,\n Igor Belwon ,\n GSS_MTK_Uboot_upstream ,\n Tom Rini ","Cc":"Julien Stephan , u-boot@lists.denx.de,\n Meiker Gao ","References":"<20260406-mtk-spi-nor-improvements-v1-0-66f675cbbd3e@baylibre.com>\n <20260406-mtk-spi-nor-improvements-v1-8-66f675cbbd3e@baylibre.com>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"\n <20260406-mtk-spi-nor-improvements-v1-8-66f675cbbd3e@baylibre.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]