[{"id":3673882,"web_url":"http://patchwork.ozlabs.org/comment/3673882/","msgid":"<8e3bcc46-abe2-431b-8fb5-e6d5d8bd0e10@linaro.org>","list_archive_url":null,"date":"2026-04-06T22:44:26","subject":"Re: [PATCH v8 18/20] target/arm/tcg/translate.c: remove target_ulong","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/7/26 04:26, Pierrick Bouvier wrote:\n> We can replace it with uint32_t, because we know it's limited to 32-bit\n> target.\n> \n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/translate.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~\n\n> \n> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\n> index 68f050746d4..aea38507ef4 100644\n> --- a/target/arm/tcg/translate.c\n> +++ b/target/arm/tcg/translate.c\n> @@ -6288,7 +6288,7 @@ static MemOp arm_memop_endian_swap(bool sctlr_b)\n> \n> /* Ditto, for a halfword (Thumb) instruction */\n> static inline uint16_t arm_lduw_code(CPUARMState *env, DisasContextBase* s,\n> - target_ulong addr, bool sctlr_b)\n> + uint32_t addr, bool sctlr_b)\n> {\n> #ifndef CONFIG_USER_ONLY\n> /* In big-endian (BE32) mode, adjacent Thumb instructions have been swapped\n> @@ -6536,7 +6536,7 @@ static void arm_post_translate_insn(DisasContext *dc)\n> \n> /* Load an instruction and return it in the standard little-endian order */\n> static inline uint32_t arm_ldl_code(CPUARMState *env, DisasContextBase *s,\n> - target_ulong addr, bool sctlr_b)\n> + uint32_t addr, bool sctlr_b)\n> {\n> return translator_ldl_end(env, s, addr, arm_memop_endian_swap(sctlr_b));\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UPtFBFEB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqPXn5cBBz1yGf\n\tfor ; Tue, 07 Apr 2026 08:44:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9sgV-0000DA-7y; Mon, 06 Apr 2026 18:44:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9sgP-0000CP-PI\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 18:44:38 -0400","from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w9sgN-0002ff-2x\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 18:44:36 -0400","by mail-pl1-x62a.google.com with SMTP id\n d9443c01a7336-2b0afa0210bso21577035ad.2\n for ; Mon, 06 Apr 2026 15:44:34 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b274735633sm152962945ad.6.2026.04.06.15.44.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 06 Apr 2026 15:44:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775515473; x=1776120273; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=zvXhDjYnYtVNwbnXjtKNimWnxYsLtxLlAw52HESpNFc=;\n b=UPtFBFEB3KqXf8XQuYZ2HZTj7uEDDEFhisW7xvvIJcU3lhGlN86AEe6esHqNMYVY72\n DM2pKW61PZ8rgYUDHkDDKKOu6Be0yI3XiAuZLYPiDg8ESMJkACGy0CN8d0psUnPMlDB0\n hCYUqIDGSAsiJ8veYKgT0kudwH79jPm4KK1GtIIdgOqOXx05nBDtJHtyPJY9Bdi6Vi8c\n beEqc6ZEW7fhskSYJKIGDkRI5bNeRxMICcLhshn+L6RBiv3Hy50r0kL9oOtlPQ7O6yzu\n kFyGmOdhKVMziKGm/4KJLuaa0/dIQjnrdEh/X16IzBh4W6BqBBz1LOO0uHytmbt0su7F\n 9G3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775515473; x=1776120273;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=zvXhDjYnYtVNwbnXjtKNimWnxYsLtxLlAw52HESpNFc=;\n b=Cp8ZzjvVNj5FPw5N3cEE+ZmgWQMVQSPDW+bEMmGtZnq+gqWU5phZzjE+/JJLUZBuuO\n ioeoIl5aapS474+wics7P/xvISgYCmJ1KZ4WGN8lduSNqBVV5Zj7H+rTIgXZHmd/DN4R\n EYutQr7sUlCggCuNw0pArQgqs4ornON9IhXwXxSrBHCWVsb+5zHRFBfq2leVB2Tb+UYV\n B+fln9t9XqbJRkLVdD0etUfwgoH2L9On62aGZbfYX2/j9yWUGL3lb0QkN3zF+KNf0But\n enFPASnVZGgVB/xTDEuuS+Lc0cZnyMuO4ntKYUaPad24iB3ROhfJdgV12OniFssrqTVy\n OfHg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUGj/HeYxMhQoBRlpy+8vdYp1O+ADMGGgpV7YXz8wAeeG9fLflSMm4WSSO+qfUtlPNl/WdyoJOcA1P2@nongnu.org","X-Gm-Message-State":"AOJu0YyAjiznbXfRpY0XnHyVIj9w4nRyQfspDMoCWZnuD5w9r6Mac+y7\n lk2oFlkkrChr7vSmYudjlJFPdqJx5Nf8IF3Gwoy6EEAF+5fIpJl5uXg/QmngVIDTHcw=","X-Gm-Gg":"AeBDiesbpo4q7YiXDbcLtXXIVHBFERRHSSOuUdulmwN/Sd6zAaRSmrzh6kTVLeTIWsC\n gbYc2x1O69OTU+t8B4gBx3pDmiy8gtqBSzfMZA5GxdrK+B2VnHs5Kc8gRVtI+bOlcJdmFHKSSmC\n h7zP5k4iy1OwAY7PX2JIqTqsI4KWrQNeG1g1CjEBKpD9uP9uvlNYPFnnVHyZdl9o/FOqo4vDa01\n gTUBqfuddgysUs/rQ2CWT31QqyZm+tG8qDtrmFSG2LGxIOe9tZ9ehgXcOukUVJT94i8E+/nMvdA\n zHrt3bBsuTnVA72UnH8x37aMMQx3OWJwJc8zGYTzZtQ4PjmV5OtnAB6TZ17FfAVwrNsyLhBeI1Q\n gaOjQYKrDHKGQLpfBWRspUEyDbLEOj8smmKVPkAQhqSe75qsrf5+/rWwmnDBk4BI1G1CVoTsq++\n foSstVu/wb+TfPslF8T0l8ishS2IteOad917S9hmD7JqlE/V7qPIRuwvUee7d1ZODiQto=","X-Received":"by 2002:a17:903:1ac3:b0:2b0:673a:7c85 with SMTP id\n d9443c01a7336-2b2818ee1f6mr145864265ad.37.1775515473404;\n Mon, 06 Apr 2026 15:44:33 -0700 (PDT)","Message-ID":"<8e3bcc46-abe2-431b-8fb5-e6d5d8bd0e10@linaro.org>","Date":"Tue, 7 Apr 2026 08:44:26 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v8 18/20] target/arm/tcg/translate.c: remove target_ulong","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , jim.macarthur@linaro.org,\n Paolo Bonzini , philmd@linaro.org, qemu-arm@nongnu.org","References":"<20260406182609.193886-1-pierrick.bouvier@linaro.org>\n <20260406182609.193886-19-pierrick.bouvier@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260406182609.193886-19-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]