[{"id":3674361,"web_url":"http://patchwork.ozlabs.org/comment/3674361/","msgid":"<CAMxuvazscrXMNc+VV_jpTLY1aRjCKAbmBoZ-LCcsZ-4iazBfvg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-07T07:49:54","subject":"Re: [PATCH v3 01/10] hw/tpm: Add TPM CRB chunking fields","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Mon, Apr 6, 2026 at 6:18 PM Arun Menon <armenon@redhat.com> wrote:\n>\n> From: Arun Menon <armenon@redhat.com>\n>\n> - Add new fields to the CRB Interface Identifier and the CRB\n>   Control Start registers.\n> - CRB_CTRL_START now has 2 new settings, that can be toggled using the\n>   nextChunk and crbRspRetry bits.\n> - CapCRBChunk bit (10) was Reserved1 previously. The field is reused in\n>   this revision of the specification.\n> - Refer to section 6.4.2.2 of [1]\n>\n> [1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_rc1_121225.pdf\n\nYou may update the link to the released version\nhttps://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_Pub.pdf\n\n>\n> Signed-off-by: Arun Menon <armenon@redhat.com>\n> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>\n\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n\n> ---\n>  hw/tpm/tpm_crb.c      | 3 +++\n>  include/hw/acpi/tpm.h | 5 ++++-\n>  2 files changed, 7 insertions(+), 1 deletion(-)\n>\n> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\n> index 8723536f93..0a1c7ecdc6 100644\n> --- a/hw/tpm/tpm_crb.c\n> +++ b/hw/tpm/tpm_crb.c\n> @@ -59,6 +59,7 @@ DECLARE_INSTANCE_CHECKER(CRBState, CRB,\n>  #define CRB_INTF_CAP_FIFO_NOT_SUPPORTED 0b0\n>  #define CRB_INTF_CAP_CRB_SUPPORTED 0b1\n>  #define CRB_INTF_IF_SELECTOR_CRB 0b1\n> +#define CRB_INTF_CAP_CRB_CHUNK 0b1\n>\n>  #define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER)\n>\n> @@ -262,6 +263,8 @@ static void tpm_crb_reset(void *dev)\n>                       CapCRB, CRB_INTF_CAP_CRB_SUPPORTED);\n>      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n>                       InterfaceSelector, CRB_INTF_IF_SELECTOR_CRB);\n> +    ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n> +                     CapCRBChunk, CRB_INTF_CAP_CRB_CHUNK);\n>      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n>                       RID, 0b0000);\n>      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID2,\n> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h\n> index d2bf6637c5..03d452d2b5 100644\n> --- a/include/hw/acpi/tpm.h\n> +++ b/include/hw/acpi/tpm.h\n> @@ -149,7 +149,7 @@ REG32(CRB_INTF_ID, 0x30)\n>    FIELD(CRB_INTF_ID, InterfaceVersion, 4, 4)\n>    FIELD(CRB_INTF_ID, CapLocality, 8, 1)\n>    FIELD(CRB_INTF_ID, CapCRBIdleBypass, 9, 1)\n> -  FIELD(CRB_INTF_ID, Reserved1, 10, 1)\n> +  FIELD(CRB_INTF_ID, CapCRBChunk, 10, 1)\n>    FIELD(CRB_INTF_ID, CapDataXferSizeSupport, 11, 2)\n>    FIELD(CRB_INTF_ID, CapFIFO, 13, 1)\n>    FIELD(CRB_INTF_ID, CapCRB, 14, 1)\n> @@ -168,6 +168,9 @@ REG32(CRB_CTRL_STS, 0x44)\n>    FIELD(CRB_CTRL_STS, tpmIdle, 1, 1)\n>  REG32(CRB_CTRL_CANCEL, 0x48)\n>  REG32(CRB_CTRL_START, 0x4C)\n> +  FIELD(CRB_CTRL_START, invoke, 0, 1)\n\nAny reason to diverge from the spec \"Start\" naming here?\n\n> +  FIELD(CRB_CTRL_START, crbRspRetry, 1, 1)\n> +  FIELD(CRB_CTRL_START, nextChunk, 2, 1)\n>  REG32(CRB_INT_ENABLED, 0x50)\n>  REG32(CRB_INT_STS, 0x54)\n>  REG32(CRB_CTRL_CMD_SIZE, 0x58)\n> --\n> 2.53.0\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aKETjzme;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=WuZExjdt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqwsG1cxyz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 05:16:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wABXF-000070-TX; Tue, 07 Apr 2026 14:52:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mlureau@redhat.com>)\n id 1wABTw-0002LR-Jt\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:49:00 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mlureau@redhat.com>)\n id 1wA1CM-0001J8-D9\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 03:50:12 -0400","from mail-pg1-f200.google.com (mail-pg1-f200.google.com\n [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-581-6i4XUjr-NCK6TDY4md18Ig-1; Tue, 07 Apr 2026 03:50:07 -0400","by mail-pg1-f200.google.com with SMTP id\n 41be03b00d2f7-c741b950511so2559060a12.0\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 00:50:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775548209;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ZvobOrqEAkaiqENsEomLroTZGJRyqRO8/LE7QH9QcTM=;\n b=aKETjzmeUXVFTFoexmG9o88B2/GD5MzFzCsiJfxRGBhVzIrXsjHf3T6Ged0HtFgA4MbKkh\n +WzC7wL6enTcQ9SAbWpYf3TJw5QvbNgYa16GGbeuCAaKBj9buM5a1m/jei0dlUuw8aOno1\n xrEqhJFgah5lNOybfdx5rr3MkuqhsjA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775548206; x=1776153006; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZvobOrqEAkaiqENsEomLroTZGJRyqRO8/LE7QH9QcTM=;\n b=WuZExjdtJAjG1sy+p9yH5/b/ZiqP8aUwmA28CfrDeeaNaurQ+YYJvVx8mL8XfLQQWN\n LyaaorQadv1DeWu64+pMfQW8n5y93JsLHDGhyosubdbk+Olh/5NOV9mxYL7BbZGlgiPi\n K96BdJd2m1022SL4rwcTb6ys9et7ImzRAO7ohNqnsr1Xt7vcymhqwKWdPInFKDx2ZfEM\n +mUuQKhpriFpKgL/t7Q3ptO8AJtocLO5l/f8GnfDW/JJTNWExqweXU2dm6ts9OZppiQh\n rx7jpg0oZ/fkJEpuLCmrO+BW8cXSfEK32tVQPL/UcEGvE+EA/8p75La84jmccrLSlNJy\n tb5A=="],"X-MC-Unique":"6i4XUjr-NCK6TDY4md18Ig-1","X-Mimecast-MFC-AGG-ID":"6i4XUjr-NCK6TDY4md18Ig_1775548207","ARC-Seal":"i=1; a=rsa-sha256; t=1775548206; cv=none;\n d=google.com; s=arc-20240605;\n b=hqmdTCqztbwdF1CzJjU9uFasJKyaHKYKOXiRunNL3nu4Fyd29PpvPNcnGHx1wYlpI7\n pGtzd2MNjL0yRLAhZK2MQnBkeiV1fPpXjz8HQJppKEmN7eeQMfnDPq4BVo14HOYn0h8O\n yWgXxCTxzYHc4R6clHgMaiWCu6YuGCtfoKIRXfTEipTrTNECX3TqZB6tee2F6FTYDXkJ\n u6a5Un/NnXwnqHUasPlvqxCA2Ga2mkcdFUvm3LgnWnqzUaLqAcSsNvZxgHp9MX6bLH/e\n L3YlqW1yXQL2GCAXLy2HbZEC4Q2BrGjaCp+UbgiqTkkyqZQf6z5H7Qq/aqL0aP2oxzXL\n MiYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=ZvobOrqEAkaiqENsEomLroTZGJRyqRO8/LE7QH9QcTM=;\n fh=I3Rojz7Rj7F7zAuh27Zv7NEdlY6RHgtmEIjZ7Qkr/EI=;\n b=dG45oXpi5t5kMos/4NbAuxhQS+GejfQFjIY1N1kwvKyH7OxG5w3mKWuj8PMCqx+dVl\n IlDqFTi9/lx5T7YjfxgcnOgIrTK1IAzb0rUZFdcmkS0YV+uXm6k0GcT95U3v4WlZWuoq\n cShJbp8fnZV5SLYph1YJpzmFKLYGVmwM/2cLr34P4YsPfgT+pLFWvtvZcNfUjWsEYIcO\n eq3e2AcigYXTwfF0gQm+o8hTyA0zTIk40LFnGnVHbp7ClPbqiTdkxqqZAkFonAffAc/v\n x1aZn17hGAUMdjRfSx/1a7r15ppw9DtPkTbMasgOzpFQP7ZT63b/whLbqjrY9Ik99f3x\n Uz1Q==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775548206; x=1776153006;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZvobOrqEAkaiqENsEomLroTZGJRyqRO8/LE7QH9QcTM=;\n b=BfchatWQaZu5e0ZD63ug7DThcwgZl7KLWEtbcYdkjP6JZ58Jj+RCMCjkPhqSVWwtSG\n mrLThhI+q4aLPuSlpJ5b6YuEtPSPPhSAVQQjfRotsAKGWUHa9tRksNfWcnKA1wuR5wew\n hHUEnDo169uoIunX56/b253C+MgkDJ/hwmafo73FDcFlvb0nrsUwlpjw7ejCauZgIJlK\n K3N5P5GPd2xkrmYOO0DTmmvAChgDd0QxGqoy8IP8ag4PIXSBFQXzkRPTBra+A81YQHl3\n TjwgSAZsrLQCmlKIWupSpX42H6QIjHsDEwQqCJZjzVl4pMlG2vc2w2R3j+RCDrYGyI+y\n xSCA==","X-Gm-Message-State":"AOJu0Ywt80VnDzNutnnKAuFFyRNyf2UsS33ZhK1ndniSePaF9laa/v9N\n sAFLNeOTw6C58Z+rZybB1SbpNjuk5Xt5i+f3EFReJj0hA0jCRWvlDm/7bni8qfczwRNYBiHQkBY\n xBAxi87dqe8ln/p+H5E0I8aBFwI8zPq+LVQ8UOiacCGg3hmpoOWnDGx7CYrdYSNpTkAHHKVXDuu\n d+W4bmWOWNy97YQVWkrkzhxTIAJUeOWoc=","X-Gm-Gg":"AeBDies/EiXZe/mN1vU1nIxlxFZM13fj3UOqlWNHYKRVe9yPF4r/gmd6J4XDNMAEVK1\n 0niZ2i54kSUgVT6shRLkgAR4PNHqKwzpbkO+rRN+FkmRFpUMTO8LgIlkPitNYRQKiwXpHTjITHN\n OUYCSLPRDMor6YE7oowZKTedNc2YNJ4rJRK8sU9ApGQ2V2mBJBv3E4SLtS1NknLfQcRpiDcdvV2\n Mvb+lnsW/PNfCCAs0V0JgFr5BKOOFfWIgQzvTu/+aPUO0QuDsooaMkltdpkjzI8xN4u6XXb+vqj\n akYQKswZ4Pti23+m7c7ihVU=","X-Received":["by 2002:a05:6a20:a11a:b0:398:c170:1c7 with SMTP id\n adf61e73a8af0-39f2f12b4f9mr16041170637.26.1775548206523;\n Tue, 07 Apr 2026 00:50:06 -0700 (PDT)","by 2002:a05:6a20:a11a:b0:398:c170:1c7 with SMTP id\n adf61e73a8af0-39f2f12b4f9mr16041148637.26.1775548206065; Tue, 07 Apr 2026\n 00:50:06 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260406141735.25844-1-armenon@redhat.com>\n <20260406141735.25844-2-armenon@redhat.com>","In-Reply-To":"<20260406141735.25844-2-armenon@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Date":"Tue, 7 Apr 2026 11:49:54 +0400","X-Gm-Features":"AQROBzDtwowtje3Ysgx5ZrasJVXquCi1HvuR-yY3xK0f6JBPSt7--7MiuVf7900","Message-ID":"\n <CAMxuvazscrXMNc+VV_jpTLY1aRjCKAbmBoZ-LCcsZ-4iazBfvg@mail.gmail.com>","Subject":"Re: [PATCH v3 01/10] hw/tpm: Add TPM CRB chunking fields","To":"Arun Menon <armenon@redhat.com>","Cc":"qemu-devel@nongnu.org, Ani Sinha <anisinha@redhat.com>,\n  Laurent Vivier <lvivier@redhat.com>, Zhao Liu <zhao1.liu@intel.com>,\n  Stefan Berger <stefanb@linux.vnet.ibm.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n  Paolo Bonzini <pbonzini@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n  \"Michael S. Tsirkin\" <mst@redhat.com>, Yanan Wang <wangyanan55@huawei.com>,\n  Igor Mammedov <imammedo@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n  Stefan Berger <stefanb@linux.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677673,"web_url":"http://patchwork.ozlabs.org/comment/3677673/","msgid":"<CAE_eyq9QqcsQcRY53rH5tbBhnYNWtXHYjQUQu7HKpGtDQOaoHw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-15T13:35:11","subject":"Re: [PATCH v3 01/10] hw/tpm: Add TPM CRB chunking fields","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/","name":"Arun Menon","email":"armenon@redhat.com"},"content":"On Tue, Apr 07, 2026 at 11:49:54AM +0400, Marc-André Lureau wrote:\n> Hi\n>\n> On Mon, Apr 6, 2026 at 6:18 PM Arun Menon <armenon@redhat.com> wrote:\n> >\n> > From: Arun Menon <armenon@redhat.com>\n> >\n> > - Add new fields to the CRB Interface Identifier and the CRB\n> >   Control Start registers.\n> > - CRB_CTRL_START now has 2 new settings, that can be toggled using the\n> >   nextChunk and crbRspRetry bits.\n> > - CapCRBChunk bit (10) was Reserved1 previously. The field is reused in\n> >   this revision of the specification.\n> > - Refer to section 6.4.2.2 of [1]\n> >\n> > [1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_rc1_121225.pdf\n>\n> You may update the link to the released version\n> https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_Pub.pdf\n>\n> >\n> > Signed-off-by: Arun Menon <armenon@redhat.com>\n> > Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>\n>\n> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n>\n> > ---\n> >  hw/tpm/tpm_crb.c      | 3 +++\n> >  include/hw/acpi/tpm.h | 5 ++++-\n> >  2 files changed, 7 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\n> > index 8723536f93..0a1c7ecdc6 100644\n> > --- a/hw/tpm/tpm_crb.c\n> > +++ b/hw/tpm/tpm_crb.c\n> > @@ -59,6 +59,7 @@ DECLARE_INSTANCE_CHECKER(CRBState, CRB,\n> >  #define CRB_INTF_CAP_FIFO_NOT_SUPPORTED 0b0\n> >  #define CRB_INTF_CAP_CRB_SUPPORTED 0b1\n> >  #define CRB_INTF_IF_SELECTOR_CRB 0b1\n> > +#define CRB_INTF_CAP_CRB_CHUNK 0b1\n> >\n> >  #define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER)\n> >\n> > @@ -262,6 +263,8 @@ static void tpm_crb_reset(void *dev)\n> >                       CapCRB, CRB_INTF_CAP_CRB_SUPPORTED);\n> >      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n> >                       InterfaceSelector, CRB_INTF_IF_SELECTOR_CRB);\n> > +    ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n> > +                     CapCRBChunk, CRB_INTF_CAP_CRB_CHUNK);\n> >      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n> >                       RID, 0b0000);\n> >      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID2,\n> > diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h\n> > index d2bf6637c5..03d452d2b5 100644\n> > --- a/include/hw/acpi/tpm.h\n> > +++ b/include/hw/acpi/tpm.h\n> > @@ -149,7 +149,7 @@ REG32(CRB_INTF_ID, 0x30)\n> >    FIELD(CRB_INTF_ID, InterfaceVersion, 4, 4)\n> >    FIELD(CRB_INTF_ID, CapLocality, 8, 1)\n> >    FIELD(CRB_INTF_ID, CapCRBIdleBypass, 9, 1)\n> > -  FIELD(CRB_INTF_ID, Reserved1, 10, 1)\n> > +  FIELD(CRB_INTF_ID, CapCRBChunk, 10, 1)\n> >    FIELD(CRB_INTF_ID, CapDataXferSizeSupport, 11, 2)\n> >    FIELD(CRB_INTF_ID, CapFIFO, 13, 1)\n> >    FIELD(CRB_INTF_ID, CapCRB, 14, 1)\n> > @@ -168,6 +168,9 @@ REG32(CRB_CTRL_STS, 0x44)\n> >    FIELD(CRB_CTRL_STS, tpmIdle, 1, 1)\n> >  REG32(CRB_CTRL_CANCEL, 0x48)\n> >  REG32(CRB_CTRL_START, 0x4C)\n> > +  FIELD(CRB_CTRL_START, invoke, 0, 1)\n>\n> Any reason to diverge from the spec \"Start\" naming here?\n\nNo reason; I think I should stick to spec. I saw cancel invoke and I\nthought start should also have an invoke.\nI will change it to FIELD(CRB_CTRL_START, start, 0, 1)\n\n>\n> > +  FIELD(CRB_CTRL_START, crbRspRetry, 1, 1)\n> > +  FIELD(CRB_CTRL_START, nextChunk, 2, 1)\n> >  REG32(CRB_INT_ENABLED, 0x50)\n> >  REG32(CRB_INT_STS, 0x54)\n> >  REG32(CRB_CTRL_CMD_SIZE, 0x58)\n> > --\n> > 2.53.0\n> >\n>\n\nRegards,\nArun Menon","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aIsg7t/E;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=LiBXDZUq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwhxj4qQRz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 23:36:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wD0PN-0003Tu-KK; Wed, 15 Apr 2026 09:35:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wD0PL-0003TN-DE\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 09:35:55 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wD0PJ-0006Pz-OW\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 09:35:55 -0400","from mail-oa1-f72.google.com (mail-oa1-f72.google.com\n [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-636-oen-oT7IMMe_BNT-UUH_Hg-1; Wed, 15 Apr 2026 09:35:50 -0400","by mail-oa1-f72.google.com with SMTP id\n 586e51a60fabf-42467c9547bso1663420fac.0\n for <qemu-devel@nongnu.org>; Wed, 15 Apr 2026 06:35:50 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776260153;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OZgxnJiKlhpfgg42CnMY+u7qWO3b1+KZaeAjDVG+U9g=;\n b=aIsg7t/E+gRI2MJTN3m52r/Ia08OYEsRVpOVCm2ZT5ShufoK/eYGD3f3N5Cs91ImUsPhZg\n 816dzET5kzD4YL6cJ6KrIiyNPTcJXJLnf6bpesudx3JENlCHsvgD/R2xd+/qVdGY9nFl8q\n jWBs/C9O0YmFP/a7VIPdLOmPKu5MAKo=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776260149; x=1776864949; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OZgxnJiKlhpfgg42CnMY+u7qWO3b1+KZaeAjDVG+U9g=;\n b=LiBXDZUqXenM9fJOcB0qOSXq79rHfVG03azufO8KA+Tqp1BP1+V0NjSrvp5nQcmI6N\n 7n9DgeFb1p+1mJAFvAgNkp7MZW1fXmArOLKkF/VLOsQnSUxuxoTL/99CmF0ENSMrW21e\n PKRWJHnr0Cts09Ub8o5ueXx7FRQ+QjWDY4+e3ZCEK5fzJlp6GI/fapH4Tz7cKDjT8eq8\n zMrrNarwGrMuvVQbne3oG5zg7NwBxz4Eh4/LI9pgr0yanQOPIcfqhmiDTEPuOBnGlYvx\n MoXua9eBq+AkjEHBGdL6c8f/ulcGML524XQLAI+XayDqq28WeveNf/J9hzlB0ctnUomj\n a9Vw=="],"X-MC-Unique":"oen-oT7IMMe_BNT-UUH_Hg-1","X-Mimecast-MFC-AGG-ID":"oen-oT7IMMe_BNT-UUH_Hg_1776260150","ARC-Seal":"i=1; a=rsa-sha256; t=1776260149; cv=none;\n d=google.com; s=arc-20240605;\n b=bxCnPFWvjiUi79+s4BGFRFbsDmICiPLLMyxgATZF/WIxroCVUS4atg25RYr0W2cJfx\n NG5TDS/kuQ+4YKTTkdNV80YMBjOuklrOeXqHGvIi7tYfnORI9sLLScGnR/tlsugePSEm\n YwUwj50Tuj/40bAm3JyRIAmcS9WtoTwzD3D0hygaE67VLqiP1swrGuJKqMTqUd+bRCRB\n dmNbFyHJSnTubnJoxupAYJ0B4H/YFmLV7lx98gETdSFynz/egrcGcBgnQJpRlSOMWoxU\n N+yqmY3WoP6Q5GXJUbEWwFIz2J5RiM8VXn2hUzy9rREChWA6C2QRRuUBtD4sCTbEJBdl\n H7/Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=OZgxnJiKlhpfgg42CnMY+u7qWO3b1+KZaeAjDVG+U9g=;\n fh=Xrp2glQicIvkcDLzKDtQ4JXqZnWs2rFpNaCudBPk6pA=;\n b=GvWQyEDd9Bj+IYWo8zxA7vw9pL6n1MlUcRydfWZQT+LptO15cpLpnQYSVo4smeXar2\n aMydlt3pyyFDcs4Tswl+rxBB/ggayhP8gK/pvbAcaEVTYa6YHLwRwBnFAyy4ezQ3PNwB\n CNmYQMOnccylnAuTP3s4MlZGG/aWSXymaOABtb7FT+raXwYJ/cLegVX/J/ymNUySijBM\n 9yg/RQ7jvvDUc3NA3jzU24VYCqayA6Z+/okCh6xavbid20VRd33bDaYzssIb1n+fYzMQ\n PDfnWKt1qeA4JlA2DJdMZQ8CtmmQs+kw4OEM1e1r9agkxT8cW0kBFgKidxNywd4ouj8J\n WBow==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776260149; x=1776864949;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=OZgxnJiKlhpfgg42CnMY+u7qWO3b1+KZaeAjDVG+U9g=;\n b=duzfBt7sjxD9jUE5ppzoQkLEkDgVMtjUi0br3A1TqVkETD6hdtkUTZ1zKIMMt04mTg\n 8AW2kFTGSRkvQkBh59na2IiSMaF9QURP6lDHtYBWLYyDMY4qlaXwiFvotzGk2GP1ibSA\n ksXouXDDY2x8SfFAlPxKQscb3gx53C4XFGOFMSnBWKUetgjU8t9x+Cwb5HHEIE26703p\n Qb3GKsOVflky4jaljo+Si0ZkPVJeadGmbrjW0Ngbr+0PyjVhLaPed5rZPwEGqQHDaomb\n osqZgRLTiO0i1p157VqjrEIEzKZ3DOvgY4xwF3KlcJw9mXlYP2CiiJR5XjrH4pMAhFS3\n lUKA==","X-Gm-Message-State":"AOJu0YyDAaASoPxFa7ikRBTl+K6C5aWrRbmR3e+XBqwTELB1S27wr+87\n 7hj93iuiKbUgOkzJZNxdyb3BpLNESRWT8VI/JfYEJ2mJ4G8pok6819EJoSJshBnjTrGiQrwtpee\n fJ1D/pdeK/XVuEFvuMsd8WB09qFRHBwrCGxKc3gi5+RuBadgvZFs8ZVtmq/D+3UgJnPeupAhDfI\n 0kGOjOWTIq2lpBIaz1XOdHEmAURpzWs/Q23Zol9nM=","X-Gm-Gg":"AeBDieuzptFgQV+kkoKJWwIO00UXddaJ1cvKM5ZA371EXa32g+T3TF7vlJb2QcVHjgQ\n fzJue8NQRFM2tzgN4NhYyISj1Yly+/2fgPD/r1JwrFjSBhaddOIQa32HDzOmk/cR7TIZ3OFutAr\n irSNn9eh64yUeTzTJCte3hq4mO+4D5ZDFh+qtdYAemgc7JsnZzkmK1cPYHXDXnscB+VzhncdiCz\n yeh3dqx7nrlOvxdo7CpxggmJx3lx14aqpGe2kI3wEySRg==","X-Received":["by 2002:a05:6820:16a8:b0:68d:9ba5:de27 with SMTP id\n 006d021491bc7-68d9ba5e476mr7838362eaf.56.1776260149268;\n Wed, 15 Apr 2026 06:35:49 -0700 (PDT)","by 2002:a05:6820:16a8:b0:68d:9ba5:de27 with SMTP id\n 006d021491bc7-68d9ba5e476mr7838345eaf.56.1776260148811; Wed, 15 Apr 2026\n 06:35:48 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260406141735.25844-1-armenon@redhat.com>\n <20260406141735.25844-2-armenon@redhat.com>\n <CAMxuvazscrXMNc+VV_jpTLY1aRjCKAbmBoZ-LCcsZ-4iazBfvg@mail.gmail.com>","In-Reply-To":"\n <CAMxuvazscrXMNc+VV_jpTLY1aRjCKAbmBoZ-LCcsZ-4iazBfvg@mail.gmail.com>","From":"Arun Menon <armenon@redhat.com>","Date":"Wed, 15 Apr 2026 19:05:11 +0530","X-Gm-Features":"AQROBzACRi4jHsRjCjqcLutU4nHp-Jl0oT6DIy9403R2yIU_hKfI99zCFZkZ2LU","Message-ID":"\n <CAE_eyq9QqcsQcRY53rH5tbBhnYNWtXHYjQUQu7HKpGtDQOaoHw@mail.gmail.com>","Subject":"Re: [PATCH v3 01/10] hw/tpm: Add TPM CRB chunking fields","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Cc":"qemu-devel@nongnu.org, Ani Sinha <anisinha@redhat.com>,\n  Laurent Vivier <lvivier@redhat.com>, Zhao Liu <zhao1.liu@intel.com>,\n  Stefan Berger <stefanb@linux.vnet.ibm.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n  Paolo Bonzini <pbonzini@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n  \"Michael S. Tsirkin\" <mst@redhat.com>, Yanan Wang <wangyanan55@huawei.com>,\n  Igor Mammedov <imammedo@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n  Stefan Berger <stefanb@linux.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]