[{"id":3674430,"web_url":"http://patchwork.ozlabs.org/comment/3674430/","msgid":"","list_archive_url":null,"date":"2026-04-07T07:50:51","subject":"Re: [PATCH v3 02/10] hw/tpm: Refactor CRB_CTRL_START register access","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Mon, Apr 6, 2026 at 6:18 PM Arun Menon wrote:\n>\n> From: Arun Menon \n>\n> Replace manual bitwise operations with ARRAY_FIELD_DP32 macros\n> No functional changes.\n>\n> Signed-off-by: Arun Menon \n> Reviewed-by: Stefan Berger \n\nReviewed-by: Marc-André Lureau \n\n(even if we decide to rename invoke->Start)\n\n> ---\n> hw/tpm/tpm_crb.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\n> index 0a1c7ecdc6..bc55908786 100644\n> --- a/hw/tpm/tpm_crb.c\n> +++ b/hw/tpm/tpm_crb.c\n> @@ -145,7 +145,7 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n> tpm_crb_get_active_locty(s) == locty) {\n> void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n>\n> - s->regs[R_CRB_CTRL_START] |= CRB_START_INVOKE;\n> + ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 1);\n> s->cmd = (TPMBackendCmd) {\n> .in = mem,\n> .in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),\n> @@ -194,7 +194,7 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)\n> {\n> CRBState *s = CRB(ti);\n>\n> - s->regs[R_CRB_CTRL_START] &= ~CRB_START_INVOKE;\n> + ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 0);\n> if (ret != 0) {\n> ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,\n> tpmSts, 1); /* fatal error */\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=J7AicINk;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=q0fsuk+c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxLN3f5Zz1yGM\n\tfor ; Wed, 08 Apr 2026 05:37:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wABXH-00008D-Fo; Tue, 07 Apr 2026 14:52:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wABTw-0003Gt-MK\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:49:00 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wA1DH-0001LR-4j\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 03:51:08 -0400","from mail-pg1-f200.google.com (mail-pg1-f200.google.com\n [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-668-BG1DGR4ZMC-x8rkIXZciNA-1; Tue, 07 Apr 2026 03:51:05 -0400","by mail-pg1-f200.google.com with SMTP id\n 41be03b00d2f7-c76c60c74f3so2375630a12.2\n for ; Tue, 07 Apr 2026 00:51:04 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775548266;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RdrQhO95S4U85205xz1Wc4yFHa8mhhW0SsGhPRPQ+eU=;\n b=J7AicINkqTwu5agRSVF+wEn6uduWKLe++ViXOjxCEHyTiVt73WkAXPTQL3nmp50ER2+tJ6\n hmzien3weGxL80ylnZ6g/Co9ONKD/pqjdSNPxjmTpq3kVZpnMxzW/EW+NihjLozV/YTJ8O\n fhnW9kAnjG9EuNxJI31/jkzyoBPtqSQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775548264; x=1776153064; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RdrQhO95S4U85205xz1Wc4yFHa8mhhW0SsGhPRPQ+eU=;\n b=q0fsuk+c10gIBTh5rgLyGYENmmTpFpJDwTHGWmHAR9uKnjmB4zIaDKTbe9jNZUOF/d\n gHYPU8woH6mmo4vfBRIy5xj4QdS4ScfNSHyOPdK7LxveeTlodE2S2vt4p+mPVHQ48YWQ\n 2kyj3bprME9zLi4DRdTdfMUjhpdq17zKKw4U5wLYCgv7rwNeWc3YAADqbuXF+pFOpjAI\n CCHzCEfGL0zIK6yCvcQ9VNeSxQ/q2b7SWumwQjx0An1CU+VlLmC9bCbYXgKSBy4Q210B\n Q0JUNDZBGphRggmO8kjsS08iyP5G86vMP3eG3Ic0HXY2FfdVT/J2LeIqMaTJq4jLqRRq\n UgwQ=="],"X-MC-Unique":"BG1DGR4ZMC-x8rkIXZciNA-1","X-Mimecast-MFC-AGG-ID":"BG1DGR4ZMC-x8rkIXZciNA_1775548264","ARC-Seal":"i=1; a=rsa-sha256; t=1775548264; cv=none;\n d=google.com; s=arc-20240605;\n b=OU6xox5jUr21PH6R46E2FYtapctQOiy6xHesesAlpEaqiWAcs9t6sg5psPeWRIGdrD\n JNHbUky+oEVvn1iFmwd4eMObEDfqQnSE1hYad++5qSN0wL2ZZtaSdFGQIgyE95/RZkbT\n odBMUH1VsVLiCv8h13cHTN09/QTp2n2fqR2MJ+tzoI8J0y++jPwsZaCyIkrofW3RcYqd\n U2laVxQ0yDA0Mw1Z9FH48rW378BWnd49JLRBnlK+609G+agR36VmGzirfpszQJRFwbEF\n Nqq/k1AgfFb/k73iL5J9Gluxf7Ax5Fl2L26Vmb7uJR8kGSy/b89HtydaqDZhCFGN7i3w\n KdaQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=RdrQhO95S4U85205xz1Wc4yFHa8mhhW0SsGhPRPQ+eU=;\n fh=I3Rojz7Rj7F7zAuh27Zv7NEdlY6RHgtmEIjZ7Qkr/EI=;\n b=H60/ODUPyQdXA2GzS27GVTekbf+RcvmV73ze+bkilDctlVV/zDC7eqQjnkjn68Hzhe\n F6FbFVfRbejcXQkpuOndoZuGHQHHt3MaTy+RxFbSeIJzLY5x05/mBM3HcE2bhLLFsgyF\n D+WYc5oCbRkqF5Eol59FYB25MJOYvYj2MZ83avzHi/eLt8MkUrZAZ6K8KPOlDDjjsp+i\n +IwchB8L7nnkaLAw03ROraWZbZ6U7BpLVAbf7zZrpyl+sjZ/hlybWU6B2/FJ0+U4AZCc\n GRIH23GZ6LIdyG2f9kU7V+dzRKqBJNVC6HLXtin9cDXD228/yeqc9DWOc33Dhhqbkqca\n nQhA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775548264; x=1776153064;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=RdrQhO95S4U85205xz1Wc4yFHa8mhhW0SsGhPRPQ+eU=;\n b=UVqPLttKYxbIkG2A4SOBJbm+0keTKH3L+0LAfGaJ7qLiaKFjai0aQK2hIQ4SBG5ZgI\n AD4NAi4Kdvy/vu93N7P7XroaegLs4WS4wo1S0cz9H/PIL8mYznVIr6LsYIclP9L2XI/L\n aT4K8ObjJbahOhKc1bD2jt+379fPHJMHu33YLBbiSKFL+XIZ9N14E1t52C113ggSvRXb\n ZaeZrq2YjBMf18VCxac8kIFkq3vsPMlV/gZTvLSjBdS9E4WGxgOAHkLrznd1d2jPWKOy\n D4wEN5sBNU19Y+sUs3oRQNWerFJVCU/XPwPNkIqM4VAd93GutcrICn6P2kg4+YQaHvgL\n 0gUw==","X-Gm-Message-State":"AOJu0YxXkWAoOMJCezX0lkpe7SiFl9zXsENyIWMQXNLI9I7lAhplIPGM\n OaD0d4NeVujlS+z957DVx92GnV5PTMD9VJnnYD+F8UWm+L0F33nvJaId6x+UymEG7dBSFjaB2xY\n QuHP/RQNCgf9c3+xPviRNI5AC2piMXH2/LScldJSQ/6n/DOgtpW0JadcRE7YIyq6+GVBAV2DqKF\n GYakvs7Wm8AU4peMLbxmSy6YT5XbSQ4IE=","X-Gm-Gg":"AeBDiesdmDleHg7oTYK56PtPb8PRuuzWHgfO9M4cHjfNNg4a6x1ExzeDnSOhcybRvuK\n bzjtPj4LK9DF/NMDjcNgVcGEjYi9QRvDyt8GNTTteyE222VLJGGpkmhPJIzC2AKlRDKh34YvfuS\n 3Rp8Sk6sKtv0JVisW/VA2rB3OMfAhskCqUsXKLiQ2EOA6rlY/jNhfNYnvOHS/xLKhtSYSOGnhX7\n pQL3y8Bjkm3+2Sp9dnAGMSH9bgEfagTLuwQ6aBJm6LKU+saO7ttgetZntYS5za8It3QAO1dS6Vc\n D3M5eAZ1X6sLpQfZI46k6cI=","X-Received":["by 2002:a05:6a20:2595:b0:398:abe1:eaac with SMTP id\n adf61e73a8af0-39f2f060b86mr15259264637.27.1775548263751;\n Tue, 07 Apr 2026 00:51:03 -0700 (PDT)","by 2002:a05:6a20:2595:b0:398:abe1:eaac with SMTP id\n adf61e73a8af0-39f2f060b86mr15259230637.27.1775548263326; Tue, 07 Apr 2026\n 00:51:03 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260406141735.25844-1-armenon@redhat.com>\n <20260406141735.25844-3-armenon@redhat.com>","In-Reply-To":"<20260406141735.25844-3-armenon@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 7 Apr 2026 11:50:51 +0400","X-Gm-Features":"AQROBzDxderAXKoCorFDXfHCCe2AtaxkBMIVVJCe19F0dVpjP86G6mfCI2tMUi4","Message-ID":"\n ","Subject":"Re: [PATCH v3 02/10] hw/tpm: Refactor CRB_CTRL_START register access","To":"Arun Menon ","Cc":"qemu-devel@nongnu.org, Ani Sinha ,\n Laurent Vivier , Zhao Liu ,\n Stefan Berger ,\n Marcel Apfelbaum ,\n Paolo Bonzini , Fabiano Rosas ,\n \"Michael S. Tsirkin\" , Yanan Wang ,\n Igor Mammedov ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Stefan Berger ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]