[{"id":3673760,"web_url":"http://patchwork.ozlabs.org/comment/3673760/","msgid":"","list_archive_url":null,"date":"2026-04-06T14:38:42","subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","submitter":{"id":92757,"url":"http://patchwork.ozlabs.org/api/people/92757/","name":"Baokun Li","email":"libaokun@linux.alibaba.com"},"content":"On 2026/4/6 15:48, skoyama.kernel@gmail.com wrote:\n> From: Sohei Koyama \n>\n> The commit c8e008b60492 (\"ext4: ignore xattrs past end\")\n> introduced a refcount leak in when block_csum is false.\n>\n> ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to\n> get iloc.bh, but never releases it with brelse().\n>\n> Fixes: c8e008b60492 (\"ext4: ignore xattrs past end\")\n> Signed-off-by: Sohei Koyama \n> Reviewed-by: Andreas Dilger \n> Reviewed-by: Ritesh Harjani (IBM) \n> Cc: stable@vger.kernel.org\n\nLooks good, feel free to add:\n\nReviewed-by: Baokun Li \n\n> ---\n> fs/ext4/xattr.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c\n> index 7bf9ba19a89d..19c72e38fb82 100644\n> --- a/fs/ext4/xattr.c\n> +++ b/fs/ext4/xattr.c\n> @@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n> {\n> \tstruct inode *ea_inode;\n> \tstruct ext4_xattr_entry *entry;\n> -\tstruct ext4_iloc iloc;\n> +\tstruct ext4_iloc iloc = { .bh = NULL };\n> \tbool dirty = false;\n> \tunsigned int ea_ino;\n> \tint err;\n> @@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n> \t\t\text4_warning_inode(parent,\n> \t\t\t\t\t \"handle dirty metadata err=%d\", err);\n> \t}\n> +\n> +\tbrelse(iloc.bh);\n> }\n> \n> /*","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=G084E1Qj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=9000=cf=vger.kernel.org=linux-ext4+bounces-15651-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.alibaba.com","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=G084E1Qj;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15651-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.alibaba.com\n header.i=@linux.alibaba.com header.b=\"G084E1Qj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=115.124.30.130","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.alibaba.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.alibaba.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBmg16vhz1xy1\n\tfor ; Tue, 07 Apr 2026 00:39:29 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fqBmd3G2fz4wC3\n\tfor ; Tue, 07 Apr 2026 00:39:29 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fqBmd3619z4wCG; Tue, 07 Apr 2026 00:39:29 +1000 (AEST)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fqBmY46S4z4wC3\n\tfor ; Tue, 07 Apr 2026 00:39:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2A594300825E\n\tfor ; Mon, 6 Apr 2026 14:39:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C3930199D8;\n\tMon, 6 Apr 2026 14:39:19 +0000 (UTC)","from out30-130.freemail.mail.aliyun.com\n (out30-130.freemail.mail.aliyun.com [115.124.30.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 191673845C8;\n\tMon, 6 Apr 2026 14:39:14 +0000 (UTC)","from 30.42.44.119(mailfrom:libaokun@linux.alibaba.com\n fp:SMTPD_---0X0WsweH_1775486331 cluster:ay36)\n by smtp.aliyun-inc.com;\n Mon, 06 Apr 2026 22:39:04 +0800"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775486369; cv=pass;\n\tb=pJ4XsGM7mKn3+ce4F3QBNENytER9z8W3uJGrvNWSXXJcLjrehszojweXDj01wrNQUWOt09Mz3AaGHN0joolQuCASZ2a8yYN8xAhcCJTvAB+e8HRq3kg0f+2wVWoY02n57IZEhOI8enl+8enXr9z4ofS8vVnBk18aEZAMxz7Sl2fa85BJPtI5tOqbQjyi6iCe4p6K/XIgQZO1p39z56SZPYCQry96npfQeiYmjnP/QnKTMRSVvJNndjLDNy+x4vmRCfV0zsJ5JStDzYKCfbz4/JGZoGUJHCiiZDT4b6unqz96TdPh6e4z/Q5HR7tQReHH69I31+SFy+Ls5rf3qRPORQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775486359; cv=none;\n b=F+BtEv/ELW7II9Mf7mSY26V6cVdfaLOFY3dqYWMqQpwh9KnAi2nRxCiGCOkIJdAfndAp/nzfYm9jsY7lc6rB8m0d6xDa6gG5DKY6UV18eStHWwXuSbNiCo+X4BsjwM/Qrb4XTTX8Sr41ZUzV289KbzUKAqiYK7dOleyBcalRCqw="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775486369; c=relaxed/relaxed;\n\tbh=D/rWtsmoe7dbMfLCdG9NTFNTxZ8ltntqEvtD01Di4K0=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=PoFvuv1sKGQb5LHbn92B82zqyPDPqYAAY/53DHXMsyM1fCzRB9yuEEUjfliNz5fIFvIzss0wIoJOfgCunSgQUMVU09hlMvhahGrSZYQVe2bL8wqgeoZrUtuUVXiwQyodJoKiBnWYF2LBfWiIbO8HtJy14h4ro2MnAaJ2Yl7CGhuI8csDYdsmha+YkIC306b3ykS+fe0IHNwRamMO62t4L/8fPjNeqFwJ03nlneIIF+c4woe4jdHFHUN8hhNQY6X4M4sPcwJKJYuu22m3Y9FDevHX2+FbkQ45tbKygoD3X+C3OsB2tqZqznMW3XKM+wlNUOfxZuUWo/0kLFmepEQ6Rg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775486359; c=relaxed/simple;\n\tbh=dxZS07APXgt/dmN6zJ9TWXeU50NMovg93IUKFknmhvk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=QVvSPFDHMDzoKJPQlJiKUW1WsprAI8HRtl8+uc6RzG/exCDpTQrx8Gs2S5r6JqM9WVez2Nv+aQZZCXOTxJj7Zf02LWhLaS/scBzCOzW5FuWg4Z8LM6/Qnbuq6yY5Egb95vhGIIBOBKWUGtVOP6bdbitxRmkACpWEaBU3ayRMdnw="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.alibaba.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=G084E1Qj; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15651-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.alibaba.com;\n spf=pass smtp.mailfrom=linux.alibaba.com;\n dkim=pass (1024-bit key) header.d=linux.alibaba.com\n header.i=@linux.alibaba.com header.b=G084E1Qj;\n arc=none smtp.client-ip=115.124.30.130"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linux.alibaba.com; s=default;\n\tt=1775486345; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type;\n\tbh=D/rWtsmoe7dbMfLCdG9NTFNTxZ8ltntqEvtD01Di4K0=;\n\tb=G084E1QjPe3qFcvetDGTtSBYULO5UHufPO4OWlsjsrftDHkQ2/xDwrw8fZZvuhY1w7hqXWbG38y8lFS0dOB0NUC2efLttT4VQZ6TDPZLgm5OvaTkNnlaoW9qgfoa9k/Uwa1F+o7tCM6au5s/E0CAkRO1sIBG6VmrEIoS4OAK8jY=","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032089153;MF=libaokun@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0X0WsweH_1775486331;","Message-ID":"","Date":"Mon, 6 Apr 2026 22:38:42 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","To":"skoyama.kernel@gmail.com, linux-ext4@vger.kernel.org","Cc":"tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,\n ojaswin@linux.ibm.com, ritesh.list@gmail.com, yi.zhang@huawei.com,\n bhupesh@igalia.com, Sohei Koyama ,\n Andreas Dilger , stable@vger.kernel.org","References":"<20260406074830.8480-1-skoyama@ddn.com>","Content-Language":"en-US","From":"Baokun Li ","In-Reply-To":"<20260406074830.8480-1-skoyama@ddn.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-8.7 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_DKIM_WL autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3673915,"web_url":"http://patchwork.ozlabs.org/comment/3673915/","msgid":"","list_archive_url":null,"date":"2026-04-07T01:13:41","subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","submitter":{"id":85428,"url":"http://patchwork.ozlabs.org/api/people/85428/","name":"Zhang Yi","email":"yi.zhang@huaweicloud.com"},"content":"On 4/6/2026 3:48 PM, skoyama.kernel@gmail.com wrote:\n> From: Sohei Koyama \n> \n> The commit c8e008b60492 (\"ext4: ignore xattrs past end\")\n> introduced a refcount leak in when block_csum is false.\n> \n> ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to\n> get iloc.bh, but never releases it with brelse().\n> \n> Fixes: c8e008b60492 (\"ext4: ignore xattrs past end\")\n> Signed-off-by: Sohei Koyama \n> Reviewed-by: Andreas Dilger \n> Reviewed-by: Ritesh Harjani (IBM) \n> Cc: stable@vger.kernel.org\n\nLooks good to me.\n\nReviewed-by: Zhang Yi \n\n> ---\n> fs/ext4/xattr.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c\n> index 7bf9ba19a89d..19c72e38fb82 100644\n> --- a/fs/ext4/xattr.c\n> +++ b/fs/ext4/xattr.c\n> @@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n> {\n> \tstruct inode *ea_inode;\n> \tstruct ext4_xattr_entry *entry;\n> -\tstruct ext4_iloc iloc;\n> +\tstruct ext4_iloc iloc = { .bh = NULL };\n> \tbool dirty = false;\n> \tunsigned int ea_ino;\n> \tint err;\n> @@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n> \t\t\text4_warning_inode(parent,\n> \t\t\t\t\t \"handle dirty metadata err=%d\", err);\n> \t}\n> +\n> +\tbrelse(iloc.bh);\n> }\n> \n> /*","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=bnhl=cg=vger.kernel.org=linux-ext4+bounces-15653-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=104.64.211.4 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15653-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.56","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqSrs6cbyz1xtJ\n\tfor ; Tue, 07 Apr 2026 11:14:04 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fqSrr2zblz4wCM\n\tfor ; Tue, 07 Apr 2026 11:14:04 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fqSrr2wsbz4wK3; Tue, 07 Apr 2026 11:14:04 +1000 (AEST)","from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fqSrm1HmLz4wCM\n\tfor ; Tue, 07 Apr 2026 11:14:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id AD77230086A6\n\tfor ; Tue, 7 Apr 2026 01:13:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6F5541DE8BE;\n\tTue, 7 Apr 2026 01:13:56 +0000 (UTC)","from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com\n [45.249.212.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F38461A9FBA;\n\tTue, 7 Apr 2026 01:13:51 +0000 (UTC)","from mail.maildlp.com (unknown [172.19.163.198])\n\tby dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fqSqK62hNzKHML7;\n\tTue, 7 Apr 2026 09:12:45 +0800 (CST)","from mail02.huawei.com (unknown [10.116.40.112])\n\tby mail.maildlp.com (Postfix) with ESMTP id 2E06140575;\n\tTue, 7 Apr 2026 09:13:44 +0800 (CST)","from [10.174.178.253] (unknown [10.174.178.253])\n\tby APP1 (Coremail) with SMTP id cCh0CgCHitpFWtRpbzmeDg--.48272S3;\n\tTue, 07 Apr 2026 09:13:43 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775524444; cv=pass;\n\tb=A69+azAyna1HNASCBMCHzTXc2hhWvTR9QLaGa6rKZdnIppPjDXV6UrB0HOfqvUbjX9GRg03qJhdk+HXEjx5RknQdo1Xz+6tLltbaPYNDDxUdr2psC1WvqGYVAxzyeEbqB8YSUFCOIej+p+/prLDAuwuuBm8m0FkcDnQnle+Dzvt9THAUUViHNdqK78TbWYhe7zg9RQkBl98O5/dJEs5TuOw0GRIesqGvEsG5uv5Y/8Ls/xc4e2Ik65YHJ4Xlo2/x2CqKPgDkMXTFYm4JMv3/KlcgoA71JeOPGkdM3KUmIPjOvqRdozR5pYJ5dddxel2PoagrHWLMdUnxwJYIqfYiMQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775524436; cv=none;\n b=fjWEjwJiiF5lEZrOo7IfUH/r0DApkXDo7W9Qb0iPdcQVU9DEY5veshZMfGel0oGtvunK2OgwOepn3iJPhG6+mg6OCC+hq9ztyJQzU+Y/5I8VnmzN08oVNb6R7sc8O/Lmt3wfVKRQHQvko/u1ozQrh5HpzKyafxGOulzJEv1iQj0="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775524444; c=relaxed/relaxed;\n\tbh=fJWVdOABLCGKVT68a2aGTIrrWHejZS0kvCLlUkaDpKA=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=DGLu0mCn/f4uAWky7NDDbrFTsyq2hW1F7qD6xZHgYDKK2h6N3PHROyzulcSiDR2RY5qcgNlluviMHv7xAF1zpzKGCt1VhvuBjbEXvq++rPHUYAVgjqRUVSphyN8XeFqmel4fPB9Fs2K9yRV/DsTw+IhiN5gBq2IAt22eldaU2/XxZnxyPAMn4ckvkwFADhmdl1TXYoGgiLu4VMkXy00XVT9c2vOZ5BBeKD9iA6U3WaCwoC39iA2HP6FG0ij8RVhX8QKiBJIDQcTIewkpYTqkqBJFyww8giYTyZtHccJQPx3lNrw82QXIviB2cPBUK6AcPZ+WyKGeq/IKLwUx7W0Gbg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775524436; c=relaxed/simple;\n\tbh=vvBe9Muv2c5jeAUg6u5C70ti/Hh5gSJXqOytBfqGUYk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=sU5ylXUjrgl7HkNEv1fPmPzbIZaQlDf07Vc5py+5xiy+M3RxiJAX46GMRoh8WWWSuV28X7z1gb97dc8p3EVjvYtUJGEwMdAXIjCrGjdD7ADaBqmKiqxBiyYiupuv1S4DxnOGsMFYebZhHEU+vmPjLhgmhapZSEpEnhga/u0TPRw="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15653-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56"],"Message-ID":"","Date":"Tue, 7 Apr 2026 09:13:41 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","To":"skoyama.kernel@gmail.com, linux-ext4@vger.kernel.org","Cc":"tytso@mit.edu, adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,\n jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com,\n bhupesh@igalia.com, Sohei Koyama ,\n Andreas Dilger , stable@vger.kernel.org","References":"<20260406074830.8480-1-skoyama@ddn.com>","Content-Language":"en-US","From":"Zhang Yi ","In-Reply-To":"<20260406074830.8480-1-skoyama@ddn.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-CM-TRANSID":"cCh0CgCHitpFWtRpbzmeDg--.48272S3","X-Coremail-Antispam":"1UD129KBjvJXoW7Zr4DCr1kCrW7XrW7CFy5CFg_yoW8GF45pw\n\t43G3W8Cr48XFyjkayakF1UuanIga47G3yUurW2k34Ykr93X3s3tFy7t3WrCa15ur4kWa12\n\tqF9Fk3Wj93ZxAaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2\n\t6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4\n\tvEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj\n\txVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x\n\t0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG\n\t6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV\n\tCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS\n\t14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I\n\t8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8\n\tZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x\n\t0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_\n\tJr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1\n\t7KsUUUUUU==","X-CM-SenderInfo":"d1lo6xhdqjqx5xdzvxpfor3voofrz/","X-Spam-Status":"No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3675952,"web_url":"http://patchwork.ozlabs.org/comment/3675952/","msgid":"<177583430881.2758959.6209162016867491519.b4-ty@b4>","list_archive_url":null,"date":"2026-04-10T15:18:41","subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Ts'o","email":"tytso@mit.edu"},"content":"On Mon, 06 Apr 2026 16:48:30 +0900, skoyama.kernel@gmail.com wrote:\n> The commit c8e008b60492 (\"ext4: ignore xattrs past end\")\n> introduced a refcount leak in when block_csum is false.\n> \n> ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to\n> get iloc.bh, but never releases it with brelse().\n> \n> \n> [...]\n\nApplied, thanks!\n\n[1/1] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()\n commit: 77d059519382bd66283e6a4e83ee186e87e7708f\n\nBest regards,","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=YZKOcskx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=+q4y=cj=vger.kernel.org=linux-ext4+bounces-15791-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=YZKOcskx;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15791-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=\"YZKOcskx\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=18.9.28.11","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=mit.edu"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsgxH2LdMz1y2d\n\tfor ; Sat, 11 Apr 2026 01:40:35 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsgxB15H9z4wTH\n\tfor ; Sat, 11 Apr 2026 01:40:30 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fsgx50fjGz4wSd; Sat, 11 Apr 2026 01:40:25 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsgx14PjRz4wSL\n\tfor ; Sat, 11 Apr 2026 01:40:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B780A30FC1D4\n\tfor ; Fri, 10 Apr 2026 15:29:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6FAAA3DE44D;\n\tFri, 10 Apr 2026 15:21:25 +0000 (UTC)","from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EDCC13DE45B\n\tfor ; Fri, 10 Apr 2026 15:21:22 +0000 (UTC)","from trampoline.thunk.org\n (pool-173-48-116-90.bstnma.fios.verizon.net [173.48.116.90])\n\t(authenticated bits=0)\n (User authenticated as tytso@ATHENA.MIT.EDU)\n\tby outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 63AFIoTA015851\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 10 Apr 2026 11:18:51 -0400","by trampoline.thunk.org (Postfix, from userid 15806)\n\tid 10D792E00E2; Fri, 10 Apr 2026 11:18:48 -0400 (EDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775835625; cv=pass;\n\tb=adtUJL0cMvhV7TqPOIbGENmF2P1mPw8Qzs+fpWsOuy/jj12H4/TavayCIX7YWnCcr2IGeKzcN9fOE20ty0OCzokSzkJKTnSx6XanixKGyoqKdTSVyBCuLS5kIgfBbDIZpLrxAPqxW7L3WqF8bo3II8UT9tQ4kjirNCa4gvJzIEdQr9cnPGvTtb4FTe0Wgzk4w6sTNxYiKV3KnD8FCOMZS/9bi1ISYy+bAhhKET+osxHsxVWbu6eem8hCV7aJLbv1YGLpCqZqA/11ONEZMR3M5LEZfbYUT0ItBLzl/gwljDscId33iG8vEbtAIjkHjemkmiRsen7LaCnF9VAxQMUJRQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775834485; cv=none;\n b=hD5RrMDqSj0FanAeu1nJduoBFQ+F09sKTGwH1T2JFHV2dZWEUOjisutiYSwLSMZ5sJOKykYM5dFNe409XynH1AmXaLRxgNXZLaLrUj84Aj6maeuofY0qxpuUfF6Vxy9qRxCNLae3u0qB45uz4GSc+VCa10Xuros0Xwq5YS/ELPU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775835625; c=relaxed/relaxed;\n\tbh=SYz4wWr52RDGSWvxm+GF80z9xD6xeY1lNx3crsmuOHM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=bhzFAA1Au68qZ41k4UptLk2+lXZwajeEJ1wNdPbuIq8B2cOI2XGlhA78YwYkUloRzHExjcu4XE25pzwobnslmWYzDAKUIIvdUx8pJPTVG1OUegqAo8Hl71sNrjgLxWfRQR8gD9ZnaOVqd5J7Aa9oB0o3aIObM5FoCPUHb29Z+jx/gekZedTHAM7Vt2E07aCot0JM+Ec59KFGKdfGAr3L3KteX2xQMyAJEIwTZifdmdtAUzjNB3GMDQxjyJePIzrPZdzbhM9ySHzt125gyROE3eCQ6upfRrm6KAmRzL8oBG3I/BgURo45xi7Z+0iBxptyI4LNsZ2VWkFaQhgf2inLSA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775834485; c=relaxed/simple;\n\tbh=xAad6Rg9r8tmoI6uN0DcOLlJLGeuxcOoVZYRaLJb4Dw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=gJNZQ2RsqIAV3sz7YnjlqTIL65CP4+QG+djuy7pZBDS5KKm2CtfNR6OtRJkk/oTr1pmMizDT4WmgZhe5geAYKaVmwfnoM7pyGQqr+mfDW01BqWXeSP3b3Mk4mcchmRHTT1DfDQ1/qxSy40akb2N4fhPA+lD7exmA4LBm6ZMzklY="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu; dkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=YZKOcskx; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15791-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu;\n spf=pass smtp.mailfrom=mit.edu;\n dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=YZKOcskx; arc=none smtp.client-ip=18.9.28.11"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing;\n\tt=1775834333; bh=SYz4wWr52RDGSWvxm+GF80z9xD6xeY1lNx3crsmuOHM=;\n\th=From:Subject:Date:Message-ID:MIME-Version:Content-Type;\n\tb=YZKOcskxG+RNFUL/f6U98aLr+DXzkdIZQj3OI7aC6mVofalIa8rZgSwIgZaGN1MJP\n\t QjE1jEbuppKUTUqS9rssyDA+BcPMQ4nFI/G4hI8uHCjGlOAUHCo+vQnyWtawNsxpqk\n\t DKTKSllqNvdiCDTfYg5r+Qg7W2bHr3xqfYOWIukdEm63we1dgqTMzEHe3rKt94cPO+\n\t l1eGGW/gc87BVVbrIu96v5EHtCYr0kihnQAP8nAWzIxKvYeTp6Hi0y8/JPADjbasl2\n\t zhSUF1cA5aXQiEj6rS+XWgdjVOzwbifkZATG6ZRs4z0/H5MKCbyWwNZYOoQ3KxX3sQ\n\t El014pUsHpuTg==","From":"\"Theodore Ts'o\" ","To":"linux-ext4@vger.kernel.org, skoyama.kernel@gmail.com","Cc":"\"Theodore Ts'o\" , adilger.kernel@dilger.ca,\n libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com,\n ritesh.list@gmail.com, yi.zhang@huawei.com, bhupesh@igalia.com,\n Sohei Koyama , Andreas Dilger ,\n stable@vger.kernel.org","Subject":"Re: [PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","Date":"Fri, 10 Apr 2026 11:18:41 -0400","Message-ID":"<177583430881.2758959.6209162016867491519.b4-ty@b4>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260406074830.8480-1-skoyama@ddn.com>","References":"<20260406074830.8480-1-skoyama@ddn.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]