[{"id":3673939,"web_url":"http://patchwork.ozlabs.org/comment/3673939/","msgid":"<177553799938.445620.9574616162049290297.b4-review@b4>","list_archive_url":null,"date":"2026-04-07T04:59:59","subject":"Re: [PATCH v3] drm/tegra: Enable cmu for Tegra186 and Tegra194","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Mon, 06 Apr 2026 02:47:31 -0500, Aaron Kling wrote:\n> Without the cmu, nvdisplay will display colors that are notably darker\n> than intended. The vendor bootloader and the downstream display driver\n> enable the cmu and sets a sRGB table. Loading that table here results in\n> the intended colors.\n> \n> Co-developed-by: Kurt Kiefer \n\nYou need to include a Signed-off-by with each Co-developed-by tag.\nFrom submitting-patches.rst:\n\n Co-developed-by: states that the patch was co-created by multiple developers;\n it is used to give attribution to co-authors (in addition to the author\n attributed by the From: tag) when several people work on a single patch. Since\n Co-developed-by: denotes authorship, every Co-developed-by: must be immediately\n followed by a Signed-off-by: of the associated co-author.\n\ncheckpatch.pl should also flag this.\n\n>\n>\n> diff --git a/drivers/gpu/drm/tegra/dc.h b/drivers/gpu/drm/tegra/dc.h\n> index 0559fa6b1bf7..973ab0bb15c9 100644\n> --- a/drivers/gpu/drm/tegra/dc.h\n> +++ b/drivers/gpu/drm/tegra/dc.h\n> @@ -103,6 +103,9 @@ struct tegra_dc {\n> \tconst struct tegra_dc_soc_info *soc;\n> \n> \tbool has_opp_table;\n> +\n> +\tu64 *cmu_output_lut;\n> +\tdma_addr_t cmu_output_phys;\n\nI think 'cmu_output_lut_phys' would be slightly clearer.\n\n>\n> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c\n> index de8b2dfc4984..78e71a3ff026 100644\n> --- a/drivers/gpu/drm/tegra/sor.c\n> +++ b/drivers/gpu/drm/tegra/sor.c\n> @@ -2557,6 +2557,17 @@ static void tegra_sor_hdmi_enable(struct drm_encoder *encoder)\n> \tvalue = tegra_dc_readl(dc, DC_DISP_DISP_COLOR_CONTROL);\n> \tvalue &= ~DITHER_CONTROL_MASK;\n> \tvalue &= ~BASE_COLOR_SIZE_MASK;\n> +\tif (dc->soc->has_nvdisplay && dc->cmu_output_lut) {\n\nChecking for cmu_output_lut not being NULL shouldn't be necessary,\nsince we fail probe if it's NULL. (Checking here gives the impression\nit might be NULL).\n\nOtherwise looks good to me. Main thing is the trailers in the commit\nmessage.\n\nThanks!\nMikko\n\n--","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=H4kVVh3Y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13590-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"H4kVVh3Y\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.85.42","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqYsn6z15z1xtJ\n\tfor ; Tue, 07 Apr 2026 15:00:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6C75D300DF45\n\tfor ; Tue, 7 Apr 2026 05:00:12 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 291C631F987;\n\tTue, 7 Apr 2026 05:00:12 +0000 (UTC)","from BYAPR05CU005.outbound.protection.outlook.com\n (mail-westusazon11010042.outbound.protection.outlook.com [52.101.85.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B47FB23507C;\n\tTue, 7 Apr 2026 05:00:10 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by DM4PR12MB7526.namprd12.prod.outlook.com (2603:10b6:8:112::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.19; Tue, 7 Apr\n 2026 05:00:04 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9769.015; Tue, 7 Apr 2026\n 05:00:04 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775538011; cv=fail;\n b=BthgPNUUdoxKLVmbFYC8dhFmuXiDd0mdmLqQ2hnlWfyCUq1RQRMEsUEwyN5rijEtobr1W0OKgKHYAkfq9cHXZkD8kqduO3/AnEwxpHdiQhl/gwZKNOpk0IZlVvpDzdR/hL1gU2OmqjSSDRM5vJsrUNKMsrEAW4kVtRje/aNCv6A=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=dIaJlE/HebljqWc8Ex4qz24ez1dy6k+9/P7hWbA2SpYH78VLWf++oIdEXxDpncTj2W0tHw41cDbHJtiqNAwSdk9UMC7Wt7HJDIj/ZiZ5oSGJV8DweNraJv9d+wWuYWaZU57Icl1mhzk5GFhjTTOTukBBqM9l2/lQlj2okMDBCm7BOyjwkNUUKAHDf8YPcLdEWMa4C+UmMU9dAAoh4VdeRzzCb7SqlEZg6YZ7bSeLDfwakc3WjMKhqX287lD7IseUznZ+OcnkBqRyKlgookhhowzSp1zDkPD4YJhsJWp1n23x1zI9Pfh3nvOADZzhj6oI0jAgibTX8ixTBBRvB/eBlg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775538011; c=relaxed/simple;\n\tbh=0jKwSU0IkSEiMVsyNv6mnVNTGvWOuY0qRqxsErLPNM0=;\n\th=Content-Type:Subject:From:To:Cc:In-Reply-To:References:Date:\n\t Message-Id:MIME-Version;\n b=KNomvnc91EkQ7IUZ84488cm11Tf57u6lMZ+FOyTWbmi7JAPM7iUA88ts2mOg4DFlMAvOaBo6QB+OVnUJO42fTS7Z3ClJY02zwCboAaoewqPUIo8pct9zWbwvVLE9Hfh/bxSqQHfl4A/avxrN0lkWpKhHUOhSGehcGnYSc7sKdKs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DTGoDWiHsDzVxcqwDtg62igM559+SoQE57jwKg2HAZw=;\n b=CwgYLsZIbeWlKkLexWYSi6mUu7VYFvIPZTXo9G8XcgMhDXrARIs6dQS9Gfek1x4Tb+aTqvXefQ5Esm4Q+QpvcUTAeCd3LDLCZ+4zZL/O0n8BkV5D0PW3I8Ae68y7XC8cicMUr1y9mxZedlY4y4YgpzSRPR69M7yJnSXFOeiCX+M2+Q2UrD8c1CAyX6DdBp/+/Vmkm6S18UUksPqKpz/eNuMFQl8cNRwt62BMIom5b9Gzs8mVF6fBV0YOeH+o2kcvoKk7vx297QNOT4RXI4Y7HnRtbvlbpHzFKu2qL7KrdXjv465x1H/1TsOt7d5KK//XHbPpV20LNJJ4QDAmZxIQig=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=H4kVVh3Y; arc=fail smtp.client-ip=52.101.85.42","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DTGoDWiHsDzVxcqwDtg62igM559+SoQE57jwKg2HAZw=;\n b=H4kVVh3Y3+6ITaDOVxKmtdoyfoBrjHJvyjQD0NgTWCaKt7VuVmMuCLbakxhqAvhnm5VB2e3HEW0wiPHOAhvU9PmLJnIoonWeUye2x10TbdIwl1dIxEVIYhtogrbf9S2ZZZ9u6D7DZBFcLo2lXde0HgGcQMb2EFKYK1x/XRqz5M5/OaVIYA2GiZMtgnLT3OgW/6XYnJuJtWnn8PrhkQVQ5iWX5eE7bjKF88IcjI1JxQeDqkpivESjyUt8+0JCOImO5Xf8H/x64/MRAxJ076YBA4rLMdzEivfCprIYLEHfbFoa3jJ7ABmuS/+gXxaWPXv+FlVN0bDpdW4v2RhGALUlLw==","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Subject":"Re: [PATCH v3] drm/tegra: Enable cmu for Tegra186 and Tegra194","From":"Mikko Perttunen ","To":"Aaron Kling ","Cc":"Thierry Reding ,\n Mikko Perttunen , David Airlie ,\n Simona Vetter , Jonathan Hunter ,\n Thierry Reding , dri-devel@lists.freedesktop.org,\n linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,\n Kurt Kiefer , Jasper Korten ","In-Reply-To":"<20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com>","References":"<20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com>","Date":"Tue, 07 Apr 2026 13:59:59 +0900","Message-Id":"<177553799938.445620.9574616162049290297.b4-review@b4>","X-Mailer":"b4 0.16-dev-37a06","X-ClientProxiedBy":"TY4P286CA0002.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:26d::19) To SJ2PR12MB9161.namprd12.prod.outlook.com\n (2603:10b6:a03:566::20)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|DM4PR12MB7526:EE_","X-MS-Office365-Filtering-Correlation-Id":"00b6f75c-642b-4125-dffe-08de946287f2","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|366016|7416014|10070799003|376014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tQZOKqIJ5Wve7TdTrhxqrbgi3bkrQPlsx84+mxRo8EFdk5/87My8MI0BeDcRUaVIcXTPpdOCkZtuk14reNu8KJ8fR3oF7GApr5icpQH1+QRMnt/4QF6MxV4Xg2qVZyJCRGxFrEZCvT1DSVD5vmZR8s90dlZYS6NqcpK+UawcGEjJ6yFRI5HQmkKddQLoA2niMTMtsktLXDX5dGGX/xoP1W2t+yeu3W1PpF7DXvvKw/jmUX5W2/ifKxquXG+YL3Oy17a3ohMw6bXaRo9DffuGR2Q3/J/NRAC8IGAqJ7TO50KAgPf3RMWBBP9f8UWVoTsETKfgtlp7Y4zRecgBlF0ilhCOLghVIUifmV8BqpVMyIudUZVdLXYUdU4FgbhIY5LLApY9Ss+u1RANPkc3xGGBNOyCpVkkmNb1o8AE9sckBxoSDsxVYJxJ3csCaZCWMkK4Xu8LSTQUO+ywnXuIalvQ18eoQVe7pLeii++lpHJbiLWlp0zEG4GTUOsae34edzm+dS9TbqyKMypkHad0li/fL9LU5LxvhF/iY5X6KKAFTGzx0qVW00yl1pcnrVujfb9V8M5Ox24AWyjvbCcjFOuXMxIN7UjyYkmWQQ8BJTqI97MvSyV/59LNgA6GoYxYSzt9mSRv1ilDhTKwZyCWPfRyfD4iYQTVHnPkGHXgBpUcNqaeRQwf1jWU+e77JV9LexTR/oBrAS2YIk/jjxLCr+jpndE8VQoCn8wuG4g+SLfUQyDw=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(10070799003)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?t7ffxy3vOeBxqoovv/IAvP//R/e4?=\n\t=?utf-8?q?EVdqKzCXU02hPuQ0TQYoWHdXGUs/dVba1eM1mPv5yejYqA6VuuAnWLnaj6Vi6puu2?=\n\t=?utf-8?q?vYoplbqqRFLVWSM2eMoLHL9MRZptD9ZiDtG6yHHuE1gRM6G0VJu0RfSnblDchM6hp?=\n\t=?utf-8?q?x9QL0zg2X+Qb2DC4IUN7NklkRp3jue0xt5Z7y4+p9OJeImTZrkjTl6O+k3wuDDL+b?=\n\t=?utf-8?q?35nfEBEDT9EVJp4uRn2W4tL84nzK6qVlK6H6qwqETToLGphW9/ua7uc+ZF7GpFTD7?=\n\t=?utf-8?q?pzpF6vrY3Db3wBSKCf+O8hkHvSYjiz5R4P7Ugpefz0aYbHt4e3JP/0/mQdex1gpUT?=\n\t=?utf-8?q?E4B2ciPrGVbPhCHRK29QfD4WEZGSPYzR4jxEgwFoHo0J6ESgZhK20o+jtZAA0Ywkr?=\n\t=?utf-8?q?JZghQ/x472IJbs9oydTvU5OuQXbxsMWChiU2rgHHynEbJVRj1SNbKNc3vy4shA3hy?=\n\t=?utf-8?q?an3ujBNa4Rb/uDRwPTPIM77jTkfHv4/vIgG1k/gyIjQ0M1EFOC5ICaFOZpL+Bu/i7?=\n\t=?utf-8?q?ujrKs8jvWU9hUJskAL3sVytx3wZ4yn6Bx9eOtfJ/EVV+kZwV6DDc1nq4ZiVFPqD4p?=\n\t=?utf-8?q?zY5y7jx8MFJLdnOj12sIHZOfHzvcj+DBaC+kK6BxRL0mPNPu8KWVG6mk+aqYfsHcq?=\n\t=?utf-8?q?5oGqk5DaqYi09Im81NpdGiE/3xDq3QzC2HY/a74O58kF2l7vAfQXYkrJfdM377kYk?=\n\t=?utf-8?q?KoOGYneoZdg03UaWz+4dihDjUpZlXhs6GSoFqR8Oc4iLFLIyda+Q5OSUsxNyWVuip?=\n\t=?utf-8?q?7LAhEpf+0jVwidfu5NmunuBdM1reJpyBS0iYA+pjWJZI4Eqe1/3zPu6DBfGoNumM7?=\n\t=?utf-8?q?5kog2MkAMJoyY/3wpZqLh7XNzGZY9AyEUOMHPbcm9e5r+5AMQQT9yzyNDwLC8kpnN?=\n\t=?utf-8?q?VhNgVRq128WbzpM3J0o/R9cu87Ykn40H1sPpH4qIYmxpTC5rKLcd/eH6AbNnXpY7o?=\n\t=?utf-8?q?x+ZbxVArecF7vSd8xdR+xz0SaQGopZmv4ClOWK2/vCMzUk1d3dN2mnNiKtOnjQ1Jc?=\n\t=?utf-8?q?YrqKFlvN/FebRUgR4CPNz+9g/dg9PdUmgcNrTmYtd9rj3hJyeAy53o6Bb9Bi1qCbh?=\n\t=?utf-8?q?4LtywoVJa5+so3kEAJL4U5C3YbE49Btjf4nTGmUWFqQN2T3Az/Rdv18UPEbBCythH?=\n\t=?utf-8?q?jzD2N9Fsa+5MNyvwY1IRBBAC0UeKaAVvgsIoRvAKp6SZE44YPhgSkwmRnDm3MRs0j?=\n\t=?utf-8?q?Blbqisp21/m9GudKaQPlQkB8mkRdftPHhr2kUCnucyogFBfj7cY3w8ybJYLu+DZKO?=\n\t=?utf-8?q?UE7ctgpecT4A9tbbgzQXzziNdmodMUG1oJLP31gmMkU3YnVKGZ6XX9cB3lOl9zlT0?=\n\t=?utf-8?q?dVo3dyWr6CI3353g9yhWI95KZ6v6Km6+yVN5Bg1qAigpR2EEH8JLIkn479rN3prL9?=\n\t=?utf-8?q?0qFMqiZ0IneImCIZlE5njRHUqEQJuEuYujWzG70RJBJ1reLZF/JvI08tLsudgxgJ/?=\n\t=?utf-8?q?vm1ZJ32wVIJg26If3ISV7IUyc75b+y4Mz2W1WMm19sOvGzV9SQ+Y749lDpEJoXxtr?=\n\t=?utf-8?q?CvIoYAPdRZDVUFE1fj+ymqn15pFjBjEmdR2VPhWq9pfdvono5JxVc8M4b6YhcxF3D?=\n\t=?utf-8?q?HRWo3MeImhDs32zl8AQqrDIbTG/CvFSiFgLRRVbRAG/ZxhqmNOuw7+0wYHFJs7H+6?=\n\t=?utf-8?q?4A2y7M3GcuGwn/wLVVCyeiH+0sMhk4l1RxiZG6v2v7dLOUm0t8lbA4GyqVF6EEuEl?=\n\t=?utf-8?q?CQY2hfuUEQLQEHnwh?=","X-MS-Exchange-AntiSpam-MessageData-1":"YJDLRZUX8wu7oA==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 00b6f75c-642b-4125-dffe-08de946287f2","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB9161.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"07 Apr 2026 05:00:04.5820\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n lfIS0LQ3acalp6jKFdqaPsUozH0l7K7p+NlJeDd1fBDo8Es+NE2rhHh6JrvTHnCZyvhugcv41uf6perQ6Cr+Yg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM4PR12MB7526"}}]