[{"id":3674186,"web_url":"http://patchwork.ozlabs.org/comment/3674186/","msgid":"","list_archive_url":null,"date":"2026-04-07T13:26:09","subject":"Re: [Intel-wired-lan] [PATCH net] i40e: Cleanup PTP pins on probe\n failure","submitter":{"id":92459,"url":"http://patchwork.ozlabs.org/api/people/92459/","name":"Kohei Enju","email":"kohei@enjuk.jp"},"content":"On 04/05 23:51, Matt Vollrath wrote:\n> --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n> +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n> @@ -940,12 +940,15 @@ int i40e_ptp_hwtstamp_get(struct net_device *netdev,\n> *\n> * Release memory allocated for PTP pins.\n> **/\n> -static void i40e_ptp_free_pins(struct i40e_pf *pf)\n> +void i40e_ptp_free_pins(struct i40e_pf *pf)\n> {\n> \tif (i40e_is_ptp_pin_dev(&pf->hw)) {\n> -\t\tkfree(pf->ptp_pins);\n> -\t\tkfree(pf->ptp_caps.pin_config);\n> +\t\tif (pf->ptp_pins)\n\nNot a big deal, but I don't think this guard is necessary, because kfree\naccepts NULL safely.\n\n> +\t\t\tkfree(pf->ptp_pins);\n> +\t\tif (pf->ptp_caps.pin_config)\n\nSame here.\n\nThank you for addressing!\n\n> +\t\t\tkfree(pf->ptp_caps.pin_config);\n> \t\tpf->ptp_pins = NULL;\n> +\t\tpf->ptp_caps.pin_config = NULL;\n> \t}\n> }\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=uKixVgsN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqn5p5ckqz1xtJ\n\tfor ; Tue, 07 Apr 2026 23:26:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 385036065C;\n\tTue, 7 Apr 2026 13:26:20 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fLtTgVUdnTUV; Tue, 7 Apr 2026 13:26:18 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 931C660BEC;\n\tTue, 7 Apr 2026 13:26:18 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id BC8C21F6\n for ; Tue, 7 Apr 2026 13:26:17 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id A243C406AE\n for ; Tue, 7 Apr 2026 13:26:17 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id OlwUEJGbxB1Q for ;\n Tue, 7 Apr 2026 13:26:16 +0000 (UTC)","from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 6B000406A3\n for ; Tue, 7 Apr 2026 13:26:15 +0000 (UTC)","from x1 (13.3.31.150.dy.iij4u.or.jp [150.31.3.13])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 637DQ9Jn093068\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 7 Apr 2026 22:26:11 +0900 (JST) (envelope-from kohei@enjuk.jp)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 931C660BEC","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6B000406A3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775568378;\n\tbh=xBSmT4yOaqX3ajWdenBEJqZ7B8ZGAJfIK5QUNMvE6Mw=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=uKixVgsN1nm7C7srOMkyXWIXlFr1P3Lja4eDowwOZu4+72oOdrOur/K1Nftgd9b3e\n\t 6K5ppUt06/yZaUSj9+jvkhN2BvuD7XsalADFZzh42iNyklJQlOwnTNXR6Y4Znrlazx\n\t kYt3j1kVUjV8hDVmb8yYAh75jMFL8FepBcCi+vWFWSIfTx3uYoqAgYL9dJ95m+iI9d\n\t JTMtSzYJKU6QY5t0rt79bQAnE810bWMFhCE5j+7htX5PuN/i3AUDc23tDZR8E8D/a6\n\t F4jpCWAQeKvIpwz2raNTeTl7AahqIfgg3/Qn3zJaZnEl0hGNrXzOM0xTrq82msjj0B\n\t MjGO+O0OPV5KA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6B000406A3","Date":"Tue, 7 Apr 2026 22:26:09 +0900","From":"Kohei Enju ","To":"Matt Vollrath ","Cc":"intel-wired-lan@osuosl.org","Message-ID":"","References":"<20260406035130.2255713-1-tactii@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260406035130.2255713-1-tactii@gmail.com>","X-Mailman-Original-DKIM-Signature":"a=rsa-sha256;\n bh=xBSmT4yOaqX3ajWdenBEJqZ7B8ZGAJfIK5QUNMvE6Mw=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:Message-ID:To:Subject:Date;\n s=rs20251215; t=1775568371; v=1;\n b=ZvrvcPGhUnU3Scv98hxl+ByC/VS+bxA0Iem9l8EfTyfXCn+6b0nLKe2HqrJYG3c6\n p4pXBFGpXHqH/cAVJPaI1nY4hsBogdsA5fIOVMpJAINat9Hmdk1L8JfAt14CEfIB\n e07seQ65J/2SRgPeVqP2b2ydzLzG03o8xIflGlr5CDBjzgqaadHOfBtgB0SwmFT7\n QMU9FfQrBF7nlLXQ0y18nC8faxcI0uKEBDyvqL0YvknECYH2nEzeTYvPY6TLjVHK\n TIRF1YTsXhTVaetybhjnG2fdPv2OGWRia/9F79uVEV8GmJEERe/i9S5Z45R8OfbP\n frlomYQTFF/kivJ6RwKV7w==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=ZvrvcPGh"],"Subject":"Re: [Intel-wired-lan] [PATCH net] i40e: Cleanup PTP pins on probe\n failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]