[{"id":3673661,"web_url":"http://patchwork.ozlabs.org/comment/3673661/","msgid":"<414634f5-3f9a-4d54-9c4d-0e87f63e8894@lunn.ch>","list_archive_url":null,"date":"2026-04-05T23:51:16","subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Sun, Apr 05, 2026 at 04:48:16PM +0100, David Carlier wrote:\n> Use the typed random integer helpers instead of\n> get_random_bytes() when filling a single integer variable.\n> The helpers return the value directly, require no pointer\n> or size argument, and better express intent.\n> \n> Skipped sites writing into __be16 fields (netdevsim) where\n> a direct assignment would trigger sparse endianness warnings.\n> \n> Signed-off-by: David Carlier \n\nReviewed-by: Andrew Lunn \n\n Andrew","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=uAR1P3fO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124\n header.b=uAR1P3fO","smtp1.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpwbr5X4Yz1xy1\n\tfor ; Mon, 06 Apr 2026 14:00:56 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2D0DC80EFD;\n\tMon, 6 Apr 2026 04:00:55 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dStE8hQyv6Hz; Mon, 6 Apr 2026 04:00:54 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 2BD6580EC0;\n\tMon, 6 Apr 2026 04:00:54 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 0FB59C04FB;\n\tMon, 6 Apr 2026 04:00:54 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id D39FDC04FA\n for ; Mon, 6 Apr 2026 00:27:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id AF74A80EF1\n for ; Mon, 6 Apr 2026 00:27:20 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id sf7s-IS8VenI for ;\n Mon, 6 Apr 2026 00:27:19 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 1479180EEF\n for ; Mon, 6 Apr 2026 00:27:18 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n (envelope-from )\n id 1w9XFN-00EvmP-0K; Mon, 06 Apr 2026 01:51:17 +0200"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2BD6580EC0","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1479180EEF"],"X-Greylist":"delayed 2149 seconds by postgrey-1.37 at util1.osuosl.org;\n Mon, 06 Apr 2026 00:27:19 UTC","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1479180EEF","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=156.67.10.101;\n helo=vps0.lunn.ch; envelope-from=andrew@lunn.ch; receiver=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n bh=GcsBfi5F620a2VKaJJ4d3Xj9iYCBM9JdnynJybp0Ml8=; b=uAR1P3fOkiXbjktHEAQYC6zv3P\n DcFFeUxQzvftzwTeBXke83cFHAZX7zKr09XszNolooc/TfS7Uigea0AFBX2DKAYWPCSw3BfMzxfA6\n o4ATmG125tktTkSaHOtOl4NmLjThQp/ltc7YDDwgEFqWQXGeaTMjH5artg7lnOr2oIXQ=;","Date":"Mon, 6 Apr 2026 01:51:16 +0200","From":"Andrew Lunn ","To":"David Carlier ","Message-ID":"<414634f5-3f9a-4d54-9c4d-0e87f63e8894@lunn.ch>","References":"<20260405154816.4774-1-devnexen@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260405154816.4774-1-devnexen@gmail.com>","X-Mailman-Approved-At":"Mon, 06 Apr 2026 04:00:52 +0000","Subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Marcelo Ricardo Leitner ,\n linux-kernel@vger.kernel.org, Matthieu Baerts ,\n dev@openvswitch.org, Xin Long ,\n Geliang Tang , Ilya Maximets ,\n Mat Martineau , Jakub Kicinski ,\n Ilya Dryomov , Paolo Abeni ,\n ceph-devel@vger.kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org, Eric Dumazet ,\n Jon Maloy , Andrew Lunn ,\n linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net,\n Simon Horman , Johannes Berg ,\n \"David S . Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}},{"id":3673750,"web_url":"http://patchwork.ozlabs.org/comment/3673750/","msgid":"<268a9951-c1a6-4b24-8578-0a8bf4b957a3@kernel.org>","list_archive_url":null,"date":"2026-04-06T14:13:14","subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","submitter":{"id":88357,"url":"http://patchwork.ozlabs.org/api/people/88357/","name":"Matthieu Baerts","email":"matttbe@kernel.org"},"content":"Hi David,\n\nOn 05/04/2026 17:48, David Carlier wrote:\n> Use the typed random integer helpers instead of\n> get_random_bytes() when filling a single integer variable.\n> The helpers return the value directly, require no pointer\n> or size argument, and better express intent.\n\nRegarding the modifications in net/mptcp, it looks good to me:\n\nReviewed-by: Matthieu Baerts (NGI0) # net/mptcp\n\n> Skipped sites writing into __be16 fields (netdevsim) where\n> a direct assignment would trigger sparse endianness warnings.\n\nNote that the AI reviews are mentioning that auth->client_challenge from\nnet/ceph/auth_x.c is declared as __le64, and it might then also cause\nsparse warnings:\n\n https://sashiko.dev/#/patchset/20260405154816.4774-1-devnexen%40gmail.com\n\n\nIt looks like they are right:\n\n $ make C=1 net/ceph/auth_x.o\n net/ceph/auth_x.c:574:40: warning: incorrect type in assignment (different base types)\n net/ceph/auth_x.c:574:40: expected restricted __le64 [usertype] client_challenge\n net/ceph/auth_x.c:574:40: got unsigned long long\n\n\nNote that the Netdev CI currently doesn't check sparse warnings:\n\n https://github.com/linux-netdev/nipa/issues/76\n\nCheers,\nMatt","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=empCJTdB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=empCJTdB","smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBBg1pHHz1yFt\n\tfor ; Tue, 07 Apr 2026 00:13:30 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0420860846;\n\tMon, 6 Apr 2026 14:13:29 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id PsTH-4tvA1Gg; Mon, 6 Apr 2026 14:13:28 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 199E8605ED;\n\tMon, 6 Apr 2026 14:13:28 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id E7779C04FB;\n\tMon, 6 Apr 2026 14:13:27 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 4ABEEC04FA\n for ; Mon, 6 Apr 2026 14:13:27 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3CA1E6063E\n for ; Mon, 6 Apr 2026 14:13:27 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4X7CWVD7FE9o for ;\n Mon, 6 Apr 2026 14:13:26 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n by smtp3.osuosl.org (Postfix) with ESMTPS id DA697605ED\n for ; Mon, 6 Apr 2026 14:13:25 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 5AFB1417B0;\n Mon, 6 Apr 2026 14:13:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 182ADC4CEF7;\n Mon, 6 Apr 2026 14:13:19 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 199E8605ED","OpenDKIM Filter v2.11.0 smtp3.osuosl.org DA697605ED"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31;\n helo=sea.source.kernel.org; envelope-from=matttbe@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org DA697605ED","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1775484805;\n bh=2P7nhu2n6o0APZ12xRvAE1wF/VnlsD5jHOe9F41i8cU=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n b=empCJTdBBTuUKZqnWlozijYep6KhdQ0ElZHQ7j2k/fp/a8+AgNDgoFWf1dcv73WU/\n l7ZRCT2dI33s5jo6Ixmdx4wFynF+ix8GRs/4bP4OVUVHVgREaIZJxdbTTRmlp+1L6X\n fwckUo67Gi0ZkqPA2RVgfrIqZ3kVFJZUQ2ZLU2nLCc7JbbJJK4X7c5g5+/DJhfx5Pa\n aQfx1UT4IE++3/CqFVPEWloUs3G6oywfys6vaIIMRfAdhKn0TLfjNGp/hhFAqMPexA\n 3qB9U+UTYOWWVaKOJ8xW4P44/hNLo9lrFAqaV33EM1ATTiWaCVvY9Kr+nOtCgRmHcB\n X9MH/+vkxvF1w==","Message-ID":"<268a9951-c1a6-4b24-8578-0a8bf4b957a3@kernel.org>","Date":"Mon, 6 Apr 2026 16:13:14 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird Beta","Content-Language":"fr","To":"David Carlier ","References":"<20260405154816.4774-1-devnexen@gmail.com>","Autocrypt":"addr=matttbe@kernel.org; keydata=\n xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf\n YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU\n c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb\n WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7\n CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A\n nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw\n TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac\n nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6\n VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs\n 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC\n YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC\n AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33\n EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7\n /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw\n MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC\n cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J\n iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm\n jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI\n 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP\n VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF\n BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX\n ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l\n 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp\n 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM\n 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf\n mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi\n Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP\n Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf\n Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs\n x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG\n V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv\n Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr\n HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb\n 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj\n Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW\n voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa\n KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6\n UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I\n vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv\n mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0\n JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz\n lzVbFe7fduHbABmYz9cefQpO7wDE/Q==","Organization":"NGI0 Core","In-Reply-To":"<20260405154816.4774-1-devnexen@gmail.com>","Subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Matthieu Baerts via dev ","Reply-To":"Matthieu Baerts ","Cc":"Marcelo Ricardo Leitner ,\n linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org,\n dev@openvswitch.org,\n Xin Long , Geliang Tang ,\n Ilya Maximets , Mat Martineau ,\n Jakub Kicinski , Ilya Dryomov ,\n Paolo Abeni , ceph-devel@vger.kernel.org,\n mptcp@lists.linux.dev, netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Eric Dumazet , Jon Maloy ,\n Andrew Lunn , tipc-discussion@lists.sourceforge.net,\n Simon Horman , Johannes Berg ,\n \"David S . Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}},{"id":3673754,"web_url":"http://patchwork.ozlabs.org/comment/3673754/","msgid":"","list_archive_url":null,"date":"2026-04-06T14:28:42","subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","submitter":{"id":76714,"url":"http://patchwork.ozlabs.org/api/people/76714/","name":"David CARLIER","email":"devnexen@gmail.com"},"content":"Hi Mathieu yes this is indeed a valid point, will address is for next\ntime. Cheers\n\nOn Mon, 6 Apr 2026 at 15:13, Matthieu Baerts wrote:\n>\n> Hi David,\n>\n> On 05/04/2026 17:48, David Carlier wrote:\n> > Use the typed random integer helpers instead of\n> > get_random_bytes() when filling a single integer variable.\n> > The helpers return the value directly, require no pointer\n> > or size argument, and better express intent.\n>\n> Regarding the modifications in net/mptcp, it looks good to me:\n>\n> Reviewed-by: Matthieu Baerts (NGI0) # net/mptcp\n>\n> > Skipped sites writing into __be16 fields (netdevsim) where\n> > a direct assignment would trigger sparse endianness warnings.\n>\n> Note that the AI reviews are mentioning that auth->client_challenge from\n> net/ceph/auth_x.c is declared as __le64, and it might then also cause\n> sparse warnings:\n>\n> https://sashiko.dev/#/patchset/20260405154816.4774-1-devnexen%40gmail.com\n>\n>\n> It looks like they are right:\n>\n> $ make C=1 net/ceph/auth_x.o\n> net/ceph/auth_x.c:574:40: warning: incorrect type in assignment (different base types)\n> net/ceph/auth_x.c:574:40: expected restricted __le64 [usertype] client_challenge\n> net/ceph/auth_x.c:574:40: got unsigned long long\n>\n>\n> Note that the Netdev CI currently doesn't check sparse warnings:\n>\n> https://github.com/linux-netdev/nipa/issues/76\n>\n> Cheers,\n> Matt\n> --\n> Sponsored by the NGI0 Core fund.\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=aC+4onAX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=aC+4onAX","smtp2.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp2.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=aC+4onAX"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBXZ4ryNz1yFt\n\tfor ; Tue, 07 Apr 2026 00:29:02 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id CE88F40863;\n\tMon, 6 Apr 2026 14:29:00 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id BQctp1AR5Gfx; Mon, 6 Apr 2026 14:29:00 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id DA0DE40818;\n\tMon, 6 Apr 2026 14:28:59 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id BADEFC04FB;\n\tMon, 6 Apr 2026 14:28:59 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id A7FA9C04FA\n for ; Mon, 6 Apr 2026 14:28:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 8896440087\n for ; Mon, 6 Apr 2026 14:28:58 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id LpZyD6ZZV08B for ;\n Mon, 6 Apr 2026 14:28:57 +0000 (UTC)","from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com\n [IPv6:2607:f8b0:4864:20::c34])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 98FDB40084\n for ; Mon, 6 Apr 2026 14:28:57 +0000 (UTC)","by mail-oo1-xc34.google.com with SMTP id\n 006d021491bc7-662efd1bdd4so2338705eaf.0\n for ; Mon, 06 Apr 2026 07:28:57 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org DA0DE40818","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 98FDB40084"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::c34; helo=mail-oo1-xc34.google.com;\n envelope-from=devnexen@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 98FDB40084","ARC-Seal":"i=1; a=rsa-sha256; t=1775485736; cv=none;\n d=google.com; s=arc-20240605;\n b=lIOzPXuXiK3GvkopJewOgDqsavVYCMKNPp2i5pI4Z3Fu0XyWKKxYhVM6dKpsGDeM62\n m2g8O+Rdd2D33Wz9V7233ZEc6IJaFJAT95Wmk195Nb2j3jD34FjS3vPMwxbx7mlZVhk4\n 92VL8UJCcYWP2DLDel6B9rJl99vcp7gEh2Drgu3dvpF2u9XBgUw9lzvOnUKDsjO7Nm/Q\n UqqLUrlx+SiYfg/6fA4d7dz15wgtfUVgTb+Jqi60nG3PNHRBcId+tiL3+i/W3wo/5ofH\n L+udXibSjVu0VOvPvFomo8cKi7T7VNoQPB4Lq2Eqxi5vejTXYjzyWcdQc3WvwJIbpeQ0\n LJHQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=pQmZeSWTgD6teuG9Cb0qg4wDQezIASQrTbGvcOITLWg=;\n fh=NW/cw5wjVQCU9DGaLFsIgkiUJJMSnywGNXfaeobh+kQ=;\n b=BmFKPZd8MO6f2mhQC7PMPJrEScnZZ7QXVIRheeLx4o44FPbaIRoc6tG81sGcUjpYyJ\n SMjuuxc00kIE85v5BvfQwuLM++lPwkw2fRf5MZOiD6V/27M+FWvuIHOLNvAqoKAQutui\n Z1OJls+dSJQF3kZZHvx1CbW1BIhuDXZHgmsbexYsWOUOFl0+w8EvqTzwL+iKQW9u1sWA\n ROjvzPgRrKQ7a1C0F6BNc3RjmnqGDjtZ3kmgezvgp+tefIx3L8bsSwQ4XXxm2emF56Wv\n dKtI67kHY9oihDDzDf/tDrBevK44uFp5WLGXMK+jM82AllXBiIrBJbSJV6orHhQRqgX2\n 6OCQ==; darn=openvswitch.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775485736; x=1776090536; darn=openvswitch.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=pQmZeSWTgD6teuG9Cb0qg4wDQezIASQrTbGvcOITLWg=;\n b=aC+4onAX5cdjXcC6vjdhKcbTNFgFihQT0o0mFg4ujHeEpKAaxLkNlCEKq6agu8FYg9\n DypZUJexEZwSYgTo9hOsH4wKeek+CJe5tcKD+97TD6MeVVZTBDCGlY/yAOPwbQvmEzIK\n jNZgH/temSmbdFWyDih2hObJSNF4s1/5g3ZrgHdSTf5y8KJc7x88Mn69CSAVsdi3jCE9\n qU33HBVop7wE2CdRvaYsdzxtCjMffzpTfVZ4oX+SLfHd64a352tGWtSRV/UecHABR2ER\n bgBdOUdbH9+59t4LHj4PkmA25gRKhp9B2Hj2gfW7I3utt8HN6YJvTnZzUBGJ5v82Irtb\n mMUA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485736; x=1776090536;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pQmZeSWTgD6teuG9Cb0qg4wDQezIASQrTbGvcOITLWg=;\n b=OEk1oBtCLOlDo1lrA6pkrq81Wnzv2rrnLiG6Gk11c1CoqQ39rbfZcWnO4vZRXmAkLM\n goin+53uqm4kGpJyC1H7OmZ3pydiE+BTlsGgLuitHwN9BDwWZgXSUwj3K1KjApi57xGK\n npdp5DzpgGjuGFN2ctiq65zAPD7EWus45fqme+mgSMqAmCaLFlt83w2fhDp/9lKWJ20b\n gU1LQalrFWs7LEZuwZOwGqB5MHmv7T48eBytUUh/eZgOtQ9YpG5jSSuyvPweGeBIuDp1\n /oOLrVdPYRFHIFCqS2W10m4ssa4BJrp0Jz80/HpgYGj4afR7ISsKwtrQf7LyceS/CGBY\n cTCQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUiHuRr7Ep6yIzafu4twUOCd43pSPhd3SmB1yH7ZKYkLR/olA1ScquKWZaajI3CkEFpt68=@openvswitch.org","X-Gm-Message-State":"AOJu0YzOsUCqQk0lDiy60OZIsVHwpaPD8evURbgMgqzQwNEr+pJIkKTH\n QLSrt+fPt0qnwScoIkEUxq4G/KQ+nosb5BoG8rMOS9x/vg7YxFW32wzIpqWCrDrw1SzOCAMU/pp\n XBBNkCXjP2d1kmTi4xYNvqWUn9SnOIX8=","X-Gm-Gg":"AeBDiesdi83uXFJj7G05PNGwifdCHr5le0P4aL8bz2/0DN+RfK0+3kIx1MAWv2JtjKA\n U4nSm002N1vCGumVPw+eDbn5nCLcdiJMQPxHi65VTVunGg9eOjbozrA/Ue7rmQ1oEGJKc62b+h2\n ukD80EI58Kz0ishy0ByM6+QlDWCRRjIe5N0LKY6w81qCjnAd9IlCKl1txUTs1fBvGQ2pRdYU4Ng\n hdZ2rf7LGhYCNxw0U0V5S32BTiKIRQrxiVhVzRWBuFM9H4hVlhs5m51xtUOyOkpxG6gv8OkNwED\n sy8dl+NS5CP95ZWHQHcqKv3dBI+fiV8jyNhIHw==","X-Received":"by 2002:a05:6820:8318:b0:683:6dbf:c6d4 with SMTP id\n 006d021491bc7-6836dbfcb7bmr3030718eaf.22.1775485736189; Mon, 06 Apr 2026\n 07:28:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20260405154816.4774-1-devnexen@gmail.com>\n <268a9951-c1a6-4b24-8578-0a8bf4b957a3@kernel.org>","In-Reply-To":"<268a9951-c1a6-4b24-8578-0a8bf4b957a3@kernel.org>","From":"David CARLIER ","Date":"Mon, 6 Apr 2026 15:28:42 +0100","X-Gm-Features":"AQROBzCw7pv9Q_nhcb2cp7aOThL8Ubn1v1x8P2vXHbgAOxV1wipCcpu51-53q2E","Message-ID":"\n ","To":"Matthieu Baerts ","Subject":"Re: [ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Marcelo Ricardo Leitner ,\n linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org,\n dev@openvswitch.org,\n Xin Long , Geliang Tang ,\n Ilya Maximets , Mat Martineau ,\n Jakub Kicinski , Ilya Dryomov ,\n Paolo Abeni , ceph-devel@vger.kernel.org,\n mptcp@lists.linux.dev, netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Eric Dumazet , Jon Maloy ,\n Andrew Lunn , tipc-discussion@lists.sourceforge.net,\n Simon Horman , Johannes Berg ,\n \"David S . Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]