[{"id":3673520,"web_url":"http://patchwork.ozlabs.org/comment/3673520/","msgid":"<15259cd2-d8c0-47c6-8ba1-0453f61d912b@gmail.com>","list_archive_url":null,"date":"2026-04-05T01:15:40","subject":"Re: [PATCH] mingw: Remove obsolete STMP_FIXINC override from\n t-cygming","submitter":{"id":29250,"url":"http://patchwork.ozlabs.org/api/people/29250/","name":"Jonathan Yong","email":"10walls@gmail.com"},"content":"On 4/5/26 00:41, Peter Damianov wrote:\n> The STMP_FIXINC assignment in t-cygming dates back to\n> r0-48723-g70e5e841b8b931, which introduced the shared cygwin/mingw\n> makefile fragment and used it to force fixincludes on for those\n> targets.\n> \n> That predates r0-63200-g53c7ffe7dd1c28, which made configure default\n> STMP_FIXINC to stmp-fixinc, so the t-cygming assignment is now\n> redundant in normal builds. Once --disable-fixincludes was added by\n> r13-2319-gbe9dd80f933480, the old override became incorrect as well,\n> because it forced stmp-fixinc back on for targets using t-cygming.\n> Configuring for mingw targets with --disable-fixincludes would then\n> fail with:\n> \n> make[1]: No rule to make target\n> '../build-x86_64-pc-linux-gnu/fixincludes/fixinc.sh', needed by 'stmp-fixinc'.\n> Stop.\n> \n> Remove the obsolete assignment so the configure-time default is used,\n> including when honoring an explicit --disable-fixincludes.\n> \n> gcc/ChangeLog:\n> \n> \t* config/mingw/t-cygming: Remove obsolete STMP_FIXINC\n> \toverride.\n> ---\n> \n> Resubmitting because I forgot to CC anyone on my first submission.\n> \n> I tested that this fixes the error I was seeing with --disable-fixincludes on\n> x86_64-w64-mingw32. There's still more small files left over related to\n> fixincludes, but I don't think they are worth addressing in this patch (or the\n> next release). That is probably not specific to mingw at all.\n> \n> gcc/config/mingw/t-cygming | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/gcc/config/mingw/t-cygming b/gcc/config/mingw/t-cygming\n> index be3323d143a..4d0f99797c3 100644\n> --- a/gcc/config/mingw/t-cygming\n> +++ b/gcc/config/mingw/t-cygming\n> @@ -61,5 +61,3 @@ msformat-c.o: $(srcdir)/config/mingw/msformat-c.cc $(CONFIG_H) $(SYSTEM_H) \\\n> $(TM_P_H) $(HASHTAB_H) $(GGC_H)\n> \t$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \\\n> \t$(srcdir)/config/mingw/msformat-c.cc\n> -\n> -STMP_FIXINC=stmp-fixinc\n\nThank you for the patch, this will make cygwin and mingw targets more \nconsistent. I am OK with this change.\n\nI will push this change to the master branch soon if nobody objects or \ndoes it first.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=UociaI9V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=UociaI9V","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.216.52"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpF0V66hYz1y2d\n\tfor ; Sun, 05 Apr 2026 11:16:25 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 279764BA2E1C\n\tfor ; Sun, 5 Apr 2026 01:16:21 +0000 (GMT)","from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52])\n by sourceware.org (Postfix) with ESMTPS id 236C54BA2E20\n for ; Sun, 5 Apr 2026 01:15:47 +0000 (GMT)","by mail-pj1-f52.google.com with SMTP id\n 98e67ed59e1d1-35c206f0481so2792228a91.0\n for ; Sat, 04 Apr 2026 18:15:47 -0700 (PDT)","from ?IPV6:2001:f40:91b::14fe? ([2001:f40:91b::14fe])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dbe5e5127sm18991442a91.1.2026.04.04.18.15.43\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 04 Apr 2026 18:15:45 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 279764BA2E1C","OpenDKIM Filter v2.11.0 sourceware.org 236C54BA2E20"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 236C54BA2E20","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 236C54BA2E20","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775351752; cv=none;\n b=lKEw67pkOy2scFnmft2FLNocpEeIrEfmmGvoEy0eFUjGfevG7Owk5ShouzKkWOlrYNYloW04YUqPaPtVurvyq1TMG78gdDIwr4AWxSOdU0wS9NHkB8o6sj1Prye5F52ZCxXBDEntsN5RSqeYHBReTmB8POUl1f/cV7Zu6+w0rbc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775351752; c=relaxed/simple;\n bh=Rz6ZyikhE0z8fGRVPRB2IKrUmM4VckHQkOASicUXLDM=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=nfoWL0jk+zKvvsvI4p/ex9GRiqk2fEjR7gsWB2iV0lxaabuSmXk5DH4sKdXZfNWdx1KBDgj6vyG7EJxUUdBwhzl2zyUXvtoW/Vs+Hl7EaJSBTEunaTPkd6QEEQo936/pEiTPZ24+VVpuyB1wj2cQl9ZljCtomOdnbtagaICPK6A=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775351746; x=1775956546; darn=gcc.gnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=6hDog51Y/CIvYHSpNsoJojm/oGTO02GgpaVCQCNyymU=;\n b=UociaI9VrYZTFZ7Ots4Q78+NFwvDDYEmz5CGQFiEZlVWuoFprPyMqhyPP5I5Zilvyt\n GzP36BsRDYGDM3WxvIHRwiV8r6a+ceGTYPcKsCnMSvHwMOWiiZM6JFGqGakN7XrllMRx\n qEu4FLCiItIRoUXOVTgmw0sh0KIBWqStK4H3tY8vdtK6XC4BlYn8GpS3O3oOI0/ntskr\n qZkmbYDmre6mUFWZ7Ch9B4mpNbxF+MpxfyfQaPQ5JN1xQHcyxG1w8+qEHS8bpWqvUmLl\n jsdyrkelQwT2yoIqHeGDXn+BP053QqaCBVQzh27NH7Uypoqadu+KLiJjtSFpMK+XqzQd\n oPDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775351746; x=1775956546;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6hDog51Y/CIvYHSpNsoJojm/oGTO02GgpaVCQCNyymU=;\n b=FpIhl/ZUU0AmCR0ysjoauNdAI6EEyPxGl6VyzMKYUUC6BBtz7ou+EXpe39PK6z4IvZ\n X5tmG1Quluz9NnlA+eruJzVOGFLyPJ9ktzwYNatAjRMBxAQMdKx+ANLDAXzuHAh/hnzu\n eLh6oK8dsrj9bKAldYfoV3ePueY4wYPK5VwEcgTbL/oX/YfXq+BcDxyTUkvI65G31t/q\n vXyOiMU5mmv+APX5sgE3CWTzp3HDbOtavzdVCc2wfN0lMJDinVa50xp/6pK9qJdb0BGv\n X5c++4W6CrpEE/ObR+2HX4h3ereq9VnRmmG5jwZ5WsNkDtn36kIfPxbhNa0roVVyrImb\n uVpA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCW9a26x9B+XyEcBQ1PJDrVBUpiIjt8dG8YVyd5xkxBG5BWtn1Ac/qgZWrJylUlQuVFPK5a387+ZCBkbVA==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YxwAPUJ3mBaISLBmkV7vLD3RA6yFFL6339ryiwlY5qpnu8O9YPg\n O9Moom2LMFAba8GAkjREJKAFJyGfnR6Clyh4IsXFU4QM2UxC7vECiGE1","X-Gm-Gg":"AeBDievdbSoBxWx8sE0ZeCIRv6CDNx725FSDsHlFoIK8fhT0ZvjnxTS4gt+HQsC+xCy\n l2aPtjUoHscp46dPZK/D4EXx+NctYENNMN/AjjUXpZlgzn6tzl2uHD79FBhC6Su/3EYQuIl7Ec9\n 6VjWu/lVknHS8do/0HKH0ti7uFy/5wKB7RR+6kguuf+23I6SwbMv5JuKuvWlevDgz3nGL1QdgUD\n 5zWi5zfxHleivGxfNo0MpfaI6DsA3yvZOSed9ZbM9aF5r9aX77OOirJe+wmWQLerQ26NQBAcHpb\n SDXKKNw7mrf3WUOJ5yLbsQu2HlyIwZI4SMxt1wx/k5Tn1zVWSqVTAFPTfHsfZ8CmJSC0G78/TQE\n ktZ7no58Rk4COiXW4f0qe6mmWUixT8fgvdVGYUXhbVnqovXw730TlsCBxtahBQfUXs6oM1gRcST\n ysckZ3uihfiPhMqQ==","X-Received":"by 2002:a17:90b:268a:b0:35b:e5cf:20fc with SMTP id\n 98e67ed59e1d1-35de692430dmr7090037a91.26.1775351746006;\n Sat, 04 Apr 2026 18:15:46 -0700 (PDT)","Message-ID":"<15259cd2-d8c0-47c6-8ba1-0453f61d912b@gmail.com>","Date":"Sun, 5 Apr 2026 01:15:40 +0000","MIME-Version":"1.0","User-Agent":"Betterbird (Linux)","Subject":"Re: [PATCH] mingw: Remove obsolete STMP_FIXINC override from\n t-cygming","To":"Peter Damianov , gcc-patches@gcc.gnu.org","Cc":"Sam James , Arsen Arsenovic ,\n Andrew Pinski , NightStrike ","References":"<20260405004102.3847-3-peter0x44@disroot.org>","From":"Jonathan Yong <10walls@gmail.com>","Content-Language":"en-US","Autocrypt":"addr=10walls@gmail.com; keydata=\n xsFNBFDEdwIBEACSrmywJMpgYlgJa0HJ1AFu9tQp8yVpVS21EfnrSK16TS6PoW/JS78D5CYx\n pshPzr1iil8yeL8/val1yXkI8uNZjMnhLxMBU5C7WEMCeY/h760btG3bZZ5BMCNCkC0Yfrtv\n JJQDEyv1H+p1U7yMFRyxNtMjaf6QDzoRjTVOzO6mtNMZWYnlhzC54etiVt3HQ4jKOlKbI+dw\n jigIw8B1SZ+xWcukAHRMBcIZYLjbnAI/XNu796pfwh6QEhJjr8EpvyNjdHLFSMMuyUPO/a3s\n r/jkFSTpqt5lr9jWejdQwe7e8WtbC+euv++fH1B9Yz42259kLxgH+aHk6lWX3epIIx3w17rG\n faMrFrINjXEBGLLOQkIy2LtBLYRU2NhDg+VSDOEwAsiOVZs1EHpSNF5GV12L8SFiNtVToHxL\n RpObNpYIHBkDFzx9gvQfX5Kocx5XFhBiNfTjdxBOjopLzQHpfCSo3fzSqc7zpscqOw3uni7G\n IN86fI8h3wSV44dQ4yaervnL2kZykRyWL5y1C9WDfjzljTIeLB6gK/gBbrsuKuVC42r6xAK9\n yC9pL0Trf7+GLJ9UF4WGnJ5IvfVpZ7gtBMjWOpiwewTprdBNwhLsVSep9Vqg/cbtmG6AnpzN\n tMsLEWAwDpgaFa5KqlehgUCuMlEdU6LhvSd0cJ/pqKwwzxEiLwARAQABzRlqb25feSA8MTB3\n YWxsc0BnbWFpbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgBYh\n BOUK3Z2wV/T6ZOG2z3E7X+KcFF1FBQJotQ0UBQkqvxD+AAoJEHE7X+KcFF1F9oYP/jb9v05W\n uEWnHo02+TgxUKsiG7fe/6I4X3qHoBkmWdtOLz3ceasoQs2b6FEKjR4NHjorCREy4gAN5Grd\n amLcW6Q+3mr7+PcGUcLxyzLpJ8wEpXj/40F6tGDQzPGsG3mmRNPrhAQ2Ze7TJzSn9dAvs17G\n rXilzxXxHyNN+2M7/gzgEc95z3bZTWsuzoygm4h2ktTX2xUoIAaKoXLL92HRB6ubwllyeBmH\n gcI0Xrn5d9ZAfLl9wg2zQqtHR4o4QuJtZJ5+OdK75hDDTQYmfLgztQtIxZSvgmx2A76HfXXw\n YUWXITLlfyf59Lq0VFrNZG21rGBzwY342Ns+kBNxV5bOQllyiX6wimQGL5lJYUtBJTy8MnY7\n pnQ0+o4EDSJUjyLpqSHcKxhWBgROWCHB1CN3jjhPnh6BzRYpHP39jG0oNQHbdVh+Rl2GdbZK\n jMDSB09O6XDJFwR70SRQrfIkmamo3XcWWMYCqogzuwxgMLK6nsR64se6KckKhkwnmg2BXo54\n XNs10WGPk5/VHk/Qj7enT39wg2EfUK57SM/4usw2Y7KWjY+8qoPxSxq0ZU9VfJCFjonmtdEN\n GCXxkofSejKKg8hv2gI4gtUHqQtUD55i1GAX8XVPTIpfNzy8Q0lfjyn15KLg2dIzdk6WbyC7\n USiCfprgCBdtXqsK+j5+3ltMQfg3zsFNBFDEdwIBEACsXcBns4YGVTUGMVKVGEocPffmAhAY\n 89XSk1c1qWPngieUtZ2GoiG+a8IKAqYIjfpuV/YXX8i9mXuGAGJvf6rRhpPos8v76y3qoFFr\n PsFjNaiTTTvPn1oNRT+Br5KWjJaDomGkmQe5bGrok6ETK4VgRdYWPib7IbTLUX1rzfaKvDP2\n 19HTsdWj/cdE3QGTZjekJUiJqgqSS8SmaBNtFm2T18r3gdx6+Xq0kJPW421IaXtuxbyD3MTB\n VJYEfY+rEvVfMUi9rvsfCG0djJOh8954D8AhVY58x7aszhHddTeQlXxUdwNpyJFFoFFhpj0L\n vmhCH84eaf+9eW8VqegPDzE2MJ/Oe+bftYS9qtIx4MMHRU5Wl7g2x3QUhsmyev3BmhBvqFzo\n 6TmBZ1bjp2MXZqQw2d5YXJNb0Vtr9qgV1EqnoG7Lf5q5wcENYAJDVeOzOMxUnM3u2VYbt8GM\n u3QITxpHw4lOukzarmEmAq3EwwzBxFKKmD9gvAbkAGmimONRiQSY9OBEW4XLmOqy9b7pnoS+\n 6x0Oqv8lELvz9TJ2Kh5urXJ/7LOvof9z3R0g7Hn7AWn1Y+0hUKN1vRqziJdIFqZ7kcViiKYA\n KfYiDPlHSAVguc3qvok0P8A3uS5qvkz2yC3C5Jt913FoNVu3ny0/UCDjpSAqC3qTXMx3otwL\n DLv/dwARAQABwsF8BBgBAgAmAhsMFiEE5QrdnbBX9Ppk4bbPcTtf4pwUXUUFAmi1DRQFCSq/\n EP4ACgkQcTtf4pwUXUXAqQ/+IUsjP8ePNao+X2C/jTi7reBWfq/h7XashVKp0z55wqQf1e4v\n qbsJY4Fo9+nCCqBxZYTBiOTs+kLeoZ0GQSRKCAogL82cmvA7/Thc3MVJ5aVUjsLjYKIKA00v\n d3wLaalM/o6IvYwGcgZDZdMaSq97bZo2FJKpWplknU9w5EgNGN/xKmF2cbgOGNBlCjNLVxre\n yzqmncZAIhd5GN8VxO/uAkg8nH8IaMDtY5AHr0Dl8f3ivPPbcgPmy7TBOmO4wSjHcWh7MgEg\n rAAvIwEe6rrL328L6g1Zh75X1EAbtJFdZ3RG7lWuyknIYFrHUJFf8DDdHGuKFfm/FcEUyKb6\n 2o2sfT38AySfQ1Ye8N5Q7GQxNUrP9FTb6OauqKpb+MgjwHHb7MdbP51xhq142v6PmnBZb9RB\n +Eew4Q7vSzPrEK/6lv5SIVgKINm6fjRvuwsi4cZK4HBTgpNHZopiDZldiazHU8DD7uR4VIBN\n HiWRZONCb68TcmqNChHhhxGwpPAFukwXSPnmD788DFQhq32hTo7Tpe6TNN45Gci/9ojDz4w6\n GPMmivVTT2E4w+i9iHsxAGRhSFXOUh2e65WxGZiqaoU+tnlCNsTmzpTFB4IG/tKXzjvtuHyW\n fn+ecVyNupgIc+Y+bq6yWXuuMijFgDzqMiiqP5Q63FHG6kRtYSZdXyW7fH8=","In-Reply-To":"<20260405004102.3847-3-peter0x44@disroot.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]