[{"id":3673388,"web_url":"http://patchwork.ozlabs.org/comment/3673388/","msgid":"","list_archive_url":null,"date":"2026-04-04T05:52:24","subject":"Re: [PATCH] xiaomi pad 5 support","submitter":{"id":92226,"url":"http://patchwork.ozlabs.org/api/people/92226/","name":"Yao Zi","email":"me@ziyao.cc"},"content":"On Fri, Apr 03, 2026 at 07:01:26PM +0300, Lobanokivan11 wrote:\n> ---\n> board/qualcomm/xiaomi-nabu.env | 11 +\n> configs/xiaomi-nabu_defconfig | 6 +\n> dts/upstream/src/arm64/qcom/pm8150.dtsi | 10 +-\n> dts/upstream/src/arm64/qcom/pm8150b.dtsi | 8 +\n\nDevicetree (and bindings) in dts/ are pulled from devicetree\nupstream[1] (i.e., Linux kernel), and you shouldn't directly modify\nfiles in it. If you need a commit in dts upstream that hasn't\nsynchronized into U-Boot yet, tools/update-subtree.sh might be used for\ncherry-picking one commit once it has landed in Linux master.\n\nHowever, I don't see such changes to pm8150(b).dtsi in Linux 7.0-rc6, so\nyou might want to push the changes to Linux upstream first.\n\n> .../src/arm64/qcom/sm8150-oneplus-common.dtsi | 545 ++++++++\n> .../arm64/qcom/sm8150-oneplus-guacamole.dts | 70 +\n> .../src/arm64/qcom/sm8150-oneplus-hotdogb.dts | 65 +\n> .../src/arm64/qcom/sm8150-wcd9340.dtsi | 86 ++\n> .../src/arm64/qcom/sm8150-xiaomi-cepheus.dts | 575 ++++++++\n> .../src/arm64/qcom/sm8150-xiaomi-nabu.dts | 1175 +++++++++++++++++\n> dts/upstream/src/arm64/qcom/sm8150.dtsi | 102 ++\n> 11 files changed, 2652 insertions(+), 1 deletion(-)\n> create mode 100644 board/qualcomm/xiaomi-nabu.env\n> create mode 100644 configs/xiaomi-nabu_defconfig\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-common.dtsi\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-guacamole.dts\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-hotdogb.dts\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-wcd9340.dtsi\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-cepheus.dts\n> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-nabu.dts\n\nWhat's the relationship between Xiaomi Pad 5 and\n\"oneplus-guacamole/hotdogb\"? The latter doesn't seem to match subject of\nthe patch, which is \"xiaomi pad 5 support\". You probably want to have a\nseparate commit for the non-xiaomi stuff.\n\nAnd, for the same reason as above, you should neither create files in\ndts/ manually. I don't think these devicetrees have been in upstream,\neither. An alternative is to put them in arch/arm/dts instead, but it'll\nstill be nice to have them upstreamed first.\n\n...\n\n> diff --git a/dts/upstream/src/arm64/qcom/pm8150.dtsi b/dts/upstream/src/arm64/qcom/pm8150.dtsi\n> index d2568686a09..c3411b308e3 100644\n> --- a/dts/upstream/src/arm64/qcom/pm8150.dtsi\n> +++ b/dts/upstream/src/arm64/qcom/pm8150.dtsi\n> @@ -116,13 +116,21 @@\n> \t\t\tstatus = \"disabled\";\n> \t\t};\n> \n> -\t\trtc@6000 {\n> +\t\tpm8150_rtc: rtc@6000 {\n> \t\t\tcompatible = \"qcom,pm8941-rtc\";\n> \t\t\treg = <0x6000>, <0x6100>;\n> \t\t\treg-names = \"rtc\", \"alarm\";\n> \t\t\tinterrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;\n> \t\t};\n\nIt's possible to refer a devicetree node by using its full path, which\nmay help if you decide not to upstream changes in pm8150.dtsi first.\n\n> +\t\tpm8150_sdam_2: sdam@b100 {\n> +\t\t\tcompatible = \"qcom,spmi-sdam\";\n> +\t\t\treg = <0xb100>;\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <1>;\n> +\t\t\tstatus = \"disabled\";\n> +\t\t};\n> +\n> \t\tpm8150_gpios: gpio@c000 {\n> \t\t\tcompatible = \"qcom,pm8150-gpio\", \"qcom,spmi-gpio\";\n> \t\t\treg = <0xc000>;\n\nRegards,\nYao Zi\n\n[1]: https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ziyao.cc header.i=me@ziyao.cc header.a=rsa-sha256\n header.s=zmail header.b=GlS74Gjq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ziyao.cc","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ziyao.cc header.i=me@ziyao.cc header.b=\"GlS74Gjq\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=ziyao.cc","phobos.denx.de; spf=pass smtp.mailfrom=me@ziyao.cc"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnlB81yY1z1yD3\n\tfor ; Sat, 04 Apr 2026 16:53:04 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B376383C14;\n\tSat, 4 Apr 2026 07:52:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0E2E0840AA; Sat, 4 Apr 2026 07:52:54 +0200 (CEST)","from sender4-op-o16.zoho.com (sender4-op-o16.zoho.com\n [136.143.188.16])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 320E483642\n for ; Sat, 4 Apr 2026 07:52:50 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1775281964441566.2147470795677;\n Fri, 3 Apr 2026 22:52:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775281967; cv=none;\n d=zohomail.com; s=zohoarc;\n b=AS1UMSztue3woEU+2JgZTPdCmaNOnktnLw965uL/rR7noZ4mxtLKnudYbQhNwgkzXRpdgJTO+IyS61bBy8TKKXUcsNYziUVNDQes7RkRj1sCQ61b9VxJEswSjZ8dvg6iS+MleajU14BVS7kIjDq7GkQzNiGuS8n3aga3wJtT6h0=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1775281967;\n h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=SbjGd2Nvn0TtM0wOtRvvLx8r4MY3fUNNiqW1rBpBHPs=;\n b=hqEmx72mKzyfngBBVhwppOxoXHZXS3Z3cenxh4GE7/l+STgUG9EOTYh584f+6cfdp7gdmOO/CCiSWJNneWMI5ZEEskT8WYutZIo1PUtFFdKU3HBCmDmTJwypU+kblqBnP97VJVtN+8Flcy9XBOuTiSeHEAjPoYNMCArmCP9UziM=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=ziyao.cc;\n spf=pass smtp.mailfrom=me@ziyao.cc;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1775281967;\n s=zmail; d=ziyao.cc; i=me@ziyao.cc;\n h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To;\n bh=SbjGd2Nvn0TtM0wOtRvvLx8r4MY3fUNNiqW1rBpBHPs=;\n b=GlS74Gjqry8moIR3AiaQkOKBimcUcehhqWDYVCadKBzUW2CAZigXe44qZfvq71+0\n YyMcePB7/iAzcrRkjq1cpFX+qaU9doCDUaeDVk2G3Uixk8TgtAMumwrQWkC2u90lAIK\n KrHOOewFaehgJFWMPhmXnNBgJ9YGowWtjpdmb6hc=","Date":"Sat, 4 Apr 2026 05:52:24 +0000","From":"Yao Zi ","To":"Lobanokivan11 , u-boot@lists.denx.de","Cc":"u-boot-qcom@groups.io, casey.connolly@linaro.org,\n neil.armstrong@linaro.org, sumit.garg@kernel.org, trini@konsulko.com","Subject":"Re: [PATCH] xiaomi pad 5 support","Message-ID":"","References":"<20260403160127.10605-1-lobanokivan11@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403160127.10605-1-lobanokivan11@gmail.com>","X-ZohoMailClient":"External","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]