[{"id":3673302,"web_url":"http://patchwork.ozlabs.org/comment/3673302/","msgid":"<4002b93b-fc1b-4b8f-ad49-ecb9c258afd3@intel.com>","list_archive_url":null,"date":"2026-04-03T20:40:45","subject":"Re: [PATCH v2] netfilter: xt_HL: add pr_fmt, drop NULL checks, add\n checkentry validation","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/3/2026 1:03 PM, Marino Dzalto wrote:\n> Add pr_fmt for module-prefixed log messages. Remove unnecessary NULL\n> checks for skb, as netfilter core guarantees skb is non-NULL. Add\n> checkentry functions to validate match mode at rule registration time.\n> \n\nThe patch is small so I guess its not a huge deal, but this feels like 3\npatches in a trench coat to me. The pr_fmt makes sense to combine, and\nthe actual patch content just appears to be implementing the .checkentry\ncallbacks. Seems like this description could use a little update.\n\n> Signed-off-by: Marino Dzalto \n> ---\n> net/netfilter/xt_hl.c | 27 +++++++++++++++++++++++++++\n> 1 file changed, 27 insertions(+)\n> \n\nThe patch also says it removes unnecessary NULL checks. But how is that\neven possible when there are no removal lines in the diff? Is that a\nleftover from the previous version?\n\nThanks,\nJake","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=UNbMtA6F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11619-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"UNbMtA6F\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=192.198.163.13","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnW3x6JRgz1yCs\n\tfor ; Sat, 04 Apr 2026 07:46:53 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EAF963108F90\n\tfor ; Fri, 3 Apr 2026 20:41:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B72923DA5A5;\n\tFri, 3 Apr 2026 20:41:03 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B381E379964;\n\tFri, 3 Apr 2026 20:40:50 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Apr 2026 13:40:50 -0700","from orsmsx901.amr.corp.intel.com ([10.22.229.23])\n by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Apr 2026 13:40:49 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 3 Apr 2026 13:40:49 -0700","from ORSEDG902.ED.cps.intel.com (10.7.248.12) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 3 Apr 2026 13:40:49 -0700","from SN4PR0501CU005.outbound.protection.outlook.com (40.93.194.12)\n by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 3 Apr 2026 13:40:48 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n DS0PR11MB7903.namprd11.prod.outlook.com (2603:10b6:8:f7::10) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17; Fri, 3 Apr 2026 20:40:47 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9769.020; Fri, 3 Apr 2026\n 20:40:47 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775248863; cv=fail;\n b=bC4ZZ4G2xHElOAsOzyu4xdDxd6GxXul9uc+SDBvVLZIGKDd7Eo6hDn+TYqoV5UPs962JrO2zonZZcQk+xxbMjgwHBZSoQgHvT4OnYPCxT05s5vHfiy3e+/t+YwnN33Ot3QVaPZazZD+5pCM7TpKQFg1H2FtryjliQIM1T+osMGo=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=TyUvyQgEfHp4NSJ+hkrxt3YEJCGK+UodXJJ3zVy/il2TvfFuo+iMre+jIkUR89kKT19i03o29z5LaU78sW4rBlYxmz0RH5C4o5TKo7zv/RNO50XYCRmus7Isn8ZrctIhKQIs9kQL2B/uGT4EjVXdzvM4IvkKeNqN0R5QZtZBQlVuUjlp7esJ3kiZXCucnsCelvPqjU4GwxLd4nrmn5A4O+qNX0z83GevEGX45bfHSggpQR2Ndng9dZc0QzDQlL4yBTKoTtfkxZr3vUI9h4l/FsV2zCV4i9kw8lGcYK7YN9AU57JY3KlsyPXAlfWP8Go2ne+OuuU+cORRQQlgvfYiLQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775248863; c=relaxed/simple;\n\tbh=mEPTBKs4wDOwhTF5V4Uyyv9FzDTmF55NV8MY+Be+lOg=;\n\th=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=VWmsP46HCUE898D0TPtVSeH5lZTTWD5MLNYgxlRRl2cTmCtLJ3mx3MInE39LHnW4ov0vCCOYxk1xj9vDBSIZtJrKXHUbDv/DBcab3axnUPDqUuzou8ifq/YWYURQQzrKSd+hG5WQfgK0buQtUNI2xvdLfDAhPqerFizWJd906cc=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=gLhhjceXIojTJ1qZ+qkXvoKyRYDpSTe+hwJKOFx3+ys=;\n b=bNmjdUsE11cGvgiASQknrfZVvrqxE8G89V3IRd9e78MdN5XQ64WdM9GkmTpBLo6rHRWwiAmr+r8DOo1OS7MDg1EyJ10ukTkGbrzGLoYygtZTjB9hL4H+yKnEOzYlI0PlbCIn6n1Wz9rx3xqXaKnUcnlNYpmLYeE2pHKb3h8S93IseZ6vcO43584JduTiK1qwO43G9/DAHp1PaQQVd3yv/kzA6HAJIHhKLcrzaXXIbZEXJM2f4mlns8Sr4IQ9iFiWsec2W6V5H0/T+JZIhNYhUIWmj32JvTDXz8YUNbIxt9u2EtsI/Hzjcf6G7djf5zTjNgc1ZGva0JtnnAJuvbBmZw=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=UNbMtA6F; arc=fail smtp.client-ip=192.198.163.13","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775248851; x=1806784851;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=mEPTBKs4wDOwhTF5V4Uyyv9FzDTmF55NV8MY+Be+lOg=;\n b=UNbMtA6FQdtKmdE9OYMFq5uMlIXwpljtAu+X3HCCS/QptvL6YV9fti/W\n 4ny4lxtI2vZyFUhJWTboN6lNp8qmyhzQ8YlpwTW7oEfg3+ebGdSEa85b7\n d3b+1hbYGNLMwHbkCPPLsyLOqZS7DSF767Hia+2QGpYdJVxBtOsuTuXs8\n +EZ0/m60fKbqCIVFmpH0ShT2DGa0nFayQHF/HQzwDOD8WfjXADozBx45L\n iS1yD34WlVOu59ialiZN+v7olUM/8CDZkbd3smPF9M003c3YMdWb0Hsxg\n gsmUXmvXYdC0/h0AR70A/+HMANg9syg5eimAai4ZNuDLLdUAPdAjU1wqg\n A==;","X-CSE-ConnectionGUID":["NPhGFSUiRcy0sqCf64qBHA==","PLSOFDPaSICCIUJbAqHLEg=="],"X-CSE-MsgGUID":["2P6cSFxDSWadDEFxrKxgNg==","NGmwRsUtQeOdQP8U1pM4wQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11748\"; a=\"78907295\"","E=Sophos;i=\"6.23,158,1770624000\";\n d=\"scan'208\";a=\"78907295\"","E=Sophos;i=\"6.23,158,1770624000\";\n d=\"scan'208\";a=\"224519923\""],"X-ExtLoop1":"1","Message-ID":"<4002b93b-fc1b-4b8f-ad49-ecb9c258afd3@intel.com>","Date":"Fri, 3 Apr 2026 13:40:45 -0700","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] netfilter: xt_HL: add pr_fmt, drop NULL checks, add\n checkentry validation","To":"Marino Dzalto , ,\n\t","CC":", ,\n\t, ","References":"<20260403200320.90449-1-marino.dzalto@gmail.com>","From":"Jacob Keller ","Content-Language":"en-US","In-Reply-To":"<20260403200320.90449-1-marino.dzalto@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW3PR06CA0001.namprd06.prod.outlook.com\n (2603:10b6:303:2a::6) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|DS0PR11MB7903:EE_","X-MS-Office365-Filtering-Correlation-Id":"a6498297-f6d0-4c5f-cee0-08de91c148b5","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|366016|376014|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n bLDBbdBw9R4Fr5alnGtvSyQCNeMYTxI8W2ib09UkWDsH1UdAkY0mZrU1t/iGOTNJZGF76UhPNUDFTzh4XhgcT3LXlWLOHikMq7KcFMDKDT011OReC4i9N7LIUDROnPN3Q2ivxJ7aeBQP6vHzg0xJUVmufMt67KJ/cA7j/str/CaoEXjmMWz72SA99QrRBtKxvG7J/tbZsFbYB4/0oDLuVQ7p/E987kwuScsNL/iklTf1Q5eTJYIHNtJdZgUZKKqDBZDh2FgSNaH66HsXZK1mJ5v9aOAnLzET0pX8Jm0hjqu4VO1VtUvICwd3rfiOGUWZEnKFiddfexfqs1vCpY7yCoL5wK/0neWKljx+A9VLrgZLYpY1f+zFtb+cyzCzxln2lvlizA6wTOg11VdlkEUfGIjfsALdjsxLm3SYS+na0kauWA+/1+Y8pBQhoWqiUwwRA2WYJEgsG0//2X82HBbIvYMsr3I/Ky8ep3NFBOLWwk8zjppb7xcjVw2poOF4X3z7M6QCTrZYUBmkcsDdf5Slmqi9FtVF78pJcbBsZaLO/O4wZpVp+JsmE7ImDHWFGelSftozRLg4b/6sShHKwtcEFuKjqozI9ABfVsQKw3AEDfHy1TScc4iQ1GPoSBXVnFfScqFciq5Wh7K3gR4jHL/kkzE3IaB6zwsI3OPn5gKsTXTNLKQQukBJSCKPnlEoOc29sFbh3HMc54nRHB5w+/etPSkJ9xrPWyTuueVktDab7ZY=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7579.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?IhwcknjhVsZd3nazS/LLTzPzJsct?=\n\t=?utf-8?q?yM6CZOItL5CiPpKf7b6uCJ5jxtimqwZDsoaK1WL4GG0lICTvE3MaAN6kMtfFE+Kno?=\n\t=?utf-8?q?B5ag7Zrtkab561AuNutkE789Ye4Ok/ahBNH0tcL5GbLlRCfmvWor8VimKbJHmNSTG?=\n\t=?utf-8?q?OvXqofSwqUgntQCy0OaVTs1rvnkkFRWrjC1WtcI8X3fU0mqB2ifSqLK7C+JQn9k3h?=\n\t=?utf-8?q?POexNmx0CFblgVrVLUzLpAAZrjeTjvj5xXznBpd1mL+Ozqmpz+dBmPFNXGkdSK8qv?=\n\t=?utf-8?q?VAYxO8lRa1/RBa/U7tts6ojcifPbRE1I0tndNR3MmJWNbucP02IzpFqL6E2KPFF3X?=\n\t=?utf-8?q?bpaJxQREuOKXq44qBcAX3Er1XL0ZU9bC6DD0mOiut0g1VIVh9sMnMRdPRSHw+1DY3?=\n\t=?utf-8?q?2XblVtdbxyAufz7R3ALD+gkw/FLkkO9ESa9pKwnS/73sgGIXgAmNMrTo5HETVz8/l?=\n\t=?utf-8?q?qh3ecoqKeimYt660/fxIy1Xo6anRaLuyYO+vf23kQUAAr5/IxVQZF1LKLIHNGaKbh?=\n\t=?utf-8?q?b0X0oATYtzyZ1FcrtbSN84KIBMRsVsRFB+sr+K4GnSbbXTrIA1l046hPwjwbjcNbX?=\n\t=?utf-8?q?ocLGURAfm5ZhLRBehCUxpI3LZoqXXiCmxTy2Z1z+DIfpojdjIMyNfVXVolH5Hf2ho?=\n\t=?utf-8?q?Txp5YV/Wprlp/SG0j6jqxqP/Iz4m3kFhSn69RdVOOvyQI1zuE4euh4PPu7dRDaHzN?=\n\t=?utf-8?q?lzr3v7G6WwkJulbRNgJTB/ZtDEIopfwJsD6gedtDkZZXNzBD5SWPxBCxiNM73UDX3?=\n\t=?utf-8?q?t6RB11qvTP3O5Jy3T73mizbHlzPJiHm4abp8Bq4OK5RkNEewBCmt+KT7cqPy3a/Wc?=\n\t=?utf-8?q?1mmzEHvIBG/wxXdU5jmNw5bWG/LLhtko6+Jis8KpeCz59EMypnn1r+eENOFsJ3gDA?=\n\t=?utf-8?q?5yrf1KyNZS+szdI8cfBsudaJ+eWouL2PkzKdLm3l3wkvlIzicv2XntOn4KM30E/7K?=\n\t=?utf-8?q?MD7KoMO7r/pbBOxg4twoWybKHPlMjWG3FiDfDiedTyGsqWIVmxtmQWpBx6u2rqJP0?=\n\t=?utf-8?q?I4WAIb3fbjgtFJQRR8j5+NO61HYPx8X071qKjLXHMwptAE43k/lWE5oUtx6Nd7DMt?=\n\t=?utf-8?q?kQueQ2DkfRTH3z5a0x4kcS9rCh7gWfO4Kw8tu1R7gsq/XmWXNcqH6gWLYiSe03zv4?=\n\t=?utf-8?q?WAM1PuSDek3Pjtfj19Ve6Yz47X362n0Itd2cZqxq0xOsM5vbJ2d2Kiuh9TLqzdpr7?=\n\t=?utf-8?q?gsz/m9mRNHOShFYo+H8HRXn4sClmJG3aVhkUYGIhWutymUDsZciSh0Lhbk4KlaBZ7?=\n\t=?utf-8?q?MOKPRw6YKazxyy8RD2L58Va0UqnYu0ULozYWH4Os8PUqfuyfh+n/vJUzwKt+YUWZM?=\n\t=?utf-8?q?mpsLNyO1whAJRstbt+iYBEW/HjNnbMsKUY8zc6q2EOwMoZHj5aX9EsvZU0IRnzTW5?=\n\t=?utf-8?q?yTYSv1vtm2cGNvaxJxYUAG7pEmAmIJdUzHJIAw0+ZEXiihBF8+tJuD2OTOWxjq84v?=\n\t=?utf-8?q?YQ1ONr3Jz0l2+2TeD2/RqHpgU9BFTPLSywb8xvtZICHWF5vevqVfLXz9zl4gkWERg?=\n\t=?utf-8?q?8ToS47oE/Pd3sw5vP10dwRnXqfShghXra5QB30YxC01fB3x2bzWVKXklmxyMGxb2B?=\n\t=?utf-8?q?dgverDIAV/waJDYZbYYyQ6/Rt0qyv41iiYGkMZ3CDnFiG4pXY8iNw7QUvk/Xs9SKA?=\n\t=?utf-8?q?9g0Q7B9vTc+LwMxobDjwQx/xAbYLmcwkcsgYOhkont9NGpDKTz7ag=3D?=","X-Exchange-RoutingPolicyChecked":"\n fdNWLmwGWxuBhGrQn4YnIo1++L5KC6oTs+Z1yqWPedtEweNGUCpg1IrdRHUPBem0plde6wIZ04GH0cw8ojmCpHONSjX7DmYanstON8ETjaDCu+yv0rBRiOsYce6OtEJ+6IpdJmmnYfs8u5cQb1Kaa5CCZ1c9lC9smMFo8loaVlbniIReF6rrNK/DywSVl46jkncUjPftuZH6tiYaX/s/ZXjd1n+jxUWuUXXr7rYFP20CL4ozBB0ZA20TEXOHa/fHl/T1c02kOdbIZotXVkq4r0FQCExIFTvgT/QUlCm8z43ZH/9HkGrqJ1u4cLCOyd1WAkC7Sy2LsWQeS1bp5YpDHg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a6498297-f6d0-4c5f-cee0-08de91c148b5","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Apr 2026 20:40:46.8926\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n CHxx5bYd3LEz0+pkCiwmeOWGRvMFQCJsCRMbzM6UImBWMiB+n3FFjj3079c8nNd5B5mteDEm0Z+m5v2ceauRUYcii4jb80S2hWXIXQENR7A=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR11MB7903","X-OriginatorOrg":"intel.com"}}]