[{"id":3673272,"web_url":"http://patchwork.ozlabs.org/comment/3673272/","msgid":"","list_archive_url":null,"date":"2026-04-03T19:46:56","subject":"Re: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL\n checks","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/","name":"Florian Westphal","email":"fw@strlen.de"},"content":"Marino Dzalto wrote:\n> Signed-off-by: Marino Dzalto \n> ---\n> net/netfilter/xt_hl.c | 25 +++++++++++++++++++------\n> 1 file changed, 19 insertions(+), 6 deletions(-)\n> \n> diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c\n> index c1a70f8f0..9434d5ca8 100644\n> --- a/net/netfilter/xt_hl.c\n> +++ b/net/netfilter/xt_hl.c\n> @@ -6,6 +6,7 @@\n> * Hop Limit matching module\n> * (C) 2001-2002 Maciej Soltysiak \n> */\n> +#define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n> \n> #include \n> #include \n> @@ -25,7 +26,12 @@ MODULE_ALIAS(\"ip6t_hl\");\n> static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par)\n> {\n> \tconst struct ipt_ttl_info *info = par->matchinfo;\n> -\tconst u8 ttl = ip_hdr(skb)->ttl;\n> +\tconst u8 ttl;\n> +\n> +\tif (!skb)\n> +\t\treturn false;\n\nIf this was NULL we'd have crashed already.\n\n> \tcase IPT_TTL_GT:\n> \t\treturn ttl > info->ttl;\n> +\tdefault:\n> +\t\tpr_warn(\"Unknown TTL match mode: %d\\n\", info->mode);\n> +\t\treturn false;\n\nPlease add a .checkentry function and reject this from there.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11617-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=strlen.de"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnTkz13wxz1xtJ\n\tfor ; Sat, 04 Apr 2026 06:47:07 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 657BC3004DCE\n\tfor ; Fri, 3 Apr 2026 19:47:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8373F3D666F;\n\tFri, 3 Apr 2026 19:47:00 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0FD37648F;\n\tFri, 3 Apr 2026 19:46:58 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid ADEB460913; Fri, 03 Apr 2026 21:46:56 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775245620; cv=none;\n b=iEnCtkIBxEEHWh5vZBLWNJa7bZ4ueFoqMIHP6XjgbJNYkOTuaviirvvLtgV8mOEV5Iej7MAnQsmtiZhAGYVjjUwhO6H35WpyCIO51Gce7gmDI9HJmCrV9mwjFdyPkFL5y56osfEz6jE95gusUi0jVuHCu+seUWs+EmZ+XRK5hf0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775245620; c=relaxed/simple;\n\tbh=GXYIOxBHh3VhjgTQVlbh4Z9tVxd5Y6Y7wE0hEfUydcM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=QJLOzsyojzPjXGn2aQP+K/j6MKfgBaIRYK57Q7IL0gpXqzvrQ05v5MLCz3LEWi35Ow/uRuYFC6WHA6BIul+BI2J9YIQ4iuMz+BNpJDo0pBwnpEEON+cvTeCnyzkmRh0q6BAVCTnSx69F9j0jzCPFB6JYotYBuXx3mv3fhO0N9tk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30","Date":"Fri, 3 Apr 2026 21:46:56 +0200","From":"Florian Westphal ","To":"Marino Dzalto ","Cc":"pablo@netfilter.org, netfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL\n checks","Message-ID":"","References":"<20260403193929.89449-1-marino.dzalto@gmail.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403193929.89449-1-marino.dzalto@gmail.com>"}},{"id":3673308,"web_url":"http://patchwork.ozlabs.org/comment/3673308/","msgid":"","list_archive_url":null,"date":"2026-04-03T21:01:55","subject":"Re: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL\n checks","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Fri, Apr 03, 2026 at 09:39:29PM +0200, Marino Dzalto wrote:\n> diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c\n> index c1a70f8f0..9434d5ca8 100644\n> --- a/net/netfilter/xt_hl.c\n> +++ b/net/netfilter/xt_hl.c\n[...]\n> static bool hl_mt6(const struct sk_buff *skb, struct xt_action_param *par)\n> {\n> \tconst struct ip6t_hl_info *info = par->matchinfo;\n> -\tconst struct ipv6hdr *ip6h = ipv6_hdr(skb);\n> +\tconst struct ipv6hdr *ip6h;\n> +\n> +\tif (!skb)\n> +\t\treturn false;\n\nNo skb !?\n\nThis codebase is frozen, I don't see any benefit in this update.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=Ra07SwbT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11622-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"Ra07SwbT\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWS44jXYz1yCs\n\tfor ; Sat, 04 Apr 2026 08:04:20 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 2773E30574AC\n\tfor ; Fri, 3 Apr 2026 21:02:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E31283D88EA;\n\tFri, 3 Apr 2026 21:02:02 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A60F53D5656;\n\tFri, 3 Apr 2026 21:02:00 +0000 (UTC)","from netfilter.org (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with UTF8SMTPSA id 5489E60251;\n\tFri, 3 Apr 2026 23:01:58 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775250122; cv=none;\n b=EL+z8SaStZauvA6u/vp2Ryrxkw1ff4u4TT9e9bsslSp1ob0lP29G+3vlsC5Cx4lnKCqfxGLqD/LHuevo8ECWyiWdXQ7C9IuL+wU3dHCYYyJKWzNZVoPjwNkMsamwxD8LNuPghpTiruz4uOz4AxV+WsxAlP3bs04GLNUJ1Pc1wmw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775250122; c=relaxed/simple;\n\tbh=OiLcugNzhOcn3+ZqTqNHyFc+1w+Of5vLCmgFDm/2EwQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=rpTug87Wa+viwaWm6eYNSMcVxeulCfOU7dx9fcjIwWDMS+s82xRGKhi0LSeYJ9lmfJapkei6kg3ixivUh0WfJVtzfr2JJxHw85C5NhXW6TPPi/gM7eujeDM1owuhkRlIl9egT4iqZrTtTmleoy1Rm+60Hv+i9wwsN+CghUyooB8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=Ra07SwbT; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1775250118;\n\tbh=Bik4T78PiVQ6FVf5qYxp+z3Qx6Y8fK8iKEYDKmRuU0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ra07SwbTcDgF/6SfYn5ARiLngAbIomIrg2hBExbZ4dCq4Uzicc6O/8/uNSC7Iggt1\n\t n/Bhk9YW76SH8Y/u7OgT4cef50decbZTX9TPO8Ip9VcpUW6kD5/06c68CIjpyHiQjx\n\t 0Rzn4YRuCIAyxI6QV21u4ESbR5KXvQEIYMe8nNN0LmkPlIEYwcPK+BWaea0NycR0WE\n\t Ggn3COvQnDjF0M884nJwJwp9zhBGadJEpGeDyAC+P5M7+x+W6/tWwHHvcSFd9UIliO\n\t uKpJNByxgjBQHUDZINiLt+vCCSQfe/kZYccGXqKztkpoZjXhriGNEdLs6uEh7FtwUC\n\t 5r/bXzaV0pQwQ==","Date":"Fri, 3 Apr 2026 23:01:55 +0200","From":"Pablo Neira Ayuso ","To":"Marino Dzalto ","Cc":"fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL\n checks","Message-ID":"","References":"<20260403193929.89449-1-marino.dzalto@gmail.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260403193929.89449-1-marino.dzalto@gmail.com>"}}]