[{"id":3673172,"web_url":"http://patchwork.ozlabs.org/comment/3673172/","msgid":"<8f85b5ce-66ea-430f-9c5f-37b0603b9fae@linaro.org>","list_archive_url":null,"date":"2026-04-03T15:24:49","subject":"Re: [PATCH] target/arm: Move OMAP CP15 register definitions to\n cpregs-omap.c","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"Hi Alessandro,\n\nOn 3/4/26 15:14, Alessandro Ratti wrote:\n> The OMAP CP15 registers are only relevant to system-mode emulation\n> of OMAP SoCs. Move them out of the monolithic helper.c into a\n> dedicated file, following the pattern of cpregs-pmu.c and\n> cpregs-gcs.c. This reduces the size of helper.c and compiles\n> the OMAP-specific code out of CONFIG_USER_ONLY builds.\n> \n> Suggested-by: Paolo Bonzini \n> Signed-off-by: Alessandro Ratti \n> ---\n> target/arm/cpregs-omap-stub.c | 10 ++++\n> target/arm/cpregs-omap.c | 88 +++++++++++++++++++++++++++++++++++\n> target/arm/helper.c | 79 +------------------------------\n> target/arm/internals.h | 2 +\n> target/arm/meson.build | 2 +\n> 5 files changed, 103 insertions(+), 78 deletions(-)\n> create mode 100644 target/arm/cpregs-omap-stub.c\n> create mode 100644 target/arm/cpregs-omap.c\n> \n> diff --git a/target/arm/cpregs-omap-stub.c b/target/arm/cpregs-omap-stub.c\n> new file mode 100644\n> index 0000000000..e0fe32632e\n> --- /dev/null\n> +++ b/target/arm/cpregs-omap-stub.c\n> @@ -0,0 +1,10 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"cpu.h\"\n\nInstead:\n\n#include \"target/arm/cpu-qom.h\"\n\n> +#include \"internals.h\"\n> +\n> +void define_omap_cp_regs(ARMCPU *cpu)\n> +{\n> + g_assert_not_reached();\n> +}\n> diff --git a/target/arm/cpregs-omap.c b/target/arm/cpregs-omap.c\n> new file mode 100644\n> index 0000000000..5fa6b70150\n> --- /dev/null\n> +++ b/target/arm/cpregs-omap.c\n> @@ -0,0 +1,88 @@\n> +/*\n> + * QEMU ARM OMAP CP15 register definitions\n> + *\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"cpu.h\"\n\nPlease use full target path:\n\n#include \"target/arm/cpu.h\"\n...\n\n> +#include \"cpregs.h\"\n> +#include \"internals.h\"\n\nWith the requested changes:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=F8jXtmlM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnMww2SJbz1xtJ\n\tfor ; Sat, 04 Apr 2026 02:25:20 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8gOH-0000O8-6R; Fri, 03 Apr 2026 11:24:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w8gOF-0000Ny-33\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 11:24:55 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w8gOD-0004KP-0N\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 11:24:54 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so20665045e9.2\n for ; Fri, 03 Apr 2026 08:24:52 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48899e48c7asm20330515e9.19.2026.04.03.08.24.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 08:24:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775229891; x=1775834691; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=oPRuMBTp2qSn1gANhoA1+5oBJwwPs87xbXGdROwdpQc=;\n b=F8jXtmlMk6Brq8SjQ+WKWdGn446iOtu19FWkutCWwT0plYzetwVgU8pG7M9e/drboM\n nssJYCIkIEsob+dzh3DyBp3ZMopQYHYnZnAgtkc6bR3UgMkelxY2o3OsZakF4lJtsYoc\n QLvrvXbmtAYbm7JSyMOLHRGlEsKjynevVUVTulgrPehrolbSSFkbrTQxoJeVdn72x1R1\n DRKosP8rgeHbx9rYzJs+pY2vkeohvJNknczckzEogFx0In2sAsdH6JqLjpmU05ZuQ287\n KKx+RqkLN89V/nsujjFuTH4pSpncrtS5WahNdN4Ry7WLbzvqYxNI8XOTb2y9urlko+y+\n OXjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775229891; x=1775834691;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=oPRuMBTp2qSn1gANhoA1+5oBJwwPs87xbXGdROwdpQc=;\n b=pTpcjwjH27jFbXnHQvNvN91z7XG/Gb6UExeYGPc5N38Giuof/yhatRQkY1Np/d/Jyz\n FllnkwjE5WjGL3mWS2BSukZnoUv+OPmRc7YSXGvDARb6hgdqClo7ZESSu9asLAz172Yz\n 7Q3+F+2jZ9pCrZtrxQf5ZDfs4mU7xPb7fKUesqnBTBQz8htUYkmV79R3bkuhPEaqBopi\n cWPYbfUjFhQ0mXFR5wGjGlJ8h8mgaj+BJP2qs78exbhSVIJK2tfDVnZNeLMuFfFXOPFo\n bw2f6EQnYZRVb4Fv21vbTER/RSKrECNW30S0y0T1mSx6O7K76MiYP1tZKifEIpbHVYLI\n 2fvw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUcxD83VqSXxsMTdwnIPXZzGdcC3vrtR6wt0LBmdsQrjXkdaDhpQE47ArSrySuxxg0wXzO98Csi2BLz@nongnu.org","X-Gm-Message-State":"AOJu0YzAyBPgqGFnUSaqtTe3uLo496GxM+55mEbpwbcMlKKC1TgTbaGX\n +ae1TJCDe6BlADNVKLPpcsIPjRJirxEIAmHQQjvicp44qpL4XAefJL+Cv7IKGeHlYSU=","X-Gm-Gg":"ATEYQzxeckenNmurgQuNWSlULpa+NvBQ2KZJddvSnIFxvIGGMatCUCVWVxVNkrVD5aV\n CSeDPSVVoBhFEguiwKHCUEz6UX8Jd96lYHh2R6xdpWcum/HiNTTwhTZw76kyOAOTejsQxA777Mg\n BLYtVu5F4noJ4F7kGhe+5vCZYS+YHMdeqVwBMSduGsHfDn5Ero2VXlljse+Gn9jsKfi23PE7VVR\n Va4C4KPWeK6qJ2ZkRyRy/AI/H4FGAY0dexTAnyRUfDYsZMB0B7UjrVKP0/QkfOcBuRwVYberwIz\n n7Lc/8Z4O7Nu6sLpb/zP8yvTIJBakbStpzNKU1dBiML4XrAPUH/Ir4J9ZJTf8G4ITepHTc2GSJW\n bU7ajxtyIHFOpQ9hhW48Vq6UFg9vVWhg7DeEfqABkU/fRNFBKCYzwd1x4xYhDPAVMoxqc3j7jp8\n mPmR4Az136N9Elsre0pKJt+m9Cl0McCzojXLENaeydvYCsMq9Z036bcbLBnNdYY829EQ==","X-Received":"by 2002:a05:600c:83c9:b0:486:fb5c:3b20 with SMTP id\n 5b1f17b1804b1-48899760093mr54762075e9.13.1775229891261;\n Fri, 03 Apr 2026 08:24:51 -0700 (PDT)","Message-ID":"<8f85b5ce-66ea-430f-9c5f-37b0603b9fae@linaro.org>","Date":"Fri, 3 Apr 2026 17:24:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] target/arm: Move OMAP CP15 register definitions to\n cpregs-omap.c","Content-Language":"en-US","To":"Alessandro Ratti , qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, pbonzini@redhat.com","References":"<20260403131458.446399-1-alessandro@0x65c.net>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260403131458.446399-1-alessandro@0x65c.net>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]