[{"id":3673447,"web_url":"http://patchwork.ozlabs.org/comment/3673447/","msgid":"","list_archive_url":null,"date":"2026-04-04T14:25:41","subject":"Re: [PATCH v6 2/4] iio: adc: ad4691: add initial driver for AD4691\n family","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"On 4/3/26 6:03 AM, Radu Sabau via B4 Relay wrote:\n> From: Radu Sabau \n> \n> Add support for the Analog Devices AD4691 family of high-speed,\n> low-power multichannel SAR ADCs: AD4691 (16-ch, 500 kSPS),\n> AD4692 (16-ch, 1 MSPS), AD4693 (8-ch, 500 kSPS) and\n> AD4694 (8-ch, 1 MSPS).\n> \n> The driver implements a custom regmap layer over raw SPI to handle the\n> device's mixed 1/2/3/4-byte register widths and uses the standard IIO\n> read_raw/write_raw interface for single-channel reads.\n> \n> The chip idles in Autonomous Mode so that single-shot read_raw can use\n> the internal oscillator without disturbing the hardware configuration.\n> \n> Three voltage supply domains are managed: avdd (required), vio, and a\n> reference supply on either the REF pin (ref-supply, external buffer)\n> or the REFIN pin (refin-supply, uses the on-chip reference buffer;\n> REFBUF_EN is set accordingly). Hardware reset is performed via\n> the reset controller framework; a software reset through SPI_CONFIG_A\n> is used as fallback when no hardware reset is available.\n> \n> Accumulator channel masking for single-shot reads uses ACC_MASK_REG via\n> an ADDR_DESCENDING SPI write, which covers both mask bytes in a single\n> 16-bit transfer.\n> \n> Signed-off-by: Radu Sabau \n> ---\nThis patch looks in good shape. Although I wouldn't mind using\nMEGA/MICRO, etc. more in numbers with more than 3 or 4 zeros.\n\nReviewed-by: David Lechner ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=T+tHPtq/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34663-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"T+tHPtq/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.167.180","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=baylibre.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=baylibre.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnyYr6n2nz1xtJ\n\tfor ; Sun, 05 Apr 2026 01:25:52 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id BDF26300DD75\n\tfor ; Sat, 4 Apr 2026 14:25:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E7CE22C11DF;\n\tSat, 4 Apr 2026 14:25:48 +0000 (UTC)","from mail-oi1-f180.google.com (mail-oi1-f180.google.com\n [209.85.167.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE4FF2874FA\n\tfor ; Sat, 4 Apr 2026 14:25:45 +0000 (UTC)","by mail-oi1-f180.google.com with SMTP id\n 5614622812f47-4670676ba03so943824b6e.1\n for ;\n Sat, 04 Apr 2026 07:25:45 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:e14e:bcc6:3f95:26eb?\n ([2600:8803:e7e4:500:e14e:bcc6:3f95:26eb])\n by smtp.gmail.com with ESMTPSA id\n 5614622812f47-46f0f4e16a9sm2936944b6e.4.2026.04.04.07.25.41\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 04 Apr 2026 07:25:43 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775312748; cv=none;\n b=jfNe6V9bjIhS5LTTfNLgCRvn4Y3A09Ju5CsDa/EFwcIF8D9FLp4sF7VlhS2PYSAuFFahsLG/xcF3V3QcZkFz133FUx4GDXzkD/BqTDvoYE0lq8Y6uXX4NUVEAwSG1x6KpFdqOj0KvaqeTJ1Gg7QhqhE/t20slz53mEyK/OGw5S4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775312748; c=relaxed/simple;\n\tbh=YDHQQIkUtIMA5RuVXX+SK+ZopnAIz0IH3aZAqaHI9pk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=awrcqZbuehkfW16guhD5w5k9MlRie7ysVimswv2mpZTLXk5YrmPzz2y4Vai+FTJ6Fsu2rtsMCvs/q2IUjAitoIMWGREe+honJQuPXdoHIdk3ZOXjhTIV4kiBXc4bRv/osVaZJ17emp0RWWN0KeaZ9x25xLDLGx4ikwyfg95gMrQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=baylibre.com;\n spf=pass smtp.mailfrom=baylibre.com;\n dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=T+tHPtq/;\n arc=none smtp.client-ip=209.85.167.180","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775312745;\n x=1775917545; darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=DG8ZLzSkLL5KxGbpBt+cYKmm52XpYZesZWRmcIu235A=;\n b=T+tHPtq/ZJmrz/x0hon6ubvef3dyaaHhk1GRRXgW8y8HepFtZGYjfJcUQczd3MEkSt\n 2Agviun9Cf5EYKtk9j0IqUraHya5+cWg7jpTqs6odctBlL2Zz+DNQ/uNqQMe9wgH193o\n z3zeYYVklZaMQki3yiMddob47zunpO6AWKU8n5PWDQ6LxULv6X3f1wcyghb+It/+xjWX\n z9PNVkRx7eWxmjJNLwRnRuJlliHjZbQNuYTor2Ij+hbvfTGn47XIa2O2GDia9HEi0TFp\n QBOE28LuVqSi18lbs2VxGAN1lYamyOifHSPJ/JYonO7K4FYFJ/G3E8jlIr/y0xjtfZ+C\n UNXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775312745; x=1775917545;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=DG8ZLzSkLL5KxGbpBt+cYKmm52XpYZesZWRmcIu235A=;\n b=qUMHB/2EgTQYULU5rZZUdlvY2/0Juf5V/pBS1/D0Fm6HT0RsNtsiw+9dBTk2DmhZfG\n drFmCRbbBbNOsT/ssZ7uLx5IPj89hUDr/RSfSYl9ZVRGg4Utk8ui5dIhc6VhvLUv0uVq\n E4iETNgFE97o2tDCeO/grMKgMSM8uSKWRvq6wNk35/hXuI8OW89EnPpflUs6xs1TmXBH\n hWNrBM9sxzUVqk9fR4XpX2AkxC/pUK0GMfR1A7FFl6v0pmdJlepeb/JHVMjpDKuXRb9t\n 4ZDpjC/31YRUbgK/51Jl6tlhOBc9IREsdT3HbD3vKZvdP/lD03HlzN2GIFbA/ToGWMET\n /Zzg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVGVrZW0FJWyK+BCKhF3nnWi1GOJZQNaDpkUUe2yhVzKOkrOeJ/R5yUkeas+cYyHsaIPHCgrFGNOOsS@vger.kernel.org","X-Gm-Message-State":"AOJu0Yzr8nRKo0slirPVf+cxhvQjVFHiPGAf+SnhnGw0bVy9ec64Aqf6\n\tV/xRI1roYJBLXfyn6D5BHtVIwF7cHpudVmEg/Gbt2SWoByDqLB+Kd2i7lPd98heAEy4=","X-Gm-Gg":"AeBDievYlw+1LEUK6YhSbob3hXK8aeq5am6KwI6M+XP6Sq6eNOegzU9Pz9w8dVOwa7E\n\tJLGegwyokCjRQMMPRuRcPGaNh3ev4N3vbkI8D2w45hQQWdTfL+Fw2RxT8rHPUvnkXNOPO8XbuMB\n\tFVgNU4YmkeG53GF5aTAH2+6L0DqbOElbzCOkECooLv+UKrRmWCBT9cph/AuNmy/HwmICCDIj3DV\n\tUN7gM8oqk5P+Yh1+amFHw9IKM7x9/lX2bCU1ok+Bo+VNh4fn8H+vooM0P0CvZe82pcyyjn0SEdA\n\tbyR/52NHbSoHHMifi/zOBpyOrCzoB8ATQRTqE6Ly3jpzIzyM+gtIaHqfLmJh6XFZ+O9B8PA+boJ\n\tMam2XkWp+f3GczNw8LQ/1Dpqa2CxKIjPKF9h2o0AqlUcBWYfZDErdi8LKDf4q8+/1USX98UHIGh\n\tGjMKbxGNDPZi8YKXEGyee4u0FQcZf1Dy58PY0bAOCh5PdAvkd4Gz+OLkHYmFsjezsuQzX4t1VNv\n\tA==","X-Received":"by 2002:a05:6808:1206:b0:46a:8dd5:3a4f with SMTP id\n 5614622812f47-46ef5002b8dmr3010289b6e.5.1775312744846;\n Sat, 04 Apr 2026 07:25:44 -0700 (PDT)","Message-ID":"","Date":"Sat, 4 Apr 2026 09:25:41 -0500","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 2/4] iio: adc: ad4691: add initial driver for AD4691\n family","To":"radu.sabau@analog.com, Lars-Peter Clausen ,\n Michael Hennerich ,\n Jonathan Cameron ,\n =?utf-8?q?Nuno_S=C3=A1?= ,\n Andy Shevchenko , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley ,\n =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= ,\n Liam Girdwood , Mark Brown ,\n Linus Walleij , Bartosz Golaszewski ,\n Philipp Zabel , Jonathan Corbet ,\n Shuah Khan ","Cc":"linux-iio@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,\n linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org","References":"\n <20260403-ad4692-multichannel-sar-adc-driver-v6-0-fa2a01a57c4e@analog.com>\n <20260403-ad4692-multichannel-sar-adc-driver-v6-2-fa2a01a57c4e@analog.com>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"\n <20260403-ad4692-multichannel-sar-adc-driver-v6-2-fa2a01a57c4e@analog.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}}]