[{"id":3673348,"web_url":"http://patchwork.ozlabs.org/comment/3673348/","msgid":"<93aff196-b436-4c8c-aa76-3d58785e5c04@linaro.org>","list_archive_url":null,"date":"2026-04-03T23:16:25","subject":"Re: [PATCH for-11.0 2/6] hw/core: Move compat_props_add() to\n 'hw/core/boards.h'","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/3/26 20:43, Michael Tokarev wrote:\n> From: Philippe Mathieu-Daudé \n> \n> compat_props_add() is only used by board models, no need\n> to expose it to any device model. Restrict by defining it\n> only in \"hw/core/boards.h\".\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> Reviewed-by: Michael Tokarev \n> ---\n> include/hw/core/boards.h | 10 ++++++++++\n> include/hw/core/qdev.h | 10 ----------\n> 2 files changed, 10 insertions(+), 10 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QLtMPr0P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnZP44Dx2z1yCs\n\tfor ; Sat, 04 Apr 2026 10:16:56 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8nkh-0007dm-Pf; Fri, 03 Apr 2026 19:16:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8nkg-0007dN-1M\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 19:16:34 -0400","from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8nke-0008CB-KF\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 19:16:33 -0400","by mail-pf1-x433.google.com with SMTP id\n d2e1a72fcca58-82ce09b61beso1054743b3a.0\n for ; Fri, 03 Apr 2026 16:16:31 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9b3dcbesm6818146b3a.22.2026.04.03.16.16.28\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 16:16:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775258190; x=1775862990; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=L2mtlTrpYfLhQMIh8FDI4ghcEctL3zHqAP1YPDVDbRI=;\n b=QLtMPr0PYrMttGexrwbSnckqLIxz7LUigh9ng8CJ7s3KOi2fHS6J9I67Vy6ZxkIbWZ\n Da2KC5Vm7z8SNhCSjmLZxQaUPD1ZddLSM5OYF7u00di94GW36OVJLD7o8xsKgWPfpDq+\n 8zKwvG426eLCJqBopyFRj4XZdynNOFq3skFussjfZvzju0TaS6cHjiiZ/iVCp6DGRNRv\n 65jB6a5uJL8E9rCFMGJCDGxA3/P6bhQMQuHvscPtweyf4SqrRiegMR9HH1FF6qK0pTGf\n vvFmZsUH6WZjeKEGenHWvfkPg8pVbgGbnBxNLZSkq+ads56Zv4pHKMp7wRKIbhBuqnZo\n 5OPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775258190; x=1775862990;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=L2mtlTrpYfLhQMIh8FDI4ghcEctL3zHqAP1YPDVDbRI=;\n b=bV34BiaZFyIqzmRCdEcBLrzUNnGjo30a91AC4DJ3r5gzq1OcmqP55kjpCSBrY9xxfU\n PIhyqGV3L1VbbnLdknr4yT8Uo0cmaEA8U8Gs3NLRUFydYDMEXpjvBsjXxOAQsvyfZT9i\n BTdkwTp+aff3dgEGC0dldm62bmgXD6RPkc/Sk7brjwgEFlajzfhAz4u3mgVUUZ+eWNAN\n VJMojknRE/Kd/2Vm4SLtf9U/5wE8MJPQ5KIrOCO3FU63ngyWpaTuz8Xm3YoI0Mk5esy/\n 79dOIEBcfHp8CD9gPM7M5ReKrAXOwILMGedzbf0ddQB6PR70TEK427bu+jaaEmsPnMfG\n aDFw==","X-Gm-Message-State":"AOJu0YzcT6MX+co/+2HMiZsQ70skAFaesA+FNNJ0Oexl/2LLlfBziFx9\n sUs3wQsyeQT+TEjM75HsFYk2xVZmBNoqYAH/xfnAlFCPZwXI3RFuF2FuCq3HVBbevcLAibn8GgT\n iTW8lPeQ=","X-Gm-Gg":"AeBDievzceOGUNNUbQXNVJ1kDLLBOmCTxfNQm0hK1aEA4n17An3SY30ryrwpvcC7OuX\n GV6Atn5yvNmhht5VlnwO7t84A7XW2+C7LSsLffElKa7qZhKDTEfHKxx5vIQCFDyfKpHXX9qKOOh\n MDg1b1hCpsKVj5Sr4TBVIlv5RJIMha8eqbkh5yjQzvnOuUG7MtkUMNmjcEJlzbUKSF9qYDMI2Ej\n huDDD/MuEa+OGgHEFIpnZ+IiOUOB1LvnpAQNj5hmeXkSBumFyOvXXe8c97O1AE+qLWcl9s//ivo\n UTQUuBkMMxmm0fwvkKQx+nd70dJkzdxdUkw9e9iy6c2Aj0Xe4Hw4hfeEIK5lsndGMhJLtxbBN93\n STiPHnFQw8rWEzm0RV3NRO/HWcNtRONNrj7yLSVg3mA20yobTxix+61jSoZSHvVXqZ40A7KgTYE\n st6Z1DntkQXFd13DXcI/Jnzpa0+d3woWl2TZodVU6pE3Xp7mqKVI88Qfjd39mXX5Nk3sU=","X-Received":"by 2002:a05:6a00:4189:b0:82c:e775:d42a with SMTP id\n d2e1a72fcca58-82d0dbc089bmr4295164b3a.49.1775258190460;\n Fri, 03 Apr 2026 16:16:30 -0700 (PDT)","Message-ID":"<93aff196-b436-4c8c-aa76-3d58785e5c04@linaro.org>","Date":"Sat, 4 Apr 2026 09:16:25 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH for-11.0 2/6] hw/core: Move compat_props_add() to\n 'hw/core/boards.h'","To":"qemu-devel@nongnu.org","References":"<20260403104327.1163942-1-mjt@tls.msk.ru>\n <20260403104327.1163942-3-mjt@tls.msk.ru>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260403104327.1163942-3-mjt@tls.msk.ru>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::433;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]