[{"id":3673095,"web_url":"http://patchwork.ozlabs.org/comment/3673095/","msgid":"<CABvxksxQctL3e41f_rTr6FAX9B1Zv8sEXmabj0Nrf2FB1e5LAg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-03T12:18:23","subject":"Re: [Buildroot] [PATCH] package/bmap-writer: fix static link with\n libarchive","submitter":{"id":92564,"url":"http://patchwork.ozlabs.org/api/people/92564/","name":"Shubham Chakraborty","email":"chakrabortyshubham66@gmail.com"},"content":"Hi Ayoub,\n\nThat makes sense. I'll send this patch as a PR to the upstream repository\ninstead of submitting it to Buildroot.\n\nThanks for the direction.\n\nBest regards,\n\nShubham\n\nOn Fri, Apr 3, 2026 at 4:07 PM Ayoub Zaki <ayoub.zaki@embetrix.com> wrote:\n\n> Hi,\n>\n> can you instead send a PR to https://github.com/embetrix/bmap-write\n> project instead of Buildroot ?\n>\n> it's always better to fix upstream\n>\n>\n> On 4/3/26 12:20, Shubham Chakraborty wrote:\n> > Use a package patch to switch bmap-writer from CMake's\n> > FindLibArchive module to pkg-config for libarchive.\n> >\n> > In static Buildroot builds, FindLibArchive only links\n> > libarchive itself. That drops libarchive's private\n> > dependencies from the final link command and causes\n> > undefined references to compression backends such as\n> > zlib, bzip2, lz4, liblzma and zstd.\n> >\n> > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>\n> > ---\n> >   ...ts.txt-use-pkg-config-for-libarchive.patch | 49 +++++++++++++++++++\n> >   1 file changed, 49 insertions(+)\n> >   create mode 100644\n> package/bmap-writer/0001-CMakeLists.txt-use-pkg-config-for-libarchive.patch\n> >\n> > diff --git\n> a/package/bmap-writer/0001-CMakeLists.txt-use-pkg-config-for-libarchive.patch\n> b/package/bmap-writer/0001-CMakeLists.txt-use-pkg-config-for-libarchive.patch\n> > new file mode 100644\n> > index 0000000000..bb2df1224b\n> > --- /dev/null\n> > +++\n> b/package/bmap-writer/0001-CMakeLists.txt-use-pkg-config-for-libarchive.patch\n> > @@ -0,0 +1,49 @@\n> > +From 5931b090c7ebe61a1bbc9a3e3c58edae5e90d71b Mon Sep 17 00:00:00 2001\n> > +From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>\n> > +Date: Fri, 3 Apr 2026 14:33:19 +0530\n> > +Subject: [PATCH] CMakeLists.txt: use pkg-config for libarchive\n> > +\n> > +CMake's FindLibArchive module only passes libarchive itself to the\n> > +final link command.\n> > +\n> > +In static Buildroot builds that is not enough, because libarchive.a\n> > +also needs its private compression backend dependencies such as zlib,\n> > +bzip2, lz4, liblzma and zstd.\n> > +\n> > +Switch libarchive discovery to pkg-config so the link command includes\n> > +the full static dependency list instead of just libarchive.\n> > +---\n> > + CMakeLists.txt | 10 +++++-----\n> > + 1 file changed, 5 insertions(+), 5 deletions(-)\n> > +\n> > +diff --git a/CMakeLists.txt b/CMakeLists.txt\n> > +index 787fc69..086b127 100644\n> > +--- a/CMakeLists.txt\n> > ++++ b/CMakeLists.txt\n> > +@@ -19,10 +19,10 @@ else()\n> > + endif()\n> > +\n> > +\n> > +-# Find libarchive\n> > +-find_package(LibArchive REQUIRED)\n> > +-if (LibArchive_FOUND)\n> > +-    include_directories(${LIBARCHIVE_INCLUDE_DIR})\n> > ++# Find libarchive via pkg-config so static builds pull in private libs\n> too.\n> > ++pkg_check_modules(LIBARCHIVE REQUIRED libarchive)\n> > ++if (LIBARCHIVE_FOUND)\n> > ++    include_directories(${LIBARCHIVE_INCLUDE_DIRS})\n> > + else()\n> > +     message(FATAL_ERROR \"libarchive not found\")\n> > + endif()\n> > +@@ -47,7 +47,7 @@ add_executable(bmap-writer bmap-writer.cpp sha256.cpp)\n> > + target_compile_options(bmap-writer PUBLIC -Wformat -Wformat-security\n> -Wconversion -Wsign-conversion -pedantic -Werror)\n> > +\n> > + # Link the libraries\n> > +-target_link_libraries(bmap-writer ${TINYXML2_LIBRARIES}\n> ${LibArchive_LIBRARIES})\n> > ++target_link_libraries(bmap-writer ${TINYXML2_LIBRARIES}\n> ${LIBARCHIVE_LIBRARIES})\n> > +\n> > + # Specify the install rules\n> > + install(TARGETS bmap-writer DESTINATION bin)\n> > +--\n> > +2.53.0\n> > +\n>\n> Mit freundlichen Grüßen / Kind regards\n>\n> --\n> Ayoub Zaki\n> Embedded Systems Consultant\n>\n> Vaihinger Straße 2/1\n> D-71634 Ludwigsburg\n>\n> Mobile   : +4917662901545\n> Email    : ayoub.zaki@embetrix.com\n> Homepage : https://embetrix.com\n> VAT No.  : DE313902634\n>\n>","headers":{"Return-Path":"<buildroot-bounces@buildroot.org>","X-Original-To":["incoming-buildroot@patchwork.ozlabs.org","buildroot@buildroot.org"],"Delivered-To":["patchwork-incoming-buildroot@legolas.ozlabs.org","buildroot@buildroot.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=oDUJRhay;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnHnc0psPz1yCt\n\tfor <incoming-buildroot@patchwork.ozlabs.org>;\n Fri, 03 Apr 2026 23:18:44 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 70FE140D61;\n\tFri,  3 Apr 2026 12:18:41 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tfgjO7zfPNpd; Fri,  3 Apr 2026 12:18:40 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 46E2140D6C;\n\tFri,  3 Apr 2026 12:18:40 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 15C2A2CC\n for <buildroot@buildroot.org>; Fri,  3 Apr 2026 12:18:39 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id E3D9F40D6C\n for <buildroot@buildroot.org>; Fri,  3 Apr 2026 12:18:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 39lzM2oQtcNW for <buildroot@buildroot.org>;\n Fri,  3 Apr 2026 12:18:38 +0000 (UTC)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n [IPv6:2a00:1450:4864:20::534])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 87D4D40D61\n for <buildroot@buildroot.org>; Fri,  3 Apr 2026 12:18:37 +0000 (UTC)","by mail-ed1-x534.google.com with SMTP id\n 4fb4d7f45d1cf-66d65646c65so255127a12.1\n for <buildroot@buildroot.org>; Fri, 03 Apr 2026 05:18:37 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 46E2140D6C","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 87D4D40D61"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1775218720;\n\tbh=kQFBYeQeu3ytFgzDvxfBNPOkdUXLgEAZZYE0eUk888Q=;\n\th=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=oDUJRhayEl8QZuNUMp6qRW7vE+OFaM5X9mGJsXpfPl386OCQf4y8E+gTaocFh1jmo\n\t YFTqdIfHuPRkmhVtOqGAwjbO8QilvqSSBShJwcQS0gplZXBDMdBJmxYziuY1ktlwHH\n\t 4pbySRWUi1b/l1S4snFEKZSjjRhzRxNxSm65+vgTJEL8f+mMYFG9WaBV66wZGfe1bz\n\t jIHcBja96VyzgITaghDNH6Sw/R8Rshjl7MYjDfXMe12iXG9QY/ExcgWv20rAkjfzBx\n\t 6tfXzc1hBsszvkclGLsj7FFvcTCung2mDTcCv26OncAJRBZ6jcFMVY4G152a2hsnBx\n\t upwby/w/ZzbPg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::534; helo=mail-ed1-x534.google.com;\n envelope-from=chakrabortyshubham66@gmail.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 87D4D40D61","ARC-Seal":"i=1; a=rsa-sha256; t=1775218715; cv=none;\n d=google.com; s=arc-20240605;\n b=XqM3IwWmTwr2RBVx+KBcaPeYX2IUDnIjfZ0HDnuur1u7SKrcGpUm1XEFan384pg2uU\n hGS2FimKwhPvSScp3qb2VA79nFkEHuTr+FdwNYxw0HNsKlhWpRR5G1iOFkaSe65I0M0v\n d9FVtUwGbp/iVL+G0YJboxrCF0zNzDfPwz3zWd2qyHW0iqYtNjz76e6T38jGeRejYCTn\n AJFkLHedqR9DiGm4ki88P8KW2171Ej5aBzU1k9QXujxiZMFaTAa5J0CX1z0RB+5d/5XN\n id93moYidajhuS+UaZ9Rv9KtVu1K3ocY1nQLFj49DshH51N+2R5vCAVGQIMcen+D+/wB\n 3q3w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=zeeQAqkPldyQKr93HRTkhuwqKm+J8y/i1J7ZG92mwD8=;\n fh=GKNY8hUCdJQW4hnNiVL+8PeKnXk/EuF+siUctVBW5Zw=;\n b=DoBKBllKIGV/kS8Vrd7RHavvBD2P2yXyPuWdOjiMVsTEmgx0F2ZiZywl1tYx4kPBlA\n LSkHgAo3P45JF0EG7vxZ2eQtCMgas3rd2zqvOBGRnvBN9RD1JY9C0IE+teCKEVqOnQFb\n lxlIMqx/+e1EabsWHTyBTBWyMcjK5k+1hccrHXIwVDlWctOXqqUrTI0db3IrQ3ldAYgf\n qkxbYPcVtwRP37KK82roCBwVyTZp4JasDmEpFBByQErzEb51CIbFvVQyvyOFaeL4ipPq\n LXAnW/M13ipAGR8QtawNy4XBD415HHLqvU8AYuN5w1ymmY8AcXynkfqrPjZBds8SPelp\n uCMw==; darn=buildroot.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775218715; x=1775823515;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zeeQAqkPldyQKr93HRTkhuwqKm+J8y/i1J7ZG92mwD8=;\n b=D0yJcfuLBV9LVpVHQ0yTGpuoOCAQIs7T8wRR9V+aEYzy3eePYOLzwlEBcEkFPfI1+v\n MnyFQgREw/67e4kViRqaNZUCRXLi4Oy3WsLk3rBY0S2TKO3HIkPy524svrDJFIbC/fpi\n +lkwLmYVIJxVJI1TdMcS49aPocrYAZpGP6zuCGCv8s6VBe2NKIf/k18fXxKh8o0ckkV5\n a4EDkiOZw1jJnfG/UvkfZzHw9vT8ADxhZCNBbf+eX3fKHmpD3jgicTgjVHiNwOArhWKS\n v9uV4X/QhMUKClKBrC+2qZuM2vgXSunJx1mp/lBIuqYFW9hsGWX+tC7w9Oc2puO44mAF\n ahEQ==","X-Gm-Message-State":"AOJu0Yz6jYW8JliF11mtybrAjVCfxuZyACTEy0B3j4iMRPU3qw6jYvn1\n 7wFrL4sW2E3hI08jhFw1m60DlOStMmEGeQvJallEifU7L8yy6zvG593cwlZ3819mpF7vjT4ZAAe\n y5giUdfU+KKZdOeVMvBvfLYRLBSlk4P247Q==","X-Gm-Gg":"AeBDieszFjuH49QiQnIWphAScDQx7Ep6Oreq8KE48/JdV/HGqIkWPA6FuHHoyCZnAce\n fBBo3fvxrnl4Yb//VbKyRPM65EFJPq1iwbaigHaL8iP3OAPEsb4a0hpmjY8jOwf9AluF/BEL6/k\n Pv7MhRLD4aVR7Mjqq745GDG/48IwoBSYmk6bjrzYkhdFMIveWcDqPCZ5l/qJAh2Rjq0EMstWPOz\n UVY1TtOyQ5OvksA3x7chpdFSzz9i8dOSfqwXuwWLYdBGp8TuBmCaLarU3WIlZaiYoXSEz/Vr0pn\n cUKlrtp9b3YKGhx0jmsG1q8O0v67u5wwV1pLVnxK","X-Received":"by 2002:a05:6402:510f:b0:66d:d429:5852 with SMTP id\n 4fb4d7f45d1cf-66e3e0e68a5mr1263905a12.3.1775218715070; Fri, 03 Apr 2026\n 05:18:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20260403102040.522314-1-chakrabortyshubham66@gmail.com>\n <aeb49176-5139-4c57-ae45-7f1f080206a0@embetrix.com>","In-Reply-To":"<aeb49176-5139-4c57-ae45-7f1f080206a0@embetrix.com>","From":"Shubham Chakraborty <chakrabortyshubham66@gmail.com>","Date":"Fri, 3 Apr 2026 17:48:23 +0530","X-Gm-Features":"AQROBzDAlBuSIvU7PG-qTHy45S4D71SpW9Wqq0aQvf5gHHp3aErmBuzwrKYDjA0","Message-ID":"\n <CABvxksxQctL3e41f_rTr6FAX9B1Zv8sEXmabj0Nrf2FB1e5LAg@mail.gmail.com>","To":"Ayoub Zaki <ayoub.zaki@embetrix.com>","Cc":"buildroot@buildroot.org","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775218715; x=1775823515; darn=buildroot.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=zeeQAqkPldyQKr93HRTkhuwqKm+J8y/i1J7ZG92mwD8=;\n b=KM7x6dKbgOWbbFYL15FkcX5GNVPTYSxKLpf+d/fys0vHkFriaBGoYChIC5tJDEE8a+\n YdrZA92F9j93Rd4oMx1eesexCB9nMrBcm7fKahbAfo2s7ktLFuKcvvqH6/ANIduYPqCp\n e5OKznONU7N2EzvPoURZ1IxXLaoFHjdhU/5FGpx4f9dzTSXGpF3EVfOkHs9b8ERlOKRI\n q2mwlE4D4PXkYroWf7+BDOJ9tsnYISIzmKY9gEVAhMQ80at52ceL9AH4HiNOtvua6w1D\n UJO6IdtP/naTMgNHVfR9enzmaoJ1LHX6OUY7/r8Wm/XTmc2EhF1GSIemC8ncn3cNP9Kv\n zByw==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=KM7x6dKb"],"Subject":"Re: [Buildroot] [PATCH] package/bmap-writer: fix static link with\n libarchive","X-BeenThere":"buildroot@buildroot.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.buildroot.org>","List-Unsubscribe":"<https://lists.buildroot.org/mailman/options/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=unsubscribe>","List-Archive":"<http://lists.buildroot.org/pipermail/buildroot/>","List-Post":"<mailto:buildroot@buildroot.org>","List-Help":"<mailto:buildroot-request@buildroot.org?subject=help>","List-Subscribe":"<https://lists.buildroot.org/mailman/listinfo/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=subscribe>","Content-Type":"multipart/mixed; boundary=\"===============5901440270440206109==\"","Errors-To":"buildroot-bounces@buildroot.org","Sender":"\"buildroot\" <buildroot-bounces@buildroot.org>"}}]