[{"id":3673115,"web_url":"http://patchwork.ozlabs.org/comment/3673115/","msgid":"<20260403125559.GC12260@macsyma-wired.lan>","list_archive_url":null,"date":"2026-04-03T12:55:59","subject":"Re: [PATCH 1/3] ext4: register 'orphan_list' procfs","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Ts'o","email":"tytso@mit.edu"},"content":"On Fri, Apr 03, 2026 at 04:25:05PM +0800, Ye Bin wrote:\n> +\t\tproc_create_data(\"orphan_list\", 0444, sbi->s_proc,\n> +\t\t\t\t &ext4_orphan_proc_ops, sb);\n\nThis should really be mode 0400, especially once the file path is made\navailable, since otherwise the kernel might end up leaking private\nuser's information.  Even in a data center use case, in a multi-user\ncontainer use case (Docker, Kubernetes, etc.) leaking information\nabout one user's file names could be a real problem.\n\n      \t  \t      \t    \t     - Ted","headers":{"Return-Path":"\n <SRS0=K8rF=CC=vger.kernel.org=linux-ext4+bounces-15626-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=RYC4Z/L+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=k8rf=cc=vger.kernel.org=linux-ext4+bounces-15626-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=RYC4Z/L+;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15626-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=\"RYC4Z/L+\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=18.9.28.11","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=mit.edu"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnJfT3KK3z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 23:57:37 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fnJfN2z0Xz4wSg\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 23:57:32 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fnJfN2tCPz4wTJ; Fri, 03 Apr 2026 23:57:32 +1100 (AEDT)","from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fnJfJ0SJZz4wSg\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 03 Apr 2026 23:57:28 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 1C7A43047BC6\n\tfor <patchwork-incoming@ozlabs.org>; Fri,  3 Apr 2026 12:57:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 881613B0AE1;\n\tFri,  3 Apr 2026 12:57:23 +0000 (UTC)","from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A92371D0B\n\tfor <linux-ext4@vger.kernel.org>; Fri,  3 Apr 2026 12:57:17 +0000 (UTC)","from macsyma.thunk.org (pool-173-48-112-174.bstnma.fios.verizon.net\n [173.48.112.174])\n\t(authenticated bits=0)\n        (User authenticated as tytso@ATHENA.MIT.EDU)\n\tby outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 633Cuxnx028499\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 3 Apr 2026 08:57:00 -0400","by macsyma.thunk.org (Postfix, from userid 15806)\n\tid 6AFF4610121C; Fri,  3 Apr 2026 08:55:59 -0400 (EDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775221052; cv=pass;\n\tb=TpWpEJgytpUMGKF6mfynhUpJvqjf9o+uObe6wLxl3sjRyy1iS5qE1SEJT3D2ERGw5XY9187Mez5i3T6nKTyB9PDgiE/VIai8AjYTvIYaVx5TAmUtW+jnIdptjaFhJIj0tsjLJNhVVj/ITbupqewTXrxPqdMH/6rhDrZXJcwAmI4eQ/qUEaMdUKo4WuVWRTV6/SPavw0utQl2fjkl1lRaYYrWBhIB5jPfUKpECkB5b/oRT6JyPj8ngc7RMYp4hpJ0bLkliKlkHfBumZaIM4LFGeV2M1IcbDhR8VFMhUj2Xa7QDUMRRp1oyqp81NnX2JgjbiC4S2XCnTMNUbqSMv4fvw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775221041; cv=none;\n b=DLU5/Q5cr5HpLeiqOj59dgeMmtUxMHTpweVJeuFj02hTrqEuwThEoOPKm1veRcLC3zSWJwnn5QL64r+5lx0yrlMndNln9kVT1uz/AIM/y9nWQTwYRqVyzhYn/ZvKj4j4O4nfTDl7WcaX3TvkrxKo+Nivhwi52OrQ3bRi+drEUo8="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775221052; c=relaxed/relaxed;\n\tbh=ABSQoXdacPFvwlcLQgd966o92a7VJQx5GHpFilRME48=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Kihnz/7Hc6jf06it4a6GXCc1qy3NJ0gpmGMT605Eqr3pam5SxYB2WtnQJLzhE+d1u2R7Bqh61QgwmHxEyfOzf1+VTSKNXWFgsKovXH3sONgu5PTGF5JlrGOqQ8VgoarSqLFpGvXH2dgkRT8iTDnIb+AqZx+f1oeKzTF0dc7dLEJORWnnK65t6mV1q3jA5mDPLl2xL0XYgEHUlWpw5mUS5xn/nKciYU6tSlTx+f6leYuTPeNQaW0H1PjHkS9h+6BmGCRsmCgMaLuCYSiZs87I+EYEgDyRhhUyU3KM2PGJZXxl/r3SlZWROS0RYVPOSnP225hua7lu3gxgwFeJR6hEqA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775221041; c=relaxed/simple;\n\tbh=iP8tlsZT0oQYcykLZdFUTmr3rwnq4htG6uiAafEkc4c=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=o/EXjvTssOadnEeife7bYVtHeN87xCCnMni/4hI1TRNuMCK5Mr46Srteo0GblcMuc/V+fmC3CGG8zq3FJwZwpwHjeJ/6QC7Uw/IimxQehrb4OdiODOdSKK5xarId/IX9BYXvetNPK5Fe3Z6koyMeQX3EecJcYYG9kG3TgJiz/dg="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu; dkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=RYC4Z/L+; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15626-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu;\n spf=pass smtp.mailfrom=mit.edu;\n dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=RYC4Z/L+; arc=none smtp.client-ip=18.9.28.11"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing;\n\tt=1775221023; bh=ABSQoXdacPFvwlcLQgd966o92a7VJQx5GHpFilRME48=;\n\th=Date:From:Subject:Message-ID:MIME-Version:Content-Type;\n\tb=RYC4Z/L+2xt82rnWBbFpmKY+S8oqAI387X3jsKyI5hdNm+CdAYpHQbv3zROnFwXJ3\n\t J2QibkGmdTsrxkR0PnphoZsGfLtUNPWwqkVQDjvj6oBC/8iFxt2ppT2LcdnBCMAzEZ\n\t pdeCsEw+PUwu848YcFjAQmUJ0NzVXNt8fHkBs/ArI3jr9vbsAyWuPzdN2Aa/zR6iIU\n\t XqRhDiNk8FrKQ0HlNjR5LlL76Mlh0X5R3mq28/PneQCX6Nf7f66efLmRKRMk7eNyx1\n\t oyQbRmXrpWB3krH//EqDT/8nNilAYyPVlW4du9C8072biy3U+2ixPXVdQoLp/N91ew\n\t 8j7EeUpdWA0/Q==","Date":"Fri, 3 Apr 2026 08:55:59 -0400","From":"\"Theodore Tso\" <tytso@mit.edu>","To":"Ye Bin <yebin@huaweicloud.com>","Cc":"adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jack@suse.cz","Subject":"Re: [PATCH 1/3] ext4: register 'orphan_list' procfs","Message-ID":"<20260403125559.GC12260@macsyma-wired.lan>","References":"<20260403082507.1882703-1-yebin@huaweicloud.com>\n <20260403082507.1882703-2-yebin@huaweicloud.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403082507.1882703-2-yebin@huaweicloud.com>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]