[{"id":3673127,"web_url":"http://patchwork.ozlabs.org/comment/3673127/","msgid":"","list_archive_url":null,"date":"2026-04-03T13:22:01","subject":"Re: [PATCH v4 3/3] binman: collection: Set build_done on referenced\n entries","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-03T07:55:27, Paul HENRYS wrote:\n> binman: collection: Set build_done on referenced entries\n>\n> The collection etype uses phandles in the 'content' property to\n> reference other entries. Mark each referenced entry with build_done\n> to avoid rebuilding the same entry data multiple times.\n>\n> This is important for cases where rebuilding may change the data\n> content, e.g. due to timestamps or random IVs in encryption.\n>\n> Refactor GetContentsByPhandle() to return both the entry object and\n> its data.\n>\n> Signed-off-by: yan wang \n>\n> tools/binman/etype/collection.py | 8 ++++++--\n> tools/binman/etype/section.py | 5 +++--\n> 2 files changed, 9 insertions(+), 4 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=WWU/Wvve;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"WWU/Wvve\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnKC52tgBz1yCs\n\tfor ; Sat, 04 Apr 2026 00:22:25 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3125483DC9;\n\tFri, 3 Apr 2026 15:22:19 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 53D5083642; Fri, 3 Apr 2026 15:22:18 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 012B484106\n for ; Fri, 3 Apr 2026 15:22:16 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-b9c3e2cf3c0so277279566b.1\n for ; Fri, 03 Apr 2026 06:22:15 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775222535; cv=none;\n d=google.com; s=arc-20240605;\n b=B+ff65EWvEcA8dgNRdn6iHnPzZLPy8oyupT0EJ1ymGSawm66TdwvMWR8rLveTAMbdS\n gMxc4TMZdGqf2SNGQHC6x6jbEJoUy6pzqKVJYxrKrVXc6wAEjTyV4+wSiW0zg6y8w+Oe\n 9R+EmMnbAoXaeJ40Ox0sFMdbTu3qp/RNNmx8udiBN8JPxI3R9cz/BWHyo0BIeIom/YlJ\n BVsU9XSk15NbkaZ+kNl2bWVpXCh9395bnmR9sxeVf77cKm7AhPQsif4LIiI6/5gPD08f\n XLl+gy5RbHn0gxUZSLeQfZWxTpjP2bpfACKp1Liu/SThFVPnFPGBSuceIbcKt3cpcRwo\n CTYw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=wJ353VM6GGFoQkksQZ/fGTbFeFTgeGyCLoBGXMvL8Og=;\n fh=GoI+sirgUYAsy875+zYsOf9xP8IMILer9nqBWQEMKjo=;\n b=Tkll66yr4guQ3dIxXgmrKHohJtLsQJgn7VFIM4qX+qsBuhQGRkSyg0PwsGl3QXnZde\n 6pw6qP8XfxfqVNN1ooinhhX6SwZzpSmgq06vk7CCWaKZHmWqwp792scoWL9nb3awouML\n Kjr66XAevVYAOMuPdzTVWpo2SxIkjvGfFEz8Rq46TiUjcyk3nMyqVIwrLjbDv42inLOg\n OaCGO/JTILLUpobWAXtwy2UfwAPA9y6eVn6foCQqC76YWxe9bhLs2BvclRH8si0kffg8\n f4RupSZbGhOxBOx8AI+fJeuBH0kS+MClL7ZX5bCEzbmpyBGrEH6ttdzNKCeEY8AI0Ijm\n QuwQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775222535; x=1775827335; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=wJ353VM6GGFoQkksQZ/fGTbFeFTgeGyCLoBGXMvL8Og=;\n b=WWU/WvverC0xAZZT1wstBcGC4QHF2cgC1PYO2POfEn5hR/WSF/Yt7cFSsZa5c5bV9b\n E5KabZ7emO2pD41nhS4FUbs2USktYK+SdDbHKLp36Ix7EpspKZy6XUe/iiLUckxTMjAl\n RiUilijAvgNUMVKX124hBtjpzraDdxyqCBXTs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775222535; x=1775827335;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wJ353VM6GGFoQkksQZ/fGTbFeFTgeGyCLoBGXMvL8Og=;\n b=JmzKPvNogPdidZm1dBb9eu99IUAzkIl/5M6raCf5FtZodp9eD2hcRln1awMjucoQdw\n QRUtlBBp2VVmrYFjoz/NkigF1oUYWLvrY+OxgY5W9cM2m27aBZXIOKdTuc0qAIL1V+Ey\n xqMS3dKfcPZJrZi0l7wCD+O9fsuiIXxx8MqDg3mVIFZKdgkqM3/LP8XW4ErASKa+HRPX\n IIOA+sOsDmEHhxv3kvtXRvGAjsaIdKB/3rLzMr2bw4UwGLN/48Qj7RwvosL4+ctG65KM\n cvJNQY53et2eywvGkhEwDEbk/7J9pITxEjYC0pMXERGAxAGOQte/rzs3osblcDIPbOCH\n DN/A==","X-Gm-Message-State":"AOJu0YxJB6MEocxTMmQKiF7nyGRwJFilDKVfWo6DLTANiFWTXBH+LXue\n IDG1YOKuhHsok46t1+oygGJlaA4aEbHegSPVFOVNDYvCUVs+2CL7C7I39Eaj9G/0NU+lXTDhiOO\n VVxQw4tj3KcdGLl4rKly3cq8APkVLZz/yC+Pxu9AG","X-Gm-Gg":"AeBDievjDlOAxH5WDWn32wC8GSt6iRC9/ZW1NT9wl3cDQFpyNQxc/AOlpziRKePkfCh\n HkA+CuMlM9o56YJQEG2oxbV2aISxwsPOOF0CB5TzokGku9c4NGr+a/jh7bou76KgtZSQHuC8JR1\n k/VTjigRusJYldeNixW/S2Xlcdr0NfdYt1uzF2DpAPVFX6FvIUvI5851xdgsYHF/5HMjOtADjiW\n UP5skiqFoq19z01M3/uYaA5d1eAlE53kaJoFS72ynFlx1sOYm+eYDQosSF5clWLP9vHA+w6BdJD\n 1s8dVw==","X-Received":"by 2002:a17:906:5999:b0:b9c:4fc9:87db with SMTP id\n a640c23a62f3a-b9c679add8cmr102206766b.30.1775222535354; Fri, 03 Apr 2026\n 06:22:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20260403073251.1051533-1-paul.henrys_ext@softathome.com>\n <20260403075528.1150196-1-paul.henrys_ext@softathome.com>\n <20260403075528.1150196-3-paul.henrys_ext@softathome.com>","In-Reply-To":"<20260403075528.1150196-3-paul.henrys_ext@softathome.com>","From":"Simon Glass ","Date":"Fri, 3 Apr 2026 07:22:01 -0600","X-Gm-Features":"AQROBzCZiPzSt2H50B9c6T1E7nOXlGL2iZnvHJt5J6m7t80DP_Qg-pftTBMsHDU","Message-ID":"\n ","Subject":"Re: [PATCH v4 3/3] binman: collection: Set build_done on referenced\n entries","To":"paul.henrys_ext@softathome.com","Cc":"u-boot+nodisclaimer@lists.denx.de, sjg+nodisclaimer@chromium.org,\n trini+nodisclaimer@konsulko.com, alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n yan wang , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]