[{"id":3673011,"web_url":"http://patchwork.ozlabs.org/comment/3673011/","msgid":"<3013fbbd-74ef-4636-9a18-5c35c4e8dd04@molgen.mpg.de>","list_archive_url":null,"date":"2026-04-03T08:09:33","subject":"Re: [Intel-wired-lan] [PATCH net-next] iavf: fix kernel-doc comment\n style in ethtool ops","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"Dear Leszek, dear Aleksandr,\n\n\nThank you for the patch.\n\nAm 03.04.26 um 07:43 schrieb Aleksandr Loktionov:\n> From: Leszek Pepiak \n> \n> iavf_get_channels() and iavf_set_channels() use the legacy `**/`\n> comment terminator and embed the return description in the body text.\n> Convert to proper kernel-doc style: single `*/` terminator and an\n> explicit `Return:` section.\n> \n> Signed-off-by: Leszek Pepiak \n> Signed-off-by: Aleksandr Loktionov \n> \n> ---\n> drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n> index 8188dd4..425acbb 100644\n> --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n> +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n> @@ -1846,13 +1846,13 @@ static int iavf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,\n> \treturn ret;\n> }\n> /**\n> - * iavf_get_channels: get the number of channels supported by the device\n> + * iavf_get_channels - get the number of channels supported by the device\n> * @netdev: network interface device structure\n> * @ch: channel information structure\n> *\n> * For the purposes of our device, we only use combined channels, i.e. a tx/rx\n> * queue pair. Report one extra channel to match our \"other\" MSI-X vector.\n> - **/\n> + */\n> static void iavf_get_channels(struct net_device *netdev,\n> \t\t\t struct ethtool_channels *ch)\n> {\n> @@ -1873,14 +1873,15 @@ static void iavf_get_channels(struct net_device *netdev,\n> }\n> \n> /**\n> - * iavf_set_channels: set the new channel count\n> + * iavf_set_channels - set the new channel count\n> * @netdev: network interface device structure\n> * @ch: channel information structure\n> *\n> * Negotiate a new number of channels with the PF then do a reset. During\n> - * reset we'll realloc queues and fix the RSS table. Returns 0 on success,\n> - * negative on failure.\n> - **/\n> + * reset we'll realloc queues and fix the RSS table.\n> + *\n> + * Return: 0 on success, negative on failure.\n> + */\n> static int iavf_set_channels(struct net_device *netdev,\n> \t\t\t struct ethtool_channels *ch)\n> {\n\nReviewed-by: Paul Menzel \n\n\nKind regards,\n\nPaul","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=plpYnigP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnBGf679xz1yCs\n\tfor ; Fri, 03 Apr 2026 19:10:00 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 66084606A3;\n\tFri, 3 Apr 2026 08:09:58 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jKpqUjpbxd0T; Fri, 3 Apr 2026 08:09:57 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 16E9560681;\n\tFri, 3 Apr 2026 08:09:57 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 9DCF11A9\n for ; Fri, 3 Apr 2026 08:09:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 8F0F160639\n for ; Fri, 3 Apr 2026 08:09:55 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NlR60oMSXfnN for ;\n Fri, 3 Apr 2026 08:09:54 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E5E7F606A3\n for ; Fri, 3 Apr 2026 08:09:52 +0000 (UTC)","from [192.168.2.229] (p57bd9728.dip0.t-ipconnect.de [87.189.151.40])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id 169814C2C37D58;\n Fri, 03 Apr 2026 10:09:36 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 16E9560681","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E5E7F606A3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775203797;\n\tbh=MbjhZi2bJN9+5VnBpc6vE+kn+nwe3T1CIFQtDNtzAsc=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=plpYnigP8Dso7hKRUmxjBGjtTLlQP57XJcDBbH1uHRphvP6K6AByHWVDAQqC3Uqki\n\t NK+AvKLJJCvK3WtXrXwnmwXbRglXGgvj6cJOSHXkQ3RA5kGUkzXntMYSHkRqW+Lm5b\n\t WqZWcsrJ/c42TXkUiebDZuXInhTDYdRtTVqVced86i+Tqs+vZW6OoilTLU4YxtY1Dr\n\t cfvx+mlHA7h4xSnIaS1RY89HlPJVNQFMobE1cQeaB+2O64lBbFx147xaxvbsABjz53\n\t 1ltakIxt5XYNOAYyIXCM91LGngk8Xtm97F0cdmS89oNPYbzpooTO4T6lGBiK6lUaN9\n\t G7P2EGhO3eJSw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E5E7F606A3","Message-ID":"<3013fbbd-74ef-4636-9a18-5c35c4e8dd04@molgen.mpg.de>","Date":"Fri, 3 Apr 2026 10:09:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","References":"<20260403054321.3791392-1-aleksandr.loktionov@intel.com>","Content-Language":"en-US","From":"Paul Menzel ","In-Reply-To":"<20260403054321.3791392-1-aleksandr.loktionov@intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-Authentication-Results":"smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH net-next] iavf: fix kernel-doc comment\n style in ethtool ops","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3673228,"web_url":"http://patchwork.ozlabs.org/comment/3673228/","msgid":"","list_archive_url":null,"date":"2026-04-03T16:57:18","subject":"Re: [Intel-wired-lan] [PATCH net-next] iavf: fix kernel-doc comment\n style in ethtool ops","submitter":{"id":91060,"url":"http://patchwork.ozlabs.org/api/people/91060/","name":"Joe Damato","email":"joe@dama.to"},"content":"On Fri, Apr 03, 2026 at 07:43:21AM +0200, Aleksandr Loktionov wrote:\n> From: Leszek Pepiak \n> \n> iavf_get_channels() and iavf_set_channels() use the legacy `**/`\n> comment terminator and embed the return description in the body text.\n> Convert to proper kernel-doc style: single `*/` terminator and an\n> explicit `Return:` section.\n> \n> Signed-off-by: Leszek Pepiak \n> Signed-off-by: Aleksandr Loktionov \n> \n> ---\n> drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n\nFWIW looks like there are a few other functions in this file that use the\n\"**/\" terminator. Not sure it's worth respinning to get them all, though, so:\n\nReviewed-by: Joe Damato ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=v6kvXcDZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnPzD2v2Hz1xtJ\n\tfor ; Sat, 04 Apr 2026 03:57:26 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 8B20782FBE;\n\tFri, 3 Apr 2026 16:57:24 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Bct9TMrEAlG4; Fri, 3 Apr 2026 16:57:23 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id EFF1882FA9;\n\tFri, 3 Apr 2026 16:57:22 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 3404E1F3\n for ; Fri, 3 Apr 2026 16:57:22 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 199E4610FC\n for ; Fri, 3 Apr 2026 16:57:22 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zMLhhLs6Kr7D for ;\n Fri, 3 Apr 2026 16:57:21 +0000 (UTC)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n [IPv6:2607:f8b0:4864:20::62d])\n by smtp3.osuosl.org (Postfix) with ESMTPS id C5977610FB\n for ; Fri, 3 Apr 2026 16:57:20 +0000 (UTC)","by mail-pl1-x62d.google.com with SMTP id\n d9443c01a7336-2b0ba3bfe16so24768375ad.1\n for ; Fri, 03 Apr 2026 09:57:20 -0700 (PDT)","from localhost ([2a03:2880:2ff:5f::])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2749a2e42sm58314565ad.56.2026.04.03.09.57.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Apr 2026 09:57:19 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org EFF1882FA9","OpenDKIM Filter v2.11.0 smtp3.osuosl.org C5977610FB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775235443;\n\tbh=2Zdj+x5c75FhlG1gdNDIWMuNMzhHYG3GmAfv3XQFkW0=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=v6kvXcDZinETRT5NYHzcYy9XKwVccA42jSCCvFgvpKYU0G4ftWaOFyPF/QhG+JkZi\n\t zkyf4PbrA9c5sAmesqNPr8KXYlrM7Kd52sGrWAlTCaTSog4CiPEjQIWaM6ZB0m9dIb\n\t KeBoWYNZW1AOM2bPO4V3Rhvei5AiAMLQzTkt9hyBPE0Jjwr3WX3cfGC8S4BpG7UbrU\n\t NRwgHVyHEb+SWzRh1pbw0HPo6qNjYHyV8Nk5HCUEhdwCpAr0beg8qkSz5FiP8udkMn\n\t nW9llPWaOS7WMXNf3B1c3lXf/07S0I2R0ckJGJlJPNfxYsnqAoFnF5RKGp0Ul+gvrb\n\t 6i2stTtVGFtRA==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::62d; helo=mail-pl1-x62d.google.com;\n envelope-from=joe@dama.to; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org C5977610FB","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775235440; x=1775840240;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=2Zdj+x5c75FhlG1gdNDIWMuNMzhHYG3GmAfv3XQFkW0=;\n b=Wp2dnPwEjWl4VjYDD8tGAZP6RD7YH9GRntAh8QM3aH9CDZXgHhHt29EVdmh3V2Re19\n hPXrN1Kd4H8hJltYS/T5I30x1vATfkFZw7RSSNjBb8rIxq5M27AoZ4ktlNVoBdw5g6j6\n HLr6yj9p/t7tEOjUF8UN0QPzRozSM47NcMULYIuelj/vrqoRZQI5KiiaHL6zLtOo13ah\n ZzqXMoas3Y/pdJcXwCzb41o/MHU5m9WaDP4OLGZfI00UTs0uFtzu/sh2cWrBqK5bD1RC\n DWn5D/rOrGqO+o4pUuFu3z5Cv1k0h3Ct6p209u7siLSITWicoA7ZPuKX7vTShEfxQKiM\n E+CQ==","X-Gm-Message-State":"AOJu0Yzuhd7JTmPzmquTJ0955oceucoJTWVAX+JbYwyHR5dxT7cDXJCx\n knbU9JdUP8n4N3ppYLqN8l/p5Gx4HeIibYVcHddccno4+LZfwsLAXQpbVNqMpJwH7ltPd5bYjbw\n Ll8CqSDM=","X-Gm-Gg":"AeBDievIyvdSDQEir/xQ6SU/WVfsVvtE37sGmoXo26xQxSUoXGsj6tujakScxlW/5Yk\n oQF++ju3i7svmxd8WwCHctn5sPATEmnLZ5y7NGrWSl8Ik6UXg0adx4nfp1ASTTG7Jvj1X+JNTzy\n OSw5hlKfRMWS/a0MSpJGLCb0CTVg9gK0ldPpL3MX0hIuVdgKne2O4TApYPISc8Z2soMJ6JZvvfv\n jlIpjwsr6t7baeoP+nAPBeO4iWzMLExCrxXTTyTyR2LozutdSkgiCCrv6oil1OODyqlh8VzUKhN\n PLAeIeWcdw6s1/zJGEdn7ydNNpb6j0f0oi6EOnwQ5AyRLRQTaf7+6GNKMv0KDQhFNm9aLLPg2NE\n j1ABBEd2QHaIvh6ttP4EfRPTeaFo6OtQ9vKbwKf9xKxxTnRbUSWarllUClhLaNlGQSzfGcPzhko\n Oqp0Gh","X-Received":"by 2002:a17:902:e84d:b0:2b0:5a4c:726f with SMTP id\n d9443c01a7336-2b277e3745cmr65000805ad.15.1775235439715;\n Fri, 03 Apr 2026 09:57:19 -0700 (PDT)","Date":"Fri, 3 Apr 2026 09:57:18 -0700","From":"Joe Damato ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","Message-ID":"","Mail-Followup-To":"Joe Damato ,\n Aleksandr Loktionov ,\n intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","References":"<20260403054321.3791392-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403054321.3791392-1-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775235440; x=1775840240;\n darn=lists.osuosl.org;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2Zdj+x5c75FhlG1gdNDIWMuNMzhHYG3GmAfv3XQFkW0=;\n b=wcjw2lZGRCONXtvZp+uwvzRlD8xyd7m8oPzT2EyCbG5zArf1lGdfWxsYgSvFUU5jER\n p9pwilJ0sunzbNOtWZiB89l61bGAxFuEpQW4IfluH5DGaRRwFpvwcYJYXacG38aWBjWN\n pQAYJ2vRDsrSZak4/s+o5VhKXslNYaJIGII40l5kIHT6R4mSrVzkfJTGQvQuyIxCVeQw\n PdyQnEn+f6pcxZ19nap5KOD3nWaKdU5T+45Abo6cbrWymOVvSg9pgh+nXydMJX/PcY/g\n dYIuSPKfOiPVJ+XKQXA3o1qHraPMbnY7s/b2t3TfavMwYe3zHh50Lw8c4jDse0TtZnf9\n rSNw==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=dama.to","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=dama-to.20251104.gappssmtp.com\n header.i=@dama-to.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=wcjw2lZG"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next] iavf: fix kernel-doc comment\n style in ethtool ops","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]