[{"id":3672980,"web_url":"http://patchwork.ozlabs.org/comment/3672980/","msgid":"<20260403041624.GD6254@frogsfrogsfrogs>","list_archive_url":null,"date":"2026-04-03T04:16:24","subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/people/77032/","name":"Darrick J. Wong","email":"djwong@kernel.org"},"content":"On Fri, Apr 03, 2026 at 12:03:26AM -0400, Theodore Ts'o wrote:\n> The function pthread_setname_np() is non-portable; that's what the\n> \"np\" means.  In particular, on Mac systems, the function takes only a\n> single argument, while on most other systems which have the function,\n> it takes two arguments.\n> \n> Also fix a problem where a 1-bit signed integer can only accept values\n> of 0 or -1.  Change it to be a 1-bit unsigned integer, which can\n> accept values of 0 or 1.  Clang will issue a warning if 1-bit signed\n> integer are used incorrectly, and fail with -Werror.\n> \n> Signed-off-by: Theodore Ts'o <tytso@mit.edu>\n> ---\n>  configure             |  6 ++++++\n>  configure.ac          |  1 +\n>  lib/config.h.in       | 24 +++++++++++++++---------\n>  lib/support/bthread.c | 12 ++++++++++--\n>  4 files changed, 32 insertions(+), 11 deletions(-)\n> \n> diff --git a/configure b/configure\n> index 4da5439fe..b9a82dcec 100755\n> --- a/configure\n> +++ b/configure\n> @@ -13887,6 +13887,12 @@ if test \"x$ac_cv_func_pwrite64\" = xyes\n>  then :\n>    printf \"%s\\n\" \"#define HAVE_PWRITE64 1\" >>confdefs.h\n>  \n> +fi\n> +ac_fn_c_check_func \"$LINENO\" \"pthread_setname_np\" \"ac_cv_func_pthread_setname_np\"\n> +if test \"x$ac_cv_func_pthread_setname_np\" = xyes\n> +then :\n> +  printf \"%s\\n\" \"#define HAVE_PTHREAD_SETNAME_NP 1\" >>confdefs.h\n> +\n>  fi\n>  ac_fn_c_check_func \"$LINENO\" \"qsort_r\" \"ac_cv_func_qsort_r\"\n>  if test \"x$ac_cv_func_qsort_r\" = xyes\n> diff --git a/configure.ac b/configure.ac\n> index ecef9df39..2473879fd 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -1269,6 +1269,7 @@ AC_CHECK_FUNCS(m4_flatten([\n>  \tpwrite\n>  \tpread64\n>  \tpwrite64\n> +\tpthread_setname_np\n>  \tqsort_r\n>  \tsecure_getenv\n>  \tsetmntent\n> diff --git a/lib/config.h.in b/lib/config.h.in\n> index 8ea7ec2b1..c6cbced5f 100644\n> --- a/lib/config.h.in\n> +++ b/lib/config.h.in\n> @@ -46,9 +46,6 @@\n>  /* Define to the version of FUSE to use */\n>  #undef FUSE_USE_VERSION\n>  \n> -/* Define to 1 if fuse supports cache_readdir */\n> -#undef HAVE_FUSE_CACHE_READDIR\n\nHuh, there's a lot of churn in this file.  Do you have a magic script\nsomewhere that regenerates config.h.in?\n\nI don't see any problems with this file's changes, but I could also not\nscatter junk everywhere :)\n\n> -\n>  /* Define to 1 if you have the 'add_key' function. */\n>  #undef HAVE_ADD_KEY\n>  \n> @@ -73,9 +70,6 @@\n>  /* Define to 1 if you have the BSD-style 'qsort_r' function. */\n>  #undef HAVE_BSD_QSORT_R\n>  \n> -/* Define to 1 if PR_SET_IO_FLUSHER is present */\n> -#undef HAVE_PR_SET_IO_FLUSHER\n> -\n>  /* Define to 1 if you have the Mac OS X function\n>     CFLocaleCopyPreferredLanguages in the CoreFoundation framework. */\n>  #undef HAVE_CFLOCALECOPYPREFERREDLANGUAGES\n> @@ -87,6 +81,9 @@\n>  /* Define to 1 if you have the 'chflags' function. */\n>  #undef HAVE_CHFLAGS\n>  \n> +/* Define to 1 if CLOCK_MONOTONIC is present */\n> +#undef HAVE_CLOCK_MONOTONIC\n> +\n>  /* Define if the GNU dcgettext() function is already present or preinstalled.\n>     */\n>  #undef HAVE_DCGETTEXT\n> @@ -136,9 +133,15 @@\n>  /* Define to 1 if you have the 'fsync' function. */\n>  #undef HAVE_FSYNC\n>  \n> +/* Define to 1 if FS_IOC_READ_VERITY_METADATA ioctl is available */\n> +#undef HAVE_FS_IOC_READ_VERITY_METADATA\n> +\n>  /* Define to 1 if you have the 'ftruncate64' function. */\n>  #undef HAVE_FTRUNCATE64\n>  \n> +/* Define to 1 if fuse supports cache_readdir */\n> +#undef HAVE_FUSE_CACHE_READDIR\n> +\n>  /* Define to 1 if you have the <fuse.h> header file. */\n>  #undef HAVE_FUSE_H\n>  \n> @@ -313,6 +316,9 @@\n>  /* Define to 1 if you have the 'pread64' function. */\n>  #undef HAVE_PREAD64\n>  \n> +/* Define to 1 if PR_SET_IO_FLUSHER is present */\n> +#undef HAVE_PR_SET_IO_FLUSHER\n> +\n>  /* Define if you have POSIX threads libraries and header files. */\n>  #undef HAVE_PTHREAD\n>  \n> @@ -322,6 +328,9 @@\n>  /* Have PTHREAD_PRIO_INHERIT. */\n>  #undef HAVE_PTHREAD_PRIO_INHERIT\n>  \n> +/* Define to 1 if you have the 'pthread_setname_np' function. */\n> +#undef HAVE_PTHREAD_SETNAME_NP\n> +\n>  /* Define to 1 if you have the 'pwrite' function. */\n>  #undef HAVE_PWRITE\n>  \n> @@ -699,7 +708,4 @@\n>  /* Define to 1 on platforms where this makes time_t a 64-bit type. */\n>  #undef __MINGW_USE_VC2005_COMPAT\n>  \n> -/* Define to 1 if CLOCK_MONOTONIC is present */\n> -#undef HAVE_CLOCK_MONOTONIC\n> -\n>  #include <dirpaths.h>\n> diff --git a/lib/support/bthread.c b/lib/support/bthread.c\n> index 936ca0f0f..87eeb1b3d 100644\n> --- a/lib/support/bthread.c\n> +++ b/lib/support/bthread.c\n> @@ -9,6 +9,7 @@\n>   * %End-Header%\n>   */\n>  #include \"config.h\"\n> +#ifdef HAVE_PTHREAD\n\nHmmm if we don't have pthreads, then shouldn't bthread.h also exclude\nall the function declarations ifndef HAVE_PTHREAD?\n\n>  #include <stdlib.h>\n>  #include <errno.h>\n>  #include <pthread.h>\n> @@ -33,7 +34,7 @@ struct bthread {\n>  \tbthread_fn_t fn;\n>  \tvoid *data;\n>  \tunsigned int period; /* seconds */\n> -\tint can_join:1;\n> +\tunsigned int can_join:1;\n\nThat works, though I suppose you could change it to bool.\n\n--D\n\n>  };\n>  \n>  /* Wait for a signal or for the periodic interval */\n> @@ -101,7 +102,13 @@ int bthread_create(const char *name,  bthread_fn_t fn, void *data,\n>  \tif (error)\n>  \t\tgoto out_cond;\n>  \n> +#ifdef HAVE_PTHREAD_SETNAME_NP\n> +#ifdef __APPLE__\n> +\tpthread_setname_np(name);\n> +#else\n>  \tpthread_setname_np(bt->thread, name);\n> +#endif\n> +#endif\n>  \n>  \t*btp = bt;\n>  \treturn 0;\n> @@ -178,7 +185,7 @@ int bthread_cancel(struct bthread *bt)\n>  /* Ask the thread to cancel itself and wait for it */\n>  void bthread_stop(struct bthread *bt)\n>  {\n> -\tint need_join = 0;\n> +\tunsigned int need_join = 0;\n>  \n>  \tpthread_mutex_lock(&bt->lock);\n>  \tswitch (bt->state) {\n> @@ -199,3 +206,4 @@ void bthread_stop(struct bthread *bt)\n>  \tif (need_join)\n>  \t\tpthread_join(bt->thread, NULL);\n>  }\n> +#endif /* HAVE_PTHREAD */\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"\n <SRS0=cNyU=CC=vger.kernel.org=linux-ext4+bounces-15616-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fxPks6/x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=cnyu=cc=vger.kernel.org=linux-ext4+bounces-15616-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fxPks6/x;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15616-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fxPks6/x\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn55C6fwFz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 15:16:31 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fn55C51XHz4wDN\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 15:16:31 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fn55C4yK0z4wSc; Fri, 03 Apr 2026 15:16:31 +1100 (AEDT)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fn5582fylz4wDN\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 03 Apr 2026 15:16:28 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EA244300E262\n\tfor <patchwork-incoming@ozlabs.org>; Fri,  3 Apr 2026 04:16:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7D2562BE7B6;\n\tFri,  3 Apr 2026 04:16:25 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 40CF217BED0\n\tfor <linux-ext4@vger.kernel.org>; Fri,  3 Apr 2026 04:16:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 10297C4CEF7;\n\tFri,  3 Apr 2026 04:16:25 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775189791; cv=pass;\n\tb=J3k9YEzGiX8ZUzbV9QuHVDh4cej7B3waPoP98ySkbLam9nlYx/TsIEKbSd/YwyjgemB1JL03ubvYCgqMvkRH2Edn/BuSW2rxKomT5kEQnKP6836avWj4FLsJ5sk3gaGjJcHvSv6lHWBuH/kHU91n1e7lcV3VR0Kzi7e7OPn5uElVP4PBUHVLXgpJq+z1dNyRRkTZ8Gk3CUgh/gGnGNMpclLs5J52zdPFB4LF+ENdNq1cpp4ZVQHZSWlsKQR9GOdNLltWkrazY2YW6XCAOHr16hYlfWUqOV9O+G0dz1u8L/+ietsBB1yXMcaY2v2MQF9/8zb1aifgcuk+vZlXDPgOtw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775189785; cv=none;\n b=aQAnV2nGNa8O24RNeSfmyoPG6ClismU09woXqri8mEBVEOjiOwG2etwEIxX0k2BqO/BQbnzINeXDfDhsMFWfnSS2GHLyGILQN4tp25o+xWR2JK9RpGztBD+3kCsTACyNwqANwBSDDE4tHCw6wNttWpU6TQkq3GBcgVvRpTKgcWc="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775189791; c=relaxed/relaxed;\n\tbh=sWKvvbr+SisVC8pyqw/X+NQ9DJ5dDO6fzKaFc1MtWHk=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=q1/aLktiLRVx360htM+IWBFj5t8Pr2oVIXNiuriVxoOIAgDj3wi4JnQWs2f0WCUDBLqYiQPEDTVT9jlGPvD8gT0SbiGjd9jlyHan+yjsUPkJ+cbQ7j0+M3DrVW9+IacMaZ2ozG7tgk+wP7upZIobzv07mUTSempzMA6u8YAQqjDKIv2HBv+pJrQEFQ/90OrRJD7bxjGqMehGFlqJLrj1GSB3xfUhElgzI2LgN8LTJpPKKQnWTzP68gK2sgunBjjktOcbrEzv1NwzcD8eubU140nGj6BZFzx3ONx7ODkBODJ2xV9wSP1rylFEKOIPnaYjFHssII0AGW4UleF55F5xXg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775189785; c=relaxed/simple;\n\tbh=/mxbgsE/Cdir0ic3oO8lsLtCRg/wt/4OuQTA0pV10pY=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=QMXpXS6eiMHud9UlabPIIMFsRZpSfycIv3Q/ZoDzensCa2iqdjH1GBFPQInPXU4S/t45fW1wSZHkrFgK7XjWYv7ULchvIQkfzuY+KNWCg5PPChhMkhZFokNrdUHqnpxPn5G9hmbEVN1W1mLel0JpeiwqOJa1rqrGiNp34h987MA="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fxPks6/x; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15616-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fxPks6/x; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775189785;\n\tbh=/mxbgsE/Cdir0ic3oO8lsLtCRg/wt/4OuQTA0pV10pY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fxPks6/xuGqpN7m8UXxfikotPKYpq0vasK1dQPQaRuldRvyMdRLdBpw5NzAPS1u+l\n\t 5FfLz4g4XyJI71imTPDjdGq95B/D7DAKoSE41Skr6zTrvev1TVXkHQY3BPz+VMNZqA\n\t W94hbopFWmA3CsjuXIlr0yG2FpbIP5PRuBXgZvRve1MxvQVqkx5zfSFQ9WPQA69AND\n\t MWe+SE9srXQ/ni/WOzyV1/oa97JmHaKylh2owflkNF3sJopyWCK6zz2VuYakv8r5+o\n\t el62CO2c7/h0MD2rB4Wr4vhFSRt5svsvKJ+6XrB/SxJYk/kjMCoS36Hv7/4Nt4zz7F\n\t Y7wwOlvQ9di0w==","Date":"Thu, 2 Apr 2026 21:16:24 -0700","From":"\"Darrick J. Wong\" <djwong@kernel.org>","To":"Theodore Ts'o <tytso@mit.edu>","Cc":"Ext4 Developers List <linux-ext4@vger.kernel.org>","Subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","Message-ID":"<20260403041624.GD6254@frogsfrogsfrogs>","References":"<20260403040328.2385083-1-tytso@mit.edu>\n <20260403040328.2385083-2-tytso@mit.edu>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403040328.2385083-2-tytso@mit.edu>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3673089,"web_url":"http://patchwork.ozlabs.org/comment/3673089/","msgid":"<20260403115313.GA12260@macsyma-wired.lan>","list_archive_url":null,"date":"2026-04-03T11:53:13","subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Ts'o","email":"tytso@mit.edu"},"content":"On Thu, Apr 02, 2026 at 09:16:24PM -0700, Darrick J. Wong wrote:\n> > -/* Define to 1 if fuse supports cache_readdir */\n> > -#undef HAVE_FUSE_CACHE_READDIR\n> \n> Huh, there's a lot of churn in this file.  Do you have a magic script\n> somewhere that regenerates config.h.in?\n\nIt's \"autoheader\".  Whenver you add or remove tests to configure.ac,\nyou need to run \"autoconf ; autoheader\".  If you don't run\n\"autoheader\", then even if the autoconf's feature test enables some\nnew feature test, say HAVE_PR_SET_IO_FLUSHER, the feature won't\nactually be enabled in the #ifdef.\n\nCheers,\n\n\t\t\t\t\t\t\t- Ted","headers":{"Return-Path":"\n <SRS0=ba8G=CC=vger.kernel.org=linux-ext4+bounces-15625-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=FMqqk10s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=ba8g=cc=vger.kernel.org=linux-ext4+bounces-15625-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=FMqqk10s;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15625-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=\"FMqqk10s\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=18.9.28.11","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=mit.edu"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnHHL0cGWz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 22:55:57 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fnHHK3nZRz4wG6\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 22:55:57 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fnHHK3RKTz4wT7; Fri, 03 Apr 2026 22:55:57 +1100 (AEDT)","from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fnHHF0f9mz4wG6\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 03 Apr 2026 22:55:53 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 4187D300BCB6\n\tfor <patchwork-incoming@ozlabs.org>; Fri,  3 Apr 2026 11:54:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A138A3BD226;\n\tFri,  3 Apr 2026 11:54:24 +0000 (UTC)","from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BE13BC680\n\tfor <linux-ext4@vger.kernel.org>; Fri,  3 Apr 2026 11:54:22 +0000 (UTC)","from macsyma.thunk.org (pool-173-48-112-174.bstnma.fios.verizon.net\n [173.48.112.174])\n\t(authenticated bits=0)\n        (User authenticated as tytso@ATHENA.MIT.EDU)\n\tby outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 633BsETk002779\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 3 Apr 2026 07:54:15 -0400","by macsyma.thunk.org (Postfix, from userid 15806)\n\tid 94F1160FF991; Fri,  3 Apr 2026 07:53:13 -0400 (EDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775217357; cv=pass;\n\tb=Cqy3p9EhlxR6H1Yk6F4CohV7dFFChY/Sk7YmAuaos2Y+wZTwSFqr8jgGtc0xSh8HuclauC5RGsH6idH71OhOvDt3nms8YRVBepDvH1Z8sB0+7Xjv6PSV559Vs76V8lZYBY5x39Ii9oEghXdUb8yc/3+9r1/k/wxELIJK52z0WX6QNvB8O1YZ4dQoVrza6QtpP+GxqFtUnZ48PMBmvd3HHFFNi1ltBJqiJ/SFLy6gk/Ezvklr9FeP02ifHxjLSMqvGnHSi5bpuXDq2hFwAW4TxpvGsUc1FwlpPK6zfXmBIzfI2i/BN4+llxMLF6mFPEl5j+hVqVr9GwWQmhBPN2RzLg==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775217264; cv=none;\n b=PAeXulLoaG4vsXhrN7binUPewaItZQEIPKx5UvZFKEfTwirYlK3GsNHxa9xadg0P3A6O0PN2bM8wVaRrivx43NvjvS5bU/XzMaOwOJGT6Cq5vn5XPjInejLiiboLEIMHNWldqvkqI/1Lyin704VTTmDkZYrrd42vVskImNZ6mnA="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775217357; c=relaxed/relaxed;\n\tbh=xILsTs+8T0FrGTJASkQ0wa4ZlXpCbhRtexlPlzFgvOA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=NdiMTtK9N3wQ60PmUC5exmM5PfbeYQht1WYtSSt5ks0iHWjVxSDoAqNFR/1S5UvoIeVRNLsgczKNmJ0CmUiKHr7vSCabACHMpWg/bOyrzJJVSYRaXmo/IQdmKg1nN9e1+HmNqF3aQtMrkuEgIKtpU7rQs+i3LuI+qJSlDq6rGKlaUVdPOJ9NH+dWeU8jJVGDbO/d+doNu/+9ldzRBGQ8AdiaWsob2PiBrVD1SIGpEoKnNB61AbpxB2i5WsbuSSWoxFHwhNrkuFhevaGhxJaJIyESphnqgav18fULioXfaSkq9YBav7PWrAnDiT41zoY5BYKTEg7zdooM/Vf0Nra9fg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775217264; c=relaxed/simple;\n\tbh=UwqKyLWLziEgV+1hrGCsLI6mKeWnvVXjKwYl6Ea7jQ8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=NeRy68wuWFRyOrpoQC2hHMbILVhUuK7wrN5WWWRy6jCtilOzAmdjtiTn4ToBiwQUGv7D9X9IaKkgCY6Q1VXQonWggXrCn6B+mnV3BaTkRg1JEtxjL6aC7AeuUo10HAzQqJ31JLspm2uS/8qNiGCKcYqShj4Xl8wwj1AYOhsXz8s="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu; dkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=FMqqk10s; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15625-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu;\n spf=pass smtp.mailfrom=mit.edu;\n dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=FMqqk10s; arc=none smtp.client-ip=18.9.28.11"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing;\n\tt=1775217255; bh=xILsTs+8T0FrGTJASkQ0wa4ZlXpCbhRtexlPlzFgvOA=;\n\th=Date:From:Subject:Message-ID:MIME-Version:Content-Type;\n\tb=FMqqk10s7yoZNgpT/QIATBg9znV5W/85ucm3PMdkdjpfLdNtymFDozpAazAV7K6N4\n\t BcEFga/61q3pBn/6XAc2WDqpLRIBCCGxvtVWhc4h3BKgfI9qsrWBDS2YoZKt04nXxy\n\t 895ABSVSJsvCoZrrNX4pz8Q+6jYNZW+hO9x33vOrSpFk6l20lz9EEXUhoO+hr5Df4v\n\t KFiPlPl5kBjRIvRQzee40Hd6OXY6RV+viW5+cwt3/zD4Zg9OXSJtzZuZJAnZT49X8+\n\t aDUo5sM7dh9nT1UQpUEQ1byZ3x7FSgdeKgJ46mjoJBS9eNk/pUppJv/FrPiYOcPUJT\n\t 1A8x4T1ETS6hQ==","Date":"Fri, 3 Apr 2026 07:53:13 -0400","From":"\"Theodore Tso\" <tytso@mit.edu>","To":"\"Darrick J. Wong\" <djwong@kernel.org>","Cc":"Ext4 Developers List <linux-ext4@vger.kernel.org>","Subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","Message-ID":"<20260403115313.GA12260@macsyma-wired.lan>","References":"<20260403040328.2385083-1-tytso@mit.edu>\n <20260403040328.2385083-2-tytso@mit.edu>\n <20260403041624.GD6254@frogsfrogsfrogs>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403041624.GD6254@frogsfrogsfrogs>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3673168,"web_url":"http://patchwork.ozlabs.org/comment/3673168/","msgid":"<20260403151535.GI6254@frogsfrogsfrogs>","list_archive_url":null,"date":"2026-04-03T15:15:35","subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/people/77032/","name":"Darrick J. Wong","email":"djwong@kernel.org"},"content":"On Fri, Apr 03, 2026 at 07:53:13AM -0400, Theodore Tso wrote:\n> On Thu, Apr 02, 2026 at 09:16:24PM -0700, Darrick J. Wong wrote:\n> > > -/* Define to 1 if fuse supports cache_readdir */\n> > > -#undef HAVE_FUSE_CACHE_READDIR\n> > \n> > Huh, there's a lot of churn in this file.  Do you have a magic script\n> > somewhere that regenerates config.h.in?\n> \n> It's \"autoheader\".  Whenver you add or remove tests to configure.ac,\n> you need to run \"autoconf ; autoheader\".  If you don't run\n> \"autoheader\", then even if the autoconf's feature test enables some\n> new feature test, say HAVE_PR_SET_IO_FLUSHER, the feature won't\n> actually be enabled in the #ifdef.\n\nAha!  Thanks for that tip; I'll go fix my dev branch.\n\n--D\n\n> Cheers,\n> \n> \t\t\t\t\t\t\t- Ted","headers":{"Return-Path":"\n <SRS0=jB1y=CC=vger.kernel.org=linux-ext4+bounces-15629-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DfvYl5aB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=jb1y=cc=vger.kernel.org=linux-ext4+bounces-15629-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DfvYl5aB;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15629-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"DfvYl5aB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnMll4kM8z1yCt\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 02:17:23 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fnMlk1lfgz4wTX\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 02:17:22 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fnMlk1JSGz4wCp; Sat, 04 Apr 2026 02:17:22 +1100 (AEDT)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fnMlf5NQdz4wSR\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 04 Apr 2026 02:17:18 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3C894301AA46\n\tfor <patchwork-incoming@ozlabs.org>; Fri,  3 Apr 2026 15:15:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BCA053148B4;\n\tFri,  3 Apr 2026 15:15:36 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A7929B799\n\tfor <linux-ext4@vger.kernel.org>; Fri,  3 Apr 2026 15:15:36 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 1B1CBC4CEF7;\n\tFri,  3 Apr 2026 15:15:36 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775229442; cv=pass;\n\tb=XJT3/NijJpPKDnzHHxX2w2xXUvfLrfBOfuK5HX1jW4W2B51GuT/ob6qfY8LSl+BUl41kBhrocdfrxQwQUDog8hx5D+f8imdHq6DyFsPegHBLmEEFlkzY2io0R4H1+1B4r5VYeV6XJWkd5cET/OMcrlPZt11Wx2TwfjS4mnxrXu2WDDEcnjttmA5HKlbLYtf/i0yLh+1Un2EcLvnih3jR2rQNludyUKqXkaJZYkQee7NSR+tm+1yxgk8s8eCBCqVtgB9oGXwoFyBsZ/Pb4udwarHvIAt4vLEkrxyxNE7da1PVi4sYPTKyJrpBtmz2fNuUDx+dM7aiTEK9nt026fDDbQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775229336; cv=none;\n b=gKr5SCYtEWjjeIBj2IZZq+tDp1G8IIHsnRX/JMm1bvDC5ScUf8St2nUMEXwvZc0c8r/n4zcOzc4fl2jSPUBq9DpqNH6ettAGSAVrt4JdZOWkOCr2DNNy6+5q+TeVVkYSn5QKtvEL9GNWqmVoAyhXm3YQRo/66czXglLeSpUjS/c="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775229442; c=relaxed/relaxed;\n\tbh=FoN+7DQ1oltcZxsIfVLmIzSoM8pnYF0EUpcshAu4tO4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=LsEfUyw0RkARaPCtvre5lrHGtjMU723gk2rsF109R+bqc9T5OBWSKLKUHWmi2K5vwfbQNlci8SgtD9UyNXCc4XqkstbLExFKK75xM0YE1MNQo+/bIxE72SMb5OellU+I/2vlXetHYdY9Ov81um4m/WqLBZ6IlrCS1EHMitYz+UWEDMIKU0xI0Yp38YvsQcC8RvRw/NYpaSojaRHDGJ6q/r+SjhmyT+U0xBfndJVFiXIA62DXm70QW35dy8BKF3h7gKW2j4qAYkgiUP7Lirq357Z/pN6vs7ygl9broqGhlZQMh2wx8bODzXer9M0Pw7u/JUtm+/Wh0txMAQt44nK6Og==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775229336; c=relaxed/simple;\n\tbh=UplDLhOZLXJ4/pVnqeRz1aozsvR7UuquHAnE22s4p4I=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Gllme+Kx78JQpVJXnFQ4wRYAnIbWHQSt+F74PlQ70oYWYEnm0z3WR503T5KNvIYXE3pmeoCF6L+Dc540kxUDdZF0bUqz1iHRk47Z6AReCD3MCaon+frih5BrJ1Bl+ukM2TqActZ9tPeWXfS7Qv6tpe//SPx7kqIWAnQN7GdNCBQ="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DfvYl5aB; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15629-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=DfvYl5aB; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775229336;\n\tbh=UplDLhOZLXJ4/pVnqeRz1aozsvR7UuquHAnE22s4p4I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DfvYl5aBlFSkYuqBzBLxNKBp+x1NjnOVa+f9yBAv7RXRfgoF5sEjFL0cq95KdSBZR\n\t dfVTJtKvEf84E0HsvViEgABU2ssFRs91KqMfQyI5XwaLvZW8hLwVilP8chstD2Dpj7\n\t xF+V9ClmrwJLA08to763mbD+zLnjZ0yEVdo26o3bdldnr75gFcfkssZKiQG0CUmQk/\n\t z5cu3qmGRXy7loLbCRZ7ZuxkjJxPwHdn3ERyNJdhivYGckEN3xZtKREUdBWCUqVzwI\n\t GjedEGnBj6AyVGbTymga5jF7aAM63xcxbS6z1H9H9jMlxh/Ur/MWOR0ugforhDQnMj\n\t 62TZ1SJ9o33Tg==","Date":"Fri, 3 Apr 2026 08:15:35 -0700","From":"\"Darrick J. Wong\" <djwong@kernel.org>","To":"Theodore Tso <tytso@mit.edu>","Cc":"Ext4 Developers List <linux-ext4@vger.kernel.org>","Subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","Message-ID":"<20260403151535.GI6254@frogsfrogsfrogs>","References":"<20260403040328.2385083-1-tytso@mit.edu>\n <20260403040328.2385083-2-tytso@mit.edu>\n <20260403041624.GD6254@frogsfrogsfrogs>\n <20260403115313.GA12260@macsyma-wired.lan>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403115313.GA12260@macsyma-wired.lan>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3673307,"web_url":"http://patchwork.ozlabs.org/comment/3673307/","msgid":"<20260403210046.GC16311@macsyma-wired.lan>","list_archive_url":null,"date":"2026-04-03T21:00:46","subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Ts'o","email":"tytso@mit.edu"},"content":"On Fri, Apr 03, 2026 at 08:15:35AM -0700, Darrick J. Wong wrote:\n> > It's \"autoheader\".  Whenver you add or remove tests to configure.ac,\n> > you need to run \"autoconf ; autoheader\".  If you don't run\n> > \"autoheader\", then even if the autoconf's feature test enables some\n> > new feature test, say HAVE_PR_SET_IO_FLUSHER, the feature won't\n> > actually be enabled in the #ifdef.\n> \n> Aha!  Thanks for that tip; I'll go fix my dev branch.\n\nJust to give more context, there are two ways that configure scripts\ncan pass the feature definitions to programs.  One is via the command\nline of the compiler.  The problem with that is if you have dozens of\noptions like -DHAVE_PR_SET_IO_FLUSHER for every single compile, it\nbloats the MAKELOG files and makes it hard to read, and eventually you\ncan run into the command-line length limits.\n\nThe other way is via a config.h file which is then #included in each\nsource file.  But for *that* to work, the config.h.in file needs to\nhave a template for echo variable that can be #defined.  And that's\nwhat autoheader takes care of for you.  Simpler projects that don't\nuse a config.h file and pass everything on the compiler's command line\ndon't need to use autoheader.\n\nFor a demonstration, try editing lib/config.h.in to remove the lines:\n\n-/* Define to 1 if PR_SET_IO_FLUSHER is present */\n-#undef HAVE_PR_SET_IO_FLUSHER\n\nThen \"rm lib/config.h\" and run \"./config.status\", and examine\nlib/config.h.  You will see that HAVE_PR_SET_IO_FLUSHER is no longer\ndefined in the config.h file.  Then run \"autoheader\", and then re-run\n\"./config.status\", and you will see that HAVE_PR_SET_IO_FLUSHER is\nproperly defined.\n\nCheers,\n\n\t\t\t\t\t- Ted","headers":{"Return-Path":"\n <SRS0=H4zk=CC=vger.kernel.org=linux-ext4+bounces-15634-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=g8L5NGmp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=h4zk=cc=vger.kernel.org=linux-ext4+bounces-15634-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=g8L5NGmp;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15634-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=\"g8L5NGmp\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=18.9.28.11","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=mit.edu"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWQD0BcRz1yCs\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 08:02:42 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fnWQ93pz5z4wTg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 08:02:41 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fnWQ93g6sz4wCX; Sat, 04 Apr 2026 08:02:41 +1100 (AEDT)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fnWQ44M6zz4wTg\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 04 Apr 2026 08:02:36 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 52F72302C342\n\tfor <patchwork-incoming@ozlabs.org>; Fri,  3 Apr 2026 21:01:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E2F4A3D8115;\n\tFri,  3 Apr 2026 21:00:59 +0000 (UTC)","from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BACA359A6D\n\tfor <linux-ext4@vger.kernel.org>; Fri,  3 Apr 2026 21:00:58 +0000 (UTC)","from macsyma.thunk.org (pool-173-48-112-174.bstnma.fios.verizon.net\n [173.48.112.174])\n\t(authenticated bits=0)\n        (User authenticated as tytso@ATHENA.MIT.EDU)\n\tby outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 633L0kwp022464\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 3 Apr 2026 17:00:48 -0400","by macsyma.thunk.org (Postfix, from userid 15806)\n\tid C5EFF610D4B6; Fri,  3 Apr 2026 17:00:46 -0400 (EDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775250161; cv=pass;\n\tb=Ns/yeth2YRFTWgj+cMnW8R1o5zGiTQnzc7ec58kMuFK0vLXNlW1kCRoIKNgtWULd5zlLgIMSCOKnMnJsXSJelsmK6KCbOa/ljlDwyrlawErG0pV05gQsAIbOOVgHKhozoHVHPxIix40wm2WOoGpNvp5PMlrDwOJCAAiXZBdVTn7y87tzqbl3k84uGSL/UM4cBSEiAMDDdDgCzF4nXhc+EBXVgQcwQ9NFhBk0ph6yn2XztsjMbxIl5T2WHt+hns8jEcp6apCj4COWAAXdt8agCzUdhoQy1ZcFASEcF63k9F4963rlqegJEjz8E71H5SHMrojxU/svCssaskdMSi4nOA==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775250059; cv=none;\n b=ZHfXaeAx9EopRdMqO59Ju/r3uoG92rsrzA0gR7LALmDhYDaDGE+vhWyiWBKnSSXoaUKiMktbfn0riUinGGztnyO3T8P9HOUOqrP6SvVXbh3L0gggeoxfZDWQgFZP/Rfpb/2MrlTqW0nQ8udS5tgGfA0JxipKQfJI1BydIWQ9CuY="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775250161; c=relaxed/relaxed;\n\tbh=qa4v8+CyqLiUjXLw1YwUpb/PTlafHDtV351thSH6QDg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=A58EFlpC7WDknvAxocelDp+KaxobK9fFLsboBXKdDidhLQmDgZYsieoLxgNKH2T0oyOfvp8KCV1OPVGBeT/wvX3zv4OpRgrGsc7jlBctRHUY/qeshfTAO4SDEk3Q+CuZrH3l96qYYHRiLFYcl9cwcLogZNKuKdrZGCD+lSxNdLLhYvUonY02UYmlBICU8YhAQDFZ5O5Xo+ek1MVU+ocbTThjPLx0/DYlN8ypHs0mmyBtvZiu6JJKp59jTA/kzwQvrgjBS+5OF06d5M5H72RtyqnqbvuR29r3sC0V/wUyR/nD1ktMBqnows5xDWGmN50fiZ5DyZ4EvJ5TR0acTKLquA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775250059; c=relaxed/simple;\n\tbh=m3KyOzcwFza2YrZ0Ws/oVBeVcwAnkwZAS+8LZIMTzYA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=PG4ezb2mLPuqAT4KYfKaH9CQ87evuKY+CIotqYJ9uKYpW02bgyCV0Qck0ISZL+nxSDFrWv0sVLaxqsKpLoj0FNxkJa0eMIj2i7sPM/7acg8GM1JI3qcaW2KdKA8OyWmkSjszSuaPlsBeit/isM8b2XxCAQexMoHruIuQWHk+6Vk="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu; dkim=pass (2048-bit key;\n unprotected) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256\n header.s=outgoing header.b=g8L5NGmp; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15634-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=mit.edu;\n spf=pass smtp.mailfrom=mit.edu;\n dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu\n header.b=g8L5NGmp; arc=none smtp.client-ip=18.9.28.11"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing;\n\tt=1775250048; bh=qa4v8+CyqLiUjXLw1YwUpb/PTlafHDtV351thSH6QDg=;\n\th=Date:From:Subject:Message-ID:MIME-Version:Content-Type;\n\tb=g8L5NGmpBRs5d66NBK7mXS9+GJYwrbnjHcgKdE4+lBbqcSR1VzI7ToHY8budJ3oc9\n\t yj0RfXyMfp9hlFBZMb5J5rh6+bBY1RuEqhYJbGguBL8sFjhB+l7WjNKipkmqUSHMmP\n\t DP7Vg+hSt8k7CRQUk55dfEltggEe5Sz/uH2E/QGghIUO9jiHp5qWbAenT4bmIrHiDe\n\t w0ItFM84VKJyJMj8Y9yFcd7i62xhmLyJp1RvPRS5cyJteyRV6/qpqU2ILNuZgNBDnV\n\t ZJWDRSQyZHv387LqQ509Gy9ZMjQj8J6nMieO7DSDlWndJkEGvnyHu7iaCdIJ8ILO1g\n\t vUHWh7uUsEbVg==","Date":"Fri, 3 Apr 2026 17:00:46 -0400","From":"\"Theodore Tso\" <tytso@mit.edu>","To":"\"Darrick J. Wong\" <djwong@kernel.org>","Cc":"Ext4 Developers List <linux-ext4@vger.kernel.org>","Subject":"Re: [PATCH 1/3] libsupport: fix portability issues with the bthread.c","Message-ID":"<20260403210046.GC16311@macsyma-wired.lan>","References":"<20260403040328.2385083-1-tytso@mit.edu>\n <20260403040328.2385083-2-tytso@mit.edu>\n <20260403041624.GD6254@frogsfrogsfrogs>\n <20260403115313.GA12260@macsyma-wired.lan>\n <20260403151535.GI6254@frogsfrogsfrogs>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403151535.GI6254@frogsfrogsfrogs>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]