[{"id":3672982,"web_url":"http://patchwork.ozlabs.org/comment/3672982/","msgid":"<20260403041814.GF6254@frogsfrogsfrogs>","list_archive_url":null,"date":"2026-04-03T04:18:14","subject":"Re: [PATCH 3/3] fuse2fs: fix build failure on systems which don't\n define EUCLEAN","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/people/77032/","name":"Darrick J. Wong","email":"djwong@kernel.org"},"content":"On Fri, Apr 03, 2026 at 12:03:28AM -0400, Theodore Ts'o wrote:\n> MacOS doesn't have EUCLEAN, so we use EIO as the closest error code.\n> But then we need to avoid a compile error caused by a duplicate case\n> labels of EUCLEAN and EIO.\n> \n> Signed-off-by: Theodore Ts'o \n\nLooks good to me,\nReviewed-by: \"Darrick J. Wong\" \n\n--D\n\n> ---\n> misc/fuse2fs.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c\n> index dfbc98636..94e289fab 100644\n> --- a/misc/fuse2fs.c\n> +++ b/misc/fuse2fs.c\n> @@ -5870,7 +5870,9 @@ static int __translate_error(ext2_filsys fs, ext2_ino_t ino, errcode_t err,\n> #ifdef EILSEQ\n> \tcase EILSEQ:\n> #endif\n> +#if EUCLEAN != EIO\n> \tcase EUCLEAN:\n> +#endif\n> \t\t/* these errnos usually denote corruption or persistence fail */\n> \t\tis_err = 1;\n> \t\tret = -err;\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=terlKr/w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=8dug=cc=vger.kernel.org=linux-ext4+bounces-15618-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=terlKr/w;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15618-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"terlKr/w\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn57N246vz1xtJ\n\tfor ; Fri, 03 Apr 2026 15:18:24 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fn57N1YFNz4wDN\n\tfor ; Fri, 03 Apr 2026 15:18:24 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fn57N1SrPz4wSc; Fri, 03 Apr 2026 15:18:24 +1100 (AEDT)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fn57J3qVhz4wDN\n\tfor ; Fri, 03 Apr 2026 15:18:20 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2607D302380F\n\tfor ; Fri, 3 Apr 2026 04:18:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A0E39309F08;\n\tFri, 3 Apr 2026 04:18:15 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B2427EFF7\n\tfor ; Fri, 3 Apr 2026 04:18:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EE09AC4CEF7;\n\tFri, 3 Apr 2026 04:18:14 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775189904; cv=pass;\n\tb=KfKw3qmxLKE4IF01VLbkfRu0j/wCVV8C2XXVOUoW3aOvjoWCePbeS2ZCR7ilx+nqFxoA+cc0+yyxSG9JIS9xz3czeb9apbaEBgf9F7zAMEgMVb1O6mM92gaiWiT3KxOHrrS0Z+zAQGn1O2wBk5uy4WhlecLUl96qifBVbmkgnV5+pBOgW0gh4MrdF/F0/dNj+f0dZcVzvRVWTIK7Ch43V+KfRN1Pic8iak5P2Fa85Bcc4JqAOlDK9XbsPDTceJvEZc6YT2xt48DAxeHmF7layCrOuwliOUZrU9UAeTkUE17wTQ2aDAUrL86XkyaA/qM068dopC2Xsxm2XnbResUVTA==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775189895; cv=none;\n b=NTWSKhQ+Sc93TT4sPLgfzxLwO2fISdDJxSI1gEQPEuRihGJjeB+uQDzAHhJKYt+SE/rlqVT+WEaTqX0YzOESQwMnjCNLKcwPTAJ3unWtFtsY4wqQo/YRQNwlE6vzc6Muac1A7F7yblNL5B2q79ZZN/dJbTwJfFePW0dWkpVE2i0="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775189904; c=relaxed/relaxed;\n\tbh=QM+O3oUboW/w0dCOsCnBcP6iIRtx4WIV/3bsv+Iv+7E=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=fRQEqGi+A/1f/DjrmdvSo0BEujd8qAjtS0+aXOrkzaCH+otrJwGTs9xzLOE/r5Be9g0LyPJ6PqPKcVG7y4U9TnRB0LDwk0ORg+YiEGVR1o+qPfZmy/B6WoUV53qN/lGrWUKCRApFvPTb6wnNnX/NJ17HMBKA5tOZ+Yc5E4NEvhXKyXQADrENwUZhOKV+e98pjPfKfC58pZtfr0q9rD7HTHFPnwO01Q1g3W+myA7iCHGH7i8zsPMVkHwSIZUWOLdnuLp76mn25WHC+EihvDhhNocQwW61Uvghj1QfJJulD1tPAmEMBMSqUxE88v3avj58xZZZ0zgbPuFJ0anowhRRPQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775189895; c=relaxed/simple;\n\tbh=1XvAJroVsdiH03IWZxxIRklsAhkvn3FmlGrD72/C4HE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=phTcByDoOmCeZNPqamYpqUM0+3DJwn4V+oxwcts76GWi//VSgeQC28qiHZacOxWCyvKUSZ97OjWMHRlKDAEEbc7GhjYf8y0EzemW4ukKjQ8F3z4ohVRGQ8y+W2Wj4hPI9YM8CSBsfeaGK/82Xgyk+NSUJtrys8kX7IW09FLHbpQ="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=terlKr/w; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15618-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=terlKr/w; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775189895;\n\tbh=1XvAJroVsdiH03IWZxxIRklsAhkvn3FmlGrD72/C4HE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=terlKr/wb/YYYrLfdayPBN3y/iCErr0XFHQVv9DhBhM7rX7lCmBqlsPGrShiLV/8H\n\t bCUp5YP9AaqQkQsS2jZtjtXQKgofvMpEHsgQI75rb4kbHydZhoRZh8eQIRi40781LW\n\t oPabyvqlIxpFXlJM0zDiI1HMCXOD/d4hRXzIxsBzoC5xbEpYKUS1vYETUoYsdGDxV6\n\t CnUMCgAu5kRtB8UipK+LYKbCn4bhuueXcquRY+DMlHPkL0mugyxMHCVd5Lnc3DAFXv\n\t dSaLad8xyjr3yvipcfoio3sNOH3ACdqOOFAbKI/D5emcdEJn+GoRVhEfA0srABt43j\n\t X4XUwLIb7Y2cQ==","Date":"Thu, 2 Apr 2026 21:18:14 -0700","From":"\"Darrick J. Wong\" ","To":"Theodore Ts'o ","Cc":"Ext4 Developers List ","Subject":"Re: [PATCH 3/3] fuse2fs: fix build failure on systems which don't\n define EUCLEAN","Message-ID":"<20260403041814.GF6254@frogsfrogsfrogs>","References":"<20260403040328.2385083-1-tytso@mit.edu>\n <20260403040328.2385083-4-tytso@mit.edu>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260403040328.2385083-4-tytso@mit.edu>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]