[{"id":3673048,"web_url":"http://patchwork.ozlabs.org/comment/3673048/","msgid":"<4567f32a-2a4f-43a4-aa09-fb669cd9e78e@redhat.com>","list_archive_url":null,"date":"2026-04-03T09:39:41","subject":"Re: [PATCH v3 14/14] intel_iommu: Expose flag\n VIOMMU_FLAG_PASID_SUPPORTED when configured","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/people/85406/","name":"Cédric Le Goater","email":"clg@redhat.com"},"content":"On 4/3/26 05:55, Zhenzhong Duan wrote:\n> VFIO device will check flag VIOMMU_FLAG_PASID_SUPPORTED and expose PASID\n> capability, or else guest could not enable PASID of this device even if\n> vIOMMU's pasid is configured.\n> \n> This is the final knob to enable PASID.\n> \n> Signed-off-by: Zhenzhong Duan \n> Tested-by: Xudong Hao \n> ---\n> hw/i386/intel_iommu.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c\n> index abcb0df5d9..3cb8a547c7 100644\n> --- a/hw/i386/intel_iommu.c\n> +++ b/hw/i386/intel_iommu.c\n> @@ -4794,6 +4794,7 @@ static uint64_t vtd_get_viommu_flags(void *opaque)\n> uint64_t flags;\n> \n> flags = s->fsts ? VIOMMU_FLAG_WANT_NESTING_PARENT : 0;\n> + flags |= s->pasid ? VIOMMU_FLAG_PASID_SUPPORTED : 0;\n\nThe '|=' operator is unexpected. Anyhow, the code has changed since.\nNeeds a rebase.\n\nThanks,\n\nC.\n\n\n> \n> return flags;\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=jRB0NcLh;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=GzGl4O6g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnDGg3827z1xtJ\n\tfor ; Fri, 03 Apr 2026 20:40:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8b0I-0004oM-QX; Fri, 03 Apr 2026 05:39:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w8b0G-0004oA-Q1\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 05:39:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w8b0F-0001ZO-EV\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 05:39:48 -0400","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-451-09NElqNWO9CYNuZZX1QEqQ-1; Fri, 03 Apr 2026 05:39:45 -0400","by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-486fb142205so17868325e9.1\n for ; Fri, 03 Apr 2026 02:39:44 -0700 (PDT)","from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c?\n ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48899ed9cb3sm15386405e9.36.2026.04.03.02.39.42\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 02:39:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775209186;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=pmuUaCxi7IXvPJkWzlVFo5/l0YEhnQzMvM4An0iU4xM=;\n b=jRB0NcLheZE7aP8m8jhOZfeO88qFBHpIrD7F3SU2cd5GphQrfD507Gz5eDdbbchKoDcP50\n DGio9oJc04TltspfFyfPq8/zil+GbWj3M7S1roFdVdDru2x249fc4hHWsBIzwTiGfYQsne\n wftvRkKfU9HAvaLDPkcSTCiyrsIm6JM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775209184; x=1775813984; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=pmuUaCxi7IXvPJkWzlVFo5/l0YEhnQzMvM4An0iU4xM=;\n b=GzGl4O6g74HSd35er1m++JCvGOvlJ+ML29EIFkH4oxc4gI0dqmWAMcLlzN9hy20K0E\n 3RvAvQgLJK31VF3Kroew9H6cMBTZLVFfaTlB7LjkcE0MgNI+QwL52mnWetOmSnIIJCDc\n ooNiS13EkDVI7YZo0gY0q7lNYnDoAtWVHJE0LHZTSbYeJ7ileRXfUk/TD+UZB6ZoZxYp\n K2eXBUPfRI0N8LNNwy9em6iFO6CHMCCtUw1AxMHUVd344mOfnmWSXQS70efCLBjG0OxU\n SnJ9zRWpQqpiS5Mh5YMAsjcpovG3tXogG0ZYUUUt57Jv+HYElmN04xhNeOYBlHBeV9s3\n f2MQ=="],"X-MC-Unique":"09NElqNWO9CYNuZZX1QEqQ-1","X-Mimecast-MFC-AGG-ID":"09NElqNWO9CYNuZZX1QEqQ_1775209184","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775209184; x=1775813984;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pmuUaCxi7IXvPJkWzlVFo5/l0YEhnQzMvM4An0iU4xM=;\n b=IzyNXHtyPCzijc8zZln1d2TEex5F1n4/JhNdOyFtF20Sbq0+BZemb92oyFBoD3kmZZ\n zyqjFw5yr0xh4XKKtLaCJOeNaiUGKcWiR9yZzLHKSCD6hSkTBqG+qFf/iP+i04q3MBka\n 0XEUyYgfvzNInc+KtDUNfGU7oa3Qm5syCZ81mlsS1V3fjLzNmQiW5NKNS1/xmXPbI67b\n mDG/BrsUPkC1ADsAX7TZ9zDs2+pI/C6i8rGQEbmgpLdyeR+ausFkspysgYlQ58Kkxkh/\n 2DC/Bua6dGE9NvmiOKQTVZh2LP0SVKDkOxdMQ3/um82TGseCCKCHVUnuezMXthqxBCI+\n P4WA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV01X0f5TOdxTWlxRKRdsbUN75QWtjBtkML/U4pStExYPO8SBDvkHEVsAiWh14EGJZqmIpd6lNp40ZY@nongnu.org","X-Gm-Message-State":"AOJu0Yy4yMtW4wre37eLb3sxE8hbHUsdSaAbM00/9Um/FqQIvSszUQ5T\n Dy7Ju6Dr/YdgvGPJgWHhPMT3zpgEvUP4gBYC3YTaUPwB5tbLhzAsyFW/C9b8F0HX0zKhVdJ5ffq\n o5oGgOkkJZ63uNqJ9jbQuAg6qwxe/5+cWTNiaOCQZbuEpGlyVPj5Mw6Ux","X-Gm-Gg":"ATEYQzwXcN+QLTDpEkAOBc0t68Ap7rVz7B/9xTe/sY2mgARzZKj/Bw3TPgc5B6TRyAA\n /gGQybItCVt3Ds2GyDHrUtCp/rn9NEayBAIEKLFFNbZJq3XesW+tU2Ntfr9RoiFr9Y9ktJpxoGJ\n 9rMtifNeZt/uyADr4l0Ap8EZJvrzZjpEy9gn4yjhSN7yNWLIkTRZFVeXsYe/Nt/jKkwvuG4CPoa\n lPBGkjaob/oyjLEVFS10Gmh5G9psG1XtUerOxVc1Jy0hlAZkHWRAmDUPhQCn3Vo7LMxMpJ250NT\n cNntRmWTBSJwWSZSj6mbMCAQALpWwAcZ4Wmx8BNk7HU3s/eniGUjYmclAwkEP5AGjNhj9aqrx3D\n 6DCfm0+d5b5XyTzDRZUpYa8JYCesqkKLIHeObAkHywpvpeQ0X2jXdARHW09lZ","X-Received":["by 2002:a05:600c:4e0e:b0:488:8577:d9c2 with SMTP id\n 5b1f17b1804b1-488997bd8f7mr35813965e9.22.1775209183866;\n Fri, 03 Apr 2026 02:39:43 -0700 (PDT)","by 2002:a05:600c:4e0e:b0:488:8577:d9c2 with SMTP id\n 5b1f17b1804b1-488997bd8f7mr35813675e9.22.1775209183411;\n Fri, 03 Apr 2026 02:39:43 -0700 (PDT)"],"Message-ID":"<4567f32a-2a4f-43a4-aa09-fb669cd9e78e@redhat.com>","Date":"Fri, 3 Apr 2026 11:39:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 14/14] intel_iommu: Expose flag\n VIOMMU_FLAG_PASID_SUPPORTED when configured","To":"Zhenzhong Duan , qemu-devel@nongnu.org","Cc":"alex@shazbot.org, eric.auger@redhat.com, mst@redhat.com,\n jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,\n skolothumtho@nvidia.com, joao.m.martins@oracle.com,\n clement.mathieu--drif@bull.com, kevin.tian@intel.com, yi.l.liu@intel.com,\n xudong.hao@intel.com","References":"<20260403035541.18355-1-zhenzhong.duan@intel.com>\n <20260403035541.18355-15-zhenzhong.duan@intel.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@redhat.com; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7\n 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg//\n S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY\n lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh\n EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71\n xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl\n hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8\n VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy\n k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ\n RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS\n 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi\n V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW\n pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ\n KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp\n bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6\n TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU\n CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS\n YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g\n LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7\n JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu\n jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx\n IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k\n 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK\n yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j\n hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop\n s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p\n LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU\n wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU\n XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA\n HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ\n izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD\n uVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260403035541.18355-15-zhenzhong.duan@intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.542,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]