[{"id":3673012,"web_url":"http://patchwork.ozlabs.org/comment/3673012/","msgid":"<87bjg0ihuq.wl-tiwai@suse.de>","date":"2026-04-03T08:11:09","subject":"Re: [PATCH v2 1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure","submitter":{"id":216,"url":"http://patchwork.ozlabs.org/api/people/216/","name":"Takashi Iwai","email":"tiwai@suse.de"},"content":"On Fri, 03 Apr 2026 03:47:36 +0200,\nwangdich9700@163.com wrote:\n> \n> From: wangdicheng \n> \n> Add missing of_node_put() in the error path.\n> \n> Signed-off-by: wangdicheng \n\nApplied to for-next branch now.\n\n\nthanks,\n\nTakashi","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=ZjapW8jF;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ZjapW8jF;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19262-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=195.135.223.131","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=ZjapW8jF;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ZjapW8jF;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=suse.de\n (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=tiwai@suse.de; receiver=lists.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnBJ92ky5z1yD3\n\tfor ; Fri, 03 Apr 2026 19:11:21 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fnBJ31xBkz2ygT;\n\tFri, 03 Apr 2026 19:11:15 +1100 (AEDT)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnBJ14PPXz2xln\n\tfor ; Fri, 03 Apr 2026 19:11:13 +1100 (AEDT)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id B207F5BD57;\n\tFri, 3 Apr 2026 08:11:09 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7C5A14A0A6;\n\tFri, 3 Apr 2026 08:11:09 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid L7wEHR12z2mfbQAAD6G6ig\n\t(envelope-from ); Fri, 03 Apr 2026 08:11:09 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775203875;\n\tcv=none;\n b=MZ+bYFL5d9fQGd0BsoXMaIUrp+hbsQ6jJmvrXkq/Ux9T2oIhfzQIPFCmn99ymjcArOBc+UsS9OsvJ9RSK/5LMkms8GjEacmSvkLCMPpf0X8Xwj7VjzR94PeLiNmTjCvpX3smp4VPm3RRZFooSwwx07GYGBKyvENpeLQScSb49e3VsSSZFOfkZ1uI+U0l2MeEs8i3w0EWFcF8nezeroDB7IiYjMo8ntCAMc2O9epgQwjn7vmodxLgCNhM2Zap2P/HXqznU81wUcZn9nJyqDfvx8ig3lW9K+411PbO4FiW36l6Ifuu9qB1CQNI6MXPbXNgO5O/v5+8BieSgy/x/x8v4g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775203875; c=relaxed/relaxed;\n\tbh=pKTj+fuw+V2CSJJ06hFpU6rHWXveJU/kjg5LgshKBS4=;\n\th=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=LstxEKFzEaKZZtUvN+hnEQJkk6Oo84GzbR2jBFFurhjpYFolxGHSN/Aby72NSrABtetbHGaUejJwcOov15bWvl/Cpqf4Tt24kW921hhvThkrdGCDL8gezhcLxXgKJt1CinxSCuEMZ0UfWKlV2Z9ezvr+WKpjhZBhYYIHOnck9wMXTXSDIpZQjp2enGLlymTuEqeSfBLjD2uXfPwK5qF0Mzc6KJjug07By/X6UQJE4qpr0IAob/hykaijvwXYGrBKREjtiSoUQeXdv9sARY6mISHyLOifjrzvZniQA+kOf0wzDNWcNH/+gyMKXGU6cS3POXVfCZ6BxcT70UnzZeGOyg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de; dkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=ZjapW8jF;\n dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ZjapW8jF;\n dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=lpDrm4gB; dkim-atps=neutral;\n spf=pass (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=tiwai@suse.de; receiver=lists.ozlabs.org) smtp.mailfrom=suse.de","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1775203869;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=pKTj+fuw+V2CSJJ06hFpU6rHWXveJU/kjg5LgshKBS4=;\n\tb=ZjapW8jFn+ffPxdody7EeAXjP3qFwL1hz3EpGCSf8VEImvuXSLJsUnhALORGFLXWTzEwmF\n\tqg6Uwvk7ByjPNIjFjrgJgT0j6coewIKlBOLSxJnJZ8+NwuzKEXxJ/m5gQIg4Pp5VAAcTHU\n\tzT+bP8PmtCGVRlHd2z3jZsQr1qNhkW4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1775203869;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=pKTj+fuw+V2CSJJ06hFpU6rHWXveJU/kjg5LgshKBS4=;\n\tb=lpDrm4gBQZVjSNqzwJ8u02Vc+sPyplzJwIgcIsNR5a//N8Hk/7iBMZZwlv2HzXUvd5XCrm\n\tE0Td6ppUMBEf4cCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1775203869;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=pKTj+fuw+V2CSJJ06hFpU6rHWXveJU/kjg5LgshKBS4=;\n\tb=ZjapW8jFn+ffPxdody7EeAXjP3qFwL1hz3EpGCSf8VEImvuXSLJsUnhALORGFLXWTzEwmF\n\tqg6Uwvk7ByjPNIjFjrgJgT0j6coewIKlBOLSxJnJZ8+NwuzKEXxJ/m5gQIg4Pp5VAAcTHU\n\tzT+bP8PmtCGVRlHd2z3jZsQr1qNhkW4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1775203869;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=pKTj+fuw+V2CSJJ06hFpU6rHWXveJU/kjg5LgshKBS4=;\n\tb=lpDrm4gBQZVjSNqzwJ8u02Vc+sPyplzJwIgcIsNR5a//N8Hk/7iBMZZwlv2HzXUvd5XCrm\n\tE0Td6ppUMBEf4cCw=="],"Date":"Fri, 03 Apr 2026 10:11:09 +0200","Message-ID":"<87bjg0ihuq.wl-tiwai@suse.de>","From":"Takashi Iwai ","To":"wangdich9700@163.com","Cc":"johannes@sipsolutions.net,\n\tperex@perex.cz,\n\ttiwai@suse.com,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-sound@vger.kernel.org,\n\twangdicheng ","Subject":"Re: [PATCH v2 1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure","In-Reply-To":"<20260403014736.33014-1-wangdich9700@163.com>","References":"<20260403014736.33014-1-wangdich9700@163.com>","User-Agent":"Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0 (generated by SEMI-EPG 1.14.7 - \"Harue\")","Content-Type":"text/plain; charset=US-ASCII","X-Spam-Score":"-3.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-3.30 / 50.00];\n\tBAYES_HAM(-3.00)[99.99%];\n\tMID_CONTAINS_FROM(1.00)[];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tNEURAL_HAM_SHORT(-0.20)[-0.999];\n\tMIME_GOOD(-0.10)[text/plain];\n\tARC_NA(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tMIME_TRACE(0.00)[0:+];\n\tFREEMAIL_TO(0.00)[163.com];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFREEMAIL_ENVRCPT(0.00)[163.com];\n\tRCVD_TLS_ALL(0.00)[];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCPT_COUNT_SEVEN(0.00)[7];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo,kylinos.cn:email]","X-Spam-Status":"No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]