[{"id":3673169,"web_url":"http://patchwork.ozlabs.org/comment/3673169/","msgid":"<12644bc4-8713-489f-9ed8-1ee71bf26a3c@linaro.org>","list_archive_url":null,"date":"2026-04-03T15:20:11","subject":"Re: [PATCH v2] hw/arm/omap_sx1: map CS3 at the correct base","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 3/4/26 03:44, zhaoguohan@kylinos.cn wrote:\n> From: GuoHan Zhao \n> \n> omap_sx1 wires the \"sx1.cs3\" region to OMAP_CS2_BASE instead of\n> OMAP_CS3_BASE.\n> \n> That places both CS2 and CS3 at the same address and leaves the real\n> CS3 window unmapped. Point the CS3 region at OMAP_CS3_BASE so the\n> static chip-select layout matches the OMAP address definitions.\n> \n\nFixes: ba1580299d0 (\"omap_sx1: convert to memory API\")\nReviewed-by: Philippe Mathieu-Daudé \n\nNote, this got unnoticed for 15 years.\n\n> Signed-off-by: GuoHan Zhao \n> ---\n> v1 -> v2:\n> - Resend to qemu-devel@nongnu.org\n> - Keep qemu-arm@nongnu.org on Cc as requested by Peter Maydell\n> \n> hw/arm/omap_sx1.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FbDwjCDS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnMrG3Kkrz1yCs\n\tfor ; Sat, 04 Apr 2026 02:21:18 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8gJn-00059n-Je; Fri, 03 Apr 2026 11:20:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w8gJm-00059V-8m\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 11:20:18 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w8gJk-0003gL-BJ\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 11:20:17 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-48896199cbaso12093285e9.1\n for ; Fri, 03 Apr 2026 08:20:15 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e93c014sm284836155e9.10.2026.04.03.08.20.12\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 08:20:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775229614; x=1775834414; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=MoKl7MAJVVoQBh3jJHjMhxTrlAT1hvj3U0F3jpD+bug=;\n b=FbDwjCDSbjK8fYQqSadtAarp9WNG7gX1RFBvDOT8durwHAfwGPR/aLw+5I3r7Vuezh\n E2rfoNjJZxHK7qL/IJalnuKmCQgdG2B/OcpO9jlf43EYW6lzHcjGbT7m8+YN8KONKkRJ\n CfXBS4EJkmjA05C6j+Yw1wpJV3ZfezMr4llT3AKEcaCC5rrdpGZ75MGiDR4GKT4W/unr\n A2ZMqt65zUazEv/TtQZl8cYFKpUZgsSNKqM3TFJon0Ot3a5mgkivoWNhCsvlW2AZIXtm\n /nlUOCl4PX61Zvw5o8QtfkJxatduqpJ4bZSXO9l1jHb6PVQNSXJv6FkKga26+IZul7Ob\n jLmQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775229614; x=1775834414;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=MoKl7MAJVVoQBh3jJHjMhxTrlAT1hvj3U0F3jpD+bug=;\n b=P1mtbmrrBTs1ikW2A7PyxhYYfoDN5QHiKIXfoTA+OPZ62Otf0Ivl6G3X9BEhxFVKxg\n rg3Upzk18huYefzb7X/+HTOg3Z0iQriCF7y0iyUbZ2LNk5yd6AmkQK6RA2xHgMTFYSnU\n yXvthFIr1SebGI3pccGoS8pBiXsBtB10rLn6FGbLELYyXnXnT8stMtDDaasQVt1FkEZO\n fOeFpMewNfJmQO4b8T0r1mM2T7QLiA8rNttMN5nnNmpojMsa0NmFFnuauMULHQtp8AVX\n ITVeDqFJCzR0VBw/KUpkNm8iXCJIQggTGkCSDg9omhAQUBItRfQYGrjWapS57zyHFXSr\n LQLg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV8ffWySdsnNSuJQa8vcPtgENmME/wSfOrJ0PQVTrw1XgolsZFnuBx8KBSMWs6S1LjhbQNVeLhrWhH2@nongnu.org","X-Gm-Message-State":"AOJu0Yy2LQRsUOe1+NvZE9KDtKuhak+GLUstmPEi5J8t+xVtQw3EOFH2\n a3E80R+DQ1QM1lgXEliM3bJWlQT0kuIXGc5myFqwxnwwcEXzg5cRec2C5g0xx3imkZU=","X-Gm-Gg":"ATEYQzz/UX5GYTb2tRHLqr0/zdLm6XANOsbsYUGekA5gaMlWwynUiY9BqLYaJuelW/T\n 7x0gsM9/VRCLeFcqaFnlVtaPBz2GrhGbwJigCj3l7CcXDQyuZbR423rNRJMBGJQcRb4O9GH5kEa\n HRwT/OPv3z2YJYjWxrzY3KQi6vD4OjVQtfVqzmcE4Kf/pbPyJ3MOBNq+3qQcRmIB65nfWhAZH5p\n qmJTckj+XmSHUdAROl13l9zNCAUfxtbTrfvvwKS/4M1+HpuAXDqVm8CmUPj89uGhBOpQ0DFFHtW\n +EwYwYkLKJzG5aAEnzZqSGcrh4OlJLZmaEyQtMK9EQFwRBIiVcLzejc0ac7By3IoosEQYdGrT0F\n 5M8lPP7fHDBAPxo71wjx+zXGGZaaRBtj07qP/FzwG4FCDtzWouabiLrqEh1ubxu3SMYqkQJdZiR\n oF8L3iaND/jll6sjliVk0E3t9QFusal+8L5Kk/bDpXUCa7F8RHbsOw4Mtgv910goxAZA==","X-Received":"by 2002:a05:600c:5292:b0:488:966f:70a7 with SMTP id\n 5b1f17b1804b1-488996b02f2mr59056445e9.2.1775229614020;\n Fri, 03 Apr 2026 08:20:14 -0700 (PDT)","Message-ID":"<12644bc4-8713-489f-9ed8-1ee71bf26a3c@linaro.org>","Date":"Fri, 3 Apr 2026 17:20:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] hw/arm/omap_sx1: map CS3 at the correct base","To":"zhaoguohan@kylinos.cn, qemu-devel@nongnu.org,\n Peter Maydell ","Cc":"qemu-arm@nongnu.org,\n =?utf-8?q?Beno=C3=AEt_Canet?= ","References":"<20260402071718.130490-1-zhaoguohan@kylinos.cn>\n <20260403014441.38725-1-zhaoguohan@kylinos.cn>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260403014441.38725-1-zhaoguohan@kylinos.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]