[{"id":3673091,"web_url":"http://patchwork.ozlabs.org/comment/3673091/","msgid":"<57452867-60be-4292-9bc5-4e2faf1f3cb4@sirena.org.uk>","date":"2026-04-03T11:56:51","subject":"Re: [PATCH v3 9/9] driver core: Replace dev->offline +\n ->offline_disabled with DEV_FLAGs","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Thu, Apr 02, 2026 at 05:49:55PM -0700, Douglas Anderson wrote:\n> In C, bitfields are not necessarily safe to modify from multiple\n> threads without locking. Switch \"offline\" and \"offline_disabled\" over\n> to the \"flags\" field so modifications are safe.\n\nAcked-by: Mark Brown ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WExiF/lE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19270-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WExiF/lE;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=broonie@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnHJc1n6Bz1xtJ\n\tfor ; Fri, 03 Apr 2026 22:57:04 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fnHJc0kt8z2yhG;\n\tFri, 03 Apr 2026 22:57:04 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnHJb3M6Cz2yVP\n\tfor ; Fri, 03 Apr 2026 22:57:03 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 975CF60121;\n\tFri, 3 Apr 2026 11:57:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E1F48C4CEF7;\n\tFri, 3 Apr 2026 11:56:53 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775217423;\n\tcv=none;\n b=kCOUv1Ehof2Ox2B5sg8mUs2I+Zi7TwSW4iifPrklOT+nUyS9Rz737YSuxtJiupVpuFi+oNUnjfxlB0QII8nL0y/z5zpI5xZZBwmIcqzy3PMfns26KfD4LIYMBhid+nt2vk9BezG0kH9eobGMPhNdpq51v6XDMOxrgDQJ+t7FkayKnFSFvGDCtM3J6ZnxjsXXo9ROVlSLBRnUxAHI9fC9NvbJ0m9MnjEGfwHVb4rnhOC+QlHAxnKDaICH8KWK9VD1Noqv52Qfpte5Wb8kYmvz7Jsi6nDTPX+zHt3mcO0OR4Ki7XSUVl58lZslEYqky903ddS7AGrFeJXV/nt4lj13SQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775217423; c=relaxed/relaxed;\n\tbh=hlI1RBQqJjfpWuFZsCc6c4R0ASQxP62EyBGuIa0hpOs=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=CEeV68gJDsweNOw6iJ8RFPMK8BlShfYzALDhv4aimTHRVUzPZuRysc4Wj+hdtX6sKWmdUjpTnBb1aQzPFTre/XkKRaG2StOfEPP3X74uB11PEOLrWi1TOM8eIoCwZgqxY2IH/sd/+Qf0VWThRYcReIMB0QV5iaKczB/6fedkoxSyEl83KbnyVaLu49Z1z9znQlzlLXCf45W7SaPtBMxL6hQoikk5yZ3UhjydmT3xJFA7f/CwZqAWppf5xo/xW20BkyIiwV+EiuoSwwF9rbF85WhD9StUvLDp2NNVaZmlxV9oEFOE0tilsincjYjjhIa0iT7ofJ2emtQtgYE8l4cwYA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WExiF/lE; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=broonie@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775217421;\n\tbh=hlI1RBQqJjfpWuFZsCc6c4R0ASQxP62EyBGuIa0hpOs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WExiF/lER3/HxYWRZ7/VYGGhEbpEpz9xoEPNjcsCFvTGNpufubq1/grWFEw4iuMUy\n\t OoXV5ZN9cvTpw+MrimzFf6s9HmUgEebMHP6rxEPoVqpOak+AAKYreCCI+aI8f5Gcf8\n\t zd3TXBgf41BbeUDYgDIMBFsxjCPG+plKws+G4eTYF97BpuDvffRy9f5yT7XQBVGQbe\n\t XqHjaEsIVjnSBX+EIpGZbUC6lXfkWCjygMqGuZgL2M9uFpPhtTcBQ2hiVkdvbT8xp0\n\t yn+PYHPMRpNNVo0RArrBjXz2Wp47lKN2V/BGSRUsMLv3YU6gYJZRfQsOsmZPjmN+O6\n\t y2sPDI66WCWpQ==","Date":"Fri, 3 Apr 2026 12:56:51 +0100","From":"Mark Brown ","To":"Douglas Anderson ","Cc":"Greg Kroah-Hartman ,\n\t\"Rafael J . Wysocki\" ,\n\tDanilo Krummrich ,\n\tAlan Stern ,\n\tRobin Murphy ,\n\tLeon Romanovsky ,\n\tPaul Burton ,\n\tSaravana Kannan ,\n\tAlexander Lobakin ,\n\tEric Dumazet , Toshi Kani ,\n\tChristoph Hellwig ,\n\tAlexey Kardashevskiy ,\n\tJohan Hovold , ardb@kernel.org,\n\tcatalin.marinas@arm.com, chleroy@kernel.org, david@kernel.org,\n\tdriver-core@lists.linux.dev, kees@kernel.org, kevin.brodsky@arm.com,\n\tlenb@kernel.org, linux-acpi@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-cxl@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, maz@kernel.org,\n\tmiko.lenczewski@arm.com, mpe@ellerman.id.au, npiggin@gmail.com,\n\tosalvador@suse.de, oupton@kernel.org, peterz@infradead.org,\n\ttglx@kernel.org, will@kernel.org, yangyicong@hisilicon.com,\n\tyeoreum.yun@arm.com","Subject":"Re: [PATCH v3 9/9] driver core: Replace dev->offline +\n ->offline_disabled with DEV_FLAGs","Message-ID":"<57452867-60be-4292-9bc5-4e2faf1f3cb4@sirena.org.uk>","References":"<20260403005005.30424-1-dianders@chromium.org>\n <20260402174925.v3.9.I897d478b4a9361d79cd5073207c1062fd4d0d0e4@changeid>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"AVRN0JUTTuR+6v5a\"","Content-Disposition":"inline","In-Reply-To":"\n <20260402174925.v3.9.I897d478b4a9361d79cd5073207c1062fd4d0d0e4@changeid>","X-Cookie":"The Korean War must have been fun.","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]