[{"id":3673401,"web_url":"http://patchwork.ozlabs.org/comment/3673401/","msgid":"","list_archive_url":null,"date":"2026-04-04T08:14:12","subject":"Re: [PATCH v2 1/2] xtensa: Avoid redundant MEM_P() checks in memory\n constraint definitions","submitter":{"id":2793,"url":"http://patchwork.ozlabs.org/api/people/2793/","name":"Max Filippov","email":"jcmvbkbc@gmail.com"},"content":"On Thu, Apr 2, 2026 at 4:09 PM Takayuki 'January June' Suwa\n wrote:\n>\n> If the memory constraint definition includes (match_code \"MEM\"), then\n> the subsequent 'op' is undoubtedly MEM rtx, and all that remains is to\n> determine if 'XEXP (op, 0)' is the address corresponding to that\n> definition using (match_test \"...\").\n>\n> This patch eliminates the need to call MEM_P() again in the predicate\n> function called from (match_test \"...\") in the memory constraint\n> definitions.\n>\n> gcc/ChangeLog:\n>\n> * config/xtensa/xtensa.cc (smalloffset_mem_p):\n> Rename it to smalloffset_address_p and remove the result check\n> of MEM_P().\n> (constantpool_address_p): Change from static scope to global.\n> * config/xtensa/xtensa-protos.h (smalloffset_mem_p):\n> Rename it to smalloffset_address_p.\n> (constantpool_address_p): New function prototype.\n> * config/xtensa/constraints.md (R):\n> Change the call in (match_test \"...\") from smalloffset_mem_p()\n> to smalloffset_address_p().\n> (T, U): Change the call in (match_test \"...\") from\n> constantpool_mem_p() to constantpool_address_p().\n> ---\n> gcc/config/xtensa/constraints.md | 6 ++---\n> gcc/config/xtensa/xtensa-protos.h | 3 ++-\n> gcc/config/xtensa/xtensa.cc | 40 +++++++++++++++----------------\n> 3 files changed, 24 insertions(+), 25 deletions(-)\n\nRegtested for target=xtensa-linux-uclibc, no new regressions.\nCommitted the whole series to master.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=oNNV2ydT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=oNNV2ydT","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.219.51"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnpKr5mdWz1xtJ\n\tfor ; Sat, 04 Apr 2026 19:14:54 +1100 (AEDT)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id BF5E44BA9009\n\tfor ; Sat, 4 Apr 2026 08:14:50 +0000 (GMT)","from mail-qv1-f51.google.com (mail-qv1-f51.google.com\n [209.85.219.51])\n by sourceware.org (Postfix) with ESMTPS id 5BE914BA2E29\n for ; Sat, 4 Apr 2026 08:14:24 +0000 (GMT)","by mail-qv1-f51.google.com with SMTP id\n 6a1803df08f44-8a210c813f8so21384736d6.0\n for ; Sat, 04 Apr 2026 01:14:24 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org BF5E44BA9009","OpenDKIM Filter v2.11.0 sourceware.org 5BE914BA2E29"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 5BE914BA2E29","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 5BE914BA2E29","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775290464; cv=pass;\n b=sd6X2CzMRG3atzfZPt/C4chX68y6j2of4lkHL7rzsxn2k67Xzrp2Ikt5GPrQzoVQCgSKc020mWoDnwUvqTUGLD16QtRdlH3Q0dZm/UpJyauCH/DeVSkivdOrLFuzkw1cgDbO0Oaag1gJwFfsgxDUMIVAYPjAcn0cmg4O3/udMMc=","i=1; a=rsa-sha256; t=1775290464; cv=none;\n d=google.com; s=arc-20240605;\n b=glxBTNfYBeDX5X+zi+MpklJY7e4at45efAAturlJU/J3DVsBOyylqnLQWVG+dgxOdg\n PGkUiii9kYdazXgOnYjolwGONUKkc2lrB3vqSTcQB1PP7AkzFtvAvf/WkCaW6cMXIBzV\n BeCfCtzVNXF1M5IjtPJNxw0kp/U/6djrQo1oau8KRhxO9+hedEMXkamSYoGug53sAIJv\n P0U0ajBk+CZJmKEdXvd6Xc/5i28ysuZDvZ/ErgACeeOsEJdUSJf5OgWb1kKUaRaoxm/B\n BJUASSeOUr5JS0JirIT/t2PfNeFa3K903XTDBDVm0r9OkEwdcHUN6ML0D1dzpXp7lYI5\n I1Gw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775290464; c=relaxed/simple;\n bh=WD+2eV0Tvil3zah6r5ZxhYupnsJY+FiVxwRvYuSU+o0=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=KLADdt5WxuMvRmx0K+vJzWgCUpYkPhulnavhjYhJF2Dcs051J6RJy//YFhcTNP1I7vAShEcDEUfOQ1Syt8CI2+al+gLEZ33x8V/vbI+vhTnizDWRdywVjVEfjBiptz4gqaK1402zKEyuDyrWztzoJYuEad7lb6o4J5aQW7BsQQ0=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=fUTCfCK8jPheb8GECvlTQFZeRwkudGpJVRMOFBvjrjQ=;\n fh=8m2HeCm0G1W3PFnSLlQafnUEAwXk3jsAddIRb77DSI8=;\n b=CoS+SlMtmjiohIthEX3bse3a2nh5o2TwarG4elf3TfwZ0cQe19NCbmctnI934CW6K3\n ZBCtA/wa2DwNKTyn4CBJLO/+teI4EOYOly0DP+I5TlpXaAjIAY2EIhOn8D9uybHuSUm0\n ypon0U/QEQmdUnSn++Ok/DqR5MccTmyjsnhneAgrXiDH6CCbr+xgS88NedLAUmWvnQ2S\n 8PMlFHPZTSNuHMgVtQ1P1gxtARoidOJRVS0y0/+xOFWrNLi6i0ULDE1qRl6bZ9Gum5E2\n 80Im28qKNLoxvWEytlYX0be8iCnne/+SnFRNIhrZAG2Bo7h8Ikf+Peu6OdPdd7+srHMv\n IiNw==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775290464; x=1775895264; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fUTCfCK8jPheb8GECvlTQFZeRwkudGpJVRMOFBvjrjQ=;\n b=oNNV2ydTV3SFzo4D5eLB2lS0Y8R5pOAmWNIweZNn7EbHwgHfxhVcD8uXF6LueGmD+/\n +YYaTbYN/N2x9WTrvz9+kKslWNsKv8UBhsT9jgLWDvn/nSa0UbGctYOcqzi+z1lsrZyp\n SeeB95YXKMIl0T/wEMRQMeSO/khU2v7UDYybHvE0npwKs8GbwKVZB3DiYR5VfA7aL2so\n 0ifBea+bDhhxpTinwDNwhofpKJEMuNZ74X7OAZFe/dku18fhYUthKywtcgGFH5vojIvA\n cztgO2WKB/CSo1iYdSSdqqnxmSy8GjkKwqn66nZwgKXmtFw+7skJQkFV/dCSDueq/Ky1\n jglw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775290464; x=1775895264;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fUTCfCK8jPheb8GECvlTQFZeRwkudGpJVRMOFBvjrjQ=;\n b=WkOvGdQU32C+5J1aTqSvwWQqYpx74gVBVp/qK/KZgTdfIh3HxqwH3NepZyg3Tt0XE6\n a5rrQRVSdHgneLFX0mn3EM326SRRJF8DVHAh1EAbMCK56T1su2jIY0qVRacDZQgiRxXr\n NX4sCG2r3XVSbGfwzlhEuPh8Ybn8jcgBS6HALmC6U586ItjvwnIcVJsADqNmntGVkUqg\n HIopXQUL6JPTVsEzgb+IeD4dwLzpQoOzJ/vtpobxpGsCgxm73xaBbitrXoGUyd3ECOqF\n QiOD+gtRmuCUcoVrQz+wvtNucrWkuonQRu3dOOwmtMensXQfv9xjssUorTmDqqGHA8ZU\n p2hA==","X-Gm-Message-State":"AOJu0Yw4zjykoBWDSHsaCo0y+NCfpqzEax/78Ih7HdWpNGbf7pxL5qTQ\n tVbFzpqSK3af8hYYRjXnm1b7bmGNgt9RkQEw9n3l+RUFFc9Y+qm2DWQvT/pWfaNLqhwMRzl3Tqq\n 7C50+R4QqE9HkO/zIT5X5gpeCZwxZqfU=","X-Gm-Gg":"AeBDieuLN5G6ghPxkLOlxCkyfxBgyrrHQYC2akPBTHp4AZ2Btx3EMWuUDbZy7cEVO1l\n rxun4Gx/0eS2blTPgXwKnHSZNj4wGvQOvY1ySIJ5wH6u4PMdZvHYlIsqxuOogVLLUpeMNt/D8I6\n 3/teueVWrR957dWZzw5iNHZRW1ucGwenrqt9gkGrlUSpZAA2OSkzWZFkfv62/L6qdgQcsK7jXIs\n LmIbTkRvoP6XnSHVwG++AF0NcSzzXIoMHBqzU20gDomC1RL+SV10KhNqlS+G/h+Q6gOqm2NBJaF\n XaXYWZl0XZyQ3Rh0mr9ddaivvlq6E+DfaqhG73t3Zd2OcKFu9hRWnjq3YM2cFfLdNb3omiJJiih\n /vqPnGPpRAJ1UnyxKaxTl3c84oQ==","X-Received":"by 2002:a05:6214:d4d:b0:8a1:8f74:3eab with SMTP id\n 6a1803df08f44-8a7024bb2b1mr96150386d6.9.1775290463637; Sat, 04 Apr 2026\n 01:14:23 -0700 (PDT)","MIME-Version":"1.0","References":"\n \n \n <319b912c-6229-4155-a306-97f5cd1d4feb@yahoo.co.jp>","In-Reply-To":"<319b912c-6229-4155-a306-97f5cd1d4feb@yahoo.co.jp>","From":"Max Filippov ","Date":"Sat, 4 Apr 2026 01:14:12 -0700","X-Gm-Features":"AQROBzDN_5JnmYZgqkXbZU5rlSwGXv6_N9ESDGsT4X5B6mushRclTxueI6hmtcs","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/2] xtensa: Avoid redundant MEM_P() checks in memory\n constraint definitions","To":"\"Takayuki 'January June' Suwa\" ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]