[{"id":3673063,"web_url":"http://patchwork.ozlabs.org/comment/3673063/","msgid":"<20260403102752.210028-1-thomas.perale@mind.be>","list_archive_url":null,"date":"2026-04-03T10:27:52","subject":"Re: [Buildroot] [PATCH 2025.02.x] package/faketime: rebase patch on\n v0.9.10","submitter":{"id":87308,"url":"http://patchwork.ozlabs.org/api/people/87308/","name":"Thomas Perale","email":"thomas.perale@mind.be"},"content":"In reply of:\n> As of glibc 2.43, faketime build was broken in buildroot because of a\n> missing const qualifier. A patch was applied to it in master to fix this\n> issue.\n> Sadly, due to a difference in faketime version between master (v0.9.12) and\n> 2025.02.x (v0.9.10), the patch didn't apply properly in 2025.02.x.\n> \n> Rebase the faketime patch on v0.9.10.\n> Fixes:\n> https://autobuild.buildroot.org/results/761/761250e8cbb2602abdc7752d182a44b6f7de5e11\n> \n> Signed-off-by: Thomas Bonnefille \n\nApplied to 2025.02.x. Thanks\n\n> ---\n> ...onst-qualifiers-to-fix-build-with-ISO-C23.patch | 23 ++++++++--------------\n> 1 file changed, 8 insertions(+), 15 deletions(-)\n> \n> diff --git a/package/faketime/0001-Add-const-qualifiers-to-fix-build-with-ISO-C23.patch b/package/faketime/0001-Add-const-qualifiers-to-fix-build-with-ISO-C23.patch\n> index ce84d40699..c889dfae29 100644\n> --- a/package/faketime/0001-Add-const-qualifiers-to-fix-build-with-ISO-C23.patch\n> +++ b/package/faketime/0001-Add-const-qualifiers-to-fix-build-with-ISO-C23.patch\n> @@ -1,4 +1,4 @@\n> -From dbe865dfdba0145d993d70b7fd4ec88b2f47554b Mon Sep 17 00:00:00 2001\n> +From 1f4f260977a7fcd09fb71b83ee64c4d87b868441 Mon Sep 17 00:00:00 2001\n> From: Tomas Korbar \n> Date: Mon, 15 Dec 2025 11:03:21 +0100\n> Subject: [PATCH] Add const qualifiers to fix build with ISO C23\n> @@ -8,15 +8,17 @@ Fix https://github.com/wolfcw/libfaketime/issues/524\n> Upstream: https://github.com/wolfcw/libfaketime/commit/dbe865dfdba0145d993d70b7fd4ec88b2f47554b\n> \n> Signed-off-by: Bernd Kuhls \n> +[Thomas: Rebased for version v0.9.10]\n> +Signed-off-by: Thomas Bonnefille \n> ---\n> - src/libfaketime.c | 4 ++--\n> - 1 file changed, 2 insertions(+), 2 deletions(-)\n> + src/libfaketime.c | 2 +-\n> + 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libfaketime.c b/src/libfaketime.c\n> -index ef1dca9..02839c8 100644\n> +index e632395..955cf3c 100644\n> --- a/src/libfaketime.c\n> +++ b/src/libfaketime.c\n> -@@ -2666,7 +2666,7 @@ int timespec_get(struct timespec *ts, int base)\n> +@@ -2365,7 +2365,7 @@ int timespec_get(struct timespec *ts, int base)\n> static void parse_ft_string(const char *user_faked_time)\n> {\n> struct tm user_faked_time_tm;\n> @@ -25,15 +27,6 @@ index ef1dca9..02839c8 100644\n> char * nstime_str;\n> \n> if (!strncmp(user_faked_time, user_faked_time_saved, BUFFERLEN))\n> -@@ -3338,7 +3338,7 @@ static void prepare_config_contents(char *contents)\n> - bool str_array_contains(const char *haystack, const char *needle)\n> - {\n> - size_t needle_len = strlen(needle);\n> -- char *pos = strstr(haystack, needle);\n> -+ const char *pos = strstr(haystack, needle);\n> - while (pos) {\n> - if (pos == haystack || *(pos - 1) == ',') {\n> - char nextc = *(pos + needle_len);\n> -- \n> -2.47.3\n> +2.53.0\n> \n> \n> ---\n> base-commit: 894ab931e1edcb2171e6c09c8efc70dd546ab52e\n> change-id: 20260403-fix_faketime-2b9ddfbe192e\n> \n> Best regards,\n> -- \n> Thomas Bonnefille \n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@buildroot.org\n> https://lists.buildroot.org/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming-buildroot@patchwork.ozlabs.org","buildroot@buildroot.org"],"Delivered-To":["patchwork-incoming-buildroot@legolas.ozlabs.org","buildroot@buildroot.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=ECLlUOex;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnFKt3pFDz1xtJ\n\tfor ;\n Fri, 03 Apr 2026 21:28:02 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 265E481B58;\n\tFri, 3 Apr 2026 10:28:01 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id D6RbqPrIy3s0; Fri, 3 Apr 2026 10:27:59 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E9F3281BBD;\n\tFri, 3 Apr 2026 10:27:58 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 4D4632CC\n for ; Fri, 3 Apr 2026 10:27:56 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 337934020D\n for ; Fri, 3 Apr 2026 10:27:56 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id j3qBaayuskqV for ;\n Fri, 3 Apr 2026 10:27:55 +0000 (UTC)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n [IPv6:2a00:1450:4864:20::433])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 14E0940055\n for ; Fri, 3 Apr 2026 10:27:54 +0000 (UTC)","by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-43cf8fe9c2aso978888f8f.2\n for ; Fri, 03 Apr 2026 03:27:54 -0700 (PDT)","from arch ([79.132.232.220]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4e52a0sm14557780f8f.30.2026.04.03.03.27.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Apr 2026 03:27:52 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org E9F3281BBD","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 14E0940055"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1775212079;\n\tbh=7UMcxeNjX3qlf3tIMN8LLiAhB41/kAlRQkXyo+nzP0A=;\n\th=To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From:Reply-To:From;\n\tb=ECLlUOexjgOPBzsjhEGg1LOl4Yf+ZtfWuHp+tXrr4M/Rw6FApZ7uMZe4NSWS7RHWd\n\t Qx0tVRjf7UBHghZ8eezl20CWZHrtjLxhQlFF4KTbSQUeC7a4EkGmU+YdPItEUlNMMJ\n\t ih1o3a/orYXEQo1wdWTdXS0d6XmXZ6fyyeKo1oFe748rbV5+zBVF3Xlb0G/TCXyyJH\n\t 1rV4UyB5bFEF1nJMrFDPaUxm4/bnAsJ2SSxRXv5N4hHSEicrSWil5Y11vlzP9oIYez\n\t 2eFdzzXsmJ3tfAduIwdm7UfYdWJGmVcUWHysrQln1lS99zSvPY5GdTyrqnejUYXigg\n\t Ri6eU/2bkstGg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::433; helo=mail-wr1-x433.google.com;\n envelope-from=thomas.perale@essensium.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 14E0940055","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775212073; x=1775816873;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=eM1BdaX1pglAlAMYkU4IymabnJ89oNcHmlR2BZNaTeU=;\n b=HFX8z9iF7mnpCUqRiLuAEmDfpna3IlJWGqw/y5MJ7DJsPs1r0Tk455SM6bACW956Fj\n 39A7a7pW3y2Dycd94O0Gbk25ZDN2+2ZiAyLYaKIr9fOBOv5XNdVrLFrnKmePMJ0iZ6fW\n Wzl0lzjlMi2mitm6mOUxjavuKSemwdCL5Y+btsYKXLMsf4Z9cJpCLawPxGnp2f1i4AfO\n La7K1uh1bw1mb7pV0W8WpDKFVKSIqYNJIeENvw856ui/5g6F/+pJbIPqad/RSJs8kXwq\n rBbR6S2rmwxOXmr8CerNmR9fWG3crBy+/IOWho52WQckRozPnXHVi9IlMGLqyDrK8WB4\n wz0A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCW6ie5dO+Koq6M/Q85jLlpW1qtxcGETGCGcU3k+VRoZ5SZNDxzSRf4urmSXgdY9C5bxKaVgsYHqfec=@buildroot.org","X-Gm-Message-State":"AOJu0Yz0rQXgLmLnMC7BqOp2RIuYQ/btWSTClrjtiH7+WaRoqlc+5bIq\n 5hfnliOg5aW7TbjPduXyyvaRJPYInTJ/lj8SAVyBo9rgpbzPXuqtjehH+v0zpzO24OJcOewbnTk\n ycKBL+uM=","X-Gm-Gg":"AeBDieukQPVuBcAU0p3OHNPKy6Mjqz7BAUhf2W0xJmyPeQ8SUQKBKxUFZeTeiDpi4GJ\n ZceskykeGuWFBVCRTNOM0klc56vmKlalnCaGsM9m1q8GHJgnsj31pj3yTSXEcsrGjzw5kj+SBjw\n NbHs9rbIKPbBKciImkA0JYlhexdVMse+wBb5Q3kGhbqBtPagwvJppfQw3R6TAmKMRE4f8Hc89XE\n WcLDRSyRjEiwda4xKaUgjuhnHcgi/l1p53kBG7OVPDrFhGblTppouECk/ne+fZthb5IlcaE/PE5\n 3BQbpeAtsrEfI264sUyEExOE6EgH/qug7d8+SuphoibRkBjcap7XKpGViYcvh4KvrIligYcPT8T\n Lmm0sdL/m3bCWIRCoX3+Tm56DBqknX1LB8E9cBT1xSTgpW25D/B7slDPQUbpeuxQteu5Z0O6UUJ\n dDesIH39koZP5DQTJBuNTuQlddnMg=","X-Received":"by 2002:a05:6000:40cc:b0:43c:dc99:771c with SMTP id\n ffacd0b85a97d-43d292ff698mr3901940f8f.42.1775212072972;\n Fri, 03 Apr 2026 03:27:52 -0700 (PDT)","To":"Thomas Bonnefille ","Cc":"Thomas Perale ,\n\tbuildroot@buildroot.org","Date":"Fri, 3 Apr 2026 12:27:52 +0200","Message-ID":"<20260403102752.210028-1-thomas.perale@mind.be>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260403-fix_faketime-v1-1-3e35e7b9c419@bootlin.com>","References":"<20260403-fix_faketime-v1-1-3e35e7b9c419@bootlin.com>","MIME-Version":"1.0","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mind.be; s=google; t=1775212073; x=1775816873; darn=buildroot.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=eM1BdaX1pglAlAMYkU4IymabnJ89oNcHmlR2BZNaTeU=;\n b=DEYLEZH42J9s7//US2zNNUdjkKM7QfeIMWBQkKdr2okNqPGk8RP1xusfns7zJlUduv\n Gu1Yicdmz8eMrVhFo/NDGgWZD43MOz2SKrzlPCfCctEaga+WGScPyBcSLkfG1c86yse+\n vYXkVFP64+SDHjMUMs8RK4suyQLRFETjBC8OOrXFl3YgM2bqZe152I01QEz0ahWvXzCB\n vfs4qE2cCkDv+REYrC+RqUFJZoftGqiVYkcnyQHWMZYh1oga8nP3d7Yu+IO96Z+CnYM1\n IEgMMZHNYQKXgKOW5+GVzPqydPvxxDtPvKQEJwNJc4kMboSHp6awAPMSethBBhqGWOtG\n +zvQ==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=mind.be","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=mind.be header.i=@mind.be\n header.a=rsa-sha256 header.s=google header.b=DEYLEZH4"],"Subject":"Re: [Buildroot] [PATCH 2025.02.x] package/faketime: rebase patch on\n v0.9.10","X-BeenThere":"buildroot@buildroot.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Thomas Perale via buildroot ","Reply-To":"Thomas Perale ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@buildroot.org","Sender":"\"buildroot\" "}}]