[{"id":3672940,"web_url":"http://patchwork.ozlabs.org/comment/3672940/","msgid":"","list_archive_url":null,"date":"2026-04-03T01:02:38","subject":"Re: [PATCH v2 3/3] binman: collection: Set build_done on referenced\n entries","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-02T19:24:29, yan wang wrote:\n> binman: collection: Set build_done on referenced entries\n>\n> The collection etype uses phandles in the 'content' property to\n> reference other entries. Mark each referenced entry with build_done\n> to avoid rebuilding the same entry data multiple times.\n>\n> This is important for cases where rebuilding may change the data\n> content, e.g. due to timestamps or random IVs in encryption.\n>\n> Refactor GetContentsByPhandle() to return both the entry object and\n> its data.\n>\n> Signed-off-by: yan wang \n>\n> tools/binman/etype/collection.py | 8 ++++++--\n> tools/binman/etype/section.py | 5 +++--\n> 2 files changed, 9 insertions(+), 4 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=CHSYM7L7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"CHSYM7L7\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn0p62xvdz1xtJ\n\tfor ; Fri, 03 Apr 2026 12:03:10 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E7E358407E;\n\tFri, 3 Apr 2026 03:02:54 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 490D38382A; Fri, 3 Apr 2026 03:02:54 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n [IPv6:2a00:1450:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5A764840BE\n for ;\n Fri, 3 Apr 2026 03:02:52 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id\n a640c23a62f3a-b9c04152730so218673766b.0\n for ;\n Thu, 02 Apr 2026 18:02:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775178172; cv=none;\n d=google.com; s=arc-20240605;\n b=dfn3p/gDPN4vsVg8fKHBT8Qz6U4tWg2LvaxqIF/4Ov2m362FcAZZ9YaVs+KK9sQvbp\n oZjv7g5tYd4iEykoLCRu79qJqU3RNJhs9N+/iPtcOk/gTxnMrp9340Shg2OERzx4u7Ts\n yq5HQLxNtgA5sfhd9LGGPj4EM+QEo6Jyr9PncSlVA8u83qq4jGqC3RDGIKASXvwxciZh\n 8o+QYOIlGBzi9xy8++uv5+eMAp1OwfLtHVYIG/9rwI7GfjsEpMafHGMBHAf3jYbZTh0o\n ckbZL4ILvUT0qE6c8mtrD74izm+KK9w7yZpt9OJ/lMvbNcVH8PRybFABE2Ln5ELgDVmE\n D36Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=KehXyKg65TuodojFq9Of/fnliFQ9A60GdBat/gTpFAA=;\n fh=rTilkJYT+OGucwgZmqaYrkAlQaWkjOIKQhfreKCPYAA=;\n b=JKrf8ckQ64bKjyhGgXZsakEehfcCEbdRGGnnNJzQ57wlTI5kgXPwXV6sziRyAZB0Mb\n UkmGRFJRQaq1xTTs1x97k6wLY4gAE0NYm0UhjMX4o/6CjV4FbwSs0MqdQz7iVbbSj5i6\n M92oma5j3R1Mjwv60eXMT2vw/0GfxAFUxN88rkMa9pVl/toSY6V7TlcRrWjVQ+X1eXSZ\n Jo/mP7KsCoE4hHOHIUuS5pDf9PnJCwfaKRfbRUCkA9JlNqSsf/M7k05RNRLXyjRCYh8a\n zCO90osBM1/cie0ZZ5ztNduZBPNhMEXvRTPysAk1XrQQLMcVmXujROEltsY5ORhyWSjE\n KsNQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775178172; x=1775782972; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=KehXyKg65TuodojFq9Of/fnliFQ9A60GdBat/gTpFAA=;\n b=CHSYM7L71Et/9VFgaa7HTDFiqYDH9vAnMCP2vTlf1tS17BYzu29vsWfVt8QKHx4m3/\n /fwEOFCdWTJG7t6Vsq672Ue9sivA0uD7pXiS29tL1R7yxuVbfQisJ6R58WUZ25H7GAo0\n 1gH3D/kg0oEwk2VBvv/IUsm1HeQOAHZ78te4w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775178172; x=1775782972;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KehXyKg65TuodojFq9Of/fnliFQ9A60GdBat/gTpFAA=;\n b=de8hdr69DhmJvOpbt40YeQKfNfP/uRSNYqK8QFedmpL9r35pcnQSulUjPwt+sQJ7MS\n DAUrkE9ghuckJjelxWqIja+6zpbcSa1SMFSIBLuh7h2PheqPYdQOE1PhkzMDUWswH29B\n anmMdI8pgArxeaM7Mpfs8Of+96+4Cu9uZ+n0TDCzfBNc1X+f0vLfTqPnPz8PkkXQBIeU\n l8pgcq0pqo0RRhvuMEqsnH7o5i5/qptP03yTSZ1S/SAPHvETMIKGEZ7c8FGmgQiJJULw\n XuC5T0u0BqSVWJxgWuKn9508RgZcaX5P5BWNsz4yo+ZMQGxjHt8oTEQD522ACOdhC1wO\n nNeQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU+pxPKH2rQiumMPMFMJE6bCSop06V2ok47/c7hS9H+KntIuJa2q0bDNz/A74rfzIz2ed9dN4g=@lists.denx.de","X-Gm-Message-State":"AOJu0YwF8COcvqZzn5X7uEUe+RG/IZXnrw98+vvqfVM3qMR3DABj0ORZ\n 8+T0KIZ6uToG7GEZ0KL3u0TNlzIUnsZvS9vfe05BmFEycqk1ZkFlEltl6H2+2Ke9bJOKs5dELIQ\n Mi3nDYzHbt2VQDgT0sP79o8SWMM7mEufsqCXAIa1Ple974YeM8fw=","X-Gm-Gg":"AeBDieuRgcSPbN8j2WML78MogVnplIiBsaQZNgg9CumnAtSCZH/FF2/a88K69KWMJLU\n 4Q1Jf6pDYabnSvCHHYJoUktlMYct4cynlkELOK0HB4FYqCfYW3cJstHhf6YjK4HLqr3e0Qjjl7y\n 1ce61VjPfdfJ4SauwfIriM+3juZkXijC4YIYhrn7XF/PYuMIwxUcOnW4WxmTMJLRZpysnG5M41j\n 3h8hSdgVH6Ick7U/uJGBkVAftdCQnTcpB67/DOeWfiJ6nZJHrzhXxUSc0NM2vuTBwWgoErTAUPs\n 0SwPYw==","X-Received":"by 2002:a17:907:3d87:b0:b8f:9bea:ad6 with SMTP id\n a640c23a62f3a-b9c6744d907mr43642966b.18.1775178171734; Thu, 02 Apr 2026\n 18:02:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20260402192431.2421155-1-yan.wang@softathome.com>\n <20260402192431.2421155-3-yan.wang@softathome.com>","In-Reply-To":"<20260402192431.2421155-3-yan.wang@softathome.com>","From":"Simon Glass ","Date":"Thu, 2 Apr 2026 19:02:38 -0600","X-Gm-Features":"AQROBzAQ7gmqtYYPO7rXhnAmeKOlHRGZZnMcaeH6R1VW7s-dlGl89Dak3duxuOU","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/3] binman: collection: Set build_done on referenced\n entries","To":"yan.wang@softathome.com","Cc":"trini+nodisclaimer@konsulko.com, sjg+nodisclaimer@chromium.org,\n alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n paul.henrys_ext+nodisclaimer@softathome.com,\n u-boot+nodisclaimer@lists.denx.de, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]