[{"id":3672938,"web_url":"http://patchwork.ozlabs.org/comment/3672938/","msgid":"","list_archive_url":null,"date":"2026-04-03T01:02:31","subject":"Re: [PATCH v2 2/3] binman: Generate preload header and sign data only\n once","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-02T19:24:29, yan wang wrote:\n> binman: Generate preload header and sign data only once\n>\n> To optimize preload generation, generate the header and signatures only\n> after all data has been collected. This avoids signing the data multiple\n> times.\n>\n> Since header_size is known upfront (from __init__), set the preload\n> header size in ObtainContents() to avoid an extra packing pass when\n> ProcessContentsUpdate() detects the size changed from 0 to header_size.\n>\n> This reduces unnecessary repacking and signing operations.\n>\n> Signed-off-by: Paul HENRYS \n>\n> tools/binman/etype/pre_load.py | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Pa+lkD9j;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Pa+lkD9j\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn0nt4LRRz1xtJ\n\tfor ; Fri, 03 Apr 2026 12:02:58 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 51BE183CF5;\n\tFri, 3 Apr 2026 03:02:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4BB9784056; Fri, 3 Apr 2026 03:02:48 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n [IPv6:2a00:1450:4864:20::535])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 182318382A\n for ; Fri, 3 Apr 2026 03:02:45 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id\n 4fb4d7f45d1cf-66bf6aa4858so2593944a12.2\n for ; Thu, 02 Apr 2026 18:02:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775178165; cv=none;\n d=google.com; s=arc-20240605;\n b=GgthEtmdgbnTkMrYOYFq0GVKFoZEwj/LoZJO+PKdG2/6XpAe8rihIrKceJa8VPSCFg\n eEsP+dxma+/86Hj4QXIEY1FU4KpaG+EQ2MUU4U6ZUrD7A76BAqm/QWGffGfORKkgienk\n h8DunWqMSo58fW58yVxshU9ZpANpSvecFuBR3z48gQceH+kAESP23fX5G18ioixTLNlc\n Bbj6x9crGtLUZUD7CpWZel08pQg9BFeqa+XtQfAm2MMrq5wcyJv4TZ6yxDRulOcfNjDu\n dutjmanpBvkZ6LqPYelG80n3MHEspxLpKS7iDDQ3tjm9aulKf2hquIShfwK47U0iSVLU\n Z8eg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=ZxZKbDj52oebJ1QAhAl1syCQ8CdjgslZPgndOb+jPYQ=;\n fh=EL/ZcCxhgAoI8dWULsj35ljp6uPAmjOcn4NyTSqMyGI=;\n b=RXihn1+PQAqiKl8Y+XKIQIoEVzLGIzDCzjEjDiIli7AncTX9yuJ4TsrOSfiPorSEpr\n M5C/cq/IagF7P7E09ch/7u7aVziXZy7aG+5TSMo6MkdNePI7jlIpt95AwKVyYMNeo9td\n Wz3byEawA96i9p6bUjOe+gtnVZ015CdJ5TNUJT4phO3MSxjsBOdXGZtxS+cbJxTY6Rfw\n AUGjaFmwA/eUuZSoXBy4Di4bntr6w/T9zId/1+u2gCdzGDpOYI+tQr8qTZJH7u/jgRmN\n d3IjjPCtn50ha8Ot8vTTQWfBRnSL5yemBr814INf5k+H4c22ROmk9cwif4/sRozbIgXh\n 9LcA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775178165; x=1775782965; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ZxZKbDj52oebJ1QAhAl1syCQ8CdjgslZPgndOb+jPYQ=;\n b=Pa+lkD9j8mISwzWe25LeDRCPZqv4kDGckIfE9sFRma1Amt6kfaSpVNWwWjAGsohy6L\n qwS5D2QIsL7KVj4LkFmAXZbm0xG837PQuX9KLguN9VqNkis5MiyCWFJnwLMRoD4L2SOt\n vcWpPD/+pwi8cM1SIKkWtkXonmQC7SZbRl67U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775178165; x=1775782965;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZxZKbDj52oebJ1QAhAl1syCQ8CdjgslZPgndOb+jPYQ=;\n b=GJABYtNzIorl/3VDimKjBqSAWpgahoG2PBolaE8uhnG1b+WrUR/bg+++3N8p+67A2G\n Jrc926dvog+4mYwNU89Qy5Kt1vdEVhiRk6/nIcS2pI1LIiCUu49qShNYidUt1U8hVT0N\n TYUnzgm3rc4g7zMjHgUQQe9Lnx43xNVr2NryBgAJ+S41i3T+pFlrYWjZlN+Fz87RRvGD\n 87j6lq3ZdOsnrrlHOCsNyudYcRcCZclF9cfkpMERid/5bzjiDRpMzOC96sgMIBpJxn2B\n VtFTuKTS1YXGwJJsVQw/s3XdoEt591tu2cKIzGiZEGQdq4Q+rHtIBk5XK8TCF5Zz1srf\n EB7Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWESMej7g4sm9WrHUJsSM2wY9AI8KVAAMxjzhJkdjAQqixX/45ULTMaBuJjTeEF4e/LSgzhu7s=@lists.denx.de","X-Gm-Message-State":"AOJu0YwAxlDCXpTrd5f/EeAFvmwu5cszx0H3bz7tFTRj/4eBROaiTHjK\n DXTVSZmad4dthIReX8yVJd3GJuKtXXQNpF3radxgrZ+z3h3rQnHsbLj87sIVgN4UQsILynikil7\n FeOVTr2wiViALVO/zFwl9g7AiVsjH+KcaIoLtlBZR","X-Gm-Gg":"AeBDieujZQ/Ryhgn4OMonjDSlsh28uBmdQMqvdkgNAS4HjO56rnIY4ipozHC9ZUqAGP\n eHLr/bk5HWW0QS7XY7BOwdeU5C1J6bcnjztSZyoRKIhy4ZYKTIzSNugvty9VaHNjvyc6kLOOtft\n k6plL9ZZCTbO7Y8OZTwve3QIlzpYVWZaVV0DkRfy9JIlZgu+9s9vPQHBxATxhaKFT7Uc8zlLWrZ\n kLMB6XR7rhVjB2hD/XdTj+qpUM1gi45z6Tu+IfJS0XKUNduNyFAcIHNknHbYqS0rNsfP6qAgmFq\n vfclgA==","X-Received":"by 2002:a17:907:9614:b0:b9c:34f8:b969 with SMTP id\n a640c23a62f3a-b9c67b3b2aemr45139066b.49.1775178165328; Thu, 02 Apr 2026\n 18:02:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20260402192431.2421155-1-yan.wang@softathome.com>\n <20260402192431.2421155-2-yan.wang@softathome.com>","In-Reply-To":"<20260402192431.2421155-2-yan.wang@softathome.com>","From":"Simon Glass ","Date":"Thu, 2 Apr 2026 19:02:31 -0600","X-Gm-Features":"AQROBzDdIA1dnh1LejCGSM_klEkGNzQDmimtheNJnlanFa0YKOPSXDzPHC-NGaw","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/3] binman: Generate preload header and sign data only\n once","To":"yan.wang@softathome.com","Cc":"trini+nodisclaimer@konsulko.com, sjg+nodisclaimer@chromium.org,\n alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n paul.henrys_ext+nodisclaimer@softathome.com,\n u-boot+nodisclaimer@lists.denx.de,\n Paul HENRYS , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]