[{"id":3672842,"web_url":"http://patchwork.ozlabs.org/comment/3672842/","msgid":"<66240c1c-07b8-4faf-84a4-0275d772b82e@linaro.org>","list_archive_url":null,"date":"2026-04-02T18:02:18","subject":"Re: [PATCH-for-11.1 v2 4/9] accel/kvm: Expose all non-target specific\n declarations","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 2/4/26 19:04, Philippe Mathieu-Daudé wrote:\n> None of the declarations guarded within the COMPILING_PER_TARGET\n> checks use target-specific declaration. \"cpu.h\" is not required\n> since some time (maybe commit 4fb54de823e \"meson: build target\n> libraries with common dependencies\"). Remove the restrictions.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/system/kvm.h | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/include/system/kvm.h b/include/system/kvm.h\n> index 9b722ad931a..c33fb160b5b 100644\n> --- a/include/system/kvm.h\n> +++ b/include/system/kvm.h\n> @@ -225,9 +225,6 @@ void kvm_irqchip_add_change_notifier(Notifier *n);\n> void kvm_irqchip_remove_change_notifier(Notifier *n);\n> void kvm_irqchip_change_notify(void);\n> \n> -#ifdef COMPILING_PER_TARGET\n> -#include \"cpu.h\"\n\nPrerequisites still missing, sorry.\n\n> /**\n> * kvm_update_guest_debug(): ensure KVM debug structures updated\n> * @cs: the CPUState for this cpu\n> @@ -450,8 +447,6 @@ void kvm_set_sigmask_len(KVMState *s, unsigned int sigmask_len);\n> int kvm_physical_memory_addr_from_host(KVMState *s, void *ram_addr,\n> hwaddr *phys_addr);\n> \n> -#endif /* COMPILING_PER_TARGET */\n> -\n> bool kvm_arch_supports_vmfd_change(void);\n> int kvm_arch_on_vmfd_change(MachineState *ms, KVMState *s);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gvWQiK1q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmqTn12ypz1yCs\n\tfor ; Fri, 03 Apr 2026 05:03:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8MNK-0001XS-5C; Thu, 02 Apr 2026 14:02:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w8MNB-0001LW-FP\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 14:02:30 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w8MN4-0000XF-3U\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 14:02:25 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4888375f735so9984615e9.3\n for ; Thu, 02 Apr 2026 11:02:21 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887c8ee2d3sm74726695e9.32.2026.04.02.11.02.18\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 02 Apr 2026 11:02:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775152940; x=1775757740; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=8Cqd02rloH4qWYkodiVboVkNgAG3Np1UDG5yCBlvtX0=;\n b=gvWQiK1qfqx21gqj1+xy6nRx8qRPo7uA0mQGxMtBZvbRipBSZPjzmrQdPVj+Jm0kfb\n xDXTO67OiIXpoBmHlkYly+czSiYuix0SDfPojYLXBYqAp+XOzFVK7LWo0/SS3t95Ym91\n iDOMII674ohN6j3vAB8wVJBAuZCEyq1Rlig0HN3ytnMERJDnZKiMfkqAxLOHeWnBviMD\n UHcu1wZLDX68Ru2N3QkuhIGh38odsJ0/WIMKbbR2lP5hFwcC44h31W82IMum0bOhp04U\n SyosVSIt1PLT6/uOfjc4Hh2U3VICHznceZOexAHbRWntIV3/TecV10J4jRftZHvQMX+s\n hBZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775152940; x=1775757740;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=8Cqd02rloH4qWYkodiVboVkNgAG3Np1UDG5yCBlvtX0=;\n b=UP2c5w1D+Hdmb3TYDOOUk/GpaKbdbc23ga1vl22akVqgfwwEnWUQG+nRz7Eb0A78p7\n fqVHSzIL7Cz3E3FEwUF7DXNNY/KsprsWLUt5/2zeKHfFLAd//eh78SNJlQ19oS1UKlg4\n fsMSM+6PH73nvJ0ZeTph9mc6Jxt6yN3+B+JeV2ODg3vLzqRCNMdLiH43eQiEiUUoub8g\n YHgNjU5GHhUF0j4Wp8OHkVcZ1YNgXJwjw8edr44lISgVEMNTH6aegwSkFx1IOcqhnyUa\n cy3didjGcoD3kNspPWM4a5h2SW9fh/eDYwqYrx5ElLb8MLIXr9TEg4P6/+DBkaZJEFfn\n NYbA==","X-Gm-Message-State":"AOJu0YxiIOZHqQzzM/S77KRFSBcy9mgKN+92nG5pcR6ZUhp7R8NhvOLd\n guKi2oH+RvwrnsTAhiq6JzoJbJ+hODC/vXsfkXBWfCWLGmdRazLl+nuUGPbdFxA0TwlG36GGZmS\n YAdZZF1Y=","X-Gm-Gg":"ATEYQzw4+80iqHc0OVPkYFCx3XFZZzHIoN1N7nSlxZo02NFZY0j6NRDUtql/z01TE+a\n yhnkaFu51bLZVv2KMCZXtMfZfqwzPFINKh43gJz2v3IYNOGQ2gjpuHe8yGSD8f4L6MfinlpP1g5\n vGJl/fifu7UyZQioSV4riKtwY5tTXakiTTlAo8r7AedOLyJWVcpiYHbbrZRHEvUHz5E5yTW5jhm\n pPeJJHpAeJrkt+x5oX6QCYUT1lusy/aTW13n8Gs4e+LFYwZAAwfTyjrdoc/o9v6nSoolaqEKIez\n QluIuY3z6vSp4k5V2b284HEnXo/tUnk6Cj5qnsNiucVIv2rdDCzFrdceUVDXYtQerY8n+jlr5MI\n 3QL8EdVBpvbbxvQIpQFo0+mHKr7/oLxCPIq4B2CZKEDvzqab9vsGH4Dr6VYcPw91O2MB5yQ1wr0\n LtvtPgs2QZ43t3aXeEouPjHw3Vt/jpnv722MynhfI61LXcDPHyrjQwdKdKlsE5L4BDyw==","X-Received":"by 2002:a05:600c:4e88:b0:485:3f72:323f with SMTP id\n 5b1f17b1804b1-4888358809emr146323355e9.11.1775152939887;\n Thu, 02 Apr 2026 11:02:19 -0700 (PDT)","Message-ID":"<66240c1c-07b8-4faf-84a4-0275d772b82e@linaro.org>","Date":"Thu, 2 Apr 2026 20:02:18 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 v2 4/9] accel/kvm: Expose all non-target specific\n declarations","To":"qemu-devel@nongnu.org","Cc":"kvm@vger.kernel.org, qemu-arm@nongnu.org, Anton Johansson ,\n qemu-s390x@nongnu.org, Pierrick Bouvier ,\n qemu-riscv@nongnu.org, Peter Maydell ,\n Paolo Bonzini ","References":"<20260402170434.94783-1-philmd@linaro.org>\n <20260402170434.94783-5-philmd@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260402170434.94783-5-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]