[{"id":3672798,"web_url":"http://patchwork.ozlabs.org/comment/3672798/","msgid":"","list_archive_url":null,"date":"2026-04-02T16:14:21","subject":"Re: [v4,3/3] fwu: Move boottime checks to EVT_POST_PREBOOT","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-02T15:36:57, Michal Simek wrote:\n> fwu: Move boottime checks to EVT_POST_PREBOOT\n> fwu: Move boottime checks to EVT_POST_PREBOOT\n>\n> Switch fwu_boottime_checks() from EVT_MAIN_LOOP to EVT_POST_PREBOOT\n> because there is no reason to call FWU so early. FWU triggers EFI\n> stack initialization before all devices are visible which prevents\n> the EFI stack from scanning these devices and adding them to EFI\n> variables.\n>\n> Signed-off-by: Michal Simek \n>\n> lib/fwu_updates/fwu.c | 2 +-\n> test/dm/fwu_mdata.c | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=lZRqrg3i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"lZRqrg3i\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmn4N25LHz1yGH\n\tfor ; Fri, 03 Apr 2026 03:14:44 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A0940840ED;\n\tThu, 2 Apr 2026 18:14:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id F4148840F5; Thu, 2 Apr 2026 18:14:37 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BD4D7840BE\n for ; Thu, 2 Apr 2026 18:14:35 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-b982b0889d8so140824266b.2\n for ; Thu, 02 Apr 2026 09:14:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775146475; cv=none;\n d=google.com; s=arc-20240605;\n b=gmeuAfiFY1w0vZOCFCGKxgvahzrNXGzK+WGsNN26Zx4zetN+iag8NzOmKpMTCbWwqd\n Km+Pbge0IL0hveyTiHd8XW9JYqcoiOhZOkanBDVUVjUab9a6IUYBxUvWi/49R7BrIlMK\n bZTTITmRm15RM94RkJP1xkcvavdyzvGoqaaE40bER4touNUugQKiOy3aczGMMVYlrOCQ\n jZNPWfeE9h1IdG2Do0BKR9dM0U76JyYnWeuZXgbpa4GYW6njEF4sT2IP7hPa2984flgp\n Ynidglh3DN8lRXG8L4P3uFuhLv9HPWQy36UfrkCABzNsy0TXF558P6RiemcKCYuW85Wt\n 42NA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=7mm58UXdXBDptkp91KDPy2aOgqRdySaJnNzLeIoyBMc=;\n fh=RnB5lhiZ2zWwUKd56qUm2o6d636ryv0VxB/lSwXL6qU=;\n b=MKmPikJq9x37vi7lhvh2xGEqNth0M6jG/ELTZ4QYxMKuK29c7ftODNdtkJ73hWZY61\n gdZ62iMWP6ZOy67/ioAPOq0WUVez/lpGmZdCej68NXbRNsPmyiX9bhRz28qvTGbucYvI\n yKauVWaT44kAjVuElt9qVwqZpbizaDtXaJSDxbnMi6u/vp3rTmYnBdGEJve8TDFkfCqG\n WJjOXe4CasSr5GYfRusT+r/raB5idJsqFqh95l0hASrFzKtAtJbX0lBtgY9S/W04BGzV\n rFHML/1yKQQBjvPtROLTMvos0dvMVib3cQucN2d8VQTK7sb7aJsZfr86HSJTbeZL+/r+\n hdUQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775146475; x=1775751275; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=7mm58UXdXBDptkp91KDPy2aOgqRdySaJnNzLeIoyBMc=;\n b=lZRqrg3i3DaNjVJeL3M/ep3iW5WyIrTj1NxxJsGLgJLp1WeVJ+4a7kRoW/X5taNvX0\n VPuau7JX9LLIzYgEAhGmAOmCzfTvqhIrN/9Y6zntBMykl6uR0EPmlTvYnjho3jCGFjEl\n fHsuyeyVhTlv1e+q1Q1rinFcYA4F8M08+Nuh8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775146475; x=1775751275;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7mm58UXdXBDptkp91KDPy2aOgqRdySaJnNzLeIoyBMc=;\n b=boMOUFreMBTO/gbae/kH3wuXdX21b3vL7PTRvVgHEmTDqYa5cUMnT/dryGDgye5fHn\n iD5UrRxo9is0okZ/L671B0gNtribL0tdhv1fHmzunolwNMuMRuHg6m5O9s2qeIUuBEnc\n FWxgLHfMFIifUOznj/rURlZ1UmHRTkBClPNYAAh0LfaF/j1ZzIH1AD/MEtdrL+/Og2+P\n JE0C/3juaw9DXg6EL+83bOPOSLK7S56xBG97LSjVopfW6f1qMjCuWxo1T2D4VU4TDX9N\n 0GBi+iKORWAcpsMXFNlwU8C5dieWMHpgid9OnyN95lOPZjUTE7CSX3AVZLHvQGz+MifY\n bCGg==","X-Gm-Message-State":"AOJu0YyVSIrjYFMaSl28Yg/UaRGrdSg4Xm5Xmhsd/PDJMBTPSWixK3h5\n OJMNUrhIUAnFfAtwYfPQGS5xr5hD1NbOxvO44gYVjxKSkpfb9RUA50oE3cGXz7t76boQT+UwitK\n ffO8kA8USvQXUXpwVqtplwTJN2OvIqVJLNzXF2hKX","X-Gm-Gg":"AeBDiesR/jtz640AkCslq0eUhlAAg8Jo0ADnVo3g5glXGM7A5C2eOSpd6AgtsE7DeV+\n Ke3E55vpVQn+h2bOeLkT7nGCK5jnT/Si+XX0/N5yqGsv/euxVro/eQxuVWQ9lE/JzIznoknewkT\n Xsk6i9K8wJvlNhPH/WY0xEG1H8HOXp2SOKTGyNCWO1tfiave3nKuC8/f5Z4TKBBIV5AORYAywZr\n 1jMSbnqDmKO7kEWsLB/uv9jE2jYdA4nLFrrRH+anCQjAqCniCpK3KWAtcR4XzFw/7orv1L6OB5w\n shDBFA==","X-Received":"by 2002:a17:906:9a92:b0:b88:6164:6421 with SMTP id\n a640c23a62f3a-b9c13903483mr443736166b.16.1775146475099; Thu, 02 Apr 2026\n 09:14:35 -0700 (PDT)","MIME-Version":"1.0","References":"\n <950bf29f73f44e8edc6b22cb7ea2d9a56cfe2872.1775144215.git.michal.simek@amd.com>","In-Reply-To":"\n <950bf29f73f44e8edc6b22cb7ea2d9a56cfe2872.1775144215.git.michal.simek@amd.com>","From":"Simon Glass ","Date":"Thu, 2 Apr 2026 10:14:21 -0600","X-Gm-Features":"AQROBzAxhmn2XUb2jt1rpmykwONYw10P04BAxSjF4ey3DU-RbHKpHAtCprClogU","Message-ID":"\n ","Subject":"Re: [v4,3/3] fwu: Move boottime checks to EVT_POST_PREBOOT","To":"michal.simek@amd.com","Cc":"u-boot@lists.denx.de, git@amd.com, xypron.glpk@gmx.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]