[{"id":3672789,"web_url":"http://patchwork.ozlabs.org/comment/3672789/","msgid":"<5e3e8684-f893-4fb0-879e-9661820f72dd@linaro.org>","list_archive_url":null,"date":"2026-04-02T15:39:09","subject":"Re: [PATCH 5/8] thermal: khadas-mcu-fan: Add fan config from platform\n data Add regulator support","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/2/26 16:27, Ronald Claveau wrote:\n> Replace the hardcoded MAX_LEVEL constant and fan register\n> with values read from platform_data (fan_reg, max_level),\n> as new MCUs need different values.\n> \n> Optionally acquire and enable a \"fan\" regulator supply\n> at probe time and on resume,\n> so boards that gate fan power through a regulator are handled.\n> \n> Signed-off-by: Ronald Claveau \n> ---\n> drivers/thermal/khadas_mcu_fan.c | 43 ++++++++++++++++++++++++++++++++++------\n> 1 file changed, 37 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c\n> index d35e5313bea41..55b496625e3bd 100644\n> --- a/drivers/thermal/khadas_mcu_fan.c\n> +++ b/drivers/thermal/khadas_mcu_fan.c\n> @@ -13,13 +13,15 @@\n> #include \n> #include \n> #include \n> -\n> -#define MAX_LEVEL 3\n> +#include \n> \n> struct khadas_mcu_fan_ctx {\n> \tstruct khadas_mcu *mcu;\n> +\tunsigned int fan_reg;\n> \tunsigned int level;\n> +\tunsigned int max_level;\n> \tstruct thermal_cooling_device *cdev;\n> +\tstruct regulator *power;\n> };\n> \n> static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> {\n> \tint ret;\n> \n> -\tret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n> -\t\t\t level);\n> +\tret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n> \tif (ret)\n> \t\treturn ret;\n> \n> @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev,\n> \t\t\t\t\tunsigned long *state)\n> {\n> -\t*state = MAX_LEVEL;\n> +\tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> +\n> +\t*state = ctx->max_level;\n> \n> \treturn 0;\n> }\n> @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev,\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> \n> -\tif (state > MAX_LEVEL)\n> +\tif (state > ctx->max_level)\n> \t\treturn -EINVAL;\n> \n> \tif (state == ctx->level)\n> @@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)\n> \tstruct device *dev = &pdev->dev;\n> \tstruct khadas_mcu_fan_ctx *ctx;\n> \tint ret;\n> +\tconst struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev);\n> \n> \tctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n> \tif (!ctx)\n> \t\treturn -ENOMEM;\n> +\n> \tctx->mcu = mcu;\n> +\tctx->fan_reg = pdata->fan_reg;\n> +\tctx->max_level = pdata->max_level;\n> +\n> +\tctx->power = devm_regulator_get_optional(dev->parent, \"fan\");\n> +\tif (IS_ERR(ctx->power)) {\n> +\t\tif (PTR_ERR(ctx->power) == -ENODEV)\n> +\t\t\tctx->power = NULL;\n> +\t\telse\n> +\t\t\treturn PTR_ERR(ctx->power);\n> +\t}\n> +\n> +\tif (ctx->power) {\n> +\t\tret = regulator_enable(ctx->power);\n> +\t\tif (ret) {\n> +\t\t\tdev_err(dev, \"Failed to enable fan power supply: %d\\n\", ret);\n> +\t\t\treturn ret;\n> +\t\t}\n> +\t}\n> +\n> \tplatform_set_drvdata(pdev, ctx);\n> \n> \tcdev = devm_thermal_of_cooling_device_register(dev->parent,\n> @@ -130,6 +154,13 @@ static int khadas_mcu_fan_suspend(struct device *dev)\n> static int khadas_mcu_fan_resume(struct device *dev)\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n> +\tint ret;\n> +\n> +\tif (ctx->power) {\n> +\t\tret = regulator_enable(ctx->power);\n\nSeems you're missing a regulator_disable() on suspend.\n\nNeil\n\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> \n> \treturn khadas_mcu_fan_set_level(ctx, ctx->level);\n> }\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QW4Y2tJ9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16942-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"QW4Y2tJ9\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.48","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmmLk5dqmz1yCs\n\tfor ; Fri, 03 Apr 2026 02:42:06 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id AE4CF30484D8\n\tfor ; Thu, 2 Apr 2026 15:39:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 658DF3E1229;\n\tThu, 2 Apr 2026 15:39:14 +0000 (UTC)","from mail-wr1-f48.google.com (mail-wr1-f48.google.com\n [209.85.221.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 774F73E2742\n\tfor ; Thu, 2 Apr 2026 15:39:12 +0000 (UTC)","by mail-wr1-f48.google.com with SMTP id\n ffacd0b85a97d-43cfe71e5d3so945966f8f.0\n for ; Thu, 02 Apr 2026 08:39:12 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:ac0e:65b8:7f89:413a?\n ([2a01:e0a:106d:1080:ac0e:65b8:7f89:413a])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4e52a0sm8533616f8f.30.2026.04.02.08.39.09\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 02 Apr 2026 08:39:10 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775144354; cv=none;\n b=uJ0AikpH66Zkrai8HhF6Cfs7TFV34HgLDAZpMcYv3fsfqEwir3IuE+yhsIDMabuzR43MmHuufRTzatRbdkgLXYJDwkldEcibLVQ/uJHab8S0SYiCLBqnuBPrEtjQKZEul3mDb5krdFFbNI/OHNYg4CaBwWcv+eW9m6uS8Xy9U34=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775144354; c=relaxed/simple;\n\tbh=X5xP4mH4gp9Nk6yWni1CQCZV7BD84tNaYS8aUYMymWw=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=O9AZWBkZp/zrNXEc0E9sLMe4gS2lcIM6op20t9SN1Jj9DnjDpkGBL92vx515sYcVcywhi3DJMJ8IaaEC3ZfLAbg3Z4s61ZX1Xm/fKccdYyTIt2bYa9r5O2MhEuY32bXTg8vEsJIbU4+0+JzRlDj6I3oF6BFQ8aD9eZkLWTrgbKY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=QW4Y2tJ9; arc=none smtp.client-ip=209.85.221.48","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775144351; x=1775749151;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=AwqyVdkU5xmyU+XRaxwsr9L7DuUGafXosoFXRqh5wTY=;\n b=QW4Y2tJ9GyvI3ZYIflHgFzx6oC7++BpuETK+mbT7e3znsu62gjd9EHSl+OlqEREgZz\n l7NVlBuZx4+gxIMK+yPLznaftDc13c9/oqtIFyEbuBKRpt7YlHUyrSCg9JSqsSscglXm\n v3/U27gOfKuY0Z6C3GWnPeBTQwTGvGtHqBmRuoOEx8Xm1q3nEoQvTRXTGHlN5ZEqTOhd\n LMhJ6QTQ19XwqjpdkTEfqBzOcOUXmSkFBtZCkvrX2Z6BX8bfs08jjJOEKdUoV2VL1Ptk\n P1AJFwPvExaTIzHcHFj032PK9V2W6hPVN4UaT+U2BV6E5MDtfvwuiTf02yCdH/ft+7sD\n vdFQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775144351; x=1775749151;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=AwqyVdkU5xmyU+XRaxwsr9L7DuUGafXosoFXRqh5wTY=;\n b=UXOC2i1WjJUmnQsUI60XQbTYibFp+IMuze4jpZjSIGnKT32oJbpObZ1V7/E13IUIqx\n UCfSli1C7nKGeLNV1HTo8yb5QL+Ke68GkK0qsc+9+vzGwMR4C6TQAKTwJgvw5nPBo4Yp\n OD6TkolwTsETYas/OTne5ufW7Xqz+2EzK638oBYBc5j78vkLx6xGP/AkIYiUw7BaiRnm\n SzDVltTDClio5Tzm0H/tUvBRVbKq6qowc+VwuPqtzEinxNrZGCE/mhIKHXMvx/waqQ6B\n rdVNCamSp10nkAAdyUxwDZv48sMGcRmcpWDCV6I1ICDeSj55nL7misKQXSF98btqK1qd\n 1pqg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWa+FtjilMLPEziL27H7WHzkBUl5Hm7ZxbCV2mXnWM7ptsTB2hlogCnWrVn1ULvmgo92uJhHMFYG88=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzzHsnfrCQ80JLKaQ2sSmpojPHSWOnFD5OZ2TVFaNL7/FPFBkQL\n\tFJfbEpZBxg0szNrut5QYMYlVDi7wQYLLNlgT0Zf3PblBZR7dIz7b8SAnWX9ckZjXcQQ=","X-Gm-Gg":"AeBDieuqbW2U8YqJyDQtWMUJ3u52Tljc6IGdAmtnFyG121t1FZXsr/uSYiqVfjSG5QT\n\tgy1xrVuTPlcAFgRsdN2UTai5+iSGZD46hs6zYmPeuNNpEImDaq9Wb+8PpJksLV/a77ppc7priQZ\n\ti/UQpkHX8OS8AuPcml2ExEx8vin9Y3SZdPdH+czQixDPKmCmfT6aJBCBKHIIH4q2hxJQy0tTIXM\n\t9s8z06LF3TKekIZD7VG5h//rg2dy++GvWuFdJCGSaJV0/1XPKDcGNlRWYJGtpYBtp4XJKP1Wnvb\n\tTFUIJg9gAhuoj9cIDWbilqDFy1QxhdMzBlETynYIaOBr39qQ3TQxQSlFwVEEacaomkxl5gRUPnw\n\t/bnOIAVaQdhS97ijRbE8zMOTtPCVzVdW/A4jgbUWsLyYh7zmnJ8Qc/WP6d7d2JcGeK8TiYigxJr\n\t87vvcAyFYflEO21GarJIDIPGgR3TybJdSxgodfEdwJOv7GJJOE+HgVPyKEc3GCR7aRKGLvVD0qF\n\ttHoqTU=","X-Received":"by 2002:a5d:5f45:0:b0:43c:fc5c:aa0b with SMTP id\n ffacd0b85a97d-43d150fb173mr16260734f8f.42.1775144350679;\n Thu, 02 Apr 2026 08:39:10 -0700 (PDT)","Message-ID":"<5e3e8684-f893-4fb0-879e-9661820f72dd@linaro.org>","Date":"Thu, 2 Apr 2026 17:39:09 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Reply-To":"Neil Armstrong ","Subject":"Re: [PATCH 5/8] thermal: khadas-mcu-fan: Add fan config from platform\n data Add regulator support","To":"Ronald Claveau , Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260402-add-mcu-fan-khadas-vim4-v1-0-2b12eb4ac7b0@aliel.fr>\n <20260402-add-mcu-fan-khadas-vim4-v1-5-2b12eb4ac7b0@aliel.fr>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"<20260402-add-mcu-fan-khadas-vim4-v1-5-2b12eb4ac7b0@aliel.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":3672827,"web_url":"http://patchwork.ozlabs.org/comment/3672827/","msgid":"","list_archive_url":null,"date":"2026-04-02T17:00:55","subject":"Re: [PATCH 5/8] thermal: khadas-mcu-fan: Add fan config from platform\n data Add regulator support","submitter":{"id":93040,"url":"http://patchwork.ozlabs.org/api/people/93040/","name":"Ronald Claveau","email":"linux-kernel-dev@aliel.fr"},"content":"On 4/2/26 5:39 PM, Neil Armstrong wrote:\n> On 4/2/26 16:27, Ronald Claveau wrote:\n>> Replace the hardcoded MAX_LEVEL constant and fan register\n>> with values read from platform_data (fan_reg, max_level),\n>> as new MCUs need different values.\n>>\n>> Optionally acquire and enable a \"fan\" regulator supply\n>> at probe time and on resume,\n>> so boards that gate fan power through a regulator are handled.\n>>\n>> Signed-off-by: Ronald Claveau \n>> ---\n>>   drivers/thermal/khadas_mcu_fan.c | 43 ++++++++++++++++++++++++++++++\n>> ++++------\n>>   1 file changed, 37 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/\n>> khadas_mcu_fan.c\n>> index d35e5313bea41..55b496625e3bd 100644\n>> --- a/drivers/thermal/khadas_mcu_fan.c\n>> +++ b/drivers/thermal/khadas_mcu_fan.c\n>> @@ -13,13 +13,15 @@\n>>   #include \n>>   #include \n>>   #include \n>> -\n>> -#define MAX_LEVEL 3\n>> +#include \n>>     struct khadas_mcu_fan_ctx {\n>>       struct khadas_mcu *mcu;\n>> +    unsigned int fan_reg;\n>>       unsigned int level;\n>> +    unsigned int max_level;\n>>       struct thermal_cooling_device *cdev;\n>> +    struct regulator *power;\n>>   };\n>>     static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n>> @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct\n>> khadas_mcu_fan_ctx *ctx,\n>>   {\n>>       int ret;\n>>   -    ret = regmap_write(ctx->mcu->regmap,\n>> KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n>> -               level);\n>> +    ret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n>>       if (ret)\n>>           return ret;\n>>   @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct\n>> khadas_mcu_fan_ctx *ctx,\n>>   static int khadas_mcu_fan_get_max_state(struct\n>> thermal_cooling_device *cdev,\n>>                       unsigned long *state)\n>>   {\n>> -    *state = MAX_LEVEL;\n>> +    struct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n>> +\n>> +    *state = ctx->max_level;\n>>         return 0;\n>>   }\n>> @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct\n>> thermal_cooling_device *cdev,\n>>   {\n>>       struct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n>>   -    if (state > MAX_LEVEL)\n>> +    if (state > ctx->max_level)\n>>           return -EINVAL;\n>>         if (state == ctx->level)\n>> @@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct\n>> platform_device *pdev)\n>>       struct device *dev = &pdev->dev;\n>>       struct khadas_mcu_fan_ctx *ctx;\n>>       int ret;\n>> +    const struct khadas_mcu_fan_pdata *pdata =\n>> dev_get_platdata(&pdev->dev);\n>>         ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n>>       if (!ctx)\n>>           return -ENOMEM;\n>> +\n>>       ctx->mcu = mcu;\n>> +    ctx->fan_reg   = pdata->fan_reg;\n>> +    ctx->max_level = pdata->max_level;\n>> +\n>> +    ctx->power = devm_regulator_get_optional(dev->parent, \"fan\");\n>> +    if (IS_ERR(ctx->power)) {\n>> +        if (PTR_ERR(ctx->power) == -ENODEV)\n>> +            ctx->power = NULL;\n>> +        else\n>> +            return PTR_ERR(ctx->power);\n>> +    }\n>> +\n>> +    if (ctx->power) {\n>> +        ret = regulator_enable(ctx->power);\n>> +        if (ret) {\n>> +            dev_err(dev, \"Failed to enable fan power supply: %d\\n\",\n>> ret);\n>> +            return ret;\n>> +        }\n>> +    }\n>> +\n>>       platform_set_drvdata(pdev, ctx);\n>>         cdev = devm_thermal_of_cooling_device_register(dev->parent,\n>> @@ -130,6 +154,13 @@ static int khadas_mcu_fan_suspend(struct device\n>> *dev)\n>>   static int khadas_mcu_fan_resume(struct device *dev)\n>>   {\n>>       struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n>> +    int ret;\n>> +\n>> +    if (ctx->power) {\n>> +        ret = regulator_enable(ctx->power);\n> \n> Seems you're missing a regulator_disable() on suspend.\n> \n> Neil\n> \n\nYou right, I will add the regulator_disable on suspend for next version.\nThanks for your feedback.\n\n>> +        if (ret)\n>> +            return ret;\n>> +    }\n>>         return khadas_mcu_fan_set_level(ctx, ctx->level);\n>>   }\n>>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=aliel.fr header.i=@aliel.fr header.a=rsa-sha256\n header.s=courrier-s1 header.b=TyDduWOp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16943-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=\"TyDduWOp\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=65.21.61.41","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=aliel.fr"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmpPC37Drz1yGH\n\tfor ; Fri, 03 Apr 2026 04:14:23 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 623D7304C463\n\tfor ; Thu, 2 Apr 2026 17:01:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DA1D43CFF70;\n\tThu, 2 Apr 2026 17:01:18 +0000 (UTC)","from courrier.aliel.fr (courrier.aliel.fr [65.21.61.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CCB913FEE;\n\tThu, 2 Apr 2026 17:01:01 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775149271; cv=none;\n b=IslpCJwrEvxZ3/Fhh+nXg11TFjS2/8tuffwNwxPtmhOIrHftuw4252YChOEZVZUp8lTYB3sQ4ZRc8DkV8mBpynYlxhnzjphggzz6vHYEce77to7OmS9I788HRvQ/pbhVn8IKFvaMzDo7nFcVaoQte1fMoTZV7BUmykniCRLJ7YA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775149271; c=relaxed/simple;\n\tbh=2OWqMG9cAvyIiZhUJJh6c3apSC/Ro+i93PaoDjc2ohY=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=TKVkkptBl7UoziHuALmVE7O/18gqh2LaTi7FRbUA/hLWgUqaidMshL48VB2rKkbgx0Rz13lolK+4t1V1zpHbjTcsFKGE72m4D1dF5wgfF8t4PoQiKoeoFeihMR2SAxgKfB4QEkK3WQlElVHTJdW4hqbAUzYU/pmGQw+r4B6Szcg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr;\n spf=pass smtp.mailfrom=aliel.fr;\n dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=TyDduWOp; arc=none smtp.client-ip=65.21.61.41","Message-ID":"","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr;\n\ts=courrier-s1; t=1775149257;\n\tbh=2OWqMG9cAvyIiZhUJJh6c3apSC/Ro+i93PaoDjc2ohY=;\n\th=Date:From:Subject:To:Cc:References:In-Reply-To;\n\tb=TyDduWOpNvxQeMWOJLRKd7O4x57VGwm/FtjFB4aCLFl7jth9inkleHxhtz7dfmZpO\n\t ainHsiv56YhFZcMxmPC6M0wdfV/f5bNz9T4fDyPLaFgxbBcKiYU+Tt4hIw74Jodnmh\n\t wBAzw0LIaUuYcMk2fb2yJxzZTEAN/qFAlVGgh+tQ=","Date":"Thu, 2 Apr 2026 19:00:55 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird Beta","From":"Ronald Claveau ","Subject":"Re: [PATCH 5/8] thermal: khadas-mcu-fan: Add fan config from platform\n data Add regulator support","To":"Neil Armstrong , Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260402-add-mcu-fan-khadas-vim4-v1-0-2b12eb4ac7b0@aliel.fr>\n <20260402-add-mcu-fan-khadas-vim4-v1-5-2b12eb4ac7b0@aliel.fr>\n <5e3e8684-f893-4fb0-879e-9661820f72dd@linaro.org>","Content-Language":"en-US","In-Reply-To":"<5e3e8684-f893-4fb0-879e-9661820f72dd@linaro.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"}}]