[{"id":3672911,"web_url":"http://patchwork.ozlabs.org/comment/3672911/","msgid":"<20260402213403.GC225068@pevik>","list_archive_url":null,"date":"2026-04-02T21:34:03","subject":"Re: [LTP] [PATCH 17/17] doc: metadata: Remove needs_drivers from\n docs","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>\n> ---\n>  doc/developers/writing_tests.rst |  3 ---\n>  doc/old/C-Test-API.asciidoc      | 13 ++++++-------\n>  metadata/README.md               | 15 ++++++---------\n>  3 files changed, 12 insertions(+), 19 deletions(-)\n\n> diff --git a/doc/developers/writing_tests.rst b/doc/developers/writing_tests.rst\n> index 992374f8b..5b1516ba5 100644\n> --- a/doc/developers/writing_tests.rst\n> +++ b/doc/developers/writing_tests.rst\n> @@ -435,9 +435,6 @@ LTP C And Shell Test API Comparison\n>      * - .needs_device\n>        - TST_NEEDS_DEVICE\n\n> -    * - .needs_drivers\n> -      - TST_NEEDS_DRIVERS\n> -\nNOTE: this is the old comparison for tst_test.sh, it should be change:\n\n -    * - not applicable\n -      - TST_NEEDS_DRIVERS\n\n>      * - .needs_kconfigs\n>        - TST_NEEDS_KCONFIGS\n\n> diff --git a/doc/old/C-Test-API.asciidoc b/doc/old/C-Test-API.asciidoc\n> index 72fd2731d..7493fc578 100644\n> --- a/doc/old/C-Test-API.asciidoc\n> +++ b/doc/old/C-Test-API.asciidoc\n> @@ -1621,13 +1621,12 @@ test should include 'tst_checksum.h' header, then can call 'tst_crc32c()'.\n>  1.26 Checking kernel for the driver support\n>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n> -Some tests may need specific kernel drivers, either compiled in, or built\n> -as a module. If '.needs_drivers' points to a 'NULL' terminated array of kernel\n> -module names these are all checked and the test exits with 'TCONF' on the\n> -first missing driver.\n> -\n> -The detection is based on reading 'modules.dep' and 'modules.builtin' files\n> -generated by kmod. The check is skipped on Android.\n> +Some tests may need specific kernel drivers, either compiled in, or built as a\n> +module. For this cases a mappping of kernel config options to modules is\n> +maintained in the kconfig checker. When a kernel config option is requested by\nPlease amend before merge to use formatting:\n``modules.dep``\n\n> +a test that has associated mapping in the kconfig source the 'modules.dep' file\n> +is checked for module presence when the option is set to 'm'. The check is\n... set to ``m``.\n> +skipped on Android.\n\nThe rest LGTM.\nReviewed-by: Petr Vorel <pvorel@suse.cz>\n\nKind regards,\nPetr","headers":{"Return-Path":"<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=koiWxzo4;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=cEHU2srg;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=koiWxzo4;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=cEHU2srg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmw944lfFz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 08:34:16 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 737083E4E93\n\tfor <incoming@patchwork.ozlabs.org>; Thu,  2 Apr 2026 23:34:14 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id EA2C93E14A5\n for <ltp@lists.linux.it>; Thu,  2 Apr 2026 23:34:10 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 4C8202002AF\n for <ltp@lists.linux.it>; Thu,  2 Apr 2026 23:34:10 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 9E0CC5BD74;\n Thu,  2 Apr 2026 21:34:09 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 701514A0B0;\n Thu,  2 Apr 2026 21:34:09 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id fKoNGNHgzmnoQQAAD6G6ig\n (envelope-from <pvorel@suse.cz>); Thu, 02 Apr 2026 21:34:09 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775165649;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uLuP+mPuOk9F3U+CgCH1xex2Sx9hSJ7VZoPjwcWAGF4=;\n b=koiWxzo4Feqa/K+IunA20Z0dc94OP0Xy2zIQQPCTm8BFHE2xKaiKsTHeRnXPgAzp+6c4x9\n 1m5aSDMd2Q9k3cOXIvVjLL+cb+f3ckIWmVDSmOkopDQaZC+neaKfoSNv3ioKviarw3HOs9\n 70+vK+mtiQxjrr5VM2VPqeyrRhjqLnE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775165649;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uLuP+mPuOk9F3U+CgCH1xex2Sx9hSJ7VZoPjwcWAGF4=;\n b=cEHU2srgvBbx3Y+t/9pOxtzmw8ucXdq6qT8Nz9OBnM0Bz6SXSdoKNzrXv7zBUzkHwkntXP\n m936bfKgzrBJKYCg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775165649;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uLuP+mPuOk9F3U+CgCH1xex2Sx9hSJ7VZoPjwcWAGF4=;\n b=koiWxzo4Feqa/K+IunA20Z0dc94OP0Xy2zIQQPCTm8BFHE2xKaiKsTHeRnXPgAzp+6c4x9\n 1m5aSDMd2Q9k3cOXIvVjLL+cb+f3ckIWmVDSmOkopDQaZC+neaKfoSNv3ioKviarw3HOs9\n 70+vK+mtiQxjrr5VM2VPqeyrRhjqLnE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775165649;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uLuP+mPuOk9F3U+CgCH1xex2Sx9hSJ7VZoPjwcWAGF4=;\n b=cEHU2srgvBbx3Y+t/9pOxtzmw8ucXdq6qT8Nz9OBnM0Bz6SXSdoKNzrXv7zBUzkHwkntXP\n m936bfKgzrBJKYCg=="],"Date":"Thu, 2 Apr 2026 23:34:03 +0200","From":"Petr Vorel <pvorel@suse.cz>","To":"Cyril Hrubis <chrubis@suse.cz>","Message-ID":"<20260402213403.GC225068@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-18-chrubis@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260402121356.31266-18-chrubis@suse.cz>","X-Spam-Score":"-7.50","X-Spam-Level":"","X-Spamd-Result":"default: False [-7.50 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,suse.cz:email];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 17/17] doc: metadata: Remove needs_drivers from\n docs","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project <ltp.lists.linux.it>","List-Unsubscribe":"<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>","List-Archive":"<http://lists.linux.it/pipermail/ltp/>","List-Post":"<mailto:ltp@lists.linux.it>","List-Help":"<mailto:ltp-request@lists.linux.it?subject=help>","List-Subscribe":"<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>","Reply-To":"Petr Vorel <pvorel@suse.cz>","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>"}}]