[{"id":3672967,"web_url":"http://patchwork.ozlabs.org/comment/3672967/","msgid":"","list_archive_url":null,"date":"2026-04-03T03:01:17","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":73704,"url":"http://patchwork.ozlabs.org/api/people/73704/","name":"Li Wang","email":"liwang@redhat.com"},"content":"> --- a/include/tst_test.h\n> +++ b/include/tst_test.h\n> @@ -498,10 +498,6 @@ struct tst_fs {\n> * to the test temporary directory from the LTP datafiles\n> * directory.\n> *\n> - * @needs_drivers: A NULL terminated array of kernel modules required to run\n> - * the test. The module has to be build in or present in order\n> - * for the test to run.\n> - *\n> * @save_restore: A {} terminated array of /proc or /sys files that should\n> * saved at the start of the test and restored at the end. See\n> * tst_sys_conf_save() and :ref:`struct tst_path_val` for details.\n\nAs we add runtime_check and module_check, I think we also need to update\nthe descrition comments of @needs_kconfigs in tst_test.h.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=bGBfLBAG;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OeIo2P8/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn3Qz4JGhz1xtJ\n\tfor ; Fri, 03 Apr 2026 14:01:47 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id E4FF23E237A\n\tfor ; Fri, 3 Apr 2026 05:01:37 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 070F93E237A\n for ; Fri, 3 Apr 2026 05:01:33 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 74EBA14010E5\n for ; Fri, 3 Apr 2026 05:01:32 +0200 (CEST)","from mail-dl1-f71.google.com (mail-dl1-f71.google.com\n [74.125.82.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-669-uRbcoC5uPDyXYwVgINdH3g-1; Thu, 02 Apr 2026 23:01:30 -0400","by mail-dl1-f71.google.com with SMTP id\n a92af1059eb24-12bf921cf49so1005929c88.1\n for ; Thu, 02 Apr 2026 20:01:30 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1775185297; h=mime-version :\n references : in-reply-to : date : message-id : to : subject : list-id\n : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=lWWeYWHm8V1y12U0/xbJ/PjyUxvx9eiYTgFCz/xyUa8=;\n b=bGBfLBAGzinGZHzbB893+vCMMWpcWcZlX53skLjSnbCacqEIB3zR/VF/sdg7zib1rS7Fg\n wHl2f8woiT1GIigi0v5SJD0djWMhnldye7jiV9u7mY4p/IKeg0+IOjA8Pk2rd4wv2T4Fz8B\n 4nYM6xeSdj3WMVzfWxc2I/A+yLkRtx8=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775185291;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=xYNwC/jtP/Vhe0pHcs88OVxZuecMT6a8nRcOb2aNUdA=;\n b=OeIo2P8/P17Gz7k/Wa2DmBC8KJAsJkebbKgh9FmJzVeQcYM7P0mTbHidEKJjhP/xB5ga1s\n ZmPCc2i1WZ1Vbp9s2NcpmjVtpzO5JgjwLLDq9yyZs4bRGbNem6gk/aV//s6ri8Og0XmknG\n RqoCs2dq8UTVhpIud5cmUqvk3JXOqbw="],"X-MC-Unique":"uRbcoC5uPDyXYwVgINdH3g-1","X-Mimecast-MFC-AGG-ID":"uRbcoC5uPDyXYwVgINdH3g_1775185289","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775185289; x=1775790089;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xYNwC/jtP/Vhe0pHcs88OVxZuecMT6a8nRcOb2aNUdA=;\n b=QALq8xluil2QtKkpYF4NrLonwmVMKAxlxPBN106H96w82jyg2t6ZoEF/9JfgTEh2iR\n S4zgrEHQdUY7LQM/VhXsgNDM/gihsQxV5PuB/NlAQJhTJOq++ytXzDR/2F2LMg5UVICd\n /Sh/pURMlW0a5d7jtp3Ns4yZTUbEFKXcwDkd+5wGJRYGI6ibrNY8eNDct0QaqPukVy9t\n ZAWv1OaZWLyALgymBuMYz57Mp49Q9wGqicAp4y+T37EU4KVxCAU2tteoi8BMVU9JLboK\n 6xj+KVJcj6wPM2qg674FBmoJnDlZcPEBluH8pMqgL13D+TkUQDqm05/o3lF/qm90QHFl\n jy+Q==","X-Gm-Message-State":"AOJu0Yz23gJdy0xjNFRRmx+X5sXM/A/ZX5kNASpQIxhtdY7VR+t0zjpY\n zio242a+d1fylJ8DSDZcvLs2ELTG+jbnUOwqHpYsOl+QsOdavgPB8LVBVfRWVd7s5X1OtpOmDay\n PJkIch5abRw6jRCKLlbLl8hwtb3afApsqnTIEC+Q17d6sGM1qBK/mJh6X2Hj6gR5pin1nWaSRSq\n lBrccBH8mP2IYqgoZSpbI3g8LV0wA=","X-Gm-Gg":"ATEYQzwnlIwSH7H+l4y2Fdf+6OPQuwaYXxPR3odxqCmP1bEWR8xlKT0sCaDMJJ5HJ8y\n BIahjy4TDBociT8yGyU/Y7MpkHUJzt8R8MfxIDvqQocnc7RmwNa3yi/B8RXencr7jWu+xqkbw5c\n JtznMNpqBUQcKyG7eEJZeHf6g/qW39lC5K3tuG+1uCpfGBRN88ml+VZCKD5/LXzSU1IBit8An0/\n Ng4/Ro=","X-Received":["by 2002:a05:7022:1005:b0:12a:6a64:81ef with SMTP id\n a92af1059eb24-12bfb6f3d90mr798980c88.9.1775185289407;\n Thu, 02 Apr 2026 20:01:29 -0700 (PDT)","by 2002:a05:7022:1005:b0:12a:6a64:81ef with SMTP id\n a92af1059eb24-12bfb6f3d90mr798964c88.9.1775185288848; Thu, 02 Apr 2026\n 20:01:28 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>","In-Reply-To":"<20260402121356.31266-17-chrubis@suse.cz>","Date":"Fri, 3 Apr 2026 11:01:17 +0800","X-Gm-Features":"AQROBzBDSuEBTFs_NFRHNlGK-jUMTvajdILf8AnB8m5BUNLB0MpqHxhJHzy2kpU","Message-ID":"\n ","To":"Cyril Hrubis ","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"RC_WaGQkJSYJeTuwfl6Zhh3yAvS1w-M6LxhR_JVYbUA_1775185289","X-Mimecast-Originator":"redhat.com","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Wang via ltp ","Reply-To":"Li Wang ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674051,"web_url":"http://patchwork.ozlabs.org/comment/3674051/","msgid":"","list_archive_url":null,"date":"2026-04-07T10:02:06","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> > --- a/include/tst_test.h\n> > +++ b/include/tst_test.h\n> > @@ -498,10 +498,6 @@ struct tst_fs {\n> > * to the test temporary directory from the LTP datafiles\n> > * directory.\n> > *\n> > - * @needs_drivers: A NULL terminated array of kernel modules required to run\n> > - * the test. The module has to be build in or present in order\n> > - * for the test to run.\n> > - *\n> > * @save_restore: A {} terminated array of /proc or /sys files that should\n> > * saved at the start of the test and restored at the end. See\n> > * tst_sys_conf_save() and :ref:`struct tst_path_val` for details.\n> \n> As we add runtime_check and module_check, I think we also need to update\n> the descrition comments of @needs_kconfigs in tst_test.h.\n\n\nWhat about something like this:\n\ndiff --git a/include/tst_test.h b/include/tst_test.h\nindex 752688c45..f2a5378cd 100644\n--- a/include/tst_test.h\n+++ b/include/tst_test.h\n@@ -511,6 +511,13 @@ struct tst_fs {\n * and parenthesis are supported, e.g.\n * \"CONFIG_X86_INTEL_UMIP=y | CONFIG_X86_UIMP=y\" is evaluated\n * to true if at least one of the options is present.\n+ * For some config options their presence in the config file\n+ * is not enough to assure the functionality is present or\n+ * enabled. E.g. config option may be set to 'm' but the\n+ * module may not be installed or functionality may be\n+ * disabled on the kernel command line. The kconfig library\n+ * has a set of additonal checks for a few config options that\n+ * are used in the tests and need additional checks.\n *\n * @bufs: A description of guarded buffers to be allocated for the test. Guarded\n * buffers are buffers with poisoned page allocated right before the start","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=T4Oz6gpN;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=ip5eL/Tc;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=G6ntDtar;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=DNnFoX6+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=G6ntDtar;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DNnFoX6+"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqhZ949lQz1yD3\n\tfor ; Tue, 07 Apr 2026 20:02:09 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id ADFBF3E26B1\n\tfor ; Tue, 7 Apr 2026 12:02:06 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id AA0843C65BB\n for ; Tue, 7 Apr 2026 12:02:02 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 2072260004C\n for ; Tue, 7 Apr 2026 12:02:01 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id ED05E4E3C8;\n Tue, 7 Apr 2026 10:01:59 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DC4354A0B0;\n Tue, 7 Apr 2026 10:01:59 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id DIMaNBfW1GklfQAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 10:01:59 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775556121;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VvlEiSv2pnyuNUYuUUQkfcO7KQUpfPQxWd7UW2J/3GA=;\n b=T4Oz6gpNbPycADhbuMkMykzyaVI2oAbzoo4iCs2qVyzewzQgJqeL54o+tvx2RvNtKKmPUD\n lsXXgIbVa/k3waUA2tBX3FqLZJtVXxW3KX/fRpwhtfWy0Kg+rwjbg28aZ8AiVQqb9qARQp\n czKAfqH7gEElSQ80lfnSqhSFDbcwRKY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775556121;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VvlEiSv2pnyuNUYuUUQkfcO7KQUpfPQxWd7UW2J/3GA=;\n b=ip5eL/TcJIsSnjNKUmtF+w6L8x2CBNw3lrxGyVGJB9xKzswFlDu9HD85FvDh65LO2OzUJK\n FFFeIXNlKi76oeBw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775556119;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VvlEiSv2pnyuNUYuUUQkfcO7KQUpfPQxWd7UW2J/3GA=;\n b=G6ntDtareRQzY2N4Z9lwC1OIJ78b4pFv97L7WzHGb1MWApDMnemZRsqoiVXCaWrMcD1d56\n QFviqsjGimefkAT2YkrYv8biBCyS0+WXqdfiQvhpKrE3qI/1bnV35fMWNAEOkhFzSQl0wp\n a+qhWJhIZpBeCLXIMBU5prItupyu5V8=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775556119;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VvlEiSv2pnyuNUYuUUQkfcO7KQUpfPQxWd7UW2J/3GA=;\n b=DNnFoX6+05KDZZ2+OmA43ZZhrZrvBkBNuZid6i/B9WVKS0bdy/g9905Q2TVfEdwjNju/aq\n ohvC2NKe5w/6krBQ=="],"Date":"Tue, 7 Apr 2026 12:02:06 +0200","From":"Cyril Hrubis ","To":"Li Wang ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>\n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"\n ","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_SOME(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:email];\n URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:email,yuki.lan:mid];\n DKIM_TRACE(0.00)[suse.cz:+]","X-Rspamd-Queue-Id":"ED05E4E3C8","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674112,"web_url":"http://patchwork.ozlabs.org/comment/3674112/","msgid":"","list_archive_url":null,"date":"2026-04-07T11:39:19","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":73704,"url":"http://patchwork.ozlabs.org/api/people/73704/","name":"Li Wang","email":"liwang@redhat.com"},"content":"Overall it's good, just minor polishing below:\n\n> --- a/include/tst_test.h\n> +++ b/include/tst_test.h\n> @@ -511,6 +511,13 @@ struct tst_fs {\n> * and parenthesis are supported, e.g.\n> * \"CONFIG_X86_INTEL_UMIP=y | CONFIG_X86_UIMP=y\" is evaluated\n> * to true if at least one of the options is present.\n\n> + * For some config options their presence in the config file\n> + * is not enough to assure the functionality is present or\n\n Merely finding a config option in the config file does not\n guarantee that the corresponding functionality is available.\n\n> + * enabled. E.g. config option may be set to 'm' but the\n> + * module may not be installed or functionality may be\n> + * disabled on the kernel command line. The kconfig library\n\n For instance, an option might be set to 'm' without the\n module being installed, or the feature could be disabled via\n the kernel command line.\n\n> + * has a set of additonal checks for a few config options that\n> + * are used in the tests and need additional checks.\n\n To address this, the kconfig library implements supplementary\n runtime checks for specific options required by the tests.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=J1V3XnHv;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QMdHC+DZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqkkc3vY1z1xy1\n\tfor ; Tue, 07 Apr 2026 21:39:36 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 300213E29A9\n\tfor ; Tue, 7 Apr 2026 13:39:34 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 962DE3C1987\n for ; Tue, 7 Apr 2026 13:39:28 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 43635200777\n for ; Tue, 7 Apr 2026 13:39:27 +0200 (CEST)","from mail-pf1-f200.google.com (mail-pf1-f200.google.com\n [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-82-edJHnnZGMj6Xr29jXUf9mQ-1; Tue, 07 Apr 2026 07:39:25 -0400","by mail-pf1-f200.google.com with SMTP id\n d2e1a72fcca58-82c714cb672so2566425b3a.0\n for ; Tue, 07 Apr 2026 04:39:24 -0700 (PDT)","from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9b3dcb3sm16897144b3a.16.2026.04.07.04.39.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 04:39:22 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1775561974; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=fnglgVBsBcoYBmYBfJCM3OKzGnmEkKGY8Ehz6Y3m4fg=;\n b=J1V3XnHvmPDXnrXHLJPmrCfEcU0T0IIsc6TGrtO759dP5wZs7Mz8MTiunieIyK8PaXfNg\n PCzH+H1RApuBuu9nYQ3SbhPm//yBdQd3kTb+RdiyMt3N5SRaJ4RRuWZIUjcbpB8WVMxO9NX\n KZfTKkDTaBZjMYrYOw8EDMd8pXL5D3w=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775561966;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uqGgVUekWYuNLVyfofKvJj/ZNO66HbIsCRhFREdbPIA=;\n b=QMdHC+DZQ/zsNmQ+URBxU236theMZX5BeNVoeaN8hG/Zl4ef83q2n8fVVPpdyGVWBZjWpm\n e/ijHoE5fIYJcmkn75uX5ObY+b6Yk4ByuuMafrhsKQZloQfq7zAoDNL2zisOw0EIywaENI\n nMeHjIFdTqeq5rwiBImFcTNuoCE73vA="],"X-MC-Unique":"edJHnnZGMj6Xr29jXUf9mQ-1","X-Mimecast-MFC-AGG-ID":"edJHnnZGMj6Xr29jXUf9mQ_1775561964","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775561964; x=1776166764;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uqGgVUekWYuNLVyfofKvJj/ZNO66HbIsCRhFREdbPIA=;\n b=Jz5QizedzWOtwgV2nH77ArMA/75PJizwWyMRYdoXjR6dbsFTfDOQCn3JAsSF+1cDFl\n TlYkvH6Z0hLoEOJlMsi5thLWUzUtuLGRLK4NU9qNCszLxkDwpymzC8zd+MmKiGYKTq2X\n Jut8j2rsXdSAjDXthZRO9wqQchJxCYDA315kioJIEtzps2K0djfYsDi/fNuMAhgRHEDj\n BPWVgV87ZQ7zSI27X7Ak84Qi7W1KYTfTEQK+eSpYBSAzrAo3JgOvXDMCxNaZbwe0pDsK\n kR1PviB8zcLZuVoSNFVFBrSptdNjjse92K9XW7HcsGqj8h8oUPKsA5aItPAcsemx09YN\n Z9uA==","X-Gm-Message-State":"AOJu0YxSoL1RLT8YnGfiW/M+Mgu6KULt9ZFz/1ETJjtykavWIEPCSiCe\n U2YNyNqsk3dNSdCAP87y64WvukqAH9is6szYQLy4Oc3nzkKdBMsVGVBsfyVCpaAS1GTAb+srTe1\n 5BkUSXI5TD6/RYMEO0Hpihd97VoZaPAhsImzttopZsHcYwE/Nft7H","X-Gm-Gg":"AeBDievuxl5Qe63EKgG0r25Y1uyDnL2K8iGYoJe6pfi6T5u3x0TIQEKSYNtR8VPxNNM\n Q4iQJfAcZjC2OlC0xfUVCb1pJxL+45hA1YM49jH7b0wikYQY0eBiQm2AK2qmJ0dBiFI03dpj5Km\n dgn0fm56aKhjnmubpQF0IzhBgOzQWUeVqVKMOuk+3qyrlxNHX/VkHXj21KLP2+IGm3JcTjm6X29\n siqAhgBQ8v/DHE+9xliARiJbZZ29g4v8l4JK3yoqJiYV2iCpM4W3SlePRfoI8Hdt/ywy53GSUM9\n hUawHI62QQyEl1x1jcYNnKbn2INubHLngJLQV/cN7C8Z8zjP9bw4LGa1wdTgAHJKGfGUOH738m1\n owlMjNi5NS9HTknLNKw==","X-Received":["by 2002:a05:6a00:808:b0:824:b181:f492 with SMTP id\n d2e1a72fcca58-82d0dbb0808mr15332594b3a.45.1775561963950;\n Tue, 07 Apr 2026 04:39:23 -0700 (PDT)","by 2002:a05:6a00:808:b0:824:b181:f492 with SMTP id\n d2e1a72fcca58-82d0dbb0808mr15332582b3a.45.1775561963462;\n Tue, 07 Apr 2026 04:39:23 -0700 (PDT)"],"Date":"Tue, 7 Apr 2026 19:39:19 +0800","To":"Cyril Hrubis ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>\n \n ","MIME-Version":"1.0","In-Reply-To":"","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"n-LEbVc8gfQmXCkCwDJAUFbpZptTXeJGnc8upz5xxcg_1775561964","X-Mimecast-Originator":"redhat.com","Content-Disposition":"inline","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Wang via ltp ","Reply-To":"Li Wang ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674113,"web_url":"http://patchwork.ozlabs.org/comment/3674113/","msgid":"","list_archive_url":null,"date":"2026-04-07T11:40:44","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> > --- a/include/tst_test.h\n> > +++ b/include/tst_test.h\n> > @@ -511,6 +511,13 @@ struct tst_fs {\n> > * and parenthesis are supported, e.g.\n> > * \"CONFIG_X86_INTEL_UMIP=y | CONFIG_X86_UIMP=y\" is evaluated\n> > * to true if at least one of the options is present.\n> \n> > + * For some config options their presence in the config file\n> > + * is not enough to assure the functionality is present or\n> \n> Merely finding a config option in the config file does not\n> guarantee that the corresponding functionality is available.\n> \n> > + * enabled. E.g. config option may be set to 'm' but the\n> > + * module may not be installed or functionality may be\n> > + * disabled on the kernel command line. The kconfig library\n> \n> For instance, an option might be set to 'm' without the\n> module being installed, or the feature could be disabled via\n> the kernel command line.\n> \n> > + * has a set of additonal checks for a few config options that\n> > + * are used in the tests and need additional checks.\n> \n> To address this, the kconfig library implements supplementary\n> runtime checks for specific options required by the tests.\n\nThanks, will use that version for the final patchset.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=0oBYJWV8;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=KxUtjfX6;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=0oBYJWV8;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=KxUtjfX6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqklx0nV8z1xtJ\n\tfor ; Tue, 07 Apr 2026 21:40:45 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 0B77E3E26AF\n\tfor ; Tue, 7 Apr 2026 13:40:43 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id B1E883C1987\n for ; Tue, 7 Apr 2026 13:40:39 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 0E58110007C5\n for ; Tue, 7 Apr 2026 13:40:38 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id AD0AD4E426;\n Tue, 7 Apr 2026 11:40:37 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 98CF74A0B0;\n Tue, 7 Apr 2026 11:40:37 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id odoxJDXt1GkqYwAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 11:40:37 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775562037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=T2EXT/xMwsKCh8vdLTVgEWJJYLoGJBHBM8i2MzsLs3o=;\n b=0oBYJWV8xz75Y8YgF6EhyB8vV51w37RgH5DQkpdFEPqfaRHX4e5LOGB8zqe7A5Ec2XK5gK\n 9xfO2ds08Hz1GXJMKubc9p25ZgYdBZ3xJWvo7SXKZV9B5Huagt81U8kvsA2qF1lAAfWvJ0\n S7NBZnF1pwHbniYD6uioEcyJ+/p2LAs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775562037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=T2EXT/xMwsKCh8vdLTVgEWJJYLoGJBHBM8i2MzsLs3o=;\n b=KxUtjfX6xH3adnnPEb2Je7L61uylvrFkD7s6w0qHIudN5xkCpLQWR8QxRcPYd3ISZop+gs\n 7SLXyYZ5Il3gYrDg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775562037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=T2EXT/xMwsKCh8vdLTVgEWJJYLoGJBHBM8i2MzsLs3o=;\n b=0oBYJWV8xz75Y8YgF6EhyB8vV51w37RgH5DQkpdFEPqfaRHX4e5LOGB8zqe7A5Ec2XK5gK\n 9xfO2ds08Hz1GXJMKubc9p25ZgYdBZ3xJWvo7SXKZV9B5Huagt81U8kvsA2qF1lAAfWvJ0\n S7NBZnF1pwHbniYD6uioEcyJ+/p2LAs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775562037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=T2EXT/xMwsKCh8vdLTVgEWJJYLoGJBHBM8i2MzsLs3o=;\n b=KxUtjfX6xH3adnnPEb2Je7L61uylvrFkD7s6w0qHIudN5xkCpLQWR8QxRcPYd3ISZop+gs\n 7SLXyYZ5Il3gYrDg=="],"Date":"Tue, 7 Apr 2026 13:40:44 +0200","From":"Cyril Hrubis ","To":"Li Wang ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>\n \n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Spam-Score":"-4.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2];\n RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[yuki.lan:mid, imap1.dmz-prg2.suse.org:helo,\n suse.cz:email]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679833,"web_url":"http://patchwork.ozlabs.org/comment/3679833/","msgid":"<20260421114738.GM506589@pevik>","list_archive_url":null,"date":"2026-04-21T11:47:38","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Cyril, Li,\n\n> Hi!\n> > > --- a/include/tst_test.h\n> > > +++ b/include/tst_test.h\n> > > @@ -498,10 +498,6 @@ struct tst_fs {\n> > > * to the test temporary directory from the LTP datafiles\n> > > * directory.\n> > > *\n> > > - * @needs_drivers: A NULL terminated array of kernel modules required to run\n> > > - * the test. The module has to be build in or present in order\n> > > - * for the test to run.\n> > > - *\n> > > * @save_restore: A {} terminated array of /proc or /sys files that should\n> > > * saved at the start of the test and restored at the end. See\n> > > * tst_sys_conf_save() and :ref:`struct tst_path_val` for details.\n\n> > As we add runtime_check and module_check, I think we also need to update\n> > the descrition comments of @needs_kconfigs in tst_test.h.\n\n\n> What about something like this:\n\n> diff --git a/include/tst_test.h b/include/tst_test.h\n> index 752688c45..f2a5378cd 100644\n> --- a/include/tst_test.h\n> +++ b/include/tst_test.h\n> @@ -511,6 +511,13 @@ struct tst_fs {\n> * and parenthesis are supported, e.g.\n> * \"CONFIG_X86_INTEL_UMIP=y | CONFIG_X86_UIMP=y\" is evaluated\n> * to true if at least one of the options is present.\n> + * For some config options their presence in the config file\n> + * is not enough to assure the functionality is present or\n> + * enabled. E.g. config option may be set to 'm' but the\n> + * module may not be installed or functionality may be\n> + * disabled on the kernel command line. The kconfig library\n> + * has a set of additonal checks for a few config options that\n\ns/additonal/additional/\n\n> + * are used in the tests and need additional checks.\n\n(Please consider configuring spell checker in your editor setup, or run make\ncheck as I enabled in our checkpatch.pl configuration check for typos.)\n\nAI would reword it, feel free to use some parts or ignore:\n\n\tFor some config options their presence in the config file is not enough to assure the functionality is present or enabled.\n\tE.g. config option may be set to 'm' but the module may not be installed or functionality may be disabled on the kernel command line.\n\n\tThe kconfig library has a set of additional checks for a few config options that are used in the tests and need additional checks.\n\tPlease rebase before adding the text (I fixed typo in include/tst_test.h).\n\nThe removal is obviously ok.\nReviewed-by: Petr Vorel \n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=mvsY5yh0;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=1rz32wqs;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=mvsY5yh0;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=1rz32wqs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mvsY5yh0;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1rz32wqs"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0LFj3DD4z1yGt\n\tfor ; Tue, 21 Apr 2026 21:47:51 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 435DA3E2D92\n\tfor ; Tue, 21 Apr 2026 13:47:49 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 41B443C5376\n for ; Tue, 21 Apr 2026 13:47:46 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 4D490140076E\n for ; Tue, 21 Apr 2026 13:47:44 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 946846A7F4;\n Tue, 21 Apr 2026 11:47:43 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A004593AF;\n Tue, 21 Apr 2026 11:47:43 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id urB0HN9j52lQKgAAD6G6ig\n (envelope-from ); Tue, 21 Apr 2026 11:47:43 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776772063;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=s6hmpgNQnkyO+pi2rH3TSTkqX7G/wDqVCxX7z3qtxiU=;\n b=mvsY5yh0hhad4DQoYVSEi4ytkT/iFOwF9KC8zF7eu3jAA9yKz2YXhzz236PvskSK/jxDvW\n f03tMKcLtH0thImO4wwoZP/iVeU/AH9qTKW4hKha8s7G8+lBU+NP8t4kr6C3gBttWdVCQG\n evADtfCIxWyYN4zROa9F1wAoj/0SA0s=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776772063;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=s6hmpgNQnkyO+pi2rH3TSTkqX7G/wDqVCxX7z3qtxiU=;\n b=1rz32wqs+4v463E90/cwEXAolGyLiW9ruv0utt+Dw8UiLdVIHhG1e1bFgijiJZOXxpPelS\n Q3IyO+1mGmjnwlDQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776772063;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=s6hmpgNQnkyO+pi2rH3TSTkqX7G/wDqVCxX7z3qtxiU=;\n b=mvsY5yh0hhad4DQoYVSEi4ytkT/iFOwF9KC8zF7eu3jAA9yKz2YXhzz236PvskSK/jxDvW\n f03tMKcLtH0thImO4wwoZP/iVeU/AH9qTKW4hKha8s7G8+lBU+NP8t4kr6C3gBttWdVCQG\n evADtfCIxWyYN4zROa9F1wAoj/0SA0s=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776772063;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=s6hmpgNQnkyO+pi2rH3TSTkqX7G/wDqVCxX7z3qtxiU=;\n b=1rz32wqs+4v463E90/cwEXAolGyLiW9ruv0utt+Dw8UiLdVIHhG1e1bFgijiJZOXxpPelS\n Q3IyO+1mGmjnwlDQ=="],"Date":"Tue, 21 Apr 2026 13:47:38 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260421114738.GM506589@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>\n \n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[];\n HAS_REPLYTO(0.30)[pvorel@suse.cz];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FREEMAIL_ENVRCPT(0.00)[gmail.com];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[];\n FREEMAIL_CC(0.00)[gmail.com,lists.linux.it];\n DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_THREE(0.00)[3];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto,suse.cz:email];\n TAGGED_RCPT(0.00)[];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Rspamd-Queue-Id":"946846A7F4","X-Spam-Score":"-3.71","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679841,"web_url":"http://patchwork.ozlabs.org/comment/3679841/","msgid":"","list_archive_url":null,"date":"2026-04-21T12:02:51","subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> (Please consider configuring spell checker in your editor setup, or run make\n> check as I enabled in our checkpatch.pl configuration check for typos.)\n> \n> AI would reword it, feel free to use some parts or ignore:\n> \n> \tFor some config options their presence in the config file is not enough to assure the functionality is present or enabled.\n> \tE.g. config option may be set to 'm' but the module may not be installed or functionality may be disabled on the kernel command line.\n> \n> \tThe kconfig library has a set of additional checks for a few config options that are used in the tests and need additional checks.\n> \tPlease rebase before adding the text (I fixed typo in include/tst_test.h).\n\nI've already agreed to use the version from Li.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0LZt4StSz1yGt\n\tfor ; Tue, 21 Apr 2026 22:02:46 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id C8D783E2D92\n\tfor ; Tue, 21 Apr 2026 14:02:43 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id ECE243D0F0A\n for ; Tue, 21 Apr 2026 14:02:40 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 529581A006F3\n for ; Tue, 21 Apr 2026 14:02:40 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id B39816A856;\n Tue, 21 Apr 2026 12:02:39 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D83C593AF;\n Tue, 21 Apr 2026 12:02:39 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id W1DBJF9n52n0OAAAD6G6ig\n (envelope-from ); Tue, 21 Apr 2026 12:02:39 +0000"],"Date":"Tue, 21 Apr 2026 14:02:51 +0200","From":"Cyril Hrubis ","To":"Petr Vorel ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-17-chrubis@suse.cz>\n \n <20260421114738.GM506589@pevik>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260421114738.GM506589@pevik>","X-Rspamd-Pre-Result":["action=no action; module=replies;\n Message is reply to one we originated","action=no action; module=replies;\n Message is reply to one we originated"],"X-Rspamd-Queue-Id":"B39816A856","X-Rspamd-Action":"no action","X-Spam-Score":"-4.00","X-Spam-Level":"","X-Spamd-Result":"default: False [-4.00 / 50.00]; REPLY(-4.00)[];\n TAGGED_RCPT(0.00)[]","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Spam-Status":"No, score=0.0 required=7.0 tests=SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused\n needs_drivers","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]