[{"id":3672969,"web_url":"http://patchwork.ozlabs.org/comment/3672969/","msgid":"","list_archive_url":null,"date":"2026-04-03T03:09:42","subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","submitter":{"id":73704,"url":"http://patchwork.ozlabs.org/api/people/73704/","name":"Li Wang","email":"liwang@redhat.com"},"content":"On Thu, Apr 02, 2026 at 02:13:43PM +0200, Cyril Hrubis wrote:\n> The .needs_kconfig and .needs_drivers fields in the tst_test structure\n> had overlaping functionality. Both were checking if a functionality was\n> build in into the kernel or compiled as a driver. Similarily to the\n> runtime checks added to tst_kconfig modules can be build but packaged\n> into separate packages and may not be installed on the system even if\n> corresponding config option was set to 'm'.\n> \n> This commit adds a mapping table from CONFIG options to module names for\n> the modules we care about. Most of the time the mapping is trivial, but\n> some CONFIG options does not really match the module name, hence we need\n> a mapping. We may also be able to generate the table from kernel config\n> infrastructure later on, but at this point the number of options is\n> small enough to be manageable by hand editing.\n> \n> Once we have that mapping we can run aditional check for a module\n> presence if the confing option was set to 'm' and if mapping exists in\n> order to disable the config option when the module was not found.\n> \n> Signed-off-by: Cyril Hrubis \n> ---\n> lib/tst_kconfig.c | 41 +++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 41 insertions(+)\n> \n> diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c\n> index 52dd6d726..c5dd97a45 100644\n> --- a/lib/tst_kconfig.c\n> +++ b/lib/tst_kconfig.c\n> @@ -144,6 +144,46 @@ static void runtime_check(struct tst_kconfig_var *var)\n> \t}\n> }\n> \n> +static struct module_check {\n> +\tconst char *config;\n> +\tconst char *module_name;\n> +} module_checks[] = {\n> +\t{\"CONFIG_KVM\", \"kvm\"},\n> +\t{\"CONFIG_ZRAM\", \"zram\"},\n> +\t{\"CONFIG_SQUASHFS\", \"squashfs\"},\n> +\t{\"CONFIG_BLK_DEV_LOOP\", \"loop\"},\n> +\t{\"CONFIG_TUN\", \"tun\"},\n> +\t{\"CONFIG_BLK_DEV_RAM\", \"brd\"},\n> +\t{\"CONFIG_HWPOISON_INJECT\", \"hwpoison_inject\"},\n> +\t{\"CONFIG_QFMT_V2\", \"quota_v2\"},\n> +\t{\"CONFIG_INPUT_UINPUT\", \"uinput\"},\n> +\t{\"CONFIG_DUMMY\", \"dummy\"},\n> +\t{\"CONFIG_CAN_VCAN\", \"vcan\"},\n> +\t{\"CONFIG_CAN_RAW\", \"can-raw\"},\n> +\t{\"CONFIG_CAN_BCM\", \"can-bcm\"},\n> +\t{\"CONFIG_IP_SCTP\", \"sctp\"},\n> +\t{}\n> +};\n\nMaybe rename the struct to:\n\n\tstatic struct config_module_map {\n\t\tconst char *config;\n\t\tconst char *module_name;\n\t} config_module_maps[] = {\n\t\t...\n\t}\n\nAnd rename 'struct runtime_check' to:\n\n\tstatic struct config_runtime_map {\n\t\tconst char *config;\n\t\tbool (*runtime_check)(void);\n\t} config_runtime_maps[] = {\n\t\t...\n\t};\n\nThis is a tiny nit; I don't have strong opinions.\n\n> static inline int kconfig_parse_line(const char *line,\n> struct tst_kconfig_var *vars,\n> unsigned int vars_len)\n> @@ -222,6 +262,7 @@ out:\n> \t\t\tcase 'm':\n> \t\t\t\tvars[i].choice = 'm';\n> \t\t\t\truntime_check(&vars[i]);\n> +\t\t\t\tmodule_check(&vars[i]);\n\nThen rename the two functions to:\n\n kconfig_runtime_check()\n kconfig_module_check()\n\nBecause in tst_kconfig.c most function contains \"kconfig_\" string.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=WbEJYPYC;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=F7URgpHM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn3cR0G8bz1yD3\n\tfor ; Fri, 03 Apr 2026 14:09:58 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 57F8B3E54DB\n\tfor ; Fri, 3 Apr 2026 05:09:56 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 833B43E2389\n for ; Fri, 3 Apr 2026 05:09:52 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id D6ECB1A0121F\n for ; Fri, 3 Apr 2026 05:09:50 +0200 (CEST)","from mail-pl1-f200.google.com (mail-pl1-f200.google.com\n [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-467-o6jEczE9P76UUXUIVrT0YQ-1; Thu, 02 Apr 2026 23:09:48 -0400","by mail-pl1-f200.google.com with SMTP id\n d9443c01a7336-2b249975139so36046915ad.0\n for ; Thu, 02 Apr 2026 20:09:47 -0700 (PDT)","from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c6476119sm4614792a12.4.2026.04.02.20.09.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 20:09:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1775185796; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=j5GIaJW/DWEX1zeYcpdPDuJz1tx1fC2opHYmooMmy2k=;\n b=WbEJYPYCxtjROBQ103yCBCt1OXlCA3fL3YimgtpgveAwnIVGUutPT6YrX3HbU64CDeX1L\n vH6CqfkpPKaIcYZDOMbMRQvAnJp4XFF9kgvQ8stj5qsP1x5FsiqZ7F1c0yZ+j88oJqE3wO4\n GlYRbS57bxbpL51b38ka8Sng9jDkSEw=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775185789;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uU0LicUvWGDyA4SMMDkcoFdRXxWWf0smsoQ4mR1HECQ=;\n b=F7URgpHM+HTGx7wRwVmA8hi5CHCxUzWCEAaggq1is2ohCISIA7MS4OkmmRJ3hq0NyHIBgL\n D/yH1zFtQ8WrbYIWWTTXam2j5D+tLNF85Z9w++wK6MyVWg2JZ6WwsKbpIPZ46+dryHlZIG\n SUiFoqbgAeQKom57s6TPoIc4BiAZSbw="],"X-MC-Unique":"o6jEczE9P76UUXUIVrT0YQ-1","X-Mimecast-MFC-AGG-ID":"o6jEczE9P76UUXUIVrT0YQ_1775185787","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775185787; x=1775790587;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uU0LicUvWGDyA4SMMDkcoFdRXxWWf0smsoQ4mR1HECQ=;\n b=TrAxT/wk5GQ38jafe1OqFunhSjA9KI4LCXErvVjEtNWCYFbuNd5fWvhUfeahDzWXWx\n 5tFo4mRnmOVxdP1/Ngt9GMwjpCN2Uf2V9LElpEGyJWX9LK6X8ZcNdm4fELr7MH/N92zb\n yzRs0eL37K1LergrQlu1u9WeFCiTiHvfy+iivbLlZJSLTgcLetea4nutYqzaIabe3lH6\n ajOk3qC/9Ga75/M7hZS5ofDcmAh4rch8tFrvKnqxFCUJU9wDHXLmjtLYsvDZ8XygVn+f\n 820SQP4V0eZkcG5qUJlyOFx3G7uXXpDbsSTMT9niOAgzceqX4kYKfUwzt67NDgHStWis\n 80bA==","X-Gm-Message-State":"AOJu0YzgbrLeaatS1HBGWJjjzn8jgU2v1XHTccfTLtBqxeklG0W6DJyW\n 3dG0YB6NY48Gp36P23yYA6RGMnR0oULKiXPe59IbzfarkVgRjPkB1Y6vFnSBdcXrnwvvPfxLUAy\n 0pzKhEtPJMdt3Lutmyqa7/G/8tsPt0fEzLjewMZdmAMpEKpPK1E55","X-Gm-Gg":"AeBDiesDT7/OCpNiUQsjPpIddTe0CKh2C8j856dKT00FKrDHvX1eiVh8yQjASjtquwI\n vl6pPrZDFtqDbCtTxcL+FaszKbU34AN4meFHR9vT3QjK5Djv/vFb0yhRr5k/Orx7vfSwpa8GDze\n gmOXD0vgXpVinRMwj+7UzhD4slZBxVHEFSKf2jhBVEvvDN9rOOjIzShvKRpbbQqpKdhsBwpL3qB\n Tw49DbMQUWdtoFw/nmEKZ4MOkgDWvVTUDXULkS5KHrncpuJxXPrERGy45+zeFm59OK8FusSp23I\n 6JVHtSZUFntKOE+rcAxDZ+8MlDcQOjieUfuXvy4jQ8u2KzEsiP7LaFEw7OQ5UZJj/pmKwm7YRj5\n FvH46sHF6hh3lJ+DPUg==","X-Received":["by 2002:a17:903:1b2e:b0:2ae:ced7:4650 with SMTP id\n d9443c01a7336-2b281799547mr16514025ad.24.1775185786922;\n Thu, 02 Apr 2026 20:09:46 -0700 (PDT)","by 2002:a17:903:1b2e:b0:2ae:ced7:4650 with SMTP id\n d9443c01a7336-2b281799547mr16513635ad.24.1775185786341;\n Thu, 02 Apr 2026 20:09:46 -0700 (PDT)"],"Date":"Fri, 3 Apr 2026 11:09:42 +0800","To":"Cyril Hrubis ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-5-chrubis@suse.cz>","MIME-Version":"1.0","In-Reply-To":"<20260402121356.31266-5-chrubis@suse.cz>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"CL7RRi1Vp8YwjMC88tbW8qUqnpelqMGaAarvuPMmHdE_1775185787","X-Mimecast-Originator":"redhat.com","Content-Disposition":"inline","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Wang via ltp ","Reply-To":"Li Wang ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674054,"web_url":"http://patchwork.ozlabs.org/comment/3674054/","msgid":"","list_archive_url":null,"date":"2026-04-07T10:05:08","subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> Maybe rename the struct to:\n> \n> \tstatic struct config_module_map {\n> \t\tconst char *config;\n> \t\tconst char *module_name;\n> \t} config_module_maps[] = {\n> \t\t...\n> \t}\n> \n> And rename 'struct runtime_check' to:\n> \n> \tstatic struct config_runtime_map {\n> \t\tconst char *config;\n> \t\tbool (*runtime_check)(void);\n> \t} config_runtime_maps[] = {\n> \t\t...\n> \t};\n> \n> This is a tiny nit; I don't have strong opinions.\n> \n> > static inline int kconfig_parse_line(const char *line,\n> > struct tst_kconfig_var *vars,\n> > unsigned int vars_len)\n> > @@ -222,6 +262,7 @@ out:\n> > \t\t\tcase 'm':\n> > \t\t\t\tvars[i].choice = 'm';\n> > \t\t\t\truntime_check(&vars[i]);\n> > +\t\t\t\tmodule_check(&vars[i]);\n> \n> Then rename the two functions to:\n> \n> kconfig_runtime_check()\n> kconfig_module_check()\n> \n> Because in tst_kconfig.c most function contains \"kconfig_\" string.\n\nI do not have strong opition, if you agree that these names are better\nwe can rename them.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=nLcUt7jc;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=/7f1kHCN;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=nLcUt7jc;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/7f1kHCN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nLcUt7jc;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=\"/7f1kHCN\""],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqhdc3chbz1xy1\n\tfor ; Tue, 07 Apr 2026 20:05:08 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 74E6E3E2183\n\tfor ; Tue, 7 Apr 2026 12:05:06 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 3511E3D0EA6\n for ; Tue, 7 Apr 2026 12:05:03 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id AF143100079A\n for ; Tue, 7 Apr 2026 12:05:02 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 1719F4E3CF;\n Tue, 7 Apr 2026 10:05:02 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 079294A0B0;\n Tue, 7 Apr 2026 10:05:02 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id oI0NAc7W1GlEAQAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 10:05:02 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775556302;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=SwYiVRSCIrnHEuXcgzajMRpjrZAdf6gTJtzlmf7qSEE=;\n b=nLcUt7jcoqj1qU+e26z3QT7a7VayGZ09Zoj0M7ZXnjR8Ho9aKypktm5ItPAeJWB+avPfcI\n 0lX7PEH3303eM2G4flskPwXg4uKYD8YTfmP/TQloL0dVnjKJjzuUkQCkFVADSBYcwdxpkn\n Nqm/cr3EaR8ux9Z8NTKQxPdgdUqbWX0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775556302;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=SwYiVRSCIrnHEuXcgzajMRpjrZAdf6gTJtzlmf7qSEE=;\n b=/7f1kHCN4r8Fxcs+maEm6CR095+vzCREGwdAiONfj1vCPkEK7CzWklMYjzFuL+wQz4KtsM\n N9TCQBE/2nUiPYAA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775556302;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=SwYiVRSCIrnHEuXcgzajMRpjrZAdf6gTJtzlmf7qSEE=;\n b=nLcUt7jcoqj1qU+e26z3QT7a7VayGZ09Zoj0M7ZXnjR8Ho9aKypktm5ItPAeJWB+avPfcI\n 0lX7PEH3303eM2G4flskPwXg4uKYD8YTfmP/TQloL0dVnjKJjzuUkQCkFVADSBYcwdxpkn\n Nqm/cr3EaR8ux9Z8NTKQxPdgdUqbWX0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775556302;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=SwYiVRSCIrnHEuXcgzajMRpjrZAdf6gTJtzlmf7qSEE=;\n b=/7f1kHCN4r8Fxcs+maEm6CR095+vzCREGwdAiONfj1vCPkEK7CzWklMYjzFuL+wQz4KtsM\n N9TCQBE/2nUiPYAA=="],"Date":"Tue, 7 Apr 2026 12:05:08 +0200","From":"Cyril Hrubis ","To":"Li Wang ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-5-chrubis@suse.cz>\n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[];\n TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:email];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n DKIM_TRACE(0.00)[suse.cz:+]","X-Rspamd-Queue-Id":"1719F4E3CF","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674114,"web_url":"http://patchwork.ozlabs.org/comment/3674114/","msgid":"","list_archive_url":null,"date":"2026-04-07T11:40:53","subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","submitter":{"id":73704,"url":"http://patchwork.ozlabs.org/api/people/73704/","name":"Li Wang","email":"liwang@redhat.com"},"content":"> I do not have strong opition, if you agree that these names are better\n> we can rename them.\n\nYes, I have a bit preference to rename.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=LLj7ZCAA;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WYIJVWgF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqkmM6Dypz1xtJ\n\tfor ; Tue, 07 Apr 2026 21:41:07 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id F134D3E26AF\n\tfor ; Tue, 7 Apr 2026 13:41:05 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 15C1F3C1987\n for ; Tue, 7 Apr 2026 13:41:01 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 7178C600714\n for ; Tue, 7 Apr 2026 13:41:00 +0200 (CEST)","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-414-2hoL2RahMMeXB5iBDxEcQg-1; Tue, 07 Apr 2026 07:40:57 -0400","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b24a00d12cso53829735ad.1\n for ; Tue, 07 Apr 2026 04:40:57 -0700 (PDT)","from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27497af26sm174471245ad.49.2026.04.07.04.40.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 04:40:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1775562066; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=h24N5UYGtlG1RJSWv4nnR3zvmX0uO5FpUapDYSMalbA=;\n b=LLj7ZCAAcPz8qcOJstv0Rjb8ckJMfc5jLMW0l8YnNp2LOgZHDGEThLB8ILyok0K++9crJ\n 1a7KQ5uYGRtTFtDUI4B9E7jSZQxKJkbU/9KkpCjnO5b1CE6yGyZ2oZxZh2q+fu2+NJJFC3P\n 0CeGY+FBpe7lr8FBWfstEvoiWDIaeOo=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775562058;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=UWKNP4She2EH6wTVESR9FIbcOscja142vLTgD1CJgWQ=;\n b=WYIJVWgFGpURk8J0+/piqtjrtyh6FcNXzUzH1DSipg3CZIuoCJ50kEeBJD1zKcUTG4QSwG\n 4s/4hN1a/Apw1nNJzOA4gLvWtkIwmPKGksyAROe42RH5pT3njIkZzJX9/tKA16xznZ2n0C\n Jyb0Ei5MWMyuG7JdXLlQzunZ0CSqBHw="],"X-MC-Unique":"2hoL2RahMMeXB5iBDxEcQg-1","X-Mimecast-MFC-AGG-ID":"2hoL2RahMMeXB5iBDxEcQg_1775562056","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775562056; x=1776166856;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=UWKNP4She2EH6wTVESR9FIbcOscja142vLTgD1CJgWQ=;\n b=r69iHsfXNntxoOjdjnoff0RWzrwmoBBq5k1wy6bFLWkvoQutBsAC+y0wgdvKUJjRAF\n lQp/n2VMFDtuzsz+BfAWpENV9bKnpBocLUWu6Kibzo9cuq0HopSs7mYY0vSD8ljR5uAF\n wcEEDxPWEibqr+zAgYV0fVjuPde648p8rTjdBSeuVjWCiow0liDjkGly89fXF19gFuAc\n VJG2CzTPwZDzcBBnjFUqLZ0s4CK0/m64KFqoEXlT7II3mIxTZvqVN3gLEPD/r4AW0xV5\n Rz7WKYSUeKdj0ThQ0/naVm9UEcRhsOblloBDLPPQb7R4OfW2JWvClppc9eTCN1c/Yy7o\n VZuQ==","X-Gm-Message-State":"AOJu0YzjT5BqIaSrDT5W7F5/mmOSNI4vkBn0iKyOBhsEQs5aihHF68cN\n zLqvSDKcG/jmJ9X+A3875i/pjNSJoXVAbALTD1uLKMrZQJ/wnQ0fqINQTCUSu/2T0+xhUAEAMcl\n y9BGChdOmy1bCx24F7vyf1nFCd9sCM6EVrTHUBfEbPQjxBJxBgjdH","X-Gm-Gg":"AeBDietylG3JAVpfderJtJw5cRHSUj+w/CWqOcE8YDNWphb6QJJ1tprnikUuUAX3q7N\n rbySsQY66A7MjU/KHw8ovNyJcw+oIWYHDD5ADEYW/NUXxSKPQ/mdC4q96lpxWwsSkbpQI0iKmHG\n WP5y+9dnL5NSpYrw/5slvyEmRQgD2ZstlNTGHLMGUXDufvxHiBtSz1PKHQHh9YuB0m3at9Vdwch\n pa3oKnd1eiOZOSGS0/DeSOtMivagnMNWxMRv5D9dYOo5LUMT8lCD6prbLftrvesMz2JqqwFUIRb\n eCaTBaRatZqCwbToCrJDXE6YIqZJVR7UY5x9ZC1f2LMIYjBHIBP4YUf+6e8BFEDVMKR1ePFDIzA\n +qlXklJBiYpDLKlfPkw==","X-Received":["by 2002:a17:903:3508:b0:2b0:7a27:bb2b with SMTP id\n d9443c01a7336-2b28178ef7amr183497265ad.34.1775562056124;\n Tue, 07 Apr 2026 04:40:56 -0700 (PDT)","by 2002:a17:903:3508:b0:2b0:7a27:bb2b with SMTP id\n d9443c01a7336-2b28178ef7amr183497015ad.34.1775562055561;\n Tue, 07 Apr 2026 04:40:55 -0700 (PDT)"],"Date":"Tue, 7 Apr 2026 19:40:53 +0800","To":"Cyril Hrubis ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-5-chrubis@suse.cz>\n ","MIME-Version":"1.0","In-Reply-To":"","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Z1KuPSRPD0Lvdt6XOf9kfl4_zFdyLttevpGRJJztG2o_1775562056","X-Mimecast-Originator":"redhat.com","Content-Disposition":"inline","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_PASS,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Wang via ltp ","Reply-To":"Li Wang ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674116,"web_url":"http://patchwork.ozlabs.org/comment/3674116/","msgid":"","list_archive_url":null,"date":"2026-04-07T11:44:21","subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> > I do not have strong opition, if you agree that these names are better\n> > we can rename them.\n> \n> Yes, I have a bit preference to rename.\n\nI will rename the config module checks in this patchset and add a rename\nfor the runtime checks on the top of it later on then.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=0k8gaSPl;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=gAsKl5Aj;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=0k8gaSPl;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=gAsKl5Aj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqkrF6l8Lz1xtJ\n\tfor ; Tue, 07 Apr 2026 21:44:29 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 075C43E29AB\n\tfor ; Tue, 7 Apr 2026 13:44:28 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id F0FF03C054A\n for ; Tue, 7 Apr 2026 13:44:23 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 8B1E0140077C\n for ; Tue, 7 Apr 2026 13:44:21 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 6A4A85BD6C;\n Tue, 7 Apr 2026 11:44:15 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 588054A0B0;\n Tue, 7 Apr 2026 11:44:15 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id RKNGEw/u1Gm/ZgAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 11:44:15 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775562255;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Az2cLOQCzlRcqAaXlPttZ9FaMWyVKpJuFd5cVhbPSxo=;\n b=0k8gaSPl9BbK5ddBYtdvT418ULGARWBSKkyR19+jyou26ArvD+E17x87xfq9h17ol7uypi\n DiegGNEkaZEAL5g/mtfFOVdn8D7ZXOOE9fyNtKRrZ5GtjYFlwdhHrXiiMn3Ir1i/M6RnQj\n PVsYewuEzNx3wZs8QBppoILZ3VZ6zrw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775562255;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Az2cLOQCzlRcqAaXlPttZ9FaMWyVKpJuFd5cVhbPSxo=;\n b=gAsKl5AjOaFRxBNObkASyOo1FE82PfJA9xf0UKMjG6+kUFeNxFZkK24Tqc/cAnBIQcSz7H\n KkvJIbwYcOwrlzDw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775562255;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Az2cLOQCzlRcqAaXlPttZ9FaMWyVKpJuFd5cVhbPSxo=;\n b=0k8gaSPl9BbK5ddBYtdvT418ULGARWBSKkyR19+jyou26ArvD+E17x87xfq9h17ol7uypi\n DiegGNEkaZEAL5g/mtfFOVdn8D7ZXOOE9fyNtKRrZ5GtjYFlwdhHrXiiMn3Ir1i/M6RnQj\n PVsYewuEzNx3wZs8QBppoILZ3VZ6zrw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775562255;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Az2cLOQCzlRcqAaXlPttZ9FaMWyVKpJuFd5cVhbPSxo=;\n b=gAsKl5AjOaFRxBNObkASyOo1FE82PfJA9xf0UKMjG6+kUFeNxFZkK24Tqc/cAnBIQcSz7H\n KkvJIbwYcOwrlzDw=="],"Date":"Tue, 7 Apr 2026 13:44:21 +0200","From":"Cyril Hrubis ","To":"Li Wang ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-5-chrubis@suse.cz>\n \n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n FROM_HAS_DN(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[];\n MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[yuki.lan:mid, suse.cz:email,\n imap1.dmz-prg2.suse.org:helo]","X-Spam-Score":"-4.30","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679805,"web_url":"http://patchwork.ozlabs.org/comment/3679805/","msgid":"<20260421110406.GB506589@pevik>","list_archive_url":null,"date":"2026-04-21T11:04:06","subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Cyril, Li,\n\n...\n> +\t\tif (tst_check_module_driver(module_checks[i].module_name)) {\n> +\t\t\ttst_res(TINFO, \"%s=%c present but module '%s' not installed\",\n> +\t\t\t\t\tvar->id, var->choice, module_checks[i].module_name);\n> +\t\t\tvar->choice = 'n';\n\nI would consider having defines for 'y', 'm', 'n' to avoid typos.\nOTOH even kernel code in scripts/kconfig/symbol.c use plain strings\n(chars) without defines so feel free to ignore.\n\nI consider renames suggested by Li slightly better (it's really mapping).\n\nReviewed-by: Petr Vorel \n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=0bYDKnzh;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=q8Ssj3Ly;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=lHpZtbmE;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Ymn3kIIB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHpZtbmE;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ymn3kIIB"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0KHV2K6Vz1yGt\n\tfor ; Tue, 21 Apr 2026 21:04:21 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 11FC93E2927\n\tfor ; Tue, 21 Apr 2026 13:04:19 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 024673C0224\n for ; Tue, 21 Apr 2026 13:04:13 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id D5A141A006BB\n for ; Tue, 21 Apr 2026 13:04:11 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 605C25BCEE;\n Tue, 21 Apr 2026 11:04:08 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 433B6593AF;\n Tue, 21 Apr 2026 11:04:08 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id ZGaQDqhZ52kGfgAAD6G6ig\n (envelope-from ); Tue, 21 Apr 2026 11:04:08 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776769449;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=;\n b=0bYDKnzhtdFjDGdyXHYDjJYqcdeyb/aHHBNkx2VsZzGs7x1nnKJEfrx96GIipUBDdaGJoj\n M6lwHBeO4vm+glvwkaM+7PH6lqWiVRjN4CYrv6h0Pmr07DlFqz/DfV0MpqxJytSZlD6Fga\n 0D6NAnuGs/MWXWbWZwQevhgfPaEz+RU=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776769449;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=;\n b=q8Ssj3LyBi/mbhoSmA0Z2FfBIe4F39Fog2jmp2ISOwAuLDrS/4oLTa4dWHJsJkmg1Nflq2\n NkqOHkVv+YIgz1CA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776769448;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=;\n b=lHpZtbmElwwOkPZYrxXvRqCEHDkA/4wFVAZ7VsnVcdakhzjPjKbmD29rBD1v7GZL/rJaeP\n GzoKTlIOMtCgc2yMEQ41WqcJExmLaRbG+Blu1uGZzvPWac47mUdoe2o50KY4xfwRJ8Bme8\n nE4CjjeArENncKFz81QmEybjqNJNU+8=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776769448;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=;\n b=Ymn3kIIBQi1mIuJevg1Kb195gCqVnZarAvskbsS4sg2S/u9dwQRiaQuuRX0+feU0tfYXzo\n /qFrS0j1MkDKTRCg=="],"Date":"Tue, 21 Apr 2026 13:04:06 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260421110406.GB506589@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-5-chrubis@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260402121356.31266-5-chrubis@suse.cz>","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[];\n HAS_REPLYTO(0.30)[pvorel@suse.cz];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com];\n RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto,suse.cz:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n FREEMAIL_CC(0.00)[lists.linux.it,gmail.com];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[];\n RCPT_COUNT_THREE(0.00)[3]; MISSING_XM_UA(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Rspamd-Queue-Id":"605C25BCEE","X-Spam-Score":"-3.71","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]