[{"id":3672907,"web_url":"http://patchwork.ozlabs.org/comment/3672907/","msgid":"<20260402212620.GA225068@pevik>","list_archive_url":null,"date":"2026-04-02T21:26:20","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Cyril,\n\n> This function allows us to check for presence of drivers build as\ns/build/built/\n> modules.\n\nReviewed-by: Petr Vorel \n\n> Signed-off-by: Cyril Hrubis \n> ---\n> include/tst_kernel.h | 10 ++++++++++\n> lib/tst_kernel.c | 12 +++++++-----\n> 2 files changed, 17 insertions(+), 5 deletions(-)\n\n> diff --git a/include/tst_kernel.h b/include/tst_kernel.h\n> index 63ecb19a4..d5a4a9625 100644\n> --- a/include/tst_kernel.h\n> +++ b/include/tst_kernel.h\n> @@ -45,6 +45,16 @@ bool tst_abi_bits(int abi);\n> */\n> int tst_check_builtin_driver(const char *driver);\n\n> +/**\n> + * tst_check_module_driver() - Check if the kernel module is present.\n> + *\n> + * @driver: the name of the driver.\n> + *\n> + * Return: 0 if module driver is present or -1 when driver is missing or config file not\n> + * available. On Android *always* 0 (always expect the module is present).\n\nnit: \"the driver\" vs. \"the module\". We have kernel modules which are builtin or\ncompiled as modules. The older two functions say \"the driver\", but they are also\nmodules (although builtin), maybe worth to change it.\n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=pO4tj6fg;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=YU+IldsT;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=pO4tj6fg;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=YU+IldsT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmw0K2Mfxz1yD3\n\tfor ; Fri, 03 Apr 2026 08:26:41 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 558433E4E90\n\tfor ; Thu, 2 Apr 2026 23:26:38 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 9F0313E2F53\n for ; Thu, 2 Apr 2026 23:26:34 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 845091400758\n for ; Thu, 2 Apr 2026 23:26:32 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id A57B34D309;\n Thu, 2 Apr 2026 21:26:26 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3981A4A0B0;\n Thu, 2 Apr 2026 21:26:26 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id efx4DALfzmn4OQAAD6G6ig\n (envelope-from ); Thu, 02 Apr 2026 21:26:26 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775165186;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=EyGwyAgL7mk3sv84CPDlfjwZd9kgzppaDft6OVmSD2Q=;\n b=pO4tj6fg85Cn5fctV3MaWrJh/lseuokn1kysYzX4OjXVluHJOuLIkq+jeYVifTVrJ6Ed4x\n ooeO3dRiGTyvDWZ9NCNPyDr71L9Etmsn42BR2LN64ndA7/To0b4IXLJ7yxaqg6twcmi+7J\n x8nc9ZtupmLE0cugGWpj8DhvVK6Ydrw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775165186;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=EyGwyAgL7mk3sv84CPDlfjwZd9kgzppaDft6OVmSD2Q=;\n b=YU+IldsTtCtHtUC+dXya42qdsmBhhuLyIMCxag1lXe8gDFBMKMUqcwdmPPTPC6QWBPNK9/\n rl8XwlghYR2LOEBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775165186;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=EyGwyAgL7mk3sv84CPDlfjwZd9kgzppaDft6OVmSD2Q=;\n b=pO4tj6fg85Cn5fctV3MaWrJh/lseuokn1kysYzX4OjXVluHJOuLIkq+jeYVifTVrJ6Ed4x\n ooeO3dRiGTyvDWZ9NCNPyDr71L9Etmsn42BR2LN64ndA7/To0b4IXLJ7yxaqg6twcmi+7J\n x8nc9ZtupmLE0cugGWpj8DhvVK6Ydrw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775165186;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=EyGwyAgL7mk3sv84CPDlfjwZd9kgzppaDft6OVmSD2Q=;\n b=YU+IldsTtCtHtUC+dXya42qdsmBhhuLyIMCxag1lXe8gDFBMKMUqcwdmPPTPC6QWBPNK9/\n rl8XwlghYR2LOEBA=="],"Date":"Thu, 2 Apr 2026 23:26:20 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260402212620.GA225068@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260402121356.31266-4-chrubis@suse.cz>","X-Spamd-Result":"default: False [-7.50 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,suse.cz:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Spam-Score":"-7.50","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3672917,"web_url":"http://patchwork.ozlabs.org/comment/3672917/","msgid":"<20260402214727.GE225068@pevik>","list_archive_url":null,"date":"2026-04-02T21:47:27","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Cyril,\n\n> @@ -200,16 +200,18 @@ static int tst_search_driver(const char *driver, const char *file)\n\n> int tst_check_builtin_driver(const char *driver)\n> {\n> -\tif (!tst_search_driver(driver, \"modules.builtin\"))\n> -\t\treturn 0;\n> +\treturn tst_search_driver(driver, \"modules.builtin\");\n> +}\n\n> -\treturn -1;\n> +int tst_check_module_driver(const char *driver)\n> +{\n> +\treturn tst_search_driver(driver, \"modules.dep\");\n\nThinking about it twice, could we check for the module by reading\n/sys/module/? Our current approach shows what module *should* be available, but\nthat might not be true for some reason (i.e. loadable module not installed).\n\nUnfortunately while this works for loadable modules (and IMHO worth to add it),\nbuiltin modules are here only if they have a version or at least one parameter\n[1]. And this will not work at least for hwpoison_inject.\n\nKind regards,\nPetr\n\n[1] https://www.kernel.org/doc/Documentation/ABI/stable/sysfs-module","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=mZJjwwlr;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=k/a+v1on;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=mZJjwwlr;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=k/a+v1on;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmwSd66gLz1xtJ\n\tfor ; Fri, 03 Apr 2026 08:47:45 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 456E23E4E80\n\tfor ; Thu, 2 Apr 2026 23:47:43 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 25C7D3E21AE\n for ; Thu, 2 Apr 2026 23:47:39 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 8826F200966\n for ; Thu, 2 Apr 2026 23:47:38 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 1EE464D309;\n Thu, 2 Apr 2026 21:47:37 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E48D34A0B0;\n Thu, 2 Apr 2026 21:47:36 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id DRM1MvjjzmmhTgAAD6G6ig\n (envelope-from ); Thu, 02 Apr 2026 21:47:36 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775166457;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Ug0+lWDLHW1RHj94H+CiAbMfYlMgqkLN8E3xCiuikTc=;\n b=mZJjwwlr8aNmlOetC2njVIW0D+dJXvJhS7yuzRveG+ifipHZJL22MfSTe40N5Z8lk/W/CQ\n l7cH7uRFl1P8REHgmJJpYbTh6GBmWXj3VvL3vLe9EHnAaoatSVyphGXd4W0UnnLTWZ4qQa\n T5+Acml1dx+2h5Jb0ub9Feb6ULnu6Ds=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775166457;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Ug0+lWDLHW1RHj94H+CiAbMfYlMgqkLN8E3xCiuikTc=;\n b=k/a+v1onIJuqvhHuiFBiFa2Y5azhmI4k6v/r7kmCspBvcd9HSAtKG0mk6TJPtlVWoTPwi5\n r/8M0vy7vEUiafCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775166457;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Ug0+lWDLHW1RHj94H+CiAbMfYlMgqkLN8E3xCiuikTc=;\n b=mZJjwwlr8aNmlOetC2njVIW0D+dJXvJhS7yuzRveG+ifipHZJL22MfSTe40N5Z8lk/W/CQ\n l7cH7uRFl1P8REHgmJJpYbTh6GBmWXj3VvL3vLe9EHnAaoatSVyphGXd4W0UnnLTWZ4qQa\n T5+Acml1dx+2h5Jb0ub9Feb6ULnu6Ds=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775166457;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Ug0+lWDLHW1RHj94H+CiAbMfYlMgqkLN8E3xCiuikTc=;\n b=k/a+v1onIJuqvhHuiFBiFa2Y5azhmI4k6v/r7kmCspBvcd9HSAtKG0mk6TJPtlVWoTPwi5\n r/8M0vy7vEUiafCQ=="],"Date":"Thu, 2 Apr 2026 23:47:27 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260402214727.GE225068@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260402121356.31266-4-chrubis@suse.cz>","X-Spam-Score":"-7.50","X-Spam-Level":"","X-Spamd-Result":"default: False [-7.50 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-0.994]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:replyto];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674032,"web_url":"http://patchwork.ozlabs.org/comment/3674032/","msgid":"","list_archive_url":null,"date":"2026-04-07T09:43:04","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> > -\treturn -1;\n> > +int tst_check_module_driver(const char *driver)\n> > +{\n> > +\treturn tst_search_driver(driver, \"modules.dep\");\n> \n> Thinking about it twice, could we check for the module by reading\n> /sys/module/? Our current approach shows what module *should* be available, but\n> that might not be true for some reason (i.e. loadable module not installed).\n\nThe modules.dep file contains names of all modules installed in\nparticular kernel modules directory. We cannot do anything better than\nparsing that file because it's (re)genrated on the system each time\npackages with modules have been installed/removed. If that wasn't the\ncase modprobe that depends on that file wouldn't work either.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=NkV+B4uP;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=cJGsMX3h;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=NkV+B4uP;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=cJGsMX3h;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqh8G53lbz1xtJ\n\tfor ; Tue, 07 Apr 2026 19:43:10 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 075A63E26B1\n\tfor ; Tue, 7 Apr 2026 11:43:08 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id E03EC3DB86B\n for ; Tue, 7 Apr 2026 11:43:04 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 5DA0120075E\n for ; Tue, 7 Apr 2026 11:43:04 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 88D274E3B0;\n Tue, 7 Apr 2026 09:43:02 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A0A34A0B0;\n Tue, 7 Apr 2026 09:43:02 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id xt3kHKbR1GlpaQAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 09:43:02 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775554982;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=rwmf17h0X4s0X5AbAAq6yXxGGrJP3SmNyhfKxQsjDh4=;\n b=NkV+B4uPMeeIPs4BF6JoA9f55Wn2sC2XtAQLmeseiuRgZ9imRDjL58lScLmQ8coOKlGn1p\n 44hHitMp3dDNxEKOOFkDzUqLHqMXESVipF7nMOLJHyRgRpt7JCgxoCQLNcCgFfJg4XvpGW\n Syl34E1AzShGWDIlKIm1w7Cd/1DLLGY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775554982;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=rwmf17h0X4s0X5AbAAq6yXxGGrJP3SmNyhfKxQsjDh4=;\n b=cJGsMX3hKYkAQjgNIYu2KI/M6ZU5B5RniZXgLOytchBluV/c+l7d6ga/Gu1dIIbRUqD4kk\n myskVZJefEty9MDQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775554982;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=rwmf17h0X4s0X5AbAAq6yXxGGrJP3SmNyhfKxQsjDh4=;\n b=NkV+B4uPMeeIPs4BF6JoA9f55Wn2sC2XtAQLmeseiuRgZ9imRDjL58lScLmQ8coOKlGn1p\n 44hHitMp3dDNxEKOOFkDzUqLHqMXESVipF7nMOLJHyRgRpt7JCgxoCQLNcCgFfJg4XvpGW\n Syl34E1AzShGWDIlKIm1w7Cd/1DLLGY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775554982;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=rwmf17h0X4s0X5AbAAq6yXxGGrJP3SmNyhfKxQsjDh4=;\n b=cJGsMX3hKYkAQjgNIYu2KI/M6ZU5B5RniZXgLOytchBluV/c+l7d6ga/Gu1dIIbRUqD4kk\n myskVZJefEty9MDQ=="],"Date":"Tue, 7 Apr 2026 11:43:04 +0200","From":"Cyril Hrubis ","To":"Petr Vorel ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>\n <20260402214727.GE225068@pevik>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260402214727.GE225068@pevik>","X-Spam-Score":"-4.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2];\n RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,imap1.dmz-prg2.suse.org:helo]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674098,"web_url":"http://patchwork.ozlabs.org/comment/3674098/","msgid":"<20260407111501.GA25645@pevik>","list_archive_url":null,"date":"2026-04-07T11:15:01","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"> Hi!\n> > > -\treturn -1;\n> > > +int tst_check_module_driver(const char *driver)\n> > > +{\n> > > +\treturn tst_search_driver(driver, \"modules.dep\");\n\n> > Thinking about it twice, could we check for the module by reading\n> > /sys/module/? Our current approach shows what module *should* be available, but\n> > that might not be true for some reason (i.e. loadable module not installed).\n\n> The modules.dep file contains names of all modules installed in\n> particular kernel modules directory. We cannot do anything better than\n> parsing that file because it's (re)genrated on the system each time\n> packages with modules have been installed/removed. If that wasn't the\n> case modprobe that depends on that file wouldn't work either.\n\nWe effectively ask users to install modules.dep and modules.builtin. While this\nis ok for distros and nobody has complained, I can imagine special embedded\nsystems can have problem. If everything was reliably detectable via /sys or\n/proc I'd move to it. But even it's not working for all modules, checking first\n/sys/module/ and fallback using modules.{builtin,dep} wouldn't take much effort.\nBut sure, we can postpone it until somebody has problems with the current\napproach.\n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqkBT5DrRz1yD3\n\tfor ; Tue, 07 Apr 2026 21:15:13 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id DF19B3E214D\n\tfor ; Tue, 7 Apr 2026 13:15:10 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D97433C9314\n for ; Tue, 7 Apr 2026 13:15:07 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 613091000609\n for ; Tue, 7 Apr 2026 13:15:07 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id D7D6B5BD36;\n Tue, 7 Apr 2026 11:15:06 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB3A44A0B0;\n Tue, 7 Apr 2026 11:15:06 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id zYOKJzrn1GmDSAAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 11:15:06 +0000"],"Date":"Tue, 7 Apr 2026 13:15:01 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260407111501.GA25645@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>\n <20260402214727.GE225068@pevik> ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Rspamd-Pre-Result":["action=no action; module=replies;\n Message is reply to one we originated","action=no action; module=replies;\n Message is reply to one we originated"],"X-Rspamd-Queue-Id":"D7D6B5BD36","X-Rspamd-Action":"no action","X-Spam-Score":"-4.00","X-Spam-Level":"","X-Spamd-Result":"default: False [-4.00 / 50.00];\n\tREPLY(-4.00)[]","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Spam-Status":"No, score=0.0 required=7.0 tests=SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674102,"web_url":"http://patchwork.ozlabs.org/comment/3674102/","msgid":"","list_archive_url":null,"date":"2026-04-07T11:24:29","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> > > Thinking about it twice, could we check for the module by reading\n> > > /sys/module/? Our current approach shows what module *should* be available, but\n> > > that might not be true for some reason (i.e. loadable module not installed).\n> \n> > The modules.dep file contains names of all modules installed in\n> > particular kernel modules directory. We cannot do anything better than\n> > parsing that file because it's (re)genrated on the system each time\n> > packages with modules have been installed/removed. If that wasn't the\n> > case modprobe that depends on that file wouldn't work either.\n> \n> We effectively ask users to install modules.dep and modules.builtin. While this\n> is ok for distros and nobody has complained, I can imagine special embedded\n> systems can have problem. If everything was reliably detectable via /sys or\n> /proc I'd move to it. But even it's not working for all modules, checking first\n> /sys/module/ and fallback using modules.{builtin,dep} wouldn't take much effort.\n\nMy code does not add any new dependencies. The check for module.dep has\nbeen in LTP since:\n\n8f7013ba6917 ('tst_check_driver(): Fix kernel module detection on BusyBox')\n\nwhich was introduced five years ago.\n\nThe only thing that changes is that the check is being moved from\nneeds_drivers to needs_kconfigs.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=iEJfG+wi;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=fRmP12Zj;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=ryDVMRLF;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=BRYLQBII;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqkPC5tXqz1xy1\n\tfor ; Tue, 07 Apr 2026 21:24:31 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 9F6453E29A8\n\tfor ; Tue, 7 Apr 2026 13:24:29 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id C17043C9314\n for ; Tue, 7 Apr 2026 13:24:26 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 3F1671000371\n for ; Tue, 7 Apr 2026 13:24:26 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 90EA95BD95;\n Tue, 7 Apr 2026 11:24:23 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 828724A0B0;\n Tue, 7 Apr 2026 11:24:23 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id A1nyHmfp1Gm2UQAAD6G6ig\n (envelope-from ); Tue, 07 Apr 2026 11:24:23 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775561064;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=;\n b=iEJfG+wi06wx1mrQaY4QHtd/S3kxsRC6JKwyEicC4G1qNhLGAunlH3JowbzB1lH8wB5F0Z\n m+8wwKJ+4ylboD84vohxDOsjTmlCo6K/X/+CcLsGCtIBnm/gIPVgk371zUlwWfsPyOJOdA\n r8rwM0ZFwK4K8X4IRcPfPc3mXGg9Bi4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775561064;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=;\n b=fRmP12ZjkKV2xKaMD2oNxZKzSrVhRsrIjSbm922Ih66Sec3sCFNLj1X3djB1AygL+2aoqM\n S2vfHw1nN3lu6cDQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775561063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=;\n b=ryDVMRLFd0dW2Xo17f6TxFSWmL4AhA0eoKsOPpjHLJ7hsOmV8i1dyY8KRrE923dEvYasYb\n Hu8fs0set3p1ZpkQoOhgBq+/vBcex4IkzXHHK1PLIxPIlY/EPNP1jZeRZxXH/+P8FHidf5\n i+Tz56+Ez+1uYYk5/75kL0ZsgMeTy/o=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775561063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=;\n b=BRYLQBIIcQMzP8Kq4SAHlArmDuFqyMiEqnxxE9Osd35grfKQ9V3bRhSwRrGh4O4pVlJBdN\n kOW6p5liyVh899Bg=="],"Date":"Tue, 7 Apr 2026 13:24:29 +0200","From":"Cyril Hrubis ","To":"Petr Vorel ","Message-ID":"","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>\n <20260402214727.GE225068@pevik> \n <20260407111501.GA25645@pevik>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260407111501.GA25645@pevik>","X-Spam-Score":"-8.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-8.30 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2];\n RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[yuki.lan:mid, imap1.dmz-prg2.suse.org:helo,\n suse.cz:email]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3674595,"web_url":"http://patchwork.ozlabs.org/comment/3674595/","msgid":"<20260408070609.GA35030@pevik>","list_archive_url":null,"date":"2026-04-08T07:06:09","subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"> Hi!\n> > > > Thinking about it twice, could we check for the module by reading\n> > > > /sys/module/? Our current approach shows what module *should* be available, but\n> > > > that might not be true for some reason (i.e. loadable module not installed).\n\n> > > The modules.dep file contains names of all modules installed in\n> > > particular kernel modules directory. We cannot do anything better than\n> > > parsing that file because it's (re)genrated on the system each time\n> > > packages with modules have been installed/removed. If that wasn't the\n> > > case modprobe that depends on that file wouldn't work either.\n\n> > We effectively ask users to install modules.dep and modules.builtin. While this\n> > is ok for distros and nobody has complained, I can imagine special embedded\n> > systems can have problem. If everything was reliably detectable via /sys or\n> > /proc I'd move to it. But even it's not working for all modules, checking first\n> > /sys/module/ and fallback using modules.{builtin,dep} wouldn't take much effort.\n\n> My code does not add any new dependencies. The check for module.dep has\n> been in LTP since:\n\n> 8f7013ba6917 ('tst_check_driver(): Fix kernel module detection on BusyBox')\n\n> which was introduced five years ago.\n\n> The only thing that changes is that the check is being moved from\n> needs_drivers to needs_kconfigs.\n\nSure, it's not new dependency and I like this cleanup. My point is not directly\nrelated to the these changes, but to the fact that I probably did not know about\n/sys/module/ back then. But I knew the limitations (no detection on Android,\npossible problems on embedded).\n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=GHTuJxz1;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=yl1jvU+H;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=GHTuJxz1;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=yl1jvU+H;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frDct49pCz1yD3\n\tfor ; Wed, 08 Apr 2026 17:06:22 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 4E1F33E2177\n\tfor ; Wed, 8 Apr 2026 09:06:20 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 5E2063CA219\n for ; Wed, 8 Apr 2026 09:06:17 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id CCF946003CC\n for ; Wed, 8 Apr 2026 09:06:16 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 61B095BD01;\n Wed, 8 Apr 2026 07:06:15 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4B0814A0B3;\n Wed, 8 Apr 2026 07:06:15 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id QJxWEWf+1WlBHgAAD6G6ig\n (envelope-from ); Wed, 08 Apr 2026 07:06:15 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775631975;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=v6nxtpJVXJWFBPS742QjtnjaUvBpE4OXDuE1ycWkhfw=;\n b=GHTuJxz1tzT+pYgchcZDaXE6zdelJc59R2xWK8g9/0dwzAKf+0nIPKIxWsohdmBMJt+s2q\n 27fKQfRlmQ7XgSgYRkI6lG6wqZ317OmDG939qk8PXvl6IaWM+ihQtsWFnnLnR6u3ax4ZvE\n YLUnF4xps+mu5YnyF2i/qxbAufQDHGM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775631975;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=v6nxtpJVXJWFBPS742QjtnjaUvBpE4OXDuE1ycWkhfw=;\n b=yl1jvU+Hb44xTDiuXhxQXr4SAQv7Sk4yWeyRDmCs+IPwKsvb5ip/k3eXtLn4SM+ManzkwV\n pUp03D1vaZHTpfAw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775631975;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=v6nxtpJVXJWFBPS742QjtnjaUvBpE4OXDuE1ycWkhfw=;\n b=GHTuJxz1tzT+pYgchcZDaXE6zdelJc59R2xWK8g9/0dwzAKf+0nIPKIxWsohdmBMJt+s2q\n 27fKQfRlmQ7XgSgYRkI6lG6wqZ317OmDG939qk8PXvl6IaWM+ihQtsWFnnLnR6u3ax4ZvE\n YLUnF4xps+mu5YnyF2i/qxbAufQDHGM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775631975;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=v6nxtpJVXJWFBPS742QjtnjaUvBpE4OXDuE1ycWkhfw=;\n b=yl1jvU+Hb44xTDiuXhxQXr4SAQv7Sk4yWeyRDmCs+IPwKsvb5ip/k3eXtLn4SM+ManzkwV\n pUp03D1vaZHTpfAw=="],"Date":"Wed, 8 Apr 2026 09:06:09 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260408070609.GA35030@pevik>","References":"<20260402121356.31266-1-chrubis@suse.cz>\n <20260402121356.31266-4-chrubis@suse.cz>\n <20260402214727.GE225068@pevik> \n <20260407111501.GA25645@pevik> ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","X-Spamd-Result":"default: False [-7.50 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Spam-Score":"-7.50","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add\n tst_check_module_driver()","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]