[{"id":3673327,"web_url":"http://patchwork.ozlabs.org/comment/3673327/","msgid":"<76cec745-7b22-425f-a7b1-cf9f7d2786bf@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:46:28","subject":"Re: [PATCH v2 06/16] target/hexagon: add v68 HVX IEEE float\n arithmetic insns","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 20:47, Matheus Tavares Bernardino wrote:\n> diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\n> index d7f4df5f96..d6ca51f175 100644\n> --- a/target/hexagon/cpu.c\n> +++ b/target/hexagon/cpu.c\n> @@ -300,6 +300,9 @@ static void hexagon_cpu_reset_hold(Object *obj, ResetType type)\n> set_float_detect_tininess(float_tininess_before_rounding, &env->fp_status);\n> /* Default NaN value: sign bit set, all frac bits set */\n> set_float_default_nan_pattern(0b11111111, &env->fp_status);\n> +\n> + set_default_nan_mode(1, &env->hvx_fp_status);\n> + set_float_default_nan_pattern(0b01111111, &env->hvx_fp_status);\n> }\n\nDo you still want to detect tininess before rounding?\nI would find it unusual for two fp units to differ on this...\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Y/Zzqd5F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnXPb6FhYz1yCs\n\tfor ; Sat, 04 Apr 2026 08:47:15 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8mLh-00021v-8g; Fri, 03 Apr 2026 17:46:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8mLf-00021U-P3\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:46:39 -0400","from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8mLe-0006KB-9q\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:46:39 -0400","by mail-pj1-x1032.google.com with SMTP id\n 98e67ed59e1d1-35c1d101355so914572a91.1\n for ; Fri, 03 Apr 2026 14:46:37 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dd35e34eesm6630377a91.2.2026.04.03.14.46.32\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:46:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775252796; x=1775857596; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=VjZVJYkFRske5nr2f9ZJZDHuMecbtzMWsssBKoJKSyc=;\n b=Y/Zzqd5FlIR8BUEjq18NKnnTDPMnagNR8P0UUOem5ZryS3qH73u8TDv3+mEDjV2RkP\n A7tzuytUit9OIuLNhV1Sez2/062wBGoxpwX1dno4o4SMv0hM/7PLwZanXINZlUdU2EHH\n AVRPGr+AU5WhZMk+oX1O0JDxFmKv+lHTxcrB9CU59eyVI3oG7h3VdPYgnXmgg5WF50ip\n qJnAaAHlVoKq571LNIuYsjc4Oqkg8jKFbx1wx5+UoujYFKI4joZ/xIog8kqH8w/a+ObO\n tDFEzMAwZ7fyd4CYSAckhHihHqHay2xB7neoJBsQuhB5Mg9w8rJskGQCwzqLrqRCNZyn\n K4yg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775252796; x=1775857596;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=VjZVJYkFRske5nr2f9ZJZDHuMecbtzMWsssBKoJKSyc=;\n b=DOqs5A1ruDA8UhOD9DcI8MPNWuVbNrU4OS9Y+o9WwfZlw5vCa5MMt0FIJJJLVMCjQV\n ynZxjWjXJFQUYuVzqLJzFH43F6C4uXQSm/Ek+EvRACFP6JBQRQ3nEoxz1j33IWcq+ydJ\n hhxjvufqBgCGdkIxxDLm0x3ZnWwBoj3cmB0ok1IIVYn/zgJASXqZT2HjWMggp5QC3rJx\n uTdtm+mtlfzwVC4hH5vK2lYuWsqNE8SJAh3FOqSJbzSudUQNb7AJHnkcm1VOZFWX7El4\n M5cJnGr0NOIkN2wcO0XjQKe2583gnD51yLhxgGNe5bWMnO4ZFWEDb6DSIMhhejhuH22i\n wkRg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXLEeZYeDGEeAm5662xzYuVIvAdZVDDZiaoiLmPylTiylzSCuuP+ramahNVsKbr6Zy1Armp/XMusbpk@nongnu.org","X-Gm-Message-State":"AOJu0YwEgWZsgScOTY89CFBCRMbe7kpavMjT3qrrqCJ9QP3IY33h8GXE\n W5BGfaFbYe0JJoP22WzEHLQyc9DquPwCpR5d6/aa6f9mWfCz5PvvSksbgE3GEjak5kU=","X-Gm-Gg":"AeBDieta8ly1ISBxYYojP1zLsM+lMzIcUcY1FnFHHcL219aUzsJi73zH1MIm8qbgn3A\n Pd0g+HdA+whxaRrP74/B8OXRpdOKzA0Ph94MAdGOgH2qxdoMSPTnQGPRiib55vDg8zIlhEO0QKQ\n RZZzWkXNauaz01Cb7tXxIegXhT3e/vOOiaRocpuwe2ryeZD4qU6EejR7q4eLLs64lzWXulHTuIZ\n TplRZEiDGWetBXihBIn1own6stw5M0wZ1bUfrajuUZUIYm2Kj419D8yxuIWk/NPNFOZyX8Qlr1Z\n wXZGnuss5Vxa866TwjKjzDd6Szv411me5Bs1bSSmC1+xbkJY5TWa4lTD8Fwes7Wr0FeuAglgOri\n X1Fnqqxyg1ERF1rA/4vhCFt9Co8zqQt2qod4azlYOevas5V1acrFZ+8FTbcSEjWnucp6b9stPAZ\n It0GQOW2SRFyJmp7DRQ+sBoI4Z9CBihcPMUdCJfFINGvQStbUnR5bX4DH8AUeVNHM4p6c=","X-Received":"by 2002:a17:90b:17c1:b0:35b:e591:99d1 with SMTP id\n 98e67ed59e1d1-35de69b8929mr3529440a91.29.1775252796508;\n Fri, 03 Apr 2026 14:46:36 -0700 (PDT)","Message-ID":"<76cec745-7b22-425f-a7b1-cf9f7d2786bf@linaro.org>","Date":"Sat, 4 Apr 2026 07:46:28 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 06/16] target/hexagon: add v68 HVX IEEE float\n arithmetic insns","To":"Matheus Tavares Bernardino ,\n qemu-devel@nongnu.org","Cc":"ale@rev.ng, anjo@rev.ng, brian.cain@oss.qualcomm.com,\n ltaylorsimpson@gmail.com, marco.liebel@oss.qualcomm.com, philmd@linaro.org,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com","References":"\n <453a9e248b8c2af50cf89912121605db07792dd5.1775122853.git.matheus.bernardino@oss.qualcomm.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <453a9e248b8c2af50cf89912121605db07792dd5.1775122853.git.matheus.bernardino@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1032;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3673328,"web_url":"http://patchwork.ozlabs.org/comment/3673328/","msgid":"<051a28b0-a67e-4da4-a13f-ed88a69bd629@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:47:43","subject":"Re: [PATCH v2 06/16] target/hexagon: add v68 HVX IEEE float\n arithmetic insns","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 20:47, Matheus Tavares Bernardino wrote:\n> +++ b/target/hexagon/mmvec/hvx_ieee_fp.c\n> @@ -0,0 +1,69 @@\n> +/*\n> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n> + *\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"hvx_ieee_fp.h\"\n> +\n> +#define DEF_FP_INSN_2(name, rt, a1t, a2t, op) \\\n> + uint##rt##_t fp_##name(uint##a1t##_t a1, uint##a2t##_t a2, \\\n> + float_status *fp_status) { \\\n> + float##a1t f1 = make_float##a1t(a1); \\\n> + float##a2t f2 = make_float##a2t(a2); \\\n> + return (op); \\\n> + }\n> +\n> +#define DEF_FP_INSN_3(name, rt, a1t, a2t, a3t, op) \\\n> + uint##rt##_t fp_##name(uint##a1t##_t a1, uint##a2t##_t a2, \\\n> + uint##a3t##_t a3, float_status *fp_status) { \\\n> + float##a1t f1 = make_float##a1t(a1); \\\n> + float##a2t f2 = make_float##a2t(a2); \\\n> + float##a3t f3 = make_float##a3t(a3); \\\n> + return (op); \\\n> + }\n\nWhy are you using uint32_t and make_float instead of declaring with float32 in the first \nplace?\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=xdJbc3kL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnXQc0d9mz1yCs\n\tfor ; Sat, 04 Apr 2026 08:48:08 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8mMs-0002F2-WF; Fri, 03 Apr 2026 17:47:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8mMr-0002Et-RR\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:47:53 -0400","from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8mMq-0006SG-Bn\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:47:53 -0400","by mail-pf1-x431.google.com with SMTP id\n d2e1a72fcca58-824c9da9928so1366337b3a.3\n for ; Fri, 03 Apr 2026 14:47:51 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9c3d67dsm7909809b3a.33.2026.04.03.14.47.46\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:47:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775252871; x=1775857671; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=H9Vukr9g6qfghWwOduq55GE+RO9Rmk0CHMOoN81TceQ=;\n b=xdJbc3kL/oVzN7D1zLFsLe0A7ho1KSd8WXTmxUAF8R8I49uv5w6enHXJp211JVQlxV\n HnM/TJ3UHviEa+YZzRk9qupEqOZjD+XmW8xv7SRCyzuQ4iGOSeg+XCV7k2AJOzNlM5vK\n aHotC7u/fWvflIa3O0xXPIoqomWWiGNWVkEXEnWHd80fcdT3CGcq1T4yQAg8cZR/nn07\n ZgwQ8dWhVBIcSHktfB1QzrOgpdeOLi+X0svdpEHRB6cho6C1OZHGmSeZzRH6I6SBF3KN\n 0abTUkrgRlxaYnjVm4r3ydbY0AYsT3nqm3ksNHKLfDx7ueb7hqussWYCNQbNKvwkp+2n\n ywvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775252871; x=1775857671;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=H9Vukr9g6qfghWwOduq55GE+RO9Rmk0CHMOoN81TceQ=;\n b=BMfYAP7jOoGHh5ab6iKixmeBUXO+RjF/JXKCR4O0yuUqCyP4Hdw9R4zN/GYLgyAOch\n m002XResGzMEm36WntdUPFkMa1ia7xIMv7NtLCxukDiAf1XCCJ/sQTeSAqMxuX37ac93\n 4/xc6dG/xHMlrB515mNr6JNzoqfaSGuAMO9W87p4xKXgIKf0NO2qVVcvRKvX5spT4g7c\n 1cjZB9hnrPRQvAc44EAoEh4Xb5QPMrjmVN2XXc6sBIYWFTKbMDcVicnyrVYBoGC6wpxJ\n SwO2Vf+bUzRGIzu1uTjDSTWsYkK8v1I7bD0JrOFqZKMHPbZwlLbZ3jlxlGshnRI5iQeu\n ccBQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXnANicA5o1H4XXTAWi8oGV+bPaS/vpw1DcrmqyyXcjis1ZTt1nhmLa7ehQ/WlM+vaXJ7atfeAjN5wc@nongnu.org","X-Gm-Message-State":"AOJu0YyRY46YGHoKWtWDBtp1VJxEGgIwHhQkBiGpbViYilV/1BfPjwv3\n PCklzj5XWfLpgv4b3ylE/Cfi1cKrAx+YoN8z89KrGF1oZGxId7x8p2Afqkraa1bx++0=","X-Gm-Gg":"AeBDiesZSV4fzQYpcw4T2j+dvtuw7C6AwyCTFjkkZbOppOBfppUiFA7xvf/26P0tXrN\n dwfDVRLX5Y0SjpL/cHF9ncbuWjzPQ4AweG5GMf6rNG0jdieulidM+tkVkfum+KZLQYXs3x2Warh\n 5fC72v5leLdX4RVq7lp+eZE1ZMHHTz7jHmZ3QnuEnMEEgAVrFG18YevKyn5HrVysq3KRiD5lJs2\n 0HhTqs5s9DEZy1XkP/7lQyLxEE6PCMBjzYGAkZgydj5oy6fpMtNq3E8XbezqnAMq7h/urmdvBNr\n iZJ8ALGf2ZN0H61WipX1gTzsApqVU5uRmedrq4Kc1XVUENjWcYR1cyoztDt9t1tVWNOfIAx1Q+5\n NJ0R0YreI19bq7OMih/7grp5WIquQGV4VfGAGljh+5P0n5JcC73KyxbSmlfW3u7vj3qsEYliclG\n 3S/xV5VcxmPPSpHbLoO4xYvqYdJ76nnOlPJu2TIhq6tafBYiBBitbyhtweYiy8jaTCk+Q62WuFc\n QVMBA==","X-Received":"by 2002:a05:6a00:4fc6:b0:81e:f1c3:89df with SMTP id\n d2e1a72fcca58-82d0dbc0dbcmr4130433b3a.50.1775252870795;\n Fri, 03 Apr 2026 14:47:50 -0700 (PDT)","Message-ID":"<051a28b0-a67e-4da4-a13f-ed88a69bd629@linaro.org>","Date":"Sat, 4 Apr 2026 07:47:43 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 06/16] target/hexagon: add v68 HVX IEEE float\n arithmetic insns","To":"Matheus Tavares Bernardino ,\n qemu-devel@nongnu.org","Cc":"ale@rev.ng, anjo@rev.ng, brian.cain@oss.qualcomm.com,\n ltaylorsimpson@gmail.com, marco.liebel@oss.qualcomm.com, philmd@linaro.org,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com","References":"\n <453a9e248b8c2af50cf89912121605db07792dd5.1775122853.git.matheus.bernardino@oss.qualcomm.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <453a9e248b8c2af50cf89912121605db07792dd5.1775122853.git.matheus.bernardino@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::431;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]