[{"id":3673203,"web_url":"http://patchwork.ozlabs.org/comment/3673203/","msgid":"","list_archive_url":null,"date":"2026-04-03T16:20:59","subject":"Re: [PATCH V10 03/13] PCI: dwc: Parse Root Port nodes in\n dw_pcie_host_init()","submitter":{"id":78905,"url":"http://patchwork.ozlabs.org/api/people/78905/","name":"Manivannan Sadhasivam","email":"mani@kernel.org"},"content":"On Thu, Apr 02, 2026 at 05:50:57PM +0800, Sherry Sun wrote:\n> Add support for parsing Root Port child nodes in dw_pcie_host_init()\n> using pci_host_common_parse_ports(). This allows DWC-based drivers to\n> specify Root Port properties (like reset GPIOs) in individual Root Port\n> nodes rather than in the host bridge node.\n> \n> Signed-off-by: Sherry Sun \n> ---\n> drivers/pci/controller/dwc/pcie-designware-host.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c\n> index da152c31bb2e..f6fca984fb34 100644\n> --- a/drivers/pci/controller/dwc/pcie-designware-host.c\n> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c\n> @@ -20,6 +20,7 @@\n> #include \n> \n> #include \"../../pci.h\"\n> +#include \"../pci-host-common.h\"\n> #include \"pcie-designware.h\"\n> \n> static struct pci_ops dw_pcie_ops;\n> @@ -581,6 +582,13 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)\n> \n> \tpp->bridge = bridge;\n> \n> +\t/* Parse Root Port nodes if present */\n> +\tret = pci_host_common_parse_ports(dev, bridge);\n> +\tif (ret && ret != -ENOENT) {\n> +\t\tdev_err(dev, \"Failed to parse Root Port nodes: %d\\n\", ret);\n> +\t\treturn ret;\n\nWon't this change break drivers that parse Root Ports on their own? Either you\nneed to modify them also in this change or call this API from imx6 driver and\nlet other drivers switch to it in a phased manner.\n\nI perfer the latter.\n\n- Mani","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=C6Tghiy/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51818-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"C6Tghiy/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnP9X1L7Fz1yCs\n\tfor ; Sat, 04 Apr 2026 03:21:20 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 55C45301A78F\n\tfor ; Fri, 3 Apr 2026 16:21:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B9FB53CAE68;\n\tFri, 3 Apr 2026 16:21:13 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 960EF246BD5;\n\tFri, 3 Apr 2026 16:21:13 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 36CE5C4CEF7;\n\tFri, 3 Apr 2026 16:21:07 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775233273; cv=none;\n b=oFpSxkAYfN9JxitdBOcXhG27614dmIJ1i6yLhEI7goQsjIdIjQOY+AX8TnAVUw7beXSntf6C9R4nQaVVD2vUWZ25Lu0uhyip8Lf9Oc/giVmuw+QUoUsZk00QhdrGcqK9dlPzhYsaCQsiKo1a5VKGfhOJoxsjioQn7wQr2MYX95A=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775233273; c=relaxed/simple;\n\tbh=lUkTNzulDtlooVfgkDMb6h1qH+67dzoddlhqIdLFbiM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=SM6RQM8hYGu0wy6XpI3tn9R6O4SB8RWAMG3yYteXS1wBO7PClaIsekTw7n92wEBlApHLd3pTScK9F7j26J9xrDpcvgwOMGs5fTL1rfrILU43dgqEtK08lM9kfj+CX3tJB2jEvhn9wILipcwuHBMs3txXJqocIbk9j7BuzCk33gg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=C6Tghiy/; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775233273;\n\tbh=lUkTNzulDtlooVfgkDMb6h1qH+67dzoddlhqIdLFbiM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C6Tghiy/QK+x9O7SpenV2rcmyZSQWQzhRs5PnFYR13Z9wnpj26EKTT+Y9ANcEQh9R\n\t xyVdsxtd8w11c32zsZ74dVMAQBaayI5yq6qpRDarKvSU5IkgMCoqBgGAO9SVkiU3G0\n\t j+HUBQ3hA/BHlvWb9UDK0USnPy3/YfpF7VxSSYhVMIzj1TUDIDF7rk340YdX/G96as\n\t nNHcQhk4RfLpc95WhJ+emUKKtxjBZqBsRNTC6Ne0xhKDA6yJt/eT1+eOb+OAmO+8JS\n\t 4PeyKHJw/3R/rp/oNNbu1ZMhB5OdR/WpIJ3+B63FVTxiaUuoZ4U6myyjBocha5N2TU\n\t At2UpudG9NEiQ==","Date":"Fri, 3 Apr 2026 21:50:59 +0530","From":"Manivannan Sadhasivam ","To":"Sherry Sun ","Cc":"robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tFrank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,\n\tfestevam@gmail.com, lpieralisi@kernel.org, kwilczynski@kernel.org,\n\tbhelgaas@google.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de,\n\timx@lists.linux.dev, linux-pci@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH V10 03/13] PCI: dwc: Parse Root Port nodes in\n dw_pcie_host_init()","Message-ID":"","References":"<20260402095107.205439-1-sherry.sun@nxp.com>\n <20260402095107.205439-4-sherry.sun@nxp.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260402095107.205439-4-sherry.sun@nxp.com>"}}]